Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/angular/angular.git. Pull mirroring updated .
  1. Jun 03, 2021
  2. Jun 02, 2021
    • David Pfeiffer's avatar
      docs: specify correct interceptor class type (#42437) · 574f6404
      David Pfeiffer authored
      In the "Interceptor order" section of the HTTP guide there is a typo which incorrectly lists the same service twice when referring to two different services. The order that these services are listed is important, and this commit fixes the typo by listing the services in the correct order.
      PR Close #42437
      574f6404
    • Andrew Scott's avatar
      docs: change Navigation from type to interface (#42281) · 6a2e3e2b
      Andrew Scott authored
      Navigation type should be interface so it can be documented on aio site.
      
      fixes #37384
      
      PR Close #42281
      6a2e3e2b
    • Renovate Bot's avatar
      build: update dependency ts-node to v10 (#42257) · 2b7dc156
      Renovate Bot authored
      PR Close #42257
      2b7dc156
    • Renovate Bot's avatar
      build: update angular (#42379) · 5babdb22
      Renovate Bot authored
      PR Close #42379
      5babdb22
    • Alex Rickabaugh's avatar
      fix(compiler-cli): better detect classes that are indirectly exported (#42207) · e039075a
      Alex Rickabaugh authored
      The compiler flag `compileNonExportedClasses` allows the Angular compiler to
      process classes which are not exported at the top level of a source file.
      This is often used to allow for AOT compilation of test classes inside
      `it()` test blocks, for example.
      
      Previously, the compiler would identify exported classes by looking for an
      `export` modifier on the class declaration itself. This works for the
      trivial case, but fails for indirectly exported classes:
      
      ```typescript
      // Component is declared unexported.
      @Component({...})
      class FooCmp {...}
      
      // Indirect export of FooCmp
      export {FooCmp};
      ```
      
      This is not an immediate problem for most application builds, since the
      default value for `compileNonExportedClasses` is `true` and therefore such
      classes get compiled regardless.
      
      However, in the Angular Language Service now, `compileNonExportedClasses` is
      forcibly overridden to `false`. That's because the tsconfig used by the IDE
      and Language Service is often far broader than the application build's
      configuration, and pulls in test files that can contain unexported classes
      not designed with AOT compilation in mind.
      
      Therefore, the Language Service has trouble working with such structures.
      
      In this commit, the `ReflectionHost` gains a new API for detecting whether a
      class is exported. The implementation of this method now not only considers
      the `export` modifier, but also scans the `ts.SourceFile` for indirect
      exports like the example above. This ensures the above case will be
      processed directly in the Language Service.
      
      This new operation is cached using an expando symbol on the `ts.SourceFile`,
      ensuring good performance even when scanning large source files with lots of
      exports (e.g. a FESM file under `ngcc`).
      
      Fixes #42184.
      
      PR Close #42207
      e039075a
    • JoostK's avatar
      docs: clarify how declaration files can be installed (#42417) · 44b737ec
      JoostK authored
      The documentation suggested that `@types/*` scoped packages would
      automatically be recognized, however the CLI configures a project such
      that the package has to be explicitly added to the TypeScript
      configuration files.
      
      Closes #37572
      
      PR Close #42417
      44b737ec
    • Kristiyan Kostadinov's avatar
      build: fix linting against jasmine focus functions (#42415) · 3e192bfa
      Kristiyan Kostadinov authored
      We were linting against usages of `fdescribe` and `fit` by referencing the `no-jasmine-focus` rule which isn't installed, causing tslint to log the following:
      
      ```
      Could not find implementations for the following rules specified in the configuration:
          no-jasmine-focus
      Try upgrading TSLint and/or ensuring that you have all necessary custom rules installed.
      If TSLint was recently upgraded, you may have old rules configured which need to be cleaned
      ```
      
      These changes switch to using the built-in `ban` rule.
      
      PR Close #42415
      3e192bfa
    • George Kalpakas's avatar
    • George Kalpakas's avatar
      fix(docs-infra): improve homepage layout in print mode (#42396) · 4a5af60d
      George Kalpakas authored
      In #41129, the `.hero-logo` image was changed from an `<img>` element to
      a `<div>` with an image background. As a result, in print mode (where
      browsers often omit backgrounds to save ink) the logo was not present.
      
      This commit fixes this by ensuring the word `Angular` is displayed as a
      title instead of the logo in print mode. It also hides the `Get started`
      button in print mode, since it doesn't add any value.
      
      Before: ![homepage-print before][1]
      After: ![homepage-print after][2]
      
      [1]: https://user-images.githubusercontent.com/8604205/120068867-889e6080-c08b-11eb-9bd5-233d8592f7ec.png
      [2]: https://user-images.githubusercontent.com/8604205/120068869-89cf8d80-c08b-11eb-8740-a68a5ef68c34.png
      
      PR Close #42396
      4a5af60d
    • George Kalpakas's avatar
      refactor(docs-infra): remove unused `_typography-theme.scss` file (#42396) · 58160742
      George Kalpakas authored
      This commit removes the `_typography-theme.scss` file that is currently
      not used. The file contains a single Sass mixin
      (`docs-site-typography-theme()`), which is never called.
      
      PR Close #42396
      58160742
    • George Kalpakas's avatar
      refactor(docs-infra): minor refactorings/style changes (#42396) · 3b972877
      George Kalpakas authored
      This commit includes some minor refactorings and style changes as a
      follow-up to PR #41129. (The changes were minor enough that didn't
      warrant blocking the PR.)
      
      PR Close #42396
      3b972877
    • Joey Perrott's avatar
      refactor(dev-infra): update to later version of @octokit/rest and remove class... · aeb40729
      Joey Perrott authored
      refactor(dev-infra): update to later version of @octokit/rest and remove class extenstion of Octokit (#42395)
      
      Update @octokit/rest and remove the usage of a class extension of Octokit as the
      class does not have a class define constructor.
      
      PR Close #42395
      aeb40729
    • George Kalpakas's avatar
      build: allow Node.js v15 and above for local development (#42387) · af762fa9
      George Kalpakas authored
      This commit changes the `engines` rules in the root `package.json` as
      well as the `package.json` used when working on docs example to also
      accept Node.js versions greater than v14. This aligns them with
      `aio/package.json` and allows using Node.js v15 and v16 (current) for
      local development in the `angular/angular` repo.
      
      Related to #42367.
      
      PR Close #42387
      af762fa9
    • Dylan Hunn's avatar
      docs(forms): make the forms validation guide specify more clearly what happens... · c54643f0
      Dylan Hunn authored
      docs(forms): make the forms validation guide specify more clearly what happens when mixing HTML5 native validators with Angular forms. (#42377)
      
      Previously, the docs didn't say anything about the fact that the `novalidate` attribute is added to the enclosing form, or how to override that behavior. I have added a couple lines in the appropriate spot clarifying this issue.
      
      PR Close #42377
      c54643f0
    • Doug Parker's avatar
      docs: update CLI builder to be platform agnostic (#42371) · e0381a87
      Doug Parker authored
      Fixes #35373.
      
      This changes the example from "run an arbitrary process" to "copy a file". This should make it a bit easier to follow, require less background knowledge to understand, and not use any platform-specific commands that won't work for Windows users.
      
      The most glaring issue with this change is that this doc does not explictly specify how to build and run a builder. I've updated some of the files to hint at this a bit more (such as the `"implementation": "./dist/my-builder.js"`), but another pass is required to figure out the best way to compile a builder and how we want to structure this example to best communicate that.
      
      PR Close #42371
      e0381a87
    • Doug Parker's avatar
      docs: minor cleanup (#42371) · 2a311c51
      Doug Parker authored
      Mainly just fixing some spacing and adding `.prototype` for non-static properties.
      
      PR Close #42371
      2a311c51
    • Andrew Scott's avatar
      docs: list supported values for `read` in decorator metadata (#42370) · 1b8bbddf
      Andrew Scott authored
      fixes #20927
      
      PR Close #42370
      1b8bbddf
    • George Kalpakas's avatar
      build(docs-infra): fix linting warnings (#42359) · e798bfab
      George Kalpakas authored
      This commit fixes some linting warning that were printed when running
      `ng lint`. The warnings can be seen in the `lint` step of
      [this CI job][1].
      
      Most of the warnings were related to the deprecation of passing context
      to Jasmine matchers in favor of using the [withContext()][2] matcher
      (introduced in Jasmine v3.3.0).
      
      [1]: https://circleci.com/gh/angular/angular/995543
      [2]: https://jasmine.github.io/api/3.3/matchers.html#withContext
      
      PR Close #42359
      e798bfab
  3. May 28, 2021
  4. May 27, 2021