From 2e3cbc9d7f4ea99ec93d7705cffa35ec2b571b59 Mon Sep 17 00:00:00 2001
From: "trop[bot]" <37223003+trop[bot]@users.noreply.github.com>
Date: Wed, 25 Sep 2024 09:21:47 +0000
Subject: [PATCH] refactor: remove C-style void arg type for no-arg functions
(#43884)
A small cleanup to remove use of the C-style function declaration idiom.
Co-authored-by: Charles Kerr <charles@charleskerr.com>
---
.../browser/osr/osr_render_widget_host_view.h | 24 +++++++++----------
shell/common/platform_util_win.cc | 12 +++++-----
2 files changed, 18 insertions(+), 18 deletions(-)
diff --git a/shell/browser/osr/osr_render_widget_host_view.h b/shell/browser/osr/osr_render_widget_host_view.h
index 22d7941858..d8a1bf0449 100644
--- a/shell/browser/osr/osr_render_widget_host_view.h
+++ b/shell/browser/osr/osr_render_widget_host_view.h
@@ -83,17 +83,17 @@ class OffScreenRenderWidgetHostView
void InitAsChild(gfx::NativeView) override;
void SetSize(const gfx::Size&) override;
void SetBounds(const gfx::Rect&) override;
- gfx::NativeView GetNativeView(void) override;
- gfx::NativeViewAccessible GetNativeViewAccessible(void) override;
+ gfx::NativeView GetNativeView() override;
+ gfx::NativeViewAccessible GetNativeViewAccessible() override;
ui::TextInputClient* GetTextInputClient() override;
- void Focus(void) override;
- bool HasFocus(void) override;
+ void Focus() override;
+ bool HasFocus() override;
uint32_t GetCaptureSequenceNumber() const override;
- bool IsSurfaceAvailableForCopy(void) override;
- void Hide(void) override;
- bool IsShowing(void) override;
+ bool IsSurfaceAvailableForCopy() override;
+ void Hide() override;
+ bool IsShowing() override;
void EnsureSurfaceSynchronizedForWebTest() override;
- gfx::Rect GetViewBounds(void) override;
+ gfx::Rect GetViewBounds() override;
gfx::Size GetVisibleViewportSize() override;
void SetInsets(const gfx::Insets&) override;
void SetBackgroundColor(SkColor color) override;
@@ -103,7 +103,7 @@ class OffScreenRenderWidgetHostView
bool request_unadjusted_movement) override;
blink::mojom::PointerLockResult ChangePointerLock(
bool request_unadjusted_movement) override;
- void UnlockPointer(void) override;
+ void UnlockPointer() override;
void TakeFallbackContentFrom(content::RenderWidgetHostView* view) override;
#if BUILDFLAG(IS_MAC)
void SetActive(bool active) override;
@@ -131,10 +131,10 @@ class OffScreenRenderWidgetHostView
void UpdateCursor(const ui::Cursor&) override;
void SetIsLoading(bool is_loading) override;
void TextInputStateChanged(const ui::mojom::TextInputState& params) override;
- void ImeCancelComposition(void) override;
+ void ImeCancelComposition() override;
void RenderProcessGone() override;
void ShowWithVisibility(content::PageVisibilityState page_visibility) final;
- void Destroy(void) override;
+ void Destroy() override;
void UpdateTooltipUnderCursor(const std::u16string&) override;
content::CursorManager* GetCursorManager() override;
void CopyFromSurface(
@@ -143,7 +143,7 @@ class OffScreenRenderWidgetHostView
base::OnceCallback<void(const SkBitmap&)> callback) override;
display::ScreenInfo GetScreenInfo() const override;
void TransformPointToRootSurface(gfx::PointF* point) override;
- gfx::Rect GetBoundsInRootWindow(void) override;
+ gfx::Rect GetBoundsInRootWindow() override;
std::optional<content::DisplayFeature> GetDisplayFeature() override;
void SetDisplayFeatureForTesting(
const content::DisplayFeature* display_feature) override;
diff --git a/shell/common/platform_util_win.cc b/shell/common/platform_util_win.cc
index 43684fc9e0..9e7018677f 100644
--- a/shell/common/platform_util_win.cc
+++ b/shell/common/platform_util_win.cc
@@ -49,11 +49,11 @@ class DeleteFileProgressSink : public IFileOperationProgressSink {
virtual ~DeleteFileProgressSink() = default;
private:
- ULONG STDMETHODCALLTYPE AddRef(void) override;
- ULONG STDMETHODCALLTYPE Release(void) override;
+ ULONG STDMETHODCALLTYPE AddRef() override;
+ ULONG STDMETHODCALLTYPE Release() override;
HRESULT STDMETHODCALLTYPE QueryInterface(REFIID riid,
LPVOID* ppvObj) override;
- HRESULT STDMETHODCALLTYPE StartOperations(void) override;
+ HRESULT STDMETHODCALLTYPE StartOperations() override;
HRESULT STDMETHODCALLTYPE FinishOperations(HRESULT) override;
HRESULT STDMETHODCALLTYPE PreRenameItem(DWORD, IShellItem*, LPCWSTR) override;
HRESULT STDMETHODCALLTYPE
@@ -92,9 +92,9 @@ class DeleteFileProgressSink : public IFileOperationProgressSink {
HRESULT,
IShellItem*) override;
HRESULT STDMETHODCALLTYPE UpdateProgress(UINT, UINT) override;
- HRESULT STDMETHODCALLTYPE ResetTimer(void) override;
- HRESULT STDMETHODCALLTYPE PauseTimer(void) override;
- HRESULT STDMETHODCALLTYPE ResumeTimer(void) override;
+ HRESULT STDMETHODCALLTYPE ResetTimer() override;
+ HRESULT STDMETHODCALLTYPE PauseTimer() override;
+ HRESULT STDMETHODCALLTYPE ResumeTimer() override;
ULONG m_cRef;
};
--
GitLab