From 16a16e6598cca4129da0d2e76de0320fbc0108f1 Mon Sep 17 00:00:00 2001 From: liyuqian <liyuqian@google.com> Date: Wed, 3 Apr 2019 15:38:31 -0700 Subject: [PATCH] Revert "Error message for setting shaderWarmUp too late (#30145)" (#30463) This reverts commit ffbb335e35ae7416be98b72779baae6c9bd25b3b. Reason for revert: flutter driver tests may have bugs in getting first frame. Revert this until we figure out what happened. --- packages/flutter/lib/src/painting/binding.dart | 15 +-------------- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/packages/flutter/lib/src/painting/binding.dart b/packages/flutter/lib/src/painting/binding.dart index 5e9113d10d5..7608917835d 100644 --- a/packages/flutter/lib/src/painting/binding.dart +++ b/packages/flutter/lib/src/painting/binding.dart @@ -53,20 +53,7 @@ mixin PaintingBinding on BindingBase, ServicesBinding { /// See also: /// /// * [ShaderWarmUp], the interface of how this warm up works. - static ShaderWarmUp get shaderWarmUp => _shaderWarmUp; - static set shaderWarmUp(ShaderWarmUp value) { - assert(_instance == null, - 'PaintingBinding.shaderWarmUp should only be set before the ' - 'PaintingBinding singleton instance is initialized.\n\n' - 'Setting it after init would not affect how shaders are warmed up.\n\n' - 'To fix this, try to change PaintingBinding.shaderWarmUp before:\n' - ' 1. runApp\n' - ' 2. WidgetsFlutterBinding.ensureInitialized\n' - ' 3. enableFlutterDriverExtension\n' - ); - _shaderWarmUp = value; - } - static ShaderWarmUp _shaderWarmUp = const DefaultShaderWarmUp(); + static ShaderWarmUp shaderWarmUp = const DefaultShaderWarmUp(); /// The singleton that implements the Flutter framework's image cache. /// -- GitLab