This project is mirrored from https://github.com/facebook/react-native.git.
Pull mirroring updated .
- Aug 19, 2024
-
-
Riccardo Cipolleschi authored
-
Nicola Corti authored
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/46092 Fixes https://github.com/facebook/react-native/issues/46077 Changelog: [Android] [Fixed] - Make Imagesource `open` for inheritance Reviewed By: rshest, cipolleschi Differential Revision: D61469357 fbshipit-source-id: ee122b46346c47c7665c60ceb5ea7e91f12a965c
-
David Vacca authored
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/46083 Fix lint warnings changelog: [internal] internal Reviewed By: tdn120 Differential Revision: D61376258 fbshipit-source-id: e4e047e478a4e5a95d5e6b3dea426189f29bb641
-
- Aug 18, 2024
-
-
Sam Zhou authored
Summary: Changelog: [Internal] Reviewed By: gkz Differential Revision: D61435279 fbshipit-source-id: 05212fe00d352c32d2be9d93ad0fcd6d414ef828
-
Nick Gerleman authored
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/46074 This brings over the changes made to OutsetBoxShadowDrawable. Namely 1. Removing reliance on CSSBackgroundDrawable for drawing paths 2. Using BlurMaskFilter instead of RenderEffect 3. Removing RenderNode usage This should make the implementation, more reliable less memory intensive for large boxes, and compatible down to Android API 29. I changed previous gating to allow outset shadows for 28+, and inset for 29+. Changelog: [Android][Changed] - Revamp InsetBoxShadowDrawable Reviewed By: joevilches Differential Revision: D61348615 fbshipit-source-id: 97b63b5dce65224ca54b76c5318c219973fc09fa
-
Nick Gerleman authored
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/46037 We no longer need to use a RenderNode, since we aren't using a RenderEffect, and when I looked at our usage, and RenderNode internals, it is definitely adding more overhead instead of less. This lets us simplify the code further, and to support down to Android API 28, allowing us to support 90% of Android devices out there, instead of 80%. API 28 [switches to Skia](https://cs.android.com/android/_/android/platform/frameworks/base/+/04f1f011397e10ded08ac14b7e62c85e6a521f27:libs/hwui/Properties.cpp;dlc=ac1d112c4bef3fef85b4de3ce0d2bc2d3006f4b5) as the default rendering backend. We see many [related drawing APIs](https://developer.android.com/topic/performance/hardware-accel#drawing-support) show as first officially supported in hardware accelerated canvases in this version, including `setShadowLayer()`, which uses [`SKMaskFilter`](https://cs.android.com/android/platform/superproject/main/+/main:frameworks/base/libs/hwui/jni/Paint.cpp;l=1104;drc=7ad774120c090227ba12b9e9e8d724db01b854f4) internally. We are still waiting on InsetBoxShadowDrawable to be changed though, before the prop setter stops gating to API 31+. Changelog: [Android][Changed] - Support OutsetBoxShadowDrawable on Android 9+ Reviewed By: joevilches Differential Revision: D61331711 fbshipit-source-id: 170f6d4e5bfebbce5005445a3c32c4b17910eb05
-
- Aug 17, 2024
-
-
Jorge Cabiedes Acosta authored
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/46073 Before we had issues with drop-shadow definitions like `drop-shadow(10 10 10 rgba(255, 255, 255, 1))` Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D61413945 fbshipit-source-id: 478c437336d3e7d5066ed62f6aa5bec106b8b061
-
Phillip Pan authored
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/46055 Changelog: [Android][Breaking] BaseReactPackage is a 1:1 replacement for the deprecated TurboReactPackage. TurboReactPackage has been deprecated since 0.74. let's move the codebase to the recommended standard. Reviewed By: cortinico Differential Revision: D61329022 fbshipit-source-id: cef69e37bb2be7f6dccbab70d0996c33a8abf091
-
SamChou19815 (Meta Employee) authored
Summary: ## Summary Flow will eventually remove the specific `React.Element` type. For most of the code, it can be replaced with `React.MixedElement` or `React.Node`. When specific react elements are required, it needs to be replaced with either `React$Element` which will trigger a `internal-type` lint error that can be disabled project-wide, or use `ExactReactElement_DEPRECATED`. Fortunately in this case, this one can be replaced with just `React.MixedElement`. ## How did you test this change? `flow` DiffTrain build for commit https://github.com/facebook/react/commit/85fb95cdffdd95f2f908ee71974cae06b1c866e1. bypass-github-export-checks Reviewed By: poteto Differential Revision: D61397212 Pulled By: SamChou19815 fbshipit-source-id: c0aa5a4ed3922f88b7e557738f76f872c02a9d07
-
- Aug 16, 2024
-
-
Sam Zhou authored
Summary: Changelog: [Internal] Reviewed By: alexmckenley Differential Revision: D61389820 fbshipit-source-id: 566a4904c570e24f5beb965734020f8b9c1ed819
-
Nicola Corti authored
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/46059 This merges all the remaining dynamic libraries into libreactnative.so. Sadly I couldn't split this in smaller diffs as all the libraries are connected with each other. I also had to introduce 2 other SOs: `libhermestooling.so` and `libjsctooling.so` which contains all the necessary libs used when loading either JSC or Hermes. They need to be isolated as RNGP will remove those libraries based on the library the user decides to pick. Changelog: [Android] [Breaking] - Merge all the remaining .so libraries into libreactnative.so Reviewed By: hezi Differential Revision: D61376496 fbshipit-source-id: ab9e725b7acbebdfd8fa3ff36ad34d080044bf0e
-
Nicola Corti authored
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/46056 This merges another library inside libreactnative.so Changelog: [Android] [Changed] - Merge libuimanagerjni.so inside libreactnative.so Reviewed By: cipolleschi Differential Revision: D61376498 fbshipit-source-id: db646721a5a4b56f2cf098d5087a3e45d2076743
-
Nicola Corti authored
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/46057 We have a bunch of prefab targets which are no longer necessary. I'm removing them all in this first round of cleanup Changelog: [Android] [Breaking] - Remove several unnecessary android prefab targets. Use ReactAndroid::reactnative instead Reviewed By: cipolleschi Differential Revision: D61376497 fbshipit-source-id: e2e3cb38b1db712890f8bd58abadbdcb5cfaeec7
-
Nicola Corti authored
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/46058 This moves other 2 libraries inside libreactnative.so Changelog: [Android] [Changed] - Move libyoga.so and libturbomodulejsijni.so inside libreactnative.so Reviewed By: cipolleschi Differential Revision: D61376499 fbshipit-source-id: 8780831491a5d57c4bb747fccf8a872ad30dc09e
-
Riccardo Cipolleschi authored
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/46060 Closures in ruby don't need the `return` statement. They exit from the calling function! ## Changelog [Internal] - fix .xcode.env.local.generation Reviewed By: cortinico Differential Revision: D61343918 fbshipit-source-id: 39073ead7ad596f48403a5c2d4c066d410355698
-
zhongwuzw authored
Summary: FIxes https://github.com/facebook/react-native/issues/45502 . cc realsoelynn ## Changelog: [GENERAL] [FIXED] - Fixes findNodeAtPoint when views were inverted Pull Request resolved: https://github.com/facebook/react-native/pull/45519 Test Plan: Demo in https://github.com/facebook/react-native/issues/45502 . Reviewed By: cipolleschi Differential Revision: D59920660 Pulled By: realsoelynn fbshipit-source-id: 9e1075406830aa3a3ec436d70d539ca0674f8d34
-
Nicola Corti authored
Move more libraries to so-merging: rninstance, react_featureflagsjni, hermesinstancejni, fabricjni (#46036) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/46036 This is a round of merging of .so libraries inside libreactnative.so Changelog: [Android] [Changed] - Move more libraries to so-merging: rninstance, react_featureflagsjni, hermesinstancejni, fabricjni Reviewed By: javache Differential Revision: D61331552 fbshipit-source-id: ac93e844b304038eefd4679680180eb3be2d5e1d
-
Nicola Corti authored
Summary: Remove unnecessary circular dependency on bridgeless<->hermes ## Changelog: [INTERNAL] - Remove unnecessary circular dependency on bridgeless<->hermes Pull Request resolved: https://github.com/facebook/react-native/pull/46048 Test Plan: CI Reviewed By: christophpurrer Differential Revision: D61343505 Pulled By: cortinico fbshipit-source-id: 5e182c724e80d419a5af1e0ea9dfb96595e4abe2
-
Joe Vilches authored
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/46054 tsia, more test = good Changelog: [Internal] Reviewed By: necolas Differential Revision: D60938608 fbshipit-source-id: abce5ab7d42a7f7f626f0edc852aa1374f8029f0
-
Joe Vilches authored
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/46053 tsia, default should be black like android Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D61370471 fbshipit-source-id: a69933049f9db30a17322bd53ef30035ae145a63
-
Edmond Chui authored
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/46010 X-link: https://github.com/facebook/hermes/pull/1474 Changelog: [General][Added]: support for rendering Error object previews in Chrome DevTools console On web, an array of Error objects have previews. This diff brings the parity to RN DevTools Reviewed By: huntie Differential Revision: D61243518 fbshipit-source-id: d9c6af4b44cef44cb63c4462eee649a8e498a429
-
Edmond Chui authored
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/45990 X-link: https://github.com/facebook/hermes/pull/1471 Changelog: [General][Added]: support for rendering Error objects in Chrome DevTools console As discussed in [Linkifying and symbolicating JavaScript Error stacks in Fusebox](https://docs.google.com/document/d/1JI_PPzxFRwRNii6pcx-4Cb7g8UTrqnZHCxaoynntIrM/edit) by hoxyq, Error objects in CDT currently displays a big blob of string. In this diff, we send the correct CDT params. Reviewed By: hoxyq Differential Revision: D60598446 fbshipit-source-id: 527c4e5858dfb879a32b40e5ad4df73a22e694e5
-
Jorge Cabiedes Acosta authored
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/45883 Isolate property lets us easily define when a <View> should set a stacking context. This is particularly useful when used with `mix-blend-mode` Changelog: [Internal] Reviewed By: christophpurrer, NickGerleman Differential Revision: D60604683 fbshipit-source-id: 449079abe45ae57e98315bdf27b54ec5cf9d6fdc
-
Jorge Cabiedes Acosta authored
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/45867 Before mix-blend-mode was blending with everything in the background, now we make it blend with just stacking context parent as spec by doing off-screen rendering. Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D60597403 fbshipit-source-id: 3af0c1266fde4ca32846785879d616316349369c
-
bacarybruno authored
Summary: Referring to the [iOS Large Content Viewer](https://developer.apple.com/videos/play/wwdc2019/261/): iOS Tab Bars can't grow with dynamic text, but the Large Content Viewer helps them to be seen by people with low vision. Currently on React Native we don't expose the properties that can help implementing iOS [UILargeContentViewerItem](https://developer.apple.com/documentation/uikit/uilargecontentvieweritem) protocol. The goal of this PR is to expose the necessary props. In this PR, I'm exposing 2 props: - `accessibilityShowsLargeContentViewer`: to enable the large content viewer - `accessibilityLargeContentTitle`: to define the large content viewer title I plan to use this to open a PR on react-navigation so that bottom tabbars can implement largeContentViewer. Should fix https://github.com/facebook/react-native/issues/30892 ## Changelog: [IOS] [ADDED] - Support LargeContentViewer on iOS for better accessibility Pull Request resolved: https://github.com/facebook/react-native/pull/45903 Test Plan: <img width="300" src="https://github.com/user-attachments/assets/d8f1dc46-66e7-4945-bc3b-f1d29044441b" /> Reviewed By: cipolleschi Differential Revision: D61148361 Pulled By: joevilches fbshipit-source-id: 86dd92f4f79534a58e6e015febdaf217ea291eb4
-
Jorge Cabiedes Acosta authored
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/45985 As title. We can now create ellipses when using percentages. The algorithm for this is still flawed and to get it to be a 1:1 to web it will probably require a re-write of some of the logic but this should get us closer for now. Some examples: 1. Border thinning on large single corner radii (100%) {F1798145800} 2. Thinning gets worse when having irregular border colors (100%) {F1798148002} Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D61025927 fbshipit-source-id: 218d44af014bc8351c329ff1bca82658aebac38c
-
Vincent Riemer authored
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/46024 Changelog: [Internal] Reviewed By: javache Differential Revision: D61298649 fbshipit-source-id: 16ee8084fa31297ee12db26ee86254eed6da248f
-
- Aug 15, 2024
-
-
Pieter De Baets authored
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/46039 Broke during Kotlin conversion I assume Image onSubmit events were failing with ``` FdingControllerListener E InternalListener exception in onSubmit E java.lang.NullPointerException: Parameter specified as non-null is null: method com.facebook.react.views.image.ReactImageView$setShouldNotifyLoadEvents$1.onSubmit, parameter callerContext E at com.facebook.react.views.image.ReactImageView$setShouldNotifyLoadEvents$1.onSubmit(Unknown Source:9) E at com.facebook.drawee.controller.ForwardingControllerListener.onSubmit(ForwardingControllerListener.java:75) E at com.facebook.drawee.controller.AbstractDraweeController.reportSubmit(AbstractDraweeController.java:832) E at com.facebook.drawee.controller.AbstractDraweeController.submitRequest(AbstractDraweeController.java:578) E at com.facebook.drawee.controller.AbstractDraweeController.onAttach(AbstractDraweeController.java:468) E at com.facebook.drawee.view.DraweeHolder.attachController(DraweeHolder.java:252) E at com.facebook.drawee.view.DraweeHolder.attachOrDetachController(DraweeHolder.java:269) E at com.facebook.drawee.view.DraweeHolder.onAttach(DraweeHolder.java:87) E at com.facebook.drawee.view.DraweeView.doAttach(DraweeView.java:208) E at com.facebook.drawee.view.DraweeView.onAttach(DraweeView.java:194) E at com.facebook.drawee.view.DraweeView.onAttachedToWindow(DraweeView.java:168) E at android.view.View.dispatchAttachedToWindow(View.java:20812) E at android.view.ViewGroup.dispatchAttachedToWindow(ViewGroup.java:3497) E at android.view.ViewGroup.dispatchAttachedToWindow(ViewGroup.java:3497) E at android.view.ViewGroup.dispatchAttachedToWindow(ViewGroup.java:3497) E at android.view.ViewGroup.addViewInner(ViewGroup.java:5290) E at android.view.ViewGroup.addView(ViewGroup.java:5076) E at com.facebook.react.views.view.ReactViewGroup.addView(ReactViewGroup.java:591) E at android.view.ViewGroup.addView(ViewGroup.java:5016) E at com.facebook.react.views.view.ReactClippingViewManager.addView(ReactClippingViewManager.java:41) E at com.facebook.react.views.view.ReactClippingViewManager.addView(ReactClippingViewManager.java:21) E at com.facebook.react.fabric.mounting.SurfaceMountingManager.addViewAt(SurfaceMountingManager.java:412) E at com.facebook.react.fabric.mounting.mountitems.IntBufferBatchMountItem.execute(IntBufferBatchMountItem.java:119) E at com.facebook.react.fabric.mounting.MountItemDispatcher.executeOrEnqueue(MountItemDispatcher.java:387) E at com.facebook.react.fabric.mounting.MountItemDispatcher.dispatchMountItems(MountItemDispatcher.java:294) E at com.facebook.react.fabric.mounting.MountItemDispatcher.tryDispatchMountItems(MountItemDispatcher.java:127) E at com.facebook.react.fabric.FabricUIManager$DispatchUIFrameCallback.doFrameGuarded(FabricUIManager.java:1362) E at com.facebook.react.fabric.GuardedFrameCallback.doFrame(GuardedFrameCallback.kt:22) E at com.facebook.react.modules.core.ReactChoreographer$frameCallback$1.doFrame(ReactChoreographer.kt:59) E at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1035) E at android.view.Choreographer.doCallbacks(Choreographer.java:845) E at android.view.Choreographer.doFrame(Choreographer.java:775) E at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1022) E at android.os.Handler.handleCallback(Handler.java:938) E at android.os.Handler.dispatchMessage(Handler.java:99) E at android.os.Looper.loopOnce(Looper.java:214) E at android.os.Looper.loop(Looper.java:304) E at android.app.ActivityThread.main(ActivityThread.java:7918) E at java.lang.reflect.Method.invoke(Native Method) E at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548) E at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1010) ``` Changelog: [Internal] Reviewed By: fabriziocucci Differential Revision: D61332854 fbshipit-source-id: 48409e2b93abf15e846620580d1f0d07a2e75025
-
Alex Hunt authored
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/46041 We observed that large or remotely loaded source maps could time out. This change aligns `OkHttpClient` timeout values with `CxxInspectorPackagerConnection`. https://github.com/facebook/react-native/blob/a77f26827fee0fc18a11faccd0b5e51d1b222735/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/CxxInspectorPackagerConnection.java#L87-L91 Changelog: [Internal] Reviewed By: robhogan Differential Revision: D61333240 fbshipit-source-id: 605b1fbf1b050d8e80ed569b25cb5694e2d14ec7
-
Thomas Nardone authored
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/45980 Use a safe remove method that won't crash on IndexOutOfBounds. Changelog: [Internal] Reviewed By: javache Differential Revision: D61132496 fbshipit-source-id: edd887611c47f236b495986fc29e2d0b9ce56b8e
-
Elene Botchoradze authored
Summary: Removed UIReturnKeyDefault as it caused bug when there wasn't any type. ## Changelog: [IOS] [REMOVED]: UIReturnKeyDefault <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests Pull Request resolved: https://github.com/facebook/react-native/pull/46020 Reviewed By: christophpurrer Differential Revision: D61277058 Pulled By: cipolleschi fbshipit-source-id: 18349c49b05d492a2c2ed5713af3ceb6d3728e70
-
Blake Friedman authored
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/46040 The URL to dispatch the workflow was not correct, see [0]. ## Changelog: [Internal] [0] https://docs.github.com/en/rest/actions/workflows?apiVersion=2022-11-28#create-a-workflow-dispatch-event ## Internal: For S441191, see the job launched: - https://github.com/react-native-community/template/actions/runs/10404141179/job/28811993693 {F1806960111} Reviewed By: cipolleschi Differential Revision: D61333084 fbshipit-source-id: 62b20d792b9c667b3ee80d6d446423a6d24a67c2
-
Riccardo Cipolleschi authored
Summary: Add changelog for 0.75.1 ## Changelog: [Internal] - Add changelog Pull Request resolved: https://github.com/facebook/react-native/pull/46038 Test Plan: N/A Reviewed By: cortinico Differential Revision: D61333096 Pulled By: cipolleschi fbshipit-source-id: 19ba0bce60056be12d1b0427939c5896c22e215b
-
Riccardo Cipolleschi authored
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/46034 The create release workflow was not working properly for 0.75: * the latest tag was not pushed because we were using the wrong input * the latest tag was not deleted because we were not fetching all the tags * the create release job 'dry-run' defaults to false, which is a bit dangerous This change is a backport from 0.75 to main of these changes. ## Changelog [Internal] - Make sure that the Latest tag is properly pushed to github while releasing Reviewed By: cortinico Differential Revision: D61331247 fbshipit-source-id: 89bf0698c45ec6c766e25b11599dbe926d8a6297
-
zhongwuzw authored
Summary: Fixes build error like https://github.com/facebook/react-native/actions/runs/10398775597/job/28797041872. cc RSNara ## Changelog: [IOS] [FIXED] - Add missing pod dependency of jserrorhandler Pull Request resolved: https://github.com/facebook/react-native/pull/46030 Test Plan: CI green. Reviewed By: cortinico Differential Revision: D61329173 Pulled By: cipolleschi fbshipit-source-id: c7dc6d7af3b57f748ae3464d9f4231ff4fb36e63
-
Ramanpreet Nara authored
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/45617 This isn't necessary. RuntimeScheduler will catch and report via js error handler. Changelog: [Internal] Reviewed By: alanleedev Differential Revision: D60139055 fbshipit-source-id: 511f384ede71d88b81ef5c031fa67b1fb03f7631
-
Ramanpreet Nara authored
Summary: If a fatal error is caught in js, and the js pipeline isn't ready, route it through the c++ pipeline. Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D60138414 fbshipit-source-id: 333e38e2b904d6434a88469816e39bf1b9d0bc3f
-
Ramanpreet Nara authored
Summary: If any fatal js error is caught in c++, just route it through js error handler. Then, make js error handler call into the right pipeline: 1. After the js pipeline is ready: Route the errors through the js pipeline 2. Otherwise: Route errors through the c++ pipeline. Changelog: [Internal] Reviewed By: javache Differential Revision: D60138417 fbshipit-source-id: 24c466ffadbd14a9e9a5571548f3d34d2f406a8d
-
Ramanpreet Nara authored
Summary: ## History 1. Originally landed in D60138415 2. Reverted in D60232011 (it broke ios oss builds) ## Motivation In bridgeless, we want to configure the error handling of runtime scheduler. So that we can route those errors to the C++ error handling pipeline, when necessary. Changelog: [Internal] Reviewed By: rubennorte Differential Revision: D60477342 fbshipit-source-id: f14e20d7aff39e0fee42918567ccc6e685674134
-
Bowen Xie authored
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/46025 Changelog: [General][Fixed] - Change RawPropsParser logs from ERROR level to WARNING Reviewed By: christophpurrer Differential Revision: D61304854 fbshipit-source-id: bc16df4916a54cb7c1fa57f359eab3d9eed4e2f4
-