Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/facebook/react-native.git. Pull mirroring updated .
  1. Aug 19, 2024
  2. Aug 18, 2024
  3. Aug 17, 2024
  4. Aug 16, 2024
  5. Aug 15, 2024
    • Pieter De Baets's avatar
      Fix type of callerContext (#46039) · f8aa7867
      Pieter De Baets authored
      Summary:
      Pull Request resolved: https://github.com/facebook/react-native/pull/46039
      
      Broke during Kotlin conversion I assume
      
      Image onSubmit events were failing with
      
      ```
      FdingControllerListener  E  InternalListener exception in onSubmit
                               E  java.lang.NullPointerException: Parameter specified as non-null is null: method com.facebook.react.views.image.ReactImageView$setShouldNotifyLoadEvents$1.onSubmit, parameter
                                  callerContext
                               E      at com.facebook.react.views.image.ReactImageView$setShouldNotifyLoadEvents$1.onSubmit(Unknown Source:9)
                               E      at com.facebook.drawee.controller.ForwardingControllerListener.onSubmit(ForwardingControllerListener.java:75)
                               E      at com.facebook.drawee.controller.AbstractDraweeController.reportSubmit(AbstractDraweeController.java:832)
                               E      at com.facebook.drawee.controller.AbstractDraweeController.submitRequest(AbstractDraweeController.java:578)
                               E      at com.facebook.drawee.controller.AbstractDraweeController.onAttach(AbstractDraweeController.java:468)
                               E      at com.facebook.drawee.view.DraweeHolder.attachController(DraweeHolder.java:252)
                               E      at com.facebook.drawee.view.DraweeHolder.attachOrDetachController(DraweeHolder.java:269)
                               E      at com.facebook.drawee.view.DraweeHolder.onAttach(DraweeHolder.java:87)
                               E      at com.facebook.drawee.view.DraweeView.doAttach(DraweeView.java:208)
                               E      at com.facebook.drawee.view.DraweeView.onAttach(DraweeView.java:194)
                               E      at com.facebook.drawee.view.DraweeView.onAttachedToWindow(DraweeView.java:168)
                               E      at android.view.View.dispatchAttachedToWindow(View.java:20812)
                               E      at android.view.ViewGroup.dispatchAttachedToWindow(ViewGroup.java:3497)
                               E      at android.view.ViewGroup.dispatchAttachedToWindow(ViewGroup.java:3497)
                               E      at android.view.ViewGroup.dispatchAttachedToWindow(ViewGroup.java:3497)
                               E      at android.view.ViewGroup.addViewInner(ViewGroup.java:5290)
                               E      at android.view.ViewGroup.addView(ViewGroup.java:5076)
                               E      at com.facebook.react.views.view.ReactViewGroup.addView(ReactViewGroup.java:591)
                               E      at android.view.ViewGroup.addView(ViewGroup.java:5016)
                               E      at com.facebook.react.views.view.ReactClippingViewManager.addView(ReactClippingViewManager.java:41)
                               E      at com.facebook.react.views.view.ReactClippingViewManager.addView(ReactClippingViewManager.java:21)
                               E      at com.facebook.react.fabric.mounting.SurfaceMountingManager.addViewAt(SurfaceMountingManager.java:412)
                               E      at com.facebook.react.fabric.mounting.mountitems.IntBufferBatchMountItem.execute(IntBufferBatchMountItem.java:119)
                               E      at com.facebook.react.fabric.mounting.MountItemDispatcher.executeOrEnqueue(MountItemDispatcher.java:387)
                               E      at com.facebook.react.fabric.mounting.MountItemDispatcher.dispatchMountItems(MountItemDispatcher.java:294)
                               E      at com.facebook.react.fabric.mounting.MountItemDispatcher.tryDispatchMountItems(MountItemDispatcher.java:127)
                               E      at com.facebook.react.fabric.FabricUIManager$DispatchUIFrameCallback.doFrameGuarded(FabricUIManager.java:1362)
                               E      at com.facebook.react.fabric.GuardedFrameCallback.doFrame(GuardedFrameCallback.kt:22)
                               E      at com.facebook.react.modules.core.ReactChoreographer$frameCallback$1.doFrame(ReactChoreographer.kt:59)
                               E      at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1035)
                               E      at android.view.Choreographer.doCallbacks(Choreographer.java:845)
                               E      at android.view.Choreographer.doFrame(Choreographer.java:775)
                               E      at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1022)
                               E      at android.os.Handler.handleCallback(Handler.java:938)
                               E      at android.os.Handler.dispatchMessage(Handler.java:99)
                               E      at android.os.Looper.loopOnce(Looper.java:214)
                               E      at android.os.Looper.loop(Looper.java:304)
                               E      at android.app.ActivityThread.main(ActivityThread.java:7918)
                               E      at java.lang.reflect.Method.invoke(Native Method)
                               E      at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
                               E      at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1010)
      ```
      
      Changelog: [Internal]
      
      Reviewed By: fabriziocucci
      
      Differential Revision: D61332854
      
      fbshipit-source-id: 48409e2b93abf15e846620580d1f0d07a2e75025
      f8aa7867
    • Alex Hunt's avatar
      Disable connection read timeout for Network.loadNetworkResource (Android) (#46041) · 2469c676
      Alex Hunt authored
      Summary:
      Pull Request resolved: https://github.com/facebook/react-native/pull/46041
      
      We observed that large or remotely loaded source maps could time out. This change aligns `OkHttpClient` timeout values with `CxxInspectorPackagerConnection`.
      
      https://github.com/facebook/react-native/blob/a77f26827fee0fc18a11faccd0b5e51d1b222735/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/CxxInspectorPackagerConnection.java#L87-L91
      
      Changelog: [Internal]
      
      Reviewed By: robhogan
      
      Differential Revision: D61333240
      
      fbshipit-source-id: 605b1fbf1b050d8e80ed569b25cb5694e2d14ec7
      2469c676
    • Thomas Nardone's avatar
      ReactViewGroup - use safer removeViewInLayout (#45980) · 49fa92e0
      Thomas Nardone authored
      Summary:
      Pull Request resolved: https://github.com/facebook/react-native/pull/45980
      
      Use a safe remove method that won't crash on IndexOutOfBounds.
      
      Changelog: [Internal]
      
      Reviewed By: javache
      
      Differential Revision: D61132496
      
      fbshipit-source-id: edd887611c47f236b495986fc29e2d0b9ce56b8e
      49fa92e0
    • Elene Botchoradze's avatar
      fix(ios): removed default value (#46020) · 26aff664
      Elene Botchoradze authored
      Summary:
      Removed UIReturnKeyDefault as it caused bug when there wasn't any type.
      
      ## Changelog:
      
      [IOS] [REMOVED]: UIReturnKeyDefault
      
      <!-- Help reviewers and the release process by writing your own changelog entry.
      
      Pick one each for the category and type tags:
      
      [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message
      
      For more details, see:
      https://reactnative.dev/contributing/changelogs-in-pull-requests
      
      Pull Request resolved: https://github.com/facebook/react-native/pull/46020
      
      Reviewed By: christophpurrer
      
      Differential Revision: D61277058
      
      Pulled By: cipolleschi
      
      fbshipit-source-id: 18349c49b05d492a2c2ed5713af3ceb6d3728e70
      26aff664
    • Blake Friedman's avatar
      Fix publish template url for GHA action (#46040) · 15c9961c
      Blake Friedman authored
      Summary:
      Pull Request resolved: https://github.com/facebook/react-native/pull/46040
      
      The URL to dispatch the workflow was not correct, see [0].
      
      ## Changelog: [Internal]
      
      [0] https://docs.github.com/en/rest/actions/workflows?apiVersion=2022-11-28#create-a-workflow-dispatch-event
      
      ## Internal:
      
      For S441191, see the job launched:
      - https://github.com/react-native-community/template/actions/runs/10404141179/job/28811993693
      
       {F1806960111}
      
      Reviewed By: cipolleschi
      
      Differential Revision: D61333084
      
      fbshipit-source-id: 62b20d792b9c667b3ee80d6d446423a6d24a67c2
      15c9961c
    • Riccardo Cipolleschi's avatar
      Add changelog for 0.75.1 (#46038) · 7d088f80
      Riccardo Cipolleschi authored
      Summary:
      Add changelog for 0.75.1
      
      ## Changelog:
      [Internal] - Add changelog
      
      Pull Request resolved: https://github.com/facebook/react-native/pull/46038
      
      Test Plan: N/A
      
      Reviewed By: cortinico
      
      Differential Revision: D61333096
      
      Pulled By: cipolleschi
      
      fbshipit-source-id: 19ba0bce60056be12d1b0427939c5896c22e215b
      7d088f80
    • Riccardo Cipolleschi's avatar
      Backport Fixes for Create Release Workflow (#46034) · b4a2a4e7
      Riccardo Cipolleschi authored
      Summary:
      Pull Request resolved: https://github.com/facebook/react-native/pull/46034
      
      The create release workflow was not working properly for 0.75:
      
      * the latest tag was not pushed because we were using the wrong input
      * the latest tag was not deleted because we were not fetching all the tags
      * the create release job 'dry-run' defaults to false, which is a bit dangerous
      
      This change is a backport from 0.75 to main of these changes.
      
      ## Changelog
      [Internal] - Make sure that the Latest tag is properly pushed to github while releasing
      
      Reviewed By: cortinico
      
      Differential Revision: D61331247
      
      fbshipit-source-id: 89bf0698c45ec6c766e25b11599dbe926d8a6297
      b4a2a4e7
    • zhongwuzw's avatar
      Add missing pod dependency of jserrorhandler (#46030) · a77f2682
      zhongwuzw authored
      Summary:
      Fixes build error like https://github.com/facebook/react-native/actions/runs/10398775597/job/28797041872. cc RSNara
      
      ## Changelog:
      
      [IOS] [FIXED] - Add missing pod dependency of jserrorhandler
      
      Pull Request resolved: https://github.com/facebook/react-native/pull/46030
      
      Test Plan: CI green.
      
      Reviewed By: cortinico
      
      Differential Revision: D61329173
      
      Pulled By: cipolleschi
      
      fbshipit-source-id: c7dc6d7af3b57f748ae3464d9f4231ff4fb36e63
      a77f2682
    • Ramanpreet Nara's avatar
      ReactInstance: Remove redundant try/catch in loadScript (#45617) · 8c26048d
      Ramanpreet Nara authored
      Summary:
      Pull Request resolved: https://github.com/facebook/react-native/pull/45617
      
      This isn't necessary.
      
      RuntimeScheduler will catch and report via js error handler.
      
      Changelog: [Internal]
      
      Reviewed By: alanleedev
      
      Differential Revision: D60139055
      
      fbshipit-source-id: 511f384ede71d88b81ef5c031fa67b1fb03f7631
      8c26048d
    • Ramanpreet Nara's avatar
      Route fatal js errors caught in js through JsErrorHandler · 7fce7170
      Ramanpreet Nara authored
      Summary:
      If a fatal error is caught in js, and the js pipeline isn't ready, route it through the c++ pipeline.
      
      Changelog: [Internal]
      
      Reviewed By: mdvacca
      
      Differential Revision: D60138414
      
      fbshipit-source-id: 333e38e2b904d6434a88469816e39bf1b9d0bc3f
      7fce7170
    • Ramanpreet Nara's avatar
      Route all js errors caught in C++ through JsErrorHandler · dd7be8de
      Ramanpreet Nara authored
      Summary:
      If any fatal js error is caught in c++, just route it through js error handler.
      
      Then, make js error handler call into the right pipeline:
      1. After the js pipeline is ready: Route the errors through the js pipeline
      2. Otherwise: Route errors through the c++ pipeline.
      
      Changelog: [Internal]
      
      Reviewed By: javache
      
      Differential Revision: D60138417
      
      fbshipit-source-id: 24c466ffadbd14a9e9a5571548f3d34d2f406a8d
      dd7be8de
    • Ramanpreet Nara's avatar
      Refactor: RuntimeScheduler: Make error hander configurable · bc930441
      Ramanpreet Nara authored
      Summary:
      ## History
      1. Originally landed in D60138415
      2. Reverted in D60232011 (it broke ios oss builds)
      
      ## Motivation
      In bridgeless, we want to configure the error handling of runtime scheduler. So that we can route those errors to the C++ error handling pipeline, when necessary.
      
      Changelog: [Internal]
      
      Reviewed By: rubennorte
      
      Differential Revision: D60477342
      
      fbshipit-source-id: f14e20d7aff39e0fee42918567ccc6e685674134
      bc930441
    • Bowen Xie's avatar
      - Change RawPropsParser logs to WARNING (#46025) · 68c0720e
      Bowen Xie authored
      Summary:
      Pull Request resolved: https://github.com/facebook/react-native/pull/46025
      
      Changelog:
      [General][Fixed] - Change RawPropsParser logs from ERROR level to WARNING
      
      Reviewed By: christophpurrer
      
      Differential Revision: D61304854
      
      fbshipit-source-id: bc16df4916a54cb7c1fa57f359eab3d9eed4e2f4
      68c0720e