Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/facebook/react-native.git. Pull mirroring updated .
  1. Jun 06, 2016
  2. May 27, 2016
  3. May 25, 2016
  4. May 24, 2016
  5. May 21, 2016
  6. May 20, 2016
    • dmueller39's avatar
      Fixed incorrect rows reported in onChangeVisibleRows · 0aea74eb
      dmueller39 authored
      Summary:
      There is a bug in onChangeVisibleRows when the renderSeparator is not null. The _updateVisibleRows function does not account for the presence of separator frames in the  _childFrames array.
      
      When renderSeparator is not null, increment the totalIndex an additional
      time for each row that isn't the last in its section, or the last in the entire
      list.
      
      This continues a slightly brittle precedent of having a set of parallel conditions in render and _updateVisibleRows. (i.e. renderSectionHeader is used in both functions, in render as a condition to create a sectionHeader, and in _updateVisibleRows as a condition to increment the totalIndex.
      
      Before change:
      ![yeeqnmvmif](https://cloud.githubusercontent.com/assets/9422359/14515342/38543952-01c7-11e6-984c-7c1a3fc3d820.gif)
      
      After change:
      ![gzbrljclzm](https://cloud.githubusercontent.com/assets/9422359/14515340/3296e294-01c7-11e6-8ae9-1ad313600956.gif)
      
      Built using https://gist.github.com/dmueller39/f95028f6fe8bd251944bb604e51f18b2
      Closes https://github.com/facebook/react-native/pull/6965
      
      Differential Revision: D3328001
      
      Pulled By: vjeux
      
      fbshipit-source-id: 977e54382ee07be7a432a54febafcae6acaae905
      0aea74eb
    • Alexander Blom's avatar
      Don't find module methods until needed · d6c2f5f3
      Alexander Blom authored
      Reviewed By: astreet
      
      Differential Revision: D3322974
      
      fbshipit-source-id: 4cb47cc2ebdffd77b62c5d54e65574d44eba286e
      d6c2f5f3
    • Eric Rozell's avatar
      Adds packager configuration to support windows platform · ef21d99d
      Eric Rozell authored
      Summary:
      This pull request is a prerequisite to enabling the react-native-windows platform extension.
      
      In the Resolver component, we need to add 'windows' to the list of platforms that are allowed in the DependencyGraph.  We also need to add 'react-native-windows' (the name of the Windows platform extension NPM module) to the `providesModuleNodeModules` option. This allows the node_module folder check in the DependencyGraphHelper from node-haste to be bypassed for *.windows.js files in the Windows NPM package.
      
      For good measure, I also included a change to blacklist.js to ensure .windows.js files are ignored when the packager is parameterized on a platform.
      Closes https://github.com/facebook/react-native/pull/7639
      
      Differential Revision: D3327771
      
      Pulled By: mkonicek
      
      fbshipit-source-id: d1080b045ff6aa0cbf05d8070ceb0eb4cdb6dceb
      ef21d99d
    • Mike Grabowski's avatar
      Merge rnpm into react-native · 149d0b91
      Mike Grabowski authored
      Summary:
      This is initial (first step) in the merging process. For now, we are just going to move our code as is into `local-cli` folder (first commit). There were other tweaks made in separate commits to make it easier to go through the code as the diff is expected to be rather large. The purpose of this is to make it easier to start working in small batches and improving the CLI incrementally on a daily basis.
      
      Current codebase will still leave in `rnpm` organisation on Github where we keep working on new features, bugs and ship releases to `npm` until we finish our integration and provide a nice interface for users to migrate (in case it changes at all)
      
      Flow, Jest and npm will ignore this folder for now until we integrate it properly.
      
      Tests are to be rewritten from mocha to jest in `rnpm/link`. We will hook them all up as soon as we start using them in local-cli.
      
      For now, there's no point in having them running and possibly breaking the builds.
      
      We will announce next steps with Kureev later this week
      Closes https://github.com/facebook/react-native/pull/7550
      
      Differential Revision: D3327772
      
      Pulled By: mkonicek
      
      fbshipit-source-id: 90faa4bd78476d93ed21b1253e0d95c755d28a30
      149d0b91
    • Andrej Badin's avatar
      Improve Docs navigation on handheld devices. · 00c77800
      Andrej Badin authored
      Summary:
      Fixes #7519
      
      JS detects handheld device by sniffing UA string (very primitive detection). If on handheld device, event listener is registered. Event handler toggles Docs Navigation overlay after clicking on "Docs" nav button.
      Original Docs Navigation panel is taken out of the natural page flow using pure CSS and is styled to look "good" on device.  As a result of this, Navigation overlay is ONLY visible when you are at Docs page, otherwise "Docs" nav button takes you Docs page first.
      
      iPhone/iPad previews
      ![iphone](https://cloud.githubusercontent.com/assets/829963/15409630/f1a64b1a-1e15-11e6-92eb-f85c5cd06754.gif)
      ![ipad](https://cloud.githubusercontent.com/assets/829963/15409631/f1a6f952-1e15-11e6-8f5c-6f89f54e6814.gif)
      Closes https://github.com/facebook/react-native/pull/7640
      
      Differential Revision: D3325440
      
      Pulled By: vjeux
      
      fbshipit-source-id: a06b21d743d56bfea5db5b750836856c3af9bbe2
      00c77800
    • Fred Liu's avatar
      Simplify SwipeableRow styling · 3ccfb587
      Fred Liu authored
      Summary: - Removed some styling from `SwipeableRow` that wasn't doing much and made slide out view full height
      
      Reviewed By: fkgozali
      
      Differential Revision: D3322849
      
      fbshipit-source-id: 811eee9032c142c61d303ae7e966d8ef7903adaf
      3ccfb587
    • Fred Liu's avatar
      Fix Android flash and iOS juttering · 62e588be
      Fred Liu authored
      Summary:
      Before:
      - Android had the slideout row flash upon render due to it being rendered first
      - iOS had the left side of each row load first, then rerender to show entire row when `scrollViewWidth` is available
      
      Reason:
      - Android was loading the slideout view first without an opacity check
      - iOS was loading the swipeable view with width 0 first then stretching to `scrollViewWidth` when it was available via `onLayout`
      
      Fix:
      Render swipeable view with `flex: 1` then render slideout view
      
      Reviewed By: fkgozali
      
      Differential Revision: D3321466
      
      fbshipit-source-id: 92a3b5e22034e06d05986ddb8c348796bafbbf34
      62e588be
    • Chris Hopman's avatar
      Move more new bridge code into OSS · 83019784
      Chris Hopman authored
      Reviewed By: mhorowitz
      
      Differential Revision: D3296231
      
      fbshipit-source-id: 5a05b1ddacdfecda067a08398dd5652df76c1f14
      83019784
    • Spencer Ahrens's avatar
      Fix 95% of WindowedListView jumpiness · 5e91a2a3
      Spencer Ahrens authored
      Summary:
      - Replace some fixes that were accidentally lost in local rebase that prevent jumpiness when incremental is disabled.
      - Require each row to have a key specified by the caller to prevent jumping because of accidental duplicates or unneeded/problematic row re-rendering because of legit re-ordering.
      
      Reviewed By: steveluscher
      
      Differential Revision: D3322006
      
      fbshipit-source-id: 0019aab07cb1fe2b148a14b5818de53aa373eb50
      5e91a2a3
    • Alexander Blom's avatar
      Make BugReporting not pull in native module on require · 942b9332
      Alexander Blom authored
      Reviewed By: astreet
      
      Differential Revision: D3322838
      
      fbshipit-source-id: 4f12fda213b6a4ab7b19d3dafad7f31eb627f85a
      942b9332
  7. May 19, 2016
    • Konstantin Raev's avatar
      Disabled flow in e2e test because it causes memory crashes · 6a34c9c3
      Konstantin Raev authored
      Summary: Closes https://github.com/facebook/react-native/pull/7620
      
      Differential Revision: D3322029
      
      fbshipit-source-id: e0406770d011956af6b47d15c5b49a68b1b611f5
      6a34c9c3
    • Leonardo Tegon's avatar
      Fixes syntax typo in DirectManipulation section of docs · 8a201b84
      Leonardo Tegon authored
      Summary:
      Fixing JSX tag in DirectManipulation section of the docs
      Closes https://github.com/facebook/react-native/pull/7622
      
      Differential Revision: D3321130
      
      fbshipit-source-id: e315529dc94c88597e4855a63ba6931301d4dba7
      8a201b84
    • Spencer Ahrens's avatar
      adaptive render window throughput · 838d8d40
      Spencer Ahrens authored
      Summary:
      Incremental rendering is a tradeoff between throughput and responsiveness because it yields. When we have plenty of
      buffer (say 50% of the target), we render incrementally to keep the app responsive. If we are dangerously low on buffer
      (say below 25%) we always disable incremental to try to catch up as fast as possible. In between, we only disable
      incremental while actively scrolling since it's unlikely the user will try to press a button while scrolling.
      
      This also optimizes some things then incremental is switching back and forth.
      
      I played around with making the render window itself adaptive, but it seems pretty futile to predict - once the user
      decides to scroll quickly in some direction, it's pretty much too late and increasing the render window size won't help
      because we're already limited by the render throughput at that point.
      
      Reviewed By: ericvicenti
      
      Differential Revision: D3250916
      
      fbshipit-source-id: 930d418522a3bf3e20083e60f6eb6f891497a2b8
      838d8d40
    • Fred Liu's avatar
      Prevent `SwipeableRow` bleed · 51467752
      Fred Liu authored
      Summary: Default image icon size for Quick Actions could cause slideout view to bleed over the slideable view. All styling has been removed and must now be passed in, thus allowing every caller to control size for best fit.
      
      Reviewed By: furdei
      
      Differential Revision: D3315696
      
      fbshipit-source-id: 8f8b3d2cf7a005d42a18d434d9e0080c64597be0
      51467752
    • Alexander Blom's avatar
      Refactor BugReporing to avoid multiple registers · dc6a4471
      Alexander Blom authored
      Reviewed By: sahrens
      
      Differential Revision: D3316146
      
      fbshipit-source-id: 80df4ea73150ba6920a03fe336b3ddb207ba535a
      dc6a4471
    • Hedger Wang's avatar
      Fork NavigationAnimatedView to NavigationTransitioner · 7db7f78d
      Hedger Wang authored
      Summary:
      - Fork NavigationAnimatedView to NavigationTransitioner
      - NavigationAnimatedView will soon be deprecated and we'd ask people to use NavigationTransitioner instead.
      
      Difference between  NavigationTransitioner and NavigationAnimatedView
      
      - prop `applyAnimation` is removed.
      - new prop `configureTransition`, `onTransitionStart`, and `onTransitionEnd` are added.
      
      tl;dr;
      
      In NavigationAnimatedView, we `position` (an Animated.Value object) as a proxy of the
      transtion which happens whenever the index of navigation state changes.
      
      Because `position` does not change unless navigation index changes, it won't
      be possible to build animations for actions that changes the  navigation state
      without changing the index.
      
      Also, we believe that the name `Transitioner` is a better name for this core component
      that focuses on transitioning. Note that the actual animation work is done via
      `<Animated.View />` returnd from the `renderScene` prop.
      
      Reviewed By: ericvicenti
      
      Differential Revision: D3302688
      
      fbshipit-source-id: 720c3a4d3ccf97eb05b038baa44c9e780aad120b
      7db7f78d
    • Joe Noon's avatar
      fixes a bug where NavigationPropTypes.SceneRenderer was a plain object · 0e997c6e
      Joe Noon authored
      Summary:
      ... used as both a shape and plain object.
      
      this splits them out so both parts can be used as needed.
      
      NavigationPropTypes.SceneRenderer is a PropTypes shape
      NavigationPropTypes.SceneRendererProps is the plain object that makes up the shape.
      Closes https://github.com/facebook/react-native/pull/7518
      
      Differential Revision: D3317322
      
      Pulled By: ericvicenti
      
      fbshipit-source-id: e8a31e05130e6647b63f68dbef31bc874550948c
      0e997c6e
    • Marc Horowitz's avatar
      shut down JSC before quitting its thread · 6796f136
      Marc Horowitz authored
      Differential Revision: D3280544
      
      fbshipit-source-id: 2a3ef2c445aaa1b224ac391b020467e087c0b81d
      6796f136
    • Marc Horowitz's avatar
      Implement incremental module requires · 779314a4
      Marc Horowitz authored
      Differential Revision: D3234844
      
      fbshipit-source-id: 24615528ad6a049aad7c2dbb7ce55e8b034c79e7
      779314a4
    • Fred Liu's avatar
      Top align quick action buttons · 7f1346bf
      Fred Liu authored
      Summary: Top align the button icons
      
      Reviewed By: fkgozali
      
      Differential Revision: D3317805
      
      fbshipit-source-id: b385f9f4e41db1253bb4d523cb07093c63e39da0
      7f1346bf
    • Alex Kotliarskyi's avatar
      Add transform-react-jsx-source to react-native preset · 858643db
      Alex Kotliarskyi authored
      Summary:
      Putting this up as request for comments.
      
      The PR adds [transform-react-jsx-source](https://github.com/babel/babel/tree/master/packages/babel-plugin-transform-react-jsx-source) to the list of plugins that come by default with the `react-native` preset. It will enable the use of a bunch of really cool tooling around JSX, however those are generally useful only in development mode. Is changing `react-native` preset the right thing to do in this case? Is there a way to enable this transform only in DEV? Should I add this somewhere else?
      Closes https://github.com/facebook/react-native/pull/6351
      
      Differential Revision: D3302906
      
      Pulled By: frantic
      
      fbshipit-source-id: 012d3a4142168f9f90d30d1686115d4dc3996eb9
      858643db
    • Joel Marcey's avatar
      Best effort selection of target platform and dev environment · 18e1b1f1
      Joel Marcey authored
      Summary:
      Right now, if you do a search and select a document in Getting Started, it will
      always default to iOS/Mac. This adds a bit of JavaScript to do a best effort
      selection based on the hashtags of the headers.
      
      If a header is associated with multiple environments (e.g., Android Studio), we
      just choose the first one. So it is not 100% perfect, but it is decent.
      
      ref: https://github.com/facebook/react-native/issues/7574
      
      ** Test Plan **
      
      Test locally by adding hash tags to the end of a doc URL and ensured that the toggler had the right
      selection.
      
      e.g., `http://localhost:8079/react-native/docs/getting-started.html#chocolatey` had `Android` and `Windows` chosen.
      Closes https://github.com/facebook/react-native/pull/7608
      
      Differential Revision: D3316802
      
      Pulled By: JoelMarcey
      
      fbshipit-source-id: 6e94d76725fb97b19b3708ddee8fba5df9350cdd
      18e1b1f1
  8. May 18, 2016