feat(ivy): let ngtsc annotate type check blocks with source positions (#30181)
The type check blocks (TCB) that ngtsc generates for achieving type checking of Angular templates needs to be annotated with positional information in order to translate TypeScript's diagnostics for the TCB code back to the location in the user's template. This commit augments the TCB by attaching trailing comments with AST nodes, such that a node can be traced back to its source location. PR Close #30181
Showing
- packages/compiler-cli/src/ngtsc/typecheck/src/diagnostics.ts 74 additions, 0 deletionspackages/compiler-cli/src/ngtsc/typecheck/src/diagnostics.ts
- packages/compiler-cli/src/ngtsc/typecheck/src/expression.ts 56 additions, 28 deletionspackages/compiler-cli/src/ngtsc/typecheck/src/expression.ts
- packages/compiler-cli/src/ngtsc/typecheck/src/type_check_block.ts 61 additions, 31 deletions.../compiler-cli/src/ngtsc/typecheck/src/type_check_block.ts
- packages/compiler-cli/src/ngtsc/typecheck/test/span_comments_spec.ts 128 additions, 0 deletions...mpiler-cli/src/ngtsc/typecheck/test/span_comments_spec.ts
- packages/compiler-cli/src/ngtsc/typecheck/test/test_utils.ts 7 additions, 2 deletionspackages/compiler-cli/src/ngtsc/typecheck/test/test_utils.ts
- packages/compiler-cli/src/ngtsc/typecheck/test/type_check_block_spec.ts 65 additions, 66 deletions...ler-cli/src/ngtsc/typecheck/test/type_check_block_spec.ts
Please register or sign in to comment