refactor(migrations): use import manager in signal input migration (#57318)
Instead of fiddling manually with the imports, which worked well, but comes at a cost of complexity— we are now using the canonical import manager. This simplifies deletion, insertion and updating of imports. Notably, our import manager is not super great at preserving whitespaces right now, but we assume a formatter runs over migrated code anyway. PR Close #57318
Showing
- packages/core/schematics/migrations/signal-migration/src/convert-input/convert_to_signal.ts 7 additions, 5 deletions...s/signal-migration/src/convert-input/convert_to_signal.ts
- packages/core/schematics/migrations/signal-migration/src/input_detection/input_decorator.ts 0 additions, 3 deletions...s/signal-migration/src/input_detection/input_decorator.ts
- packages/core/schematics/migrations/signal-migration/src/passes/10_apply_import_manager.ts 59 additions, 0 deletions...ns/signal-migration/src/passes/10_apply_import_manager.ts
- packages/core/schematics/migrations/signal-migration/src/passes/6_migrate_input_declarations.ts 6 additions, 54 deletions...gnal-migration/src/passes/6_migrate_input_declarations.ts
- packages/core/schematics/migrations/signal-migration/src/passes/9_migrate_ts_type_references.ts 1 addition, 37 deletions...gnal-migration/src/passes/9_migrate_ts_type_references.ts
- packages/core/schematics/migrations/signal-migration/src/phase_migrate.ts 12 additions, 3 deletions...hematics/migrations/signal-migration/src/phase_migrate.ts
- packages/core/schematics/migrations/signal-migration/test/golden.txt 26 additions, 26 deletions...re/schematics/migrations/signal-migration/test/golden.txt
- packages/core/schematics/migrations/signal-migration/test/golden_best_effort.txt 31 additions, 31 deletions...s/migrations/signal-migration/test/golden_best_effort.txt
Please register or sign in to comment