This project is mirrored from https://github.com/angular/angular.git.
Pull mirroring updated .
- Feb 09, 2022
-
-
Dylan Hunn authored
PR Close #45018
-
- Feb 08, 2022
-
-
Alan Cohen authored
PR Close #44988
-
Andrew Kushnir authored
This commit updates various places in the repo (mostly tests/examples) to drop all `.ngfactory` and `.ngsummary` imports as they are no longer needed in Ivy. PR Close #44957
-
Shai Reznik authored
to resources PR Close #44969
-
Kristiyan Kostadinov authored
When an `NgModel` is created within a `form`, it receives an `NgControl` based on its `name`, but the control doesn't get swapped out if the name changes. This can lead to problems if the `NgModel` is part of an `ngFor`, because the name can change based on its position in the list and a new control can be defined with the same name, leading us to having multiple directives pointing to the same control. For example, if we start off with a list like : ``` [0, 1, 2]; -> [NgModel(0), NgModel(1), NgModel(2)] ``` Then we remove the second item: ``` [0, 2]; -> [NgModel(0), NgModel(2)] ``` And finally, if we decide to add an item to the end of the list, we'll already have a control for index 2, causing the list to look like: ``` [0, 2, 3]; -> [NgModel(0), NgModel(2), NgModel(2)] ``` These changes fix the issue by removing the old control when the `name` of the directive changes. Fixes #38465. Fixes #37920. PR Close #40459
-
iRealNirmal authored
This commit updates the `PatternValidator` class to inherit `AbstractValidatorDirective` to make it conistent with other validators. Closes angular#42267 PR Close #44887
-
JoostK authored
For two-way-bindings that use the banana-in-a-box syntax, the compiler synthesizes an event assignment expression from the primary expression. It is valid for the primary expression to be terminated by the non-null operator, however naive string substitution is used for the synthesized expression, such that the `!` would immediately precede the `=` token, resulting in the valid `!=` operator token. The expression would still parse correctly but it doesn't implement the proper semantics, resulting in incorrect runtime behavior. Changing the expression substitution to force a space between the primary expression and the assignment avoids this mistake, but it uncovers a new issue. The grammar does not allow for the LHS of an assignment to be the non-null operator, so the synthesized expression would fail to parse. To alleviate this, the synthesized expression is parsed with a special parser flag to allow for this syntax. Fixes #36551 PR Close #37809
-
Alan Agius authored
With this change we group all the scorecard action dependencies so that Renovate opens a single PR. PR Close #44998
-
dario-piotrowicz authored
fix the "cosidered" typo (which should be "considered") PR Close #44987
-
- Feb 05, 2022
-
-
Renovate Bot authored
Patch port of #44963 PR Close #44974
-
Ramzan authored
revert the condition as dev only PR Close #44354
-
Andrew Kushnir authored
This commit updates `DebugNode` and `DebugElement` implementaitons to cleanup ViewEngine removal artifacts. There is no need for a separate interface and implementation class, so we can combine them now. This comment also gets rid of `R3` suffixes (denoting Ivy) in helper methods. PR Close #44270
-
Jayson Acosta authored
Service worker card contains typo 'us' when it should be 'use.' PR Close #44793
-
zuckjet authored
low version nodejs doesn't support nullish coalescing operator very well PR Close #44968
-
- Feb 04, 2022
-
-
Joey Perrott authored
The devtools scoped commits are not included in the repository's CHANGELOG.md file as these commits are not references areas which are included in the primary released artifacts. PR Close #44964
-
Olivier Capuozzo authored
"deleteRequest" is the *event* (not target) and "crossOffItem" is the *handler* of the event (not "source"). PR Close #39900
-
Joey Perrott authored
Set up OpenSSF Scorecard to begin tracking security metrics within the repo. PR Close #44960
-
jhonyeduardo authored
PR Close #43689
-
dario-piotrowicz authored
add types to all the buttons in the angular.io examples to encourage the best practice of always including a type per button (regardless to whether it is in a form or now) PR Close #44557
-
dario-piotrowicz authored
remove the comments present in aio examples saying that for older browsers such as IE CustomEvent could be necessary (as the the Event constructor could be not available) such comments are no longer necessary/relevant since the Event constructor is available for all the supported browsers PR Close #44557
-
Dario Piotrowicz authored
the aio examples have various eslint issues regarding template rules, those are currently turned off and TODO comments have been added to them in the examples eslintrc, fix such issues and remove the respective TODO comments this also includes examples refactoring to use buttons for better accessibility, this change tries to make the smallest amound of changes to the examples' behaviors and designs/UI PR Close #44557
-
TANMAY SRIVASTAVA authored
in the last Lines ViewEncapsulationComponent should be EmulatedEncapsulationComponent as there is no such ViewEncapsulationComponent exists in this example where as ShadowDomEncapsulationComponent contains NoEncapsulationComponent and EmulatedEncapsulationComponent PR Close #42899
-
dario-piotrowicz authored
slightly improve the punctuation in the animation sequence summary present in the complex animation sequences guide PR Close #44567
-
Dario Piotrowicz authored
add a section regarding reordering list items in the complex animation sequences guide to help developers rememeber to use a `TrackByFunction` whenever they are animating `*ngFor` list items which change their ordering as suggested here: https://github.com/angular/angular/issues/42750#issuecomment-979127165 relates to issue #28040 and #42750 PR Close #44567
-
Andrew Scott authored
After trying this feature, it turns out the approach does not work and we will be reverting the commits. Note that the feature _never_ worked so it's not a breaking change. PR Close #44961
-
Daniel Díaz authored
PR Close #44958
-
- Feb 03, 2022
-
-
Doug Parker authored
refactor(compiler): add `@suppress {msgDescriptions}` if no description is present on an i18n message (#44787) Refs http://b/214103351. This happens if a user writes `<span i18n>Message</span>`. This is accepted as an internationalized message, but without a description. JSCompiler will throw an error in this situation because descriptions are generally required. Now, the Angular compiler will generate a suppression annotation so JSCompiler allows the syntax. This will ease an internal migration to JSCompiler-based i18n. PR Close #44787
-
Andrew Scott authored
This code mimics behavior that Google Analytics has been using to prevent duplicate navigations. They set up their own `HybridRoutingService` location sync to avoid duplicate navigations that came from the Angular router. This would happen because the Angular router would trigger a navigation, which would then get picked up by the `$locationShim`, which would trigger a `$locationChangeStart`, which would then be picked up by the `setUpLocationSync` watcher here, which would again trigger a navigation in the Angular Router. All of this can be prevented by checking if the `navigationId` exists on the history state object. This property is added by the Angular router during navigations. fixes #21610 PR Close #43441
-
Andrew Scott authored
This updates the router upgrade tests to use less mocked behavior. The test upgrade location module is copied from the one that's used in the common package. This update to the tests verifies more real behavior of the upgrade module. PR Close #43441
-
mgechev authored
The survey is now over. We can remove the banner. PR Close #44949
-
Jessica Janiuk authored
-
George Kalpakas authored
Updating [angular#13.2.x](https://github.com/angular/angular/tree/13.2.x) from [cli-builds#13.2.x](https://github.com/angular/cli-builds/tree/13.2.x). ## Relevant changes in [commit range](https://github.com/angular/cli-builds/compare/9ac3df5d1...0f51d5c70): **Modified** - help/test.json PR Close #44943
-
- Feb 02, 2022
-
-
mgechev authored
Extend with a few more days since the survey is still open. PR Close #44938
-
JoostK authored
The logical filesystem would store a cached result based on the canonical path, where the cached value contains the physical path that was originally provided. This meant that other physical paths with an identical canonical path would use a cached result derived from another physical path. This inconsistency is not known to result in actual issues but is primarily being made as a performance improvement, as using the provided physical paths as cache key avoids the need to canonicalize the path if its result is already cached. PR Close #44798
-
JoostK authored
refactor(compiler-cli): use relative imports into dts files as fallback in type-check files (#44798) The generated imports should normally use module specifiers that are valid for use in production code, where arbitrary relative imports into e.g. node_modules are not allowed. For template type-checking code it is however acceptable to use relative imports, as such files are never emitted to JS code. It is desirable to allow a filesystem relative import as fallback if an import would otherwise fail to be generated, as doing so allows fewer situations from needing an inline type constructor. PR Close #44798
-
JoostK authored
This commit removes the leftover `Identifiers` class that was used in the ViewEngine compiler. The remaining usages of the `inlineInterpolate` and `interpolate` instructions were refactored to make use of an `InterpolationExpression` output expression to capture the argument list of an interpolation expression. An attempt was made to refactor this further by converting to the desired interpolation instruction immediately, but some downstream consumers are designed in a way where the argument list itself is needed, e.g. as other arguments need to be prepended/appended. PR Close #44676
-
Andrew Scott authored
CI ran before the change to the tsconfig file PR Close #44935
-
markostanimirovic authored
PR Close #44932
-
JoostK authored
When `HttpTestingController.verify` is used to verify that there are not open, unexpected requests it would throw an error with the method and URL of all pending requests, excluding the query parameters. This is confusing, as e.g. `expectOne` matches a URL including its query parameters and `expectOne` does include the query parameters when it reports when no request could be matched. This commit changes the error that is reported by `verify` to include the query parameters. Closes #19974 PR Close #44917
-
Renovate Bot authored
PR Close #44930
-