Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/angular/angular.git. Pull mirroring updated .
  1. Feb 09, 2022
  2. Feb 08, 2022
    • Alan Cohen's avatar
      docs: fix command to clear cache on Windows (#44988) · 7bc4dbd7
      Alan Cohen authored
      PR Close #44988
      7bc4dbd7
    • Andrew Kushnir's avatar
      refactor(core): drop all `.ngfactory` and `.ngsummary` imports (#44957) · d40ac205
      Andrew Kushnir authored
      This commit updates various places in the repo (mostly tests/examples) to drop all `.ngfactory` and `.ngsummary` imports as they are no longer needed in Ivy.
      
      PR Close #44957
      d40ac205
    • Shai Reznik's avatar
      docs: add Cost-Effective Angular Testing (#44969) · 1368f58b
      Shai Reznik authored
      to resources
      PR Close #44969
      1368f58b
    • Kristiyan Kostadinov's avatar
      fix(forms): incorrectly keeping track of ngModel with ngFor inside a form (#40459) · b75e90f8
      Kristiyan Kostadinov authored
      When an `NgModel` is created within a `form`, it receives an `NgControl` based on its `name`, but
      the control doesn't get swapped out if the name changes. This can lead to problems if the `NgModel`
      is part of an `ngFor`, because the name can change based on its position in the list and a new
      control can be defined with the same name, leading us to having multiple directives pointing to
      the same control. For example, if we start off with a list like :
      
      ```
      [0, 1, 2]; -> [NgModel(0), NgModel(1), NgModel(2)]
      ```
      
      Then we remove the second item:
      
      ```
      [0, 2]; -> [NgModel(0), NgModel(2)]
      ```
      
      And finally, if we decide to add an item to the end of the list, we'll already have a control for
      index 2, causing the list to look like:
      
      ```
      [0, 2, 3]; -> [NgModel(0), NgModel(2), NgModel(2)]
      ```
      
      These changes fix the issue by removing the old control when the `name` of the directive changes.
      
      Fixes #38465.
      Fixes #37920.
      
      PR Close #40459
      b75e90f8
    • iRealNirmal's avatar
      refactor(forms): update `PatternValidator` to inherit `AbstractValidatorDirective` (#44887) · 3919ee37
      iRealNirmal authored
      This commit updates the `PatternValidator` class to inherit `AbstractValidatorDirective` to make it conistent with other validators.
      
      Closes angular#42267
      
      PR Close #44887
      3919ee37
    • JoostK's avatar
      fix(compiler): allow banana-in-a-box bindings to end with non-null assertion (#37809) · 37af6abb
      JoostK authored
      For two-way-bindings that use the banana-in-a-box syntax, the compiler
      synthesizes an event assignment expression from the primary expression.
      It is valid for the primary expression to be terminated by the non-null
      operator, however naive string substitution is used for the synthesized
      expression, such that the `!` would immediately precede the `=` token,
      resulting in the valid `!=` operator token. The expression would still
      parse correctly but it doesn't implement the proper semantics, resulting
      in incorrect runtime behavior.
      
      Changing the expression substitution to force a space between the
      primary expression and the assignment avoids this mistake, but it
      uncovers a new issue. The grammar does not allow for the LHS of an
      assignment to be the non-null operator, so the synthesized expression
      would fail to parse. To alleviate this, the synthesized expression is
      parsed with a special parser flag to allow for this syntax.
      
      Fixes #36551
      
      PR Close #37809
      37af6abb
    • Alan Agius's avatar
      ci: group all scorecard action dependencies (#44998) · 604a67f0
      Alan Agius authored
      With this change we group all the scorecard action dependencies so that Renovate opens a single PR.
      
      PR Close #44998
      604a67f0
    • dario-piotrowicz's avatar
      docs(docs-infra): fix cosidered typo (#44987) · baf0c7a1
      dario-piotrowicz authored
      fix the "cosidered" typo (which should be "considered")
      
      PR Close #44987
      baf0c7a1
  3. Feb 05, 2022
  4. Feb 04, 2022
  5. Feb 03, 2022
  6. Feb 02, 2022
    • mgechev's avatar
      docs: update the survey expiration date (#44938) · 165aa4f1
      mgechev authored
      Extend with a few more days since the survey is still open.
      
      PR Close #44938
      165aa4f1
    • JoostK's avatar
      fix(compiler-cli): ensure casing of logical paths is preserved (#44798) · 4a5ad179
      JoostK authored
      The logical filesystem would store a cached result based on the canonical path,
      where the cached value contains the physical path that was originally provided.
      This meant that other physical paths with an identical canonical path would use
      a cached result derived from another physical path.
      
      This inconsistency is not known to result in actual issues but is primarily
      being made as a performance improvement, as using the provided physical paths
      as cache key avoids the need to canonicalize the path if its result is already
      cached.
      
      PR Close #44798
      4a5ad179
    • JoostK's avatar
      refactor(compiler-cli): use relative imports into dts files as fallback in... · d65a42b1
      JoostK authored
      refactor(compiler-cli): use relative imports into dts files as fallback in type-check files (#44798)
      
      The generated imports should normally use module specifiers that are valid for
      use in production code, where arbitrary relative imports into e.g. node_modules
      are not allowed. For template type-checking code it is however acceptable to
      use relative imports, as such files are never emitted to JS code. It is
      desirable to allow a filesystem relative import as fallback if an import would
      otherwise fail to be generated, as doing so allows fewer situations from
      needing an inline type constructor.
      
      PR Close #44798
      d65a42b1
    • JoostK's avatar
      refactor(compiler): remove ViewEngine identifiers (#44676) · dee108b6
      JoostK authored
      This commit removes the leftover `Identifiers` class that was used in the
      ViewEngine compiler. The remaining usages of the `inlineInterpolate` and
      `interpolate` instructions were refactored to make use of an
      `InterpolationExpression` output expression to capture the argument list of an
      interpolation expression. An attempt was made to refactor this further by
      converting to the desired interpolation instruction immediately, but some
      downstream consumers are designed in a way where the argument list itself is
      needed, e.g. as other arguments need to be prepended/appended.
      
      PR Close #44676
      dee108b6
    • Andrew Scott's avatar
      build: fix test for useUnknownInCatch (#44935) · 5a757218
      Andrew Scott authored
      CI ran before the change to the tsconfig file
      
      PR Close #44935
      5a757218
    • markostanimirovic's avatar
      ec497968
    • JoostK's avatar
      fix(common): include query parameters for open HTTP requests in `verify` (#44917) · b4e46178
      JoostK authored
      When `HttpTestingController.verify` is used to verify that there are not open,
      unexpected requests it would throw an error with the method and URL of all pending
      requests, excluding the query parameters. This is confusing, as e.g. `expectOne`
      matches a URL including its query parameters and `expectOne` does include the
      query parameters when it reports when no request could be matched.
      
      This commit changes the error that is reported by `verify` to include the query
      parameters.
      
      Closes #19974
      
      PR Close #44917
      b4e46178
    • Renovate Bot's avatar
      build: update all non-major dependencies (#44930) · 812c1ba9
      Renovate Bot authored
      PR Close #44930
      812c1ba9