This project is mirrored from https://github.com/angular/angular.git.
Pull mirroring updated .
- Mar 10, 2022
-
-
Andrew Kushnir authored
-
- Mar 09, 2022
-
-
Andrew Scott authored
When authoring Angular templates, developers are likely to be most interested in the current Directive/Component inputs and outputs, then potential attributes which would match other directives to the element, and lastly the plethora of DOM events and attributes. This change ensures that Angular-specific information appears above DOM information by prepending the first printable ASCII characters to the sort text. Fixes https://github.com/angular/vscode-ng-language-service/issues/1537 PR Close #45293
-
Andrew Scott authored
valueDeclaration is only set when the Symbol type is a `Value`: * [setValueDeclaration](https://sourcegraph.com/github.com/microsoft/TypeScript@d8b21a8d6cef772fea5cf2a507b651c5d38194bd/-/blob/src/compiler/binder.ts?L321-322) * [Value union](https://sourcegraph.com/github.com/microsoft/TypeScript@d8b21a8d6cef772fea5cf2a507b651c5d38194bd/-/blob/src/compiler/types.ts?L4849:9#tab=references) This won't be the case if the symbol is an interface (notice that `Interface` is not in the union for `Value` above). For this reason, we can't rely on the `valueDeclaration` property of the symbol. Instead, it's more reliable to just compare the first items in the `declarations` list. PR Close #45292
-
Renovate Bot authored
PR Close #45248
-
Mladen Jakovljević authored
Remove anchor tags from heritage docs and let `autoLinkCode` insert them properly. PR Close #45287
-
Luca authored
Add file system concurrency hash test Fixes #45133 PR Close #45262
-
Andrew Scott authored
When parsing interpolations, the input string is _decoded_ from what was in the orginal template. This means that we cannot soley rely on the input string to compute source spans because it does not necessarily reflect the exact content of the original template. Specifically, when there is an HTML entity (i.e. ` `), this will show up in its decoded form when processing the interpolation (' '). We need to compute offsets using the original _encoded_ string. Note that this problem only surfaces in the splitting of interpolations. The spans to this point have already been tracked accurately. For example, given the template ` <div></div>`, the source span for the `div` is already correctly determined to be 6. Only when we encounter interpolations with many parts do we run into situations where we need to compute new spans for the individual parts of the interpolation. PR Close #44811
-
- Mar 08, 2022
-
-
Srikanth Kolli authored
PR Close #45257
-
nanda18 authored
PR Close #45237
-
Renovate Bot authored
PR Close #45260
-
Renovate Bot authored
PR Close #45247
-
Kristiyan Kostadinov authored
Jasmine logs a warning when there's a `describe` with no tests. These changes fix one such case in the compiler that happens when the tests are run against Windows. PR Close #45285
-
JiaLiPassion authored
CI components test install the angular package from the local version, but still use the zone.js from npm, so this commit let components also install zone.js from local too. PR Close #45277
-
- Mar 05, 2022
-
-
Andrew Scott authored
This update matches the other locations where noMatch is thrown. PR Close #45244
-
Joey Perrott authored
Local patch ahead of landing of https://github.com/angular/dev-infra/pull/449 PR Close #45269
-
- Mar 04, 2022
-
-
Anner Visser authored
PR Close #45207
-
Aristeidis Bampakos authored
PR Close #45152
-
JiaLiPassion authored
Close #44095 Fix `defineProperties` patch not set `symbol` props issue. Co-authored-by:
<varomodt<varomodt@users.noreply.github.com> Co-authored-by:
<AndrewKushnir<AndrewKushnir@users.noreply.github.com> PR Close #45098
-
Andrew Scott authored
This commit removes special (undocumented) logic in the Router code that is meant to prevent duplicate navigations that result from location syncs in AngularJS/Angular hybrid applications. The duplicate navigations can occur when both the Router and the AngularJS sync code detect a location change via a popstate/hashchange event. When this happens, the Angular Router schedules a navigation to sync itself with the browser, but the hybrid listener may also schedule an additional navigation. There are a few reasons this logic should not be included in the Router: * This special logic is not tree shakeable so it introduces a bundle size cost for all applications, most of which don't need it. * There have been many updates to the routing pipeline to tolerate duplicate navigations. That is, duplicate navigations can happen and routing should still complete successfully. * https://github.com/angular/angular/commit/0e8548f667e5fdefa3ac7cdf1ba47e3e17011ffc * https://github.com/angular/angular/commit/9e039ca68bfae5328f3fc1f16fabd7673c466a25 * The logic is really in the wrong place: The hybrid sync code should be the location to handle this. If duplicate navigations are meant to be avoided, the hybrid sync code should have handling to _not_ trigger duplicate navs. * This logic _also_ used to exist because the mock location helper used for test incorrectly triggered popstate events during router navigations. In order to avoid unexpected behavior in tests, this logic needed to be added. This incorrect mocking may also have been put in place because the upgrade module _would_ see a location change event and trigger a duplicate navigation. The location mock has since been updated to match real browser behavior so this is no longer necessary. The upgrade module has also been updated to not trigger duplicate navigations. The following commits are related to this: * https://github.com/angular/angular/commit/202a1a56314af4ddb99c476f974536a10e390319 * https://github.com/angular/angular/commit/c6a93001eb74374b0fbc6aea1286fe1183d21382 Side note: The `setTimeout` in the location change listener is used to ensure the ordering of duplicate navigations was consistent. You can see that the logic being removed here expects the imperative navigation to precede the popstate/hashchange. With the removal of this code, the `setTimeout` no longer serves a purpose. However, it has been found that tests can rely on this behavior (incorrectly) because they expect the navigation to be complete but in reality, it hasn't even started because the test has not flushed the timeout. Removing the timeout would be a breaking change as a result. PR Close #45240
-
Paul Gschwendtner authored
Similar to 63e9cc7c, but for the patch branch where the `aio` job increased in total by ~100b. New total: 718427 bytes Before total: 718357 bytes PR Close #45239
-
Joey Perrott authored
Remove errant extra space in fw-compiler glob matcher. PR Close #45061 PR Close #45239
-
Paul Gschwendtner authored
Previously, dev-infra only bundled the CLI with all its dependencies, while we still also kept all bundled dependencies in the `dependencies`. This basically meant that the CLI bundling did not provide any value at all. We fixed this upstream and now dependencies are still bundled, but no longer also declared as `dependencies`. We also stopped shipping deep JS files, only shipping the bundles now. As part of this deep file removal, we introduced a runtime entry-point for exports/types. This one will also benefit from the bundling and it will be predictable what symbols dev-infra consumer projects rely on (allowing us to also have an API guard or something in the future). PR Close #45239
-
Renovate Bot authored
Updates Angular through Renovate. Patch port. PR Close #45239
-
Kristiyan Kostadinov authored
Several people on the team (myself included) have had issues where the `webdriver-manager` step of the `postinstall` script fails on the first run, but work correctly on the second one. These changes attempt to simplify the workflow by retrying the script up to 3 times before giving up. PR Close #45252
-
- Mar 03, 2022
-
-
Jessica Janiuk authored
-
- Mar 02, 2022
-
-
Andrew Kushnir authored
This commit updates the `NgLocalization` token to become tree-shakable (vs using a direct reference to that token in the `providers` section of the `CommonModule`). The `NgLocalization` token is used for apps that use i18n and for other apps it would be excluded from the bundle. PR Close #45118 PR Close #45226
-
Theodore Brown authored
The documented command for updating the forms gold files was outdated and didn't work. Since this command list can easily become outdated, remove the individual commands in favor of the simpler global scripts. PR Close #45198
-
Andrew Kushnir authored
perf(core): make `LOCALE_ID` and other tokens from `ApplicationModule` tree-shakable (#45102) (#45222) The `ApplicationModule` module has a number of tokens declared as non-tree-shakable providers. This commit updates them to make tree-shakable. PR Close #45102 PR Close #45222
-
Andrew Kushnir authored
perf(core): make `Compiler`, `ApplicationRef` and `ApplicationInitStatus` tree-shakable (#45102) (#45222) The `Compiler`, `ApplicationRef` and `ApplicationInitStatus` classes are registered as non-tree-shakable providers in the `ApplicationModule`. This commit converts them to the tree-shakable providers instead. PR Close #45102 PR Close #45222
-
Andrew Kushnir authored
The `SCHEDULER` provider was used previously when both ViewEngine and Ivy code was present. After some prior refactoring, all references to the `SCHEDULER` token were removed, but the token itself remains present in the `ApplicationModule`, which makes it non-tree-shakable. This commit removes the `SCHEDULER` token as unused. PR Close #45102 PR Close #45222
-
- Mar 01, 2022
-
-
dario-piotrowicz authored
improve the http aio example by: - adding a background color to the messages section so that it can be distinguished from the others - avoid using `hr` elements to divide the various sections, use css instead (so that the divisions can also be omitted when the sections are not being shown) - fix the erroneous presence of an input text element inside a button (see: https://github.com/angular/angular/pull/44557#discussion_r787239658) PR Close #44986
-
Guillaume Bonnet authored
The previous configuration didn't allow to serve in any language. Fixes #45066 PR Close #45097
-
- Feb 26, 2022
-
-
Paul Gschwendtner authored
Sometimes Renovate proposes an update and we need to add some manual fixups, like updating a size golden. For this we push to same upstream branch. Renovate will update the PR though when another new revision/version becomes available, overriding the fixup and discarding it. This happened quite often now and causes significantly more work required by the dev-infra time.. PR Close #45204
-
Paul Gschwendtner authored
Fixes the stamping for snapshot builds and the artifact deployment job. Currently the stamped versions will have the `.with-local-changes` version suffix given that we add a file to the Git repo that is just needed for the CircleCI cache key computation. PR Close #45147
-
JoostK authored
Automatic updating of Babel was disabled because there were build failures when using the latest version of Babel, but these have been resolved in #44931. This commit removes Babel packages from Renovate's ignored list to allow automatic updates again. PR Close #45203
-
JoostK authored
The `@angular/localize` package depends on a version of Babel that is two years old, so this commit updates to the latest version. Some changes were made to the linker and compliance tests to account for slight changes in source maps, along with a few code updates because of changes to the typings of Babel. PR Close #45203
-
- Feb 25, 2022
-
-
Andrew Scott authored
The implementation of `throwError` in `rxjs` is identical to what is done manually in the Router code. PR Close #45170
-
Andrew Scott authored
The `lastChild` property in the match result is only used to compute the remaining segments (i.e. the ones which were not consumed). The updated type here makes it easier to use and more clear. PR Close #45170
-
dario-piotrowicz authored
in the aio example apps page the style guide for documentation contributions is included in the Routing section instead of being in its own section, add a documentation section and include the example in that one PR Close #45148
-
Charles Lyding authored
The currently recommended best practice for Github action workflows is to set top-level permissions to read only. And if the job uses the automatic `GITHUB_TOKEN`, fine-grained permissions for each job based on the job's requirements should also be added. All existing workflows in the repository now have top-level read only permission blocks. Only the `scorecard` workflow currently requires additional job level permissions and the minimum set of permissions were already present for the job. PR Close #45177
-