This project is mirrored from https://github.com/angular/angular.git.
Pull mirroring updated .
- Aug 26, 2022
-
-
Alex Rickabaugh authored
-
Alex Rickabaugh authored
PR Close #47267
-
Alex Rickabaugh authored
-
Joey Perrott authored
update to the latest ng-dev version PR Close #47258
-
- Aug 25, 2022
-
-
Kara Erickson authored
This commit removes a duplicate deepForEach function from url.ts. It is also in the preconnect_link_checker, where it is actually used. PR Close #47189
-
Pawel Kozlowski authored
The NgOptimizedImage directive was previously trying to use an already destroyed injector in the ngOnDestroy callback. This fix pre-injects necessery tokens so no injector calls are done in the destroy process. PR Close #47243
-
Katie Hempenius authored
PR Close #47155
-
Paul Gschwendtner authored
Yarn 1.x has a bug where it keeps nested unused node modules and doesn't delete them automatically. This throws off Bazel in some scenarios when the lock file is updated. This commit invalidates the cache to get a fresh clean node modules cache without any unused nested directories. PR Close #47240
-
- Aug 24, 2022
-
-
Pawel Kozlowski authored
Valid density descriptors used in the NgOptimizedImage can contain multiple digits (ex. 1.25x, 25x). This change fixes the issue where density descriptors with multiple digits (ex. 25x) where considered invalid. Please note that a valid density descriptor might still be rejected by the directive's validation logic if the supplied value is too big. PR Close #47230
-
Kalbarczyk authored
PR Close #47227
-
Angular Robot authored
See associated pull request for more information. PR Close #47104
-
Paul Gschwendtner authored
Back when we fixed the pullapprove verify command and our config to properly include dot-prefixed files, we accidentally started matching the pullapprove file in the dev-infra group. This commit fixes this so that dev-infra is not triggered for basic code owner config changes. PR Close #47216
-
- Aug 23, 2022
-
-
Jessica Janiuk authored
The peek-a-boo example image does not exactly reflect what happens. This updates the hook table and the image of the peek-a-boo output. Closes #40138 PR Close #47219
-
Kalbarczyk authored
PR Close #47129
-
Kristiyan Kostadinov authored
This is the compile-time implementation of the `hostDirectives` feature plus a little bit of runtime code to illustrate how the newly-generated code will plug into the runtime. It works by creating a call to the new `ɵɵHostDirectivesFeature` feature whenever a directive has a `hostDirectives` field. Afterwards `ɵɵHostDirectivesFeature` will patch a new function onto the directive definition that will be invoked during directive matching. For example, if we take the following definition: ```ts @Directive({ hostDirectives: [HostA, {directive: HostB, inputs: ['input: alias']}] }) class MyDir {} ``` Will compile to: ```js MyDir.ɵdir = ɵɵdefineComponent({ features: [ɵɵHostDirectivesFeature([HostA, { directive: HostB, inputs: { input: "alias" } }])] }); ``` The template type checking is implemented during directive matching by adding the host directives applied on the host to the array of matched directives whenever the host is matched in a template. Relates to #8785. PR Close #46868
-
Alex Rickabaugh authored
This reverts commit 05f5e8ad. Reason: breaks internal g3 tests PR Close #47222
-
Alan Agius authored
This forces the usage of the latest packages. PR Close #47092
-
Alan Agius authored
This commits addresses an issue where AIO examples would always be updated to use the `next` version. PR Close #47092
-
Alan Agius authored
With this change we replace AIO examples to use stable Angular packages. The main reasons for this is that prereleases might contain bugs that are not in the stable version especially in the Angular CLI were it's not validated in G3. PR Close #47092
-
Dylan Hunn authored
This helper accepts a class for an Angular trait, and returns the NgModule which owns that trait. This will be useful for the language service import project, which needs to edit import arrays on the module. PR Close #47166
-
Angular Robot authored
See associated pull request for more information. PR Close #47187
-
vyom authored
Fixes grammar issues in various markdown files, like the `CHANGELOG.md` PR Close #47200
-
dario-piotrowicz authored
prior to this change the stagger timing was being built during the ast building instead of dynamically when visiting the stagger animation, thus it could not handle params correctly, this change makes it so that during ast building a timing ast is built instead and that ast is used dynammically to build animations which can handle params correctly resolves #19786 PR Close #47208
-
George Kalpakas authored
Fix some TypeScript build warnings related to things like redundant `?.` and `??` operators and uninitialized/non-nullable `@Input` properties. You can see an example build with the warnings [on CI][1]. [1]: https://circleci.com/gh/angular/angular/1215057#step-104-232 PR Close #47201
-
George Kalpakas authored
fix(docs-infra): prevent unnecessary warning in `mergeOverridenImplementation` Dgeni processor (#47201) The `mergeOverridenImplementation` processor tries to ensure that any doc used with the `@overrideImplementation` annotation is not itself public (and explicitly marks is as internal if it is). Previously, it determined the public/private status of a doc by only checking the value of the doc's `internal` property (which is mainly set via the `@internal` annotation). This failed to account for docs marked as "private exports" (such as those prefixed with `ɵ`), which are essentially also treated as internal. This would result in incorrect warnings. [Example warning][1]: > Constructor doc forms/ɵFormControlCtor was not marked '@internal'; > adding this annotation. This commit prevents the incorrect warning by also checking the value of the doc's `privateExport` property to determine its public/private status. [1]: https://circleci.com/gh/angular/angular/1215057#step-104-164 PR Close #47201
-
George Kalpakas authored
Previously, error messages related to an overriden constructor doc would stringify the doc as `[object Object]`, which is not helpful for debugging the issue. For example: > Constructor doc [object Object] was not marked '@internal' This commit improves the error message by including the doc's ID instead. For example, the above error message would become: > Constructor doc forms/ɵFormControlCtor was not marked '@internal' PR Close #47201
-
Kara Erickson authored
This commit fixes a bug where `rawSrcset` in the image directive would allow density descriptors like `1.5x` but not like `1.25x`. Now descriptors with 2+ digits after the decimal point should work. PR Close #47197
-
Pawel Kozlowski authored
Minor cleanups based on the review comments that were not addressed after the initial review. PR Close #47170
-
Kara Erickson authored
This is a tiny commit to add newlines in the image directive's "oversized image" error. Currently, the rendered and intrinsic image sizes are printed mid-line, which make them a little hard to read. This commit puts them each on their own line. PR Close #47188
-
Andrew Scott authored
The `UrlTree` is a fundamental concept in the router's API design. Generally speaking, a `UrlTree` would be constructed via things like `Router.createUrlTree` or `UrlSerializer#parse`. The second example here is the core reason to make the constructor public, regardless of how develpers generally create a `UrlTree` in an application. Applications can provide their own `UrlSerializer` and may want to implement their own `parse` method. This means they would also need to create a `UrlTree` but would not be able to do so effectively because the constructor is marked `@internal`. In addition, the `UrlTree` constructor only has 3 parameters, all of which are already public. There's nothing "special" about it other than the potential desire to push developers to use other methods for constructing a `UrlTree` (i.e. `Router.createUrlTree`). Also see http://b/234604699#comment9 for additional context. PR Close #47186
-
Dylan Hunn authored
Create three new helper methods: `addElementToArrayLiteral`, `objectPropertyAssignmentForKey`, and `updateObjectValueForKey`. These methods make interacting with array and object literals easier. These will be useful for the standalone imports feature, which will need to add new terms to import arrays in Component and NgModule decorators. PR Close #47181
-
Kristiyan Kostadinov authored
Replaces (almost) all of the usages of the deprecated `getMutableClone` function from TypeScript which has started to log deprecation warnings in version 4.8 and will likely be removed in version 5.0. The one place we have left is in the default import handling of ngtsc which will be more difficult to remove. PR Close #47167
-
Dylan Hunn authored
This helper accepts a class, and returns the primary Angular Decorator associated with that trait (e.g. the Component, Pipe, Directive, or NgModule decorator). This will be useful for the language service import project, which needs to edit import arrays inside the decorator. PR Close #47180
-
Angular Robot authored
See associated pull request for more information. PR Close #47162
-
Bob Watson authored
PR Close #47217
-
- Aug 22, 2022
-
-
George Kalpakas authored
Ensure contributor images are not distorted. This was accidentally broken in #46347. PR Close #47215
-
- Aug 19, 2022
-
-
Jeremy Elbourn authored
Validation for `data:` urls is obsolete now that modern browsers ([Firefox as of v57+](https://blog.mozilla.org/security/2017/10/04/treating-data-urls-unique-origins-firefox-57)) don't treat `data:` urls as same-origin resources. Googlers can see internal change cl/363609175 for additional context. PR Close #45860
-
Jan Kuehle authored
Fix compilation issue with TypeScript nightly. TypeScript added a field `0` to `RegExpMatchArray` in https://github.com/microsoft/TypeScript/commit/3b80ddca212959ae5dcf2f48704be627283c6468. Before that, `RegExpMatchArray` and `RegExpExecArray` were identical. In one place Angular incorrectly expects `RegExpMatchArray` as the result of a RegExp#exec() call. This assignment fails on TypeScript nightly with the error: Property '0' is missing in type 'RegExpExecArray' but required in type 'RegExpMatchArray'. Fix the issue by using the type `RegExpExecArray` instead. This also works for older TypeScript versions. PR Close #47169
-
Pawel Kozlowski authored
Fixing changelog merge issues. PR Close #47177
-
FatalMerlin authored
Missing updated on golden `index.md` Updated with api-extractor PR Close #47044
-