Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/angular/angular.git. Pull mirroring updated .
  1. Nov 10, 2022
  2. Nov 09, 2022
  3. Nov 08, 2022
  4. Nov 05, 2022
  5. Nov 04, 2022
  6. Nov 02, 2022
    • Andrew Kushnir's avatar
      fix(core): hardening rules related to the attribute order on iframe elements (#47935) · d4b3c0b4
      Andrew Kushnir authored
      This commit updates the logic related to the attribute order on iframes and makes the rules more strict. There is a set of iframe attributes that may affect the behavior of an iframe, this change enforces that these attributes are applied before an `src` or `srcdoc` attributes are applied to an iframe, so that they are taken into account.
      
      If Angular detects that some of the attributes are set after the `src` or `srcdoc`, it throws an error message, which contains the name of ann attribute that is causing the problem and the name of a Component where an iframe is located. In most cases, it should be enough to change the order of attributes in a template to move the `src` or `srcdoc` ones to the very end.
      
      BREAKING CHANGE:
      
      Existing iframe usages may have `src` or `srcdoc` preceding other attributes. Such usages may need to be updated to ensure compliance with the new stricter rules around iframe bindings.
      
      PR Close #47935
      d4b3c0b4
  7. Nov 01, 2022
    • mgechev's avatar
      docs: update roadmap as of q4 2022 (#47910) · e6357477
      mgechev authored
      PR Close #47910
      e6357477
    • Kristiyan Kostadinov's avatar
      perf(platform-browser): resolve memory leak when using animations with shadow DOM (#47903) · d5cd79f8
      Kristiyan Kostadinov authored
      `AnimationRendererFactory` maintains a map between a renderer delegate and the animations renderer it corresponds to, but the renderers are never removed from the map. This leads to memory leaks when used with the `ShadowDom` view encapsulation, because the specific renderer keeps a references to its shadow root which in turn references all the elements in the view.
      
      These changes resolve the leak by clearing the reference when the animations renderer is destroyed.
      
      Fixes #47892.
      
      PR Close #47903
      d5cd79f8
    • Alex Rickabaugh's avatar
      docs(core): update standalone docs for `provideRouter` (#47902) · e683298b
      Alex Rickabaugh authored
      This commit updates the standalone components guide on AIO to showcase the
      new `provideRouter` API. Previously the guide demonstrated configuring the
      router via `importProvidersFrom(RouterModule.forRoot(...))`. A new section
      was added to ensure `importProvidersFrom` was still shown in an example.
      
      PR Close #47902
      e683298b
    • Paul Gschwendtner's avatar
      refactor(bazel): enable typescript strictness flags for package (#47893) · 99597c8c
      Paul Gschwendtner authored
      No longer maintains a separate tsconfig for the Bazel package. This
      seems to be a legacy artifact back when ngc-wrapped was put into GitHub.
      
      We now use the canonical repository Bazel tsconfig. This commit also
      fixes all strictness-related errors and makes ngc-wrapped compatible.
      
      PR Close #47893
      99597c8c
    • Paul Gschwendtner's avatar
      refactor(compiler-cli): update `emit` signature to support for strongly typed... · f99cc40c
      Paul Gschwendtner authored
      refactor(compiler-cli): update `emit` signature to support for strongly typed `emitCallback` (#47893)
      
      Currently `ngc-wrapped` mostly relies on any casts/or disabled
      strictness checks to be able to use `tsickle`'s emit callback and
      emit result merging for ngtsc. We should change this so that supertypes
      of `ts.EmitResult` can be used in these optional callbacks- allowing us
      to enable strictness checks in `packages/bazel/...` too.
      
      PR Close #47893
      f99cc40c
  8. Oct 28, 2022