This project is mirrored from https://github.com/angular/angular.git.
Pull mirroring updated .
- Mar 09, 2023
-
-
Jessica Janiuk authored
-
Paul Gschwendtner authored
The decorator downlevel transform is never used for actual class decorators because Angular class decorators rely on immediate execution for JIT. Initially we also supported downleveling of class decorators for View Engine library output, but libraries are shipped using partial compilation output and are not using this transform anymore. The transform is exclusively used for JIT processing, commonly for test files to help ease temporal dead-zone/forward-ref issues. We can remove the class decorator downlevel logic to remove technical debt. PR Close #49351
-
- Mar 08, 2023
-
-
Matthieu Riegler authored
* 2 categories : Runtime errors and Compiler Errors. * Numeric sort on error code. PR Close #49343
-
Sai Kartheek Bommisetty authored
PR Close #49307
-
Vinit Neogi authored
documentation glossary for view hierarchy is missing a "is" to be grammatically correct Fixes #49352 PR Close #49356
-
Matthieu Riegler authored
Error code for bad AsyncValidatorFn is 1101 not 1003. PR Close #49344
-
- Mar 07, 2023
-
-
Matthieu Riegler authored
This commit removes the remaining ones in animations code base PR Close #49231
-
Matthieu Riegler authored
Unused code in core and other packages. They were private exports. PR Close #49299
-
Matthieu Riegler authored
Both `camelCaseToDashCase` and `dashCaseToCamelCase` haven't been used since 2.2.0. PR Close #49302
-
Andrew Kushnir authored
Previously (at the early days of Ivy) a TNode used to keep an array of TViews, but the logic was changed since that time, but the `tViews` field remained on TNode interface (+ corresponding typings). This commit renames TNode.tViews to TNode.tView and cleans up typings. PR Close #49313
-
Matthieu Riegler authored
This commit removes the remaining TODO(issue/24571) in platform-browser code base. PR Close #49232
-
- Mar 04, 2023
-
-
Andrew Scott authored
The `ChangeTracker` is generally useful and could be used by a lot of migrations instead of having to rewrite similar boilerplate. PR Close #49308
-
Paul Gschwendtner authored
We recently migrated the testing example to use the router testing harness. There was one instance of the previous non-`TestBed` examples left that still relies on a stub that has already been removed. This example is not used anywhere and we should rather encourage a single pattern of testing. i.e. the harness as per recent changes. This commit removes the broken file. PR Close #49293
-
Paul Gschwendtner authored
Currently, examples with test commands like `ng build` are *never* using the local version of `//packages/compiler-cli`. This is because the CLI is invoked accidentally from within `external/aio_example_deps`. Since the CLI relies on importing the compiler-cli, it will always resolve the dependency from that directory- causing it to be always the version installed via `aio/examples/tools/shared/package.json`. We should never resolve symlinks and escape the e2e sandbox. That way the compiler-cli would be resolved properly and could also become the locally built one, depending on the test mode (i.e. npm or "local"). PR Close #49293
-
Paul Gschwendtner authored
Chromium is launched via Karma from within the Bazel AIO example e2e tests. This breaks depending on the platform and sandbox mechanism used. We should never use Chromium's sandbox on top of Bazel's sandbox invocation. The Angular CLI exposes a browser exactly for this use-case. PR Close #49293
-
Paul Gschwendtner authored
Whenever we run example tests using the local framework packages, the e2e tests will have the local framework packages symlinked in the `node_modules`. This works well in general, but due to NodeJS by default resolving symlinks to the target location, NodeJS will end up looking for transitive dependencies in the `bazel-bin` instead of in the example `node_modules` folder. This means that we end up incorrectly resolving older versions of `@angular/core` that end up existing in the main project dependencies. This causes errors like: ``` Error: ../../home/circleci/.cache/bazel/_bazel_circleci/9ce5c2144ecf75d11717c0aa41e45a8d/execroot/angular/bazel-out/k8-fastbuild/bin/packages/common/npm_package/http/testing/index.d.ts:12:21 - error TS2307: Cannot find module '@angular/common/http' or its corresponding type declarations. 12 import * as i1 from '@angular/common/http'; ~~~~~~~~~~~~~~~~~~~~~~ Error: ../../home/circleci/.cache/bazel/_bazel_circleci/9ce5c2144ecf75d11717c0aa41e45a8d/execroot/angular/bazel-out/k8-fastbuild/bin/packages/common/npm_package/index.d.ts:1630:18 - error TS2707: Generic type 'ɵɵDirectiveDeclaration' requires between 6 and 8 type arguments. 1630 static ɵdir: i0.ɵɵDirectiveDeclaration<NgClass, "[ngClass]", never, { "klass": "class"; "ngClass": "ngClass"; }, {}, never, never, true, never>; ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ``` We can fix this by properly ensuring that NodeJS does not resolve symlinks, but rather preserves them. In the error above, the e2e tests end up accidentally resolving `@angular/core` v14 that comes from `@angular/benchpress`. Angular Benchpress is installed via `@angular/build-tooling` in the project root. PR Close #49293
-
Paul Gschwendtner authored
This causes the e2e tests to fail. The tests were compiled using a tsconfig with `lib=dom`, but the tests explicitly tried to pull in the Node types. This causes a conflict for e.g. `AbortController` types. PR Close #49293
-
Paul Gschwendtner authored
The `run-example-e2e` script does not properly fail if configured tests of examples are failing. This happens when a CLI example configures multiple tests in the `example-config`. Due to incorrect usage of promises in combination with reduce, only the last test command had an effect on the overall test conclusion. A similar issue seems to occur with SystemJS Protractor tests. This commit fixes the problem and also cleans up the code a little by switching it to `async/await`. PR Close #49293
-
Paul Gschwendtner authored
Formats the `run-example-e2e.mjs` file with prettier to ease future diffs. PR Close #49293
-
Matthieu Riegler authored
The unit tests have been updated in #44120, this export is unused now. PR Close #49296
-
Matthieu Riegler authored
PR Close #49306
-
Matthieu Riegler authored
`BrowserPlatformLocation` was add to the public API by #48488. PR Close #49301
-
- Mar 03, 2023
-
-
Angular Robot authored
See associated pull request for more information. PR Close #49267
-
Kristiyan Kostadinov authored
Passes the path of the current file to the import remapper. Useful if we want to generate absolute paths. PR Close #49288
-
Andrew Scott authored
This commit updates the documentation on testing the `Router` to use the `RouterTestingHarness` rather than stubs. The stubs described in the previous form of this document actually creates tests which are incapable of catching bugs related to the component's interaction with the `Router`. In addition, managing the stubs is more difficult than using the real `Router` classes. Stubbing something like the `RouterLink` is quite harmful because it neither tests the actual URL being created, nor the end result of the navigation. There have been serveral bug fixes in the Router over the years the would change the outcome of these but would not be caught by tests which create a stub. PR Close #48553
-
Paul Gschwendtner authored
In the past, `ts-node` had a bug that prevented forking processes when used in combination with `--esm`. We contributed a fix upstream to `ts-node` to fix this, and this commit updates to the latest version so that we can simplify our `ng-dev` invocation. https://github.com/TypeStrong/ts-node/commit/32d07e2b2fcbaab97c11e71ee5fc3a79fc20c802 Fixes #46858 PR Close #49289
-
Matthieu Riegler authored
PR #48433 removed the last external usage of `isListLikeIterable`. We can now remove it from the private exports. PR Close #49297
-
Matthieu Riegler authored
PR Close #49287
-
- Mar 02, 2023
-
-
Matthieu Riegler authored
`directiveMetadata()` already assigns the `standalone` property to the `R3ComponentMetadataFacade` there is no need to do it twice. PR Close #49065
-
Alan Agius authored
This is no longer needed as Angular is ever green. PR Close #49259
-
Andrew Kushnir authored
This commit moves the `APP_BOOTSTRAP_LISTENER` token into the `application_ref.ts` to avoid a risk of circular dependencies. The main problem is that the token refers to the `ComponentRef`, which in turn refers to more symbols, thus making the `application_tokens.ts` file susceptible to circular dependencies. Such a dependency was identified in https://github.com/angular/angular/pull/49271. PR Close #49273
-
Kristiyan Kostadinov authored
The new `bootstrapApplication` API doesn't include Protractor support anymore which may cause existing e2e tests to break after the migration. These changes add some logic that will provide Protractor support if any imports to `protractor` or `protractor/*` are detected. PR Close #49274
-
Andrew Kushnir authored
-
- Mar 01, 2023
-
-
Stephanie Tuerk authored
The example in the code snippet below this line of text shows `ActivatedRouter` being injected into a component's constructor. When I read instruction to inject A`ActivatedRouter` into **application's** constructor, I assumed this meant the constructor for `app.component.ts`. Editing to clarify/match code example below. PR Close #49270
-
Joey Perrott authored
See associated pull request for more information. PR Close #49268
-
Alan Agius authored
This ensures that the latest version of zone.js is supported. PR Close #49244
-
Matthieu Riegler authored
We are targeting evergreen browsers, we can drop the shim. PR Close #49207
-
Kristiyan Kostadinov authored
If a class is declared in multiple modules, the standalone migration may end up generating invalid code. While declaring a class in multiple modules is an error, it can happen with modules in tests. These changes avoid the issue by using a `Set` to track the classes being migrated. PR Close #49245
-
Virginia Dooley authored
PR Close #48915
-
Virginia Dooley authored
PR Close #48912
-