This project is mirrored from https://github.com/angular/angular.git.
Pull mirroring updated .
- Mar 17, 2023
-
-
Alex Rickabaugh authored
-
- Mar 16, 2023
-
-
Angular Robot authored
See associated pull request for more information. PR Close #49377
-
Alan Agius authored
The below error is displayed during some tests ```js ERROR: 'Unhandled Promise rejection:', 'Cannot read properties of null (reading 'markForCheck')', '; Zone:', 'ProxyZone', '; Task:', 'Promise.then', '; Value:', TypeError: Cannot read properties of null (reading 'markForCheck') TypeError: Cannot read properties of null (reading 'markForCheck') at AsyncPipe2._updateLatestValue (http://angular-ci.local:9876/base/dist/legacy-test-bundle.spec.js?49174f830d8743d5c8a9551b77550b859b934291:51947:19) ``` This is caused by the fact that `ref` in `AsyncPipe` is initialized with a value of `null` which causes `_updateLatestValue` to fail since it is not expected to be `null`. This change ensures that a `ref` is always provided and that all subscriptions are disposed off after each test. PR Close #49433
-
Virginia Dooley authored
PR Close #49429
-
Angular Robot authored
See associated pull request for more information. PR Close #49428
-
Angular Robot authored
See associated pull request for more information. PR Close #49420
-
Alan Agius authored
Currently, tests are tested twice using "production" like configuration. This commit disabled "optimization" for non production builds. PR Close #49391
-
- Mar 15, 2023
-
-
Esteban Gehring authored
PR Close #49416
-
Esteban Gehring authored
PR Close #49416
-
Angular Robot authored
See associated pull request for more information. PR Close #49397
-
- Mar 13, 2023
-
-
Angular Robot authored
See associated pull request for more information. PR Close #49410
-
- Mar 10, 2023
-
-
Virginia Dooley authored
PR Close #49294
-
Virginia Dooley authored
PR Close #48914
-
Virginia Dooley authored
PR Close #48909
-
Virginia Dooley authored
PR Close #48909
-
Virginia Dooley authored
PR Close #48909
-
- Mar 09, 2023
-
-
Matthieu Riegler authored
These todos do not apply anymore, let's remove them. PR Close #49362
-
Matthieu Riegler authored
`RenderComponentType` was removed by #33019 PR Close #49363
-
Angular Robot authored
Generated `events.json` with the latest events retrieved from the Firebase DB. Closes #49355 PR Close #49366
-
Angular Robot authored
See associated pull request for more information. PR Close #49348
-
Alan Agius authored
Before this change `ɵɵdefineDirective` called `ɵɵdefineComponent` under the hood. This is problematic for the consistent component id generation as it could result in hash collisions for certain directives. Directives however do not require an id. This changes moves common definition generation logic into a separate function that is re-used in `ɵɵdefineDirective` and `ɵɵdefineComponent`. PR Close #49350
-
Jessica Janiuk authored
-
Paul Gschwendtner authored
The decorator downlevel transform is never used for actual class decorators because Angular class decorators rely on immediate execution for JIT. Initially we also supported downleveling of class decorators for View Engine library output, but libraries are shipped using partial compilation output and are not using this transform anymore. The transform is exclusively used for JIT processing, commonly for test files to help ease temporal dead-zone/forward-ref issues. We can remove the class decorator downlevel logic to remove technical debt. PR Close #49351
-
- Mar 08, 2023
-
-
Matthieu Riegler authored
* 2 categories : Runtime errors and Compiler Errors. * Numeric sort on error code. PR Close #49343
-
Sai Kartheek Bommisetty authored
PR Close #49307
-
Vinit Neogi authored
documentation glossary for view hierarchy is missing a "is" to be grammatically correct Fixes #49352 PR Close #49356
-
Matthieu Riegler authored
Error code for bad AsyncValidatorFn is 1101 not 1003. PR Close #49344
-
- Mar 07, 2023
-
-
Matthieu Riegler authored
This commit removes the remaining ones in animations code base PR Close #49231
-
Matthieu Riegler authored
Unused code in core and other packages. They were private exports. PR Close #49299
-
Matthieu Riegler authored
Both `camelCaseToDashCase` and `dashCaseToCamelCase` haven't been used since 2.2.0. PR Close #49302
-
Andrew Kushnir authored
Previously (at the early days of Ivy) a TNode used to keep an array of TViews, but the logic was changed since that time, but the `tViews` field remained on TNode interface (+ corresponding typings). This commit renames TNode.tViews to TNode.tView and cleans up typings. PR Close #49313
-
Matthieu Riegler authored
This commit removes the remaining TODO(issue/24571) in platform-browser code base. PR Close #49232
-
- Mar 04, 2023
-
-
Andrew Scott authored
The `ChangeTracker` is generally useful and could be used by a lot of migrations instead of having to rewrite similar boilerplate. PR Close #49308
-
Paul Gschwendtner authored
We recently migrated the testing example to use the router testing harness. There was one instance of the previous non-`TestBed` examples left that still relies on a stub that has already been removed. This example is not used anywhere and we should rather encourage a single pattern of testing. i.e. the harness as per recent changes. This commit removes the broken file. PR Close #49293
-
Paul Gschwendtner authored
Currently, examples with test commands like `ng build` are *never* using the local version of `//packages/compiler-cli`. This is because the CLI is invoked accidentally from within `external/aio_example_deps`. Since the CLI relies on importing the compiler-cli, it will always resolve the dependency from that directory- causing it to be always the version installed via `aio/examples/tools/shared/package.json`. We should never resolve symlinks and escape the e2e sandbox. That way the compiler-cli would be resolved properly and could also become the locally built one, depending on the test mode (i.e. npm or "local"). PR Close #49293
-
Paul Gschwendtner authored
Chromium is launched via Karma from within the Bazel AIO example e2e tests. This breaks depending on the platform and sandbox mechanism used. We should never use Chromium's sandbox on top of Bazel's sandbox invocation. The Angular CLI exposes a browser exactly for this use-case. PR Close #49293
-
Paul Gschwendtner authored
Whenever we run example tests using the local framework packages, the e2e tests will have the local framework packages symlinked in the `node_modules`. This works well in general, but due to NodeJS by default resolving symlinks to the target location, NodeJS will end up looking for transitive dependencies in the `bazel-bin` instead of in the example `node_modules` folder. This means that we end up incorrectly resolving older versions of `@angular/core` that end up existing in the main project dependencies. This causes errors like: ``` Error: ../../home/circleci/.cache/bazel/_bazel_circleci/9ce5c2144ecf75d11717c0aa41e45a8d/execroot/angular/bazel-out/k8-fastbuild/bin/packages/common/npm_package/http/testing/index.d.ts:12:21 - error TS2307: Cannot find module '@angular/common/http' or its corresponding type declarations. 12 import * as i1 from '@angular/common/http'; ~~~~~~~~~~~~~~~~~~~~~~ Error: ../../home/circleci/.cache/bazel/_bazel_circleci/9ce5c2144ecf75d11717c0aa41e45a8d/execroot/angular/bazel-out/k8-fastbuild/bin/packages/common/npm_package/index.d.ts:1630:18 - error TS2707: Generic type 'ɵɵDirectiveDeclaration' requires between 6 and 8 type arguments. 1630 static ɵdir: i0.ɵɵDirectiveDeclaration<NgClass, "[ngClass]", never, { "klass": "class"; "ngClass": "ngClass"; }, {}, never, never, true, never>; ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ``` We can fix this by properly ensuring that NodeJS does not resolve symlinks, but rather preserves them. In the error above, the e2e tests end up accidentally resolving `@angular/core` v14 that comes from `@angular/benchpress`. Angular Benchpress is installed via `@angular/build-tooling` in the project root. PR Close #49293
-
Paul Gschwendtner authored
This causes the e2e tests to fail. The tests were compiled using a tsconfig with `lib=dom`, but the tests explicitly tried to pull in the Node types. This causes a conflict for e.g. `AbortController` types. PR Close #49293
-
Paul Gschwendtner authored
The `run-example-e2e` script does not properly fail if configured tests of examples are failing. This happens when a CLI example configures multiple tests in the `example-config`. Due to incorrect usage of promises in combination with reduce, only the last test command had an effect on the overall test conclusion. A similar issue seems to occur with SystemJS Protractor tests. This commit fixes the problem and also cleans up the code a little by switching it to `async/await`. PR Close #49293
-
Paul Gschwendtner authored
Formats the `run-example-e2e.mjs` file with prettier to ease future diffs. PR Close #49293
-