Automated rollback of commit 4a2e51b3.
*** Reason for rollback *** Breaks targets on the nightly TGP. Reproduction: blaze build //third_party/bazel_rules/rules_kotlin/tests/android/java/com/google/jni:AndroidJniTest --compilation_mode=opt --flaky_test_attempts=2 --fat_apk_cpu=x86 --android_platforms=//buildenv/platforms/android:x86 --incompatible_enable_android_toolchain_resolution=1 --collect_code_coverage=1 --instrumentation_filter=//java/com/google/android/samples/apps/topeka[/:],//third_party/bazel_rules/rules_kotlin[/:],//tools/build_defs/kotlin[/:] TGP link: [] *** Original change description *** Make `getPrimaryOutput()` always return the first artifact in `getOutputs()`. This is already the case everywhere except `CppCompileAction` but was not documented, leading to `SpawnAction` unnecessarily storing a field for the primary output when it's already just the first element in its outputs. This change saves 8 bytes per `SpawnAction` and `GenRuleAction`, and moves other `SpawnAction` subclasses closer to an 8-byte threshold. `CppCompileAction` had been using the coverage artifact (if pr *** RELNOTES: None. PiperOrigin-RevId: 523634597 Change-Id: I0aa70851fe4d403afabc56e808546d6638a9f2b7
Showing
- src/main/java/com/google/devtools/build/lib/actions/AbstractAction.java 4 additions, 2 deletions...com/google/devtools/build/lib/actions/AbstractAction.java
- src/main/java/com/google/devtools/build/lib/actions/ActionAnalysisMetadata.java 1 addition, 2 deletions...le/devtools/build/lib/actions/ActionAnalysisMetadata.java
- src/main/java/com/google/devtools/build/lib/actions/ActionExecutionMetadata.java 3 additions, 3 deletions...e/devtools/build/lib/actions/ActionExecutionMetadata.java
- src/main/java/com/google/devtools/build/lib/analysis/actions/SpawnAction.java 31 additions, 8 deletions...ogle/devtools/build/lib/analysis/actions/SpawnAction.java
- src/main/java/com/google/devtools/build/lib/analysis/actions/StarlarkAction.java 9 additions, 7 deletions...e/devtools/build/lib/analysis/actions/StarlarkAction.java
- src/main/java/com/google/devtools/build/lib/analysis/extra/ExtraAction.java 7 additions, 1 deletion...google/devtools/build/lib/analysis/extra/ExtraAction.java
- src/main/java/com/google/devtools/build/lib/analysis/test/TestRunnerAction.java 6 additions, 1 deletion...le/devtools/build/lib/analysis/test/TestRunnerAction.java
- src/main/java/com/google/devtools/build/lib/rules/cpp/CcCompilationHelper.java 7 additions, 7 deletions...gle/devtools/build/lib/rules/cpp/CcCompilationHelper.java
- src/main/java/com/google/devtools/build/lib/rules/cpp/CppCompileAction.java 69 additions, 43 deletions...google/devtools/build/lib/rules/cpp/CppCompileAction.java
- src/main/java/com/google/devtools/build/lib/rules/cpp/CppCompileActionTemplate.java 2 additions, 1 deletion...evtools/build/lib/rules/cpp/CppCompileActionTemplate.java
- src/main/java/com/google/devtools/build/lib/rules/cpp/LtoBackendAction.java 7 additions, 3 deletions...google/devtools/build/lib/rules/cpp/LtoBackendAction.java
- src/main/java/com/google/devtools/build/lib/rules/genrule/GenRuleAction.java 2 additions, 0 deletions...oogle/devtools/build/lib/rules/genrule/GenRuleAction.java
- src/main/java/com/google/devtools/build/lib/rules/java/JavaHeaderCompileActionBuilder.java 1 addition, 0 deletions.../build/lib/rules/java/JavaHeaderCompileActionBuilder.java
Please register or sign in to comment