[7.1.0] Avoid using `InputStream.available()` to detect EOF while reading...
[7.1.0] Avoid using `InputStream.available()` to detect EOF while reading delimited protos. (#21143) It's not a reliable method to check for EOF: it returns how many bytes are guaranteed to be read without blocking, and the base implementation always returns 0. Instead, leverage the fact that parseDelimitedFrom() returns null if the stream is at EOF. PiperOrigin-RevId: 602257598 Change-Id: I61e51774611196fb44745dc0aa2dc836b41fcd68
parent
f3e0d5b9
Showing
- src/main/java/com/google/devtools/build/lib/exec/ExpandedSpawnLogContext.java 2 additions, 2 deletions...ogle/devtools/build/lib/exec/ExpandedSpawnLogContext.java
- src/main/java/com/google/devtools/build/lib/exec/StableSort.java 2 additions, 2 deletions...n/java/com/google/devtools/build/lib/exec/StableSort.java
- src/test/java/com/google/devtools/build/lib/buildeventservice/BazelBuildEventServiceModuleTest.java 6 additions, 4 deletions...b/buildeventservice/BazelBuildEventServiceModuleTest.java
- src/test/java/com/google/devtools/build/lib/buildtool/TargetCompleteEventTest.java 3 additions, 2 deletions...devtools/build/lib/buildtool/TargetCompleteEventTest.java
- src/test/java/com/google/devtools/build/lib/exec/CompactSpawnLogContextTest.java 2 additions, 2 deletions...e/devtools/build/lib/exec/CompactSpawnLogContextTest.java
- src/test/java/com/google/devtools/build/lib/exec/ExpandedSpawnLogContextTest.java 2 additions, 2 deletions.../devtools/build/lib/exec/ExpandedSpawnLogContextTest.java
- src/tools/execlog/src/main/java/com/google/devtools/build/execlog/ExecLogParser.java 5 additions, 7 deletions...java/com/google/devtools/build/execlog/ExecLogParser.java
Please register or sign in to comment