Make `Label#toString` return `@@`-prefixed labels
This change causes all labels in error messages, log output, Build Event Protocol, etc. to be prefixed with double-at (`@@`) if they are from non-main repos. This prevents cases where messages contain stuff like `the target @abc~1.0//:def is wrong` but the user can't do `bazel query @abc~1.0//:def` at all, since the actual target is `@@abc~1.0//:def`. This required more test changes than expected as there have been many places in the codebase where we compare labels using some sort of string form (for example, toolchain types as automatic exec groups). Fixes https://github.com/bazelbuild/bazel/issues/18543. PiperOrigin-RevId: 565141761 Change-Id: I1261ab14067bcf5d44cd140e5528b5da5916dc87
Showing
- src/main/java/com/google/devtools/build/lib/analysis/RuleConfiguredTargetBuilder.java 1 addition, 1 deletion...tools/build/lib/analysis/RuleConfiguredTargetBuilder.java
- src/main/java/com/google/devtools/build/lib/analysis/config/StarlarkDefinedConfigTransition.java 4 additions, 3 deletions.../lib/analysis/config/StarlarkDefinedConfigTransition.java
- src/main/java/com/google/devtools/build/lib/analysis/starlark/FunctionTransitionUtil.java 3 additions, 5 deletions...s/build/lib/analysis/starlark/FunctionTransitionUtil.java
- src/main/java/com/google/devtools/build/lib/analysis/starlark/StarlarkRuleClassFunctions.java 2 additions, 2 deletions...ild/lib/analysis/starlark/StarlarkRuleClassFunctions.java
- src/main/java/com/google/devtools/build/lib/bazel/rules/cpp/BazelCppSemantics.java 2 additions, 1 deletion...devtools/build/lib/bazel/rules/cpp/BazelCppSemantics.java
- src/main/java/com/google/devtools/build/lib/bazel/rules/java/BazelJavaSemantics.java 3 additions, 3 deletions...vtools/build/lib/bazel/rules/java/BazelJavaSemantics.java
- src/main/java/com/google/devtools/build/lib/cmdline/Label.java 0 additions, 23 deletions...ain/java/com/google/devtools/build/lib/cmdline/Label.java
- src/main/java/com/google/devtools/build/lib/cmdline/PackageIdentifier.java 2 additions, 2 deletions.../google/devtools/build/lib/cmdline/PackageIdentifier.java
- src/main/java/com/google/devtools/build/lib/cmdline/RepositoryName.java 17 additions, 14 deletions...com/google/devtools/build/lib/cmdline/RepositoryName.java
- src/main/java/com/google/devtools/build/lib/packages/BuiltinRestriction.java 2 additions, 2 deletions...oogle/devtools/build/lib/packages/BuiltinRestriction.java
- src/main/java/com/google/devtools/build/lib/packages/StarlarkNativeModule.java 2 additions, 1 deletion...gle/devtools/build/lib/packages/StarlarkNativeModule.java
- src/main/java/com/google/devtools/build/lib/repository/RepositoryFetchProgress.java 1 addition, 1 deletion...evtools/build/lib/repository/RepositoryFetchProgress.java
- src/main/java/com/google/devtools/build/lib/rules/cpp/CcCommon.java 1 addition, 1 deletion...ava/com/google/devtools/build/lib/rules/cpp/CcCommon.java
- src/main/java/com/google/devtools/build/lib/rules/java/JavaPluginsFlagAliasRule.java 5 additions, 3 deletions...vtools/build/lib/rules/java/JavaPluginsFlagAliasRule.java
- src/main/java/com/google/devtools/build/lib/rules/repository/RepositoryDelegatorFunction.java 1 addition, 1 deletion...ild/lib/rules/repository/RepositoryDelegatorFunction.java
- src/main/java/com/google/devtools/build/lib/skyframe/BzlLoadCycleReporter.java 3 additions, 3 deletions...gle/devtools/build/lib/skyframe/BzlLoadCycleReporter.java
- src/main/java/com/google/devtools/build/lib/skyframe/BzlmodRepoCycleReporter.java 1 addition, 1 deletion.../devtools/build/lib/skyframe/BzlmodRepoCycleReporter.java
- src/main/java/com/google/devtools/build/lib/skyframe/LocalRepositoryLookupValue.java 1 addition, 1 deletion...vtools/build/lib/skyframe/LocalRepositoryLookupValue.java
- src/main/java/com/google/devtools/build/lib/skyframe/PackageLookupFunction.java 3 additions, 3 deletions...le/devtools/build/lib/skyframe/PackageLookupFunction.java
- src/main/java/com/google/devtools/build/lib/skyframe/PackageLookupValue.java 3 additions, 2 deletions...oogle/devtools/build/lib/skyframe/PackageLookupValue.java
Please register or sign in to comment