[8.2.0] Set macro symbol's exported location as MacroFunction's callable...
[8.2.0] Set macro symbol's exported location as MacroFunction's callable location for Starlark stack (#25802) This ensures Starlark instantiation stack for rule targets defined in a symbolic macro shows both the macro's location and symbol. Requires changing StarlarkThread to track the location of where symbols are exported. As follow-up, we should do the same for rules, providers, and aspects. PiperOrigin-RevId: 745731053 Change-Id: I6732a9762fbc932d823a70d7753a2b6edc140df6 Commit https://github.com/bazelbuild/bazel/commit/a3e26ed827badf6c4cf4f09aa37747622357635c
Showing
- src/main/java/com/google/devtools/build/lib/analysis/starlark/StarlarkRuleClassFunctions.java 17 additions, 2 deletions...ild/lib/analysis/starlark/StarlarkRuleClassFunctions.java
- src/main/java/com/google/devtools/build/lib/analysis/starlark/StarlarkSubrule.java 4 additions, 1 deletion...devtools/build/lib/analysis/starlark/StarlarkSubrule.java
- src/main/java/com/google/devtools/build/lib/bazel/bzlmod/ModuleFileFunction.java 2 additions, 2 deletions...e/devtools/build/lib/bazel/bzlmod/ModuleFileFunction.java
- src/main/java/com/google/devtools/build/lib/bazel/bzlmod/ModuleFileGlobals.java 3 additions, 1 deletion...le/devtools/build/lib/bazel/bzlmod/ModuleFileGlobals.java
- src/main/java/com/google/devtools/build/lib/bazel/repository/starlark/StarlarkRepositoryModule.java 8 additions, 2 deletions...b/bazel/repository/starlark/StarlarkRepositoryModule.java
- src/main/java/com/google/devtools/build/lib/packages/StarlarkDefinedAspect.java 4 additions, 1 deletion...le/devtools/build/lib/packages/StarlarkDefinedAspect.java
- src/main/java/com/google/devtools/build/lib/packages/StarlarkExportable.java 4 additions, 2 deletions...oogle/devtools/build/lib/packages/StarlarkExportable.java
- src/main/java/com/google/devtools/build/lib/packages/StarlarkProvider.java 3 additions, 1 deletion.../google/devtools/build/lib/packages/StarlarkProvider.java
- src/main/java/com/google/devtools/build/lib/packages/TargetDefinitionContext.java 4 additions, 0 deletions.../devtools/build/lib/packages/TargetDefinitionContext.java
- src/main/java/com/google/devtools/build/lib/rules/BUILD 1 addition, 0 deletionssrc/main/java/com/google/devtools/build/lib/rules/BUILD
- src/main/java/com/google/devtools/build/lib/rules/test/StarlarkTestingModule.java 6 additions, 1 deletion.../devtools/build/lib/rules/test/StarlarkTestingModule.java
- src/main/java/com/google/devtools/build/lib/skyframe/BzlLoadFunction.java 2 additions, 2 deletions...m/google/devtools/build/lib/skyframe/BzlLoadFunction.java
- src/main/java/net/starlark/java/eval/Eval.java 1 addition, 1 deletionsrc/main/java/net/starlark/java/eval/Eval.java
- src/main/java/net/starlark/java/eval/StarlarkThread.java 1 addition, 1 deletionsrc/main/java/net/starlark/java/eval/StarlarkThread.java
- src/test/java/com/google/devtools/build/lib/analysis/SymbolicMacroTest.java 6 additions, 3 deletions...google/devtools/build/lib/analysis/SymbolicMacroTest.java
- src/test/java/com/google/devtools/build/lib/packages/RequiredProvidersTest.java 5 additions, 1 deletion...le/devtools/build/lib/packages/RequiredProvidersTest.java
- src/test/java/net/starlark/java/eval/EvaluationTestCase.java 1 addition, 1 deletionsrc/test/java/net/starlark/java/eval/EvaluationTestCase.java
Please register or sign in to comment