[7.1.0] Use execution info instead of hard-coded mnemonics for Java path mapping (#21461)
By removing Java rules from the hard-coded mnemonics allowlist for path mapping, users can rely on `--modify_execution_info` to selectively disable path mapping for them just like for Starlark actions. This requires fixing two minor inconsistencies in how execution info is populated for Java actions: * In `JavaCompilationHelper`, `buildKeepingLast` is used instead of `buildOrThrow` to prevent a crash when a target sets `supports-path-mapping` via `tags`. * In `JavaHeaderCompileAction`, `--experimental_inmemory_jdeps_files` no longer causes all other execution info to be lost. Fixes #21092 Closes #21093. Commit https://github.com/bazelbuild/bazel/commit/f8337c754c8c1b27b34b84cde2c608c802266e96 PiperOrigin-RevId: 609064092 Change-Id: I6803e34a6861f19d185542e707b00029ee018a0a Co-authored-by:Fabian Meumertzheim <fabian@meumertzhe.im>
Showing
- src/main/java/com/google/devtools/build/lib/analysis/actions/PathMappers.java 2 additions, 5 deletions...ogle/devtools/build/lib/analysis/actions/PathMappers.java
- src/main/java/com/google/devtools/build/lib/rules/java/JavaCompilationHelper.java 9 additions, 7 deletions.../devtools/build/lib/rules/java/JavaCompilationHelper.java
- src/main/java/com/google/devtools/build/lib/rules/java/JavaCompileAction.java 0 additions, 2 deletions...ogle/devtools/build/lib/rules/java/JavaCompileAction.java
- src/main/java/com/google/devtools/build/lib/rules/java/JavaHeaderCompileAction.java 21 additions, 9 deletions...evtools/build/lib/rules/java/JavaHeaderCompileAction.java
- src/main/java/com/google/devtools/build/lib/rules/java/ResourceJarActionBuilder.java 4 additions, 0 deletions...vtools/build/lib/rules/java/ResourceJarActionBuilder.java
Please register or sign in to comment