Skip to content
Snippets Groups Projects
Select Git revision
0 result
Search by author
  • Any Author
0 authors
This project is mirrored from https://github.com/bazelbuild/bazel.git. Pull mirroring updated .
  1. Nov 22, 2024
  3. Nov 21, 2024
  5. Nov 20, 2024
  7. Nov 19, 2024
  9. Nov 18, 2024
  11. Nov 16, 2024
    • Xùdōng Yáng's avatar
      [8.0.0] Misc cherry-picks (#24351) · e18aad1b
      Xùdōng Yáng authored 
      * 3d9c90e6 (use Bazel 7.4.1)
* 00c5f1fa (docs for REPO.bazel)
* 2fd61151 (add .bazelbsp to .gitignore)
      e18aad1b
    • Xùdōng Yáng's avatar
      [8.0.0] Reland "Fix most Unicode encoding bugs" (#24350) · 2733cffd
      Xùdōng Yáng authored 
      Roll forward of
https://github.com/bazelbuild/bazel/commit/a58fe3fa6b9ab1f7bfcd1ad8c94ab1f09a4cca39:
Fix most Unicode encoding bugs.

NEW: Relative to the original CL, the only changes are in
latin1_jni_path.cc and NativePosixFiles.java. In latin1_jni_path.cc, the
former implementation of GetStringLatin1Chars with a fallback for
strings with a UTF-16 coder is restored, with a BugReport sent whenever
any such string is detected. In NativePosixFiles.java, a private method
is added to be called from JNI to send the BugReport.

*** Original change description ***

Automated rollback of commit a58fe3fa

.

*** Reason for rollback ***

Causing crashes for internal software that uses Bazel's VFS stuff.

*** Original change description ***

Fix most Unicode encoding bugs

Bazel aims to support arbitrary file system path encodings (even raw
byte sequences) by attempting to force the JVM to use a Latin-1 locale
for OS interactions. As a result, Bazel internally encodes Strings as
raw byte arrays with a Latin-1 coder and no encoding information.
Whenever it interacts with encoding-aware APIs, this may require a
reencoding of the String contents, depending on the OS and availability
of a Latin-1 locale.

***

PiperOrigin-RevId: 696524066
Change-Id: Ifdddacc08c1a81ad719b1aeac2a93882cbafbcd2

Co-authored-by: default avatarFabian Meumertzheim <fabian@meumertzhe.im>
      2733cffd
    • bazel.build machine account's avatar
      [8.0.0] Add test for Unicode console output (#24349) · 3e7cab5d
      bazel.build machine account authored 
      Closes #24243.

PiperOrigin-RevId: 696968080
Change-Id: I8ad1dbe03c54b3a8d13f699026140f114f75e928

Commit
https://github.com/bazelbuild/bazel/commit/54a9c0b7e8b23eb7338bf38022745e9095b80641



Co-authored-by: default avatarFabian Meumertzheim <fabian@meumertzhe.im>
      3e7cab5d
    • Jon Brandvein's avatar
      [8.0.0] Refactor RuleVisibility validation and concatenation (#24332) · 12cd6eda
      Jon Brandvein authored 
      This CL simplifies RuleVisibility concatenation by inlining
concatWithElement() into concatWithPackage(). The latter was the only
caller of the former in production. The implementation no longer has to
handle the case where the RHS is public or private -- something that was
not needed in practice, but which was required in abstract for the
deleted method's API to be correct. It also now doesn't need to parse an
untrusted label, so there's no need to catch or throw EvalException.

concatWithPackage() is also made non-static, which looks nicer at the
call sites.

The validate() method is renamed to checkForVisibilityMisspelling(),
since that's the only thing it does now. (A previous CL removed its
other job of detecting formerly illegal combinations of public/private
visibility with other items in a list.)

Added an equals() and hashCode() while we're at it, to avoid depending
on singleton identity (I'm not sure whether @SerializationConstant lets
us assume that). It's based on just getDeclaredLabels() since that
should superset any information returned by getDependencyLabels().
Changed RuleVisibility from an interface to an abstract class too -- I
would've made it `sealed`, but the singleton PUBLIC and PRIVATE
anonymous subclasses prevent that and it's not worth making them named
classes.

MacroInstance.java
- Implement the TODO. (I went with "getDefinitionPackage" over
"getDefiningPackage" because the latter might be confused with the
package that defines the macro *instance*.)

MacroClass.java
- Condense to if-expr form now that the else branch is more concise.

RuleVisibilityTest.java
- Add pkg() helper for concatenation() test case.
- Remove assertEqual() now that we have a RuleVisibility#equals()
method.
- Rename "B" -> "B_PG" for clarity/contrast with "A" and "C".
- Delete test cases for concatWithElement that are no longer applicable
(where the RHS is public or private visibility)

Work toward https://github.com/bazelbuild/bazel/issues/23855.

PiperOrigin-RevId: 689400241
Change-Id: I6b7a1c9f87c4b3c9e5cd99d5dc4d906b5d798d28

Commit
https://github.com/bazelbuild/bazel/commit/bd273e537cc52e41194a5e0c67c1673467bbe1eb
      12cd6eda
    • Ivo List's avatar
      [8.0.0] Remove proto providers (#24291) · 25518e0a
      Ivo List authored 
      Fixes: https://github.com/bazelbuild/bazel/issues/24194


Cherry-picks:
ebb27909
89e5e4a8
df5ab9da
a2ccbb90
09ca1f30
76963446
8ce16617
a1af43cd
93b62651
6b29bed6



---------

Co-authored-by: default avatarGoogler <hvd@google.com>
      25518e0a
  13. Nov 15, 2024
  15. Nov 14, 2024
  17. Nov 13, 2024