This project is mirrored from https://github.com/bazelbuild/bazel.git.
Pull mirroring updated .
- Jul 30, 2024
-
-
bazel.build machine account authored
Defaults to false. When set to true, we use `+` instead of `~` as the separator in canonical repo names. Some more subtle changes include: - We now officially say that the "build" part of version strings (the part that begins with a plus) is ignored and stripped. - When the flag is set to true, we effectively increase the lockfile version by 1 (see code comment in BazelLockFileModule). - When true, we no longer insert a `_main` in front of names of repos generated by module extensions hosted in the main repo. (`~abc` as a name was problematic, but `+abc` is not.) - When true, we no longer insert a `v` in front of numerical versions in canonical repo names. (`my_mod~1.1` could be a Windows short path, but `my_mod+1.1` cannot.) Work towards https://github.com/bazelbuild/bazel/issues/22865. Closes #23103. PiperOrigin-RevId: 657202616 Change-Id: I015b2a04a823b1d951015a1b2e1b99b154dcc5a2 Commit https://github.com/bazelbuild/bazel/commit/2f67e57899425a7adad0ba03d524d6287902b11f Co-authored-by:
Xdng Yng <wyverald@gmail.com>
-
- Jul 29, 2024
-
-
bazel.build machine account authored
Javac actions gained support for multiplex sandboxing with rules_java 7.5.0, which makes it possible to test path mapping in this mode. Fixes #21091 Closes #21837. PiperOrigin-RevId: 657111790 Change-Id: Ib08f2c0bc48d210cce013e328da0e871f73278aa Commit https://github.com/bazelbuild/bazel/commit/8e79fe0329b995ec6db2f63d5cced84f90d158f3 Co-authored-by:
Fabian Meumertzheim <fabian@meumertzhe.im>
-
Fabian Meumertzheim authored
When path mapping is enabled, different `Spawn`s in the same build can have identical `RemoteAction.ActionKey`s and can thus provide remote cache hits for each other. However, cache hits are only possible after the first local execution has concluded and uploaded its result to the cache. To avoid unnecessary duplication of local work, the first `Spawn` for each `RemoteAction.ActionKey` is tracked until its results have been uploaded and all other concurrently scheduled `Spawn`s wait for it and then copy over its local outputs. Fixes #21043 Closes #22556. PiperOrigin-RevId: 655097996 Change-Id: I4368f9210c67a306775164d252aae122d8b46f9b Closes #23060
-
Fabian Meumertzheim authored
In `CommandLines`, the very first argument of the first command line is always a path to an executable. As such, it should be path mapped, even when it is a string. This wasn't the case for `SpawnAction`'s created via `ctx.actions.run(executable = <some string>)`. Work towards #6526 Work towards #22366 Closes #22844. PiperOrigin-RevId: 656258007 Change-Id: Ia046a7cc66aae51aec764e2f1c49e1d4f69e4b37 Closes #23040
-
Fabian Meumertzheim authored
When the Windows launcher binary is copied to become the `executable` of another target, it can't expect to find the main file right next to it. Instead, look it up via `Rlocation`, which doesn't require colocation to find the file. This helps with a common pattern in wrapper rules where `ctx.symlink` is used to work around the limitation that the `executable` of a target has to be produced by that target. For the Python rules, for which the source of truth is not the Bazel repo anymore, the new launch key is checked for in a backwards compatible way. Closes #23076. PiperOrigin-RevId: 657116461 Change-Id: I3f966b48e0812668cfa7bd394f2eaf23d66889b6 Closes #23121
-
- Jul 27, 2024
-
-
bazel.build machine account authored
When clang generates dotd files when using `-fmodule-map-file` any `extern module` directives in the modulemap are included in the dotd file if they exist. The result of this was that with sandboxing disabled the dotd file included transitive cppmap files that weren't in its input set, resulting in build failures. This change excludes those instead since they're not required as evidence by the fact that with sandboxing enabled they are not part of the input set. Fixes https://github.com/bazelbuild/bazel/issues/21592 Closes #21832. PiperOrigin-RevId: 656382428 Change-Id: I4bc9802884ce1bc66ceda65a602db8dffbd1d9ea Commit https://github.com/bazelbuild/bazel/commit/ad53147cc4f4d47c064845ec9612876161ff139e Co-authored-by:
Keith Smiley <keithbsmiley@gmail.com>
-
- Jul 26, 2024
-
-
bazel.build machine account authored
In the experimental_remote_cache_async mode, the cache upload steps were not profiled, unlike in the non-async case. This adds the profiling back. Fixes #20404. It'd be great if this could be backported into 7.3.0 once merged. Closes #23056. PiperOrigin-RevId: 655466182 Change-Id: Ib450ba4ea88a8ecdad66c6db0728db901e925017 Commit https://github.com/bazelbuild/bazel/commit/54820bde03e5e9330d3ffa063f7a304ce04701fc Co-authored-by:
Cornelius Riemenschneider <cornelius.riemenschneider@googlemail.com>
-
- Jul 24, 2024
-
-
bazel.build machine account authored
`Runfiles` insurance are cheap, `Preloaded` instances are costly. Closes #23006. PiperOrigin-RevId: 654661845 Change-Id: I46ee31718a2c5753d983b9c741547fe2a1de5d88 Commit https://github.com/bazelbuild/bazel/commit/7d266153af8516cfcd78f9e986a806566b205b27 Co-authored-by:
Fabian Meumertzheim <fabian@meumertzhe.im>
-
- Jul 22, 2024
-
-
Ian (Hee) Cha authored
Documenting the default caching behaviour for `rctx.download` and `rctx.download_and_extract`. Related to #22652 Closes #22716. PiperOrigin-RevId: 653878029 Change-Id: I129f9eede2b841483a98d5335651c1d1198aaf76 Commit https://github.com/bazelbuild/bazel/commit/d4b416f503d9e202dec0b24905366109ace43165 Co-authored-by:
Jordan Mele <jordan.mele@outlook.com.au>
-
- Jul 18, 2024
-
-
Fabian Meumertzheim authored
This is not a cherry-pick, but a dedicated fix for Bazel 7.x. Bazel 8 is not affected as the switch to the Starlarkified exec configuration has already resolved this problem. Fixes #14169
-
- Jul 11, 2024
-
-
Ian (Hee) Cha authored
This makes the lockfile independent of OS/arch. Closes #22718. PiperOrigin-RevId: 645176563 Change-Id: I23d35c911c20ad115943d276ca5ed49d317f7f83 Commit https://github.com/bazelbuild/bazel/commit/01f6decac7aa7ccd4c7c511517b1e1b4ab28c985 Co-authored-by:
Fabian Meumertzheim <fabian@meumertzhe.im>
-
- Jul 10, 2024
-
-
bazel.build machine account authored
This allows module extensions to parallelize downloads of archives via `module_ctx.download(..., block = False)` and then extract them once they have finished downloading. Closes #22825. PiperOrigin-RevId: 645435518 Change-Id: I3c128358f2ba006e0fb8c1c9b8580d8b752dcf01 Commit https://github.com/bazelbuild/bazel/commit/46745793eb986d84cd16ebb6d2eba7eff48f4ddd Co-authored-by:
Fabian Meumertzheim <fabian@meumertzhe.im> Co-authored-by:
Yun Peng <pcloudy@google.com>
-
Yun Peng authored
We are moving android tests out of Bazel repo. PiperOrigin-RevId: 650742822 Change-Id: I2a0363b91420e744cdeeecc82eebfbcd727d306d
-
Fabian Meumertzheim authored
Basic support for path mapping for `CppCompile` actions is added by wiring up `PathMapper` with: * structured path variables for files and include paths (`Artifact` and `NestedSet<PathFragment>`) * inputs/outputs via `Spawn#getPathMapper()` * header discovery Also turns `external_include_paths` into a structured variable, which was missed in #22463. The following features are known to be unsupported for now: * `layering_check` (requires rewriting paths to and in module maps) * source tree artifacts (requires wiring up `PathMapper` in `CppCompileActionTemplate`) * location expanded paths to generated files such as sanitizer suppression lists (requires heuristically rewriting paths in `user_compile_flags`) These limitations will be lifted in follow-up PRs. Work towards #6526 RELNOTES: Experimental support for path mapping `CppCompile` actions can be enabled via `--modify_execution_info=CppCompile=+supports-path-mapping`. Closes #22445. PiperOrigin-RevId: 646109274 Change-Id: I6f4eb92b6be3052547f144c681b6588e9fc40693 Closes #22875 Co-authored-by:
Yun Peng <pcloudy@google.com>
-
bazel.build machine account authored
This fixes action conflicts when `cc_toolchain`s in different repos, but with identical package and target names, use `dynamic_runtime_lib`. Closes #22738. PiperOrigin-RevId: 650552244 Change-Id: Ic17877766d21361af64abdfdaeefeb69e40dc747 Commit https://github.com/bazelbuild/bazel/commit/8d1861883c30595aec6c180cdee244da6517e550 Co-authored-by:
Fabian Meumertzheim <fabian@meumertzhe.im> Co-authored-by:
Yun Peng <pcloudy@google.com>
-
bazel.build machine account authored
This makes sure vendored repos work correctly even without a bazel server restart. For example, when ``` bazel vendor //:bin --vendor_dir=vendor_src rm -rf vendor_src bazel vendor //:bin --vendor_dir=vendor_src ``` Closes #22817. PiperOrigin-RevId: 645429810 Change-Id: Iede46fd5d3af7a6c18442f953adf4c2232f422e9 Commit https://github.com/bazelbuild/bazel/commit/5a61e0be8d9134f44da6cfc1a982ebaefee9a1c8 Co-authored-by:
Yun Peng <pcloudy@google.com>
-
bazel.build machine account authored
Fixes #14270 Closes #22590. PiperOrigin-RevId: 646928926 Change-Id: I8182bc57fabebbbba441aaa593c72f8c90fa45bb Commit https://github.com/bazelbuild/bazel/commit/9eab47cd60dab28a2dc9b021b18e37fa4ce77e65 Co-authored-by:
Fabian Meumertzheim <fabian@meumertzhe.im> Co-authored-by:
Yun Peng <pcloudy@google.com>
-
bazel.build machine account authored
Repo wasn't vendored as expected due to wrong SkyValue cache caused by incorrect equals function. Related: https://github.com/bazelbuild/bazel/issues/19563 Closes #22953. PiperOrigin-RevId: 650648957 Change-Id: Id31aa7d6f9bcbe2e3eb9e556ae31b3b8e42436bf Commit https://github.com/bazelbuild/bazel/commit/076bbbbca84807a6fddf86c9d3930a36f12668a6 Co-authored-by:
Yun Peng <pcloudy@google.com>
-
Yun Peng authored
- Upgraded Bazel to 7.2.1 to include remote cache fixes - Backport changes to adapt https://github.com/bazelbuild/continuous-integration/issues/1981 --------- Co-authored-by:
Googler <fwe@google.com>
-
- Jul 04, 2024
-
-
Chi Wang authored
Address https://github.com/bazelbuild/bazel/issues/20559#issuecomment-2203999686. PiperOrigin-RevId: 649360592 Change-Id: I50ac2ed3b54d6cffb5f96d3f8315279786c4f30f
-
- Jun 28, 2024
-
-
bazel.build machine account authored
This still leaves the question of "what do we do instead?". See issues #22208 and #21515. Fixes https://github.com/bazelbuild/bazel/issues/22754. Closes #22774. PiperOrigin-RevId: 645148811 Change-Id: Ib9d07d2ecbc3a79e3341de6739de1c3349124d6b Commit https://github.com/bazelbuild/bazel/commit/1246ff498b51acb92776efb9402c40f54d83fdee Co-authored-by:
Xdng Yng <wyverald@gmail.com>
-
- Jun 27, 2024
-
-
bazel.build machine account authored
Fixes #22642 Closes #22887. PiperOrigin-RevId: 646981159 Change-Id: I3fc42339ab7013d0a01e3f5feb16a781b799edd5 Commit https://github.com/bazelbuild/bazel/commit/9c4e73d9f0a76ed7203cea05c651ad570da05208 Co-authored-by:
Laurent Le Brun <laurentlb@gmail.com>
-
- Jun 26, 2024
-
-
bazel.build machine account authored
This is required for UTF-8 to be rendered properly in a terminal (e.g. for `bazel mod graph`). Closes #22874. PiperOrigin-RevId: 646592183 Change-Id: I33692986301ea472462ad0e6da9634bd580c8a5f Commit https://github.com/bazelbuild/bazel/commit/4a5fe6207eb596effc13fe6b8e862727dc03eda6 Co-authored-by:
Fabian Meumertzheim <fabian@meumertzhe.im>
-
- Jun 25, 2024
-
-
Fabian Meumertzheim authored
`StarlarkBaseExternalContext` now implements `AutoCloseable` and, in `close()`: 1. Cancels all pending async tasks. 2. Awaits their termination. 3. Cleans up the working directory (always for module extensions, on failure for repo rules). 4. Fails if there were pending async tasks in an otherwise successful evaluation. Previously, module extensions didn't do any of those. Repo rules did 1 and 4 and sometimes 3, but not in all cases. This change required replacing the fixed-size thread pool in `DownloadManager` with virtual threads, thereby resolving a TODO about not using a fixed-size thread pool for the `GrpcRemoteDownloader`. Work towards #22680 Work towards #22748 Closes #22772. PiperOrigin-RevId: 644669599 Change-Id: Ib71e5bf346830b92277ac2bd473e11c834cb2624 Closes #22776
-
- Jun 21, 2024
-
-
Fabian Meumertzheim authored
This in particular removes an extension that recorded the hash of the `MODULE.bazel` file, resulting in frequent invalidation. Closes #22840. PiperOrigin-RevId: 645330993 Change-Id: Ibf1b6b74b5a2bb0ea9d91bcc3ab74237a1d2855e Closes #22841
-
Fabian Meumertzheim authored
Getting rid of the single boolean field on `AbstractFileWriteAction` reduces padding on each subclass instance and in particular frees up a 4-byte field on `CppModuleMapAction`. Also use a lambda to define `newDeterministicWriter` if possible for improved readability. This prepares for future changes that will add fields to `CppModuleMapAction` to support path mapping. Work towards #6526 Closes #22609. PiperOrigin-RevId: 643340715 Change-Id: Id3af26049098e6dfa731f0e7a1be6709bea0d9f2 Closes #22749 Closes #22750
-
Ted authored
…ocal header PiperOrigin-RevId: 644428764 Change-Id: Ie320016c301721e9ec03032a1dbf8dc9193abab6 Co-authored-by:
Googler <cushon@google.com> Co-authored-by:
Yun Peng <pcloudy@google.com>
-
bazel.build machine account authored
This avoids collisions between overlay files and regular BCR files such as `source.json`. Overlay support has been released in 7.2.0, but hasn't been used in the BCR yet. Closes #22811. PiperOrigin-RevId: 645071272 Change-Id: Ib05855a728ebb09795bf70afb14457e9e6d23bf0 Commit https://github.com/bazelbuild/bazel/commit/36da00463d4b645752d1be7c5b8d41139d3b8811 Co-authored-by:
Fabian Meumertzheim <fabian@meumertzhe.im> Co-authored-by:
Yun Peng <pcloudy@google.com>
-
Xùdōng Yáng authored
Fixes #22741. PiperOrigin-RevId: 643932127 Change-Id: Ia9566acb7b828224679ad57b71644281a8e52db4 Co-authored-by:
Googler <chiwang@google.com> Co-authored-by:
Yun Peng <pcloudy@google.com>
-
bazel.build machine account authored
There is an [open issue](https://github.com/bazelbuild/bazel/issues/22104) where bazel will occasionally fail at start up time because it is unable to parse the downloader config. While I've yet to create a reliable reproduction for this issue, the one time I've triggered this error with a build with additional logging, it seemed to be because the current working directory wasn't the root of the workspace. While I'm not sure this will actually fully resolve the problem (since I don't know what's causing it) being clearer about where the config file is meant to be can only be a Good Thing. Addresses #22104 Closes #22770. PiperOrigin-RevId: 645115556 Change-Id: I7e9bea1c55a106cd767ebfd6d557a7c59c47cd66 Commit https://github.com/bazelbuild/bazel/commit/0e220f03f154cbb5e52190e1085b01173f301c02 Co-authored-by:
Simon Mavi Stewart <simon_stewart@apple.com> Co-authored-by:
Yun Peng <pcloudy@google.com>
-
Ian (Hee) Cha authored
Contains fixes for the remote jdk mirror URLs Closes #22815. PiperOrigin-RevId: 644965303 Change-Id: I86ee6f2b2ac42066489c8fc563c8fc28ea67afaa Commit https://github.com/bazelbuild/bazel/commit/b587a05dc531b1e6b4ede01e016d6c200755df16 Co-authored-by:
hvd <hvadehra@gmail.com> Co-authored-by:
Yun Peng <pcloudy@google.com>
-
Yun Peng authored
Commits back-ported: - b2bdf977 - e7635c5f - 06123411 - 84e0304b - 96b90baf - fe0262be - c94c1c32 - 05cdac86 - fbcd70ee RELNOTES: Bazel now supports vendoring external dependencies with Bzlmod, see https://bazel.build/external/vendor for details. --------- Co-authored-by:
salma-samy <salmasamy@google.com> Co-authored-by:
Googler <wyv@google.com>
-
- Jun 20, 2024
-
-
bazel.build machine account authored
[7.3.0] Fix permissions on tree artifact subdirectories as needed to move them out of the sandbox. (#22802) Similar to https://github.com/bazelbuild/bazel/commit/547f0c6955942e6aafd279adbb2f5368a7a2347e, but also includes the r and x bits. Fixes #22260. PiperOrigin-RevId: 644705156 Change-Id: I5354db76dd2c375a6e686fb4808649053b24c500 Commit https://github.com/bazelbuild/bazel/commit/fb05e916ddf18dc06ef1fdde5063de6c49cee5c1 Co-authored-by:
Googler <tjgq@google.com>
-
- Jun 19, 2024
-
-
bazel.build machine account authored
This was already the case for "local" spawns. Statistics may be missing if the spawn wrapper exits abnormally. Fixes #22151. Closes #22780. PiperOrigin-RevId: 644378541 Change-Id: Ia3d792f380b78945523f21875c593744b60f0c81 Commit https://github.com/bazelbuild/bazel/commit/ec41dd1fe71380ac724399839f5bf22c3969f24b Co-authored-by:
Fabian Meumertzheim <fabian@meumertzhe.im>
-
bazel.build machine account authored
[7.3.0] Use the generic term "config file" instead of the product-specific ".blazerc" in error messages. (#22793) Fixes #22685. PiperOrigin-RevId: 644377301 Change-Id: I05e7e01f1b4f79c219aa974871efcbc41966966c Commit https://github.com/bazelbuild/bazel/commit/7b02eaa837fabf0e3d0e810690e51d55506529ab Co-authored-by:
Googler <tjgq@google.com>
-
bazel.build machine account authored
Closes #18444. PiperOrigin-RevId: 642659695 Change-Id: I97f2c2a20a8dd7a3958e6d814475395a2802dc70 Commit https://github.com/bazelbuild/bazel/commit/0ca7099eb81b2d1a4d8b85e8f7ad0bd83536fbee --------- Co-authored-by:
Fabian Meumertzheim <fabian@meumertzhe.im> Co-authored-by:
iancha1992 <heec@google.com>
-
- Jun 18, 2024
-
-
Chi Wang authored
Previously, it only retries when we have error whose message contains "connection reset by peer". In some cases, we could also have message like "Connection reset", e.g. https://buildkite.com/bazel/bazel-bazel-macos-ninja/builds/1827#01902690-f35a-4f3d-9166-7b39c1f885fb. PiperOrigin-RevId: 644325070 Change-Id: I75500646b35681fda25e584ec5d6ec3348cee9a5
-
bazel.build machine account authored
`--override_module=foo=` will discard previous overrides specified by this option. Closes #22751. PiperOrigin-RevId: 644253498 Change-Id: If723756433545bfc875d7f877d596f2e3f041464 Commit https://github.com/bazelbuild/bazel/commit/82e31358549f7614497bf9d9fe8d16415a49eece Co-authored-by:
Yun Peng <pcloudy@google.com>
-
bazel.build machine account authored
This would make the bind mount fail, which would cause the sandbox to be terminated. Fixes https://github.com/bazelbuild/bazel/issues/4963 PiperOrigin-RevId: 643257634 Change-Id: I19d83ba2413a1d3c6606e7ea381dff2b71922e86 Commit https://github.com/bazelbuild/bazel/commit/b6bb80078633438be4c8b3537a0ec8d7f8ae3825 Co-authored-by:
Googler <twerth@google.com>
-
bazel.build machine account authored
With `-std=c++20`, Clang defaults to using C++ modules rather than Clang modules, which can result in failures when using `layering_check` and thus `use_module_maps`. Fixes https://github.com/bazel-contrib/toolchains_llvm/issues/334 Closes #22660. PiperOrigin-RevId: 642548168 Change-Id: Ie1dd4c482d716635f7b6c53ffd3c5d84b6aa8cc2 Commit https://github.com/bazelbuild/bazel/commit/9e913fbfa2e3930742fc30dfb60ac5e2694c70cf Co-authored-by:
Fabian Meumertzheim <fabian@meumertzhe.im>
-