This PR removes the DownloadManager from the registry factory
implementation. As the registry created by the factory is cached by the
SkyFunction mechanism, the DownloadManager instance was living too long
- it is supposed to be re-created for every command instantiation to
respect changes in command line options, but for the registry, it
ignored those changes.

Instead, the DownloadManager is set directly into the affected
SkyFunctions that require access to it. This way, the per-command
DownloadManager instance is correctly used.

This fixes https://github.com/bazelbuild/bazel/issues/24166

.

Note for reviewers: This is my first time touching code with
SkyFunctions, so I don't really know what I'm doing.

Closes #24212.

PiperOrigin-RevId: 693644409
Change-Id: I7b16684e52673043615290d114f078ab7ab99fcf

Co-authored-by: Cornelius Riemenschneider <cornelius@github.com>

This reverts commit cb1bc28f.

Closes https://github.com/bazelbuild/bazel/issues/24158

PiperOrigin-RevId: 587638256
Change-Id: I4aa6b9c2009323e9c4adc7f6e8b5e335a637ed1c

(cherry picked from commit fb446e63)

Looks like f6687ad4 didn't fully fix
things, based on looking at https://bazel.build/external/module today:

<img width="907" alt="Screenshot 2024-10-15 at 1 13 37 PM"
src="https://github.com/user-attachments/assets/800487d4-0845-418d-8042-bd2c4bad017c">

Closes #23985.

PiperOrigin-RevId: 691071540
Change-Id: Ic474af8308843314aaeaaa85a40dfc487cf7efca

Commit
https://github.com/bazelbuild/bazel/commit/4e4b88fd8385471b783c36f3d9835ba177470fc7



Co-authored-by: Matt Brown <mattbrown@spotify.com>

Since `WorkRequest` encodes strings as UTF-8, Bazel's internal string
encoding of file paths needs to be undone before passing them to the
protobuf builder.

Closes #23924.

PiperOrigin-RevId: 690737819
Change-Id: I3eb341c05e045c75ac004da57e1f46f3587a6810

Commit
https://github.com/bazelbuild/bazel/commit/89f798effcec161c99164f08f58d5565e66c7602



Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>

`wc -c` has leading spaces that needs to be removed, otherwise
trim_length would become ` 29` for example.

~I'm not very sure how test cases could work but this fails in our
repo.~ I understand it now. We set `IFS=$'\\n\\t'` in our script, which
makes this trick stops working `cut -b ${trim_length}-` (note that there
are no quotes around `${trim_length}`. Although we could fix our `IFS`,
this still seems to be a bug because it is not "portable".

Closes #24076.

PiperOrigin-RevId: 690707015
Change-Id: I728b7462994a6ffdb9b88c3cbea3ec044a8b0134

Commit
https://github.com/bazelbuild/bazel/commit/bf666fb0cb7d74a1005e49cd48bfc790cf46d3a4



Co-authored-by: Honnix <honnix@users.noreply.github.com>

Fixes https://github.com/bazelbuild/bazel/issues/24098

With this change the disk cache garbage collection works correctly:
```
241027 09:06:34.732:I 681 [com.google.devtools.build.lib.remote.disk.DiskCacheGarbageCollectorIdleTask.run] Disk cache garbage collection started
241027 09:07:06.123:I 681 [com.google.devtools.build.lib.remote.disk.DiskCacheGarbageCollectorIdleTask.run] Deleted 190243 of 446229 files, reclaimed 5.4 GiB of 15.4 GiB
```

Closes #24099.

PiperOrigin-RevId: 690652512
Change-Id: Ie8d1fa6b2afb0bd5bd85fdb6835871023a64ad24

Commit
https://github.com/bazelbuild/bazel/commit/374658377f662701f1e92f757090949fdd0da1ab



Co-authored-by: Roman Salvador <rsalvador@salesforce.com>

We want a lower bound, not an upper one.

PiperOrigin-RevId: 690593852
Change-Id: If391e695593c9d445b4968be98d05e6169a06b3a

Fixes #24061

[7.4.1] Revert "[7.4.0] Propagate `linkopts` of header-only libraries to `cc_shared_library`" (#24087)

Reverts bazelbuild/bazel#24017

The change has broken multiple existing builds. Even if it can be fixed,
its usefulness does not justify the potential for more breakages in a
minor release.

PiperOrigin-RevId: 688955616
Change-Id: I408da72cfe409db7feb1978762fc6848f8fe118f (cherry picked from
commit 38833e15)

Release Notes:

createDexMergerActions continues to be exposed to Starlark due to it's
use for SpawnActionTemplate which is not exposed to Starlark. We must
pass a file containing global information to the final dexmerging step
in order to support Java 17 Record desugaring. This change adds an
optional parameter to the Starlark interface to forward the globals file
to the Dex Merger.

PiperOrigin-RevId: 660045021
Change-Id: Ie3b961ff2687f48ca29a94e67180c0e5875ddbe3

Commit
https://github.com/bazelbuild/bazel/commit/2daa0a3d893a3c18021e7c1191d4cacc270dd062



Co-authored-by: Andrew Sinclair <asinclair@google.com>

Fixes #23981

Closes #23982.

PiperOrigin-RevId: 686486627
Change-Id: I5f03b63601a535f8d551c005b00bf040846a324d

Commit
https://github.com/bazelbuild/bazel/commit/b0f1430f0e9b7608b9ecc64b20c3b0fe40ac4a43



Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>

Fixes #21884
Fixes #23053

Closes #23215.

PiperOrigin-RevId: 686518093
Change-Id: I1a6699b169fe4291ad0dda3be7e74f38c8e37bf1

Commit
https://github.com/bazelbuild/bazel/commit/0fdb36f8a5cf79fda9931b6e3f119bb5f41f0701



Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>

When cancelling an asynchronous repository download task, an interrupt
signal is sent to the download thread. This doesn't mean that the
download stops immediately. Avoid restarting a download until the
previous download has actually stopped, so that the new download is able
to clean old data without crashing (on Windows).

Fixes #21773

Closes #23837.

PiperOrigin-RevId: 686175953
Change-Id: I8d75f905b739d38b6cb430d5b5e84fda9a2d14e3

Commit
https://github.com/bazelbuild/bazel/commit/48338d2ff33586a0d053e358da6b94e23fe0e2eb



Co-authored-by: Fredrik Medley <fredrik@meroton.com>

This really just exposes the existing LABEL_DICT_UNARY type that already
exists in Java.

Other than writing some boring conversion logic, all pieces fell
together pretty pleasantly.

Work towards #7989. That one calls for a string-to-label-list-dict type,
but I'm planning to resolve that as WAI, since string-to-label-dict is
close enough.

RELNOTES: None.
PiperOrigin-RevId: 686415025
Change-Id: Ib07ada7ab2ede95220ed1cc2d3569996fc4afb88

PiperOrigin-RevId: 685675470
Change-Id: I1194e08ab32f881b84cf7324fdb954dd3f0ce22c (cherry picked from
commit 0d5673a6)

The logic picked the first instead of the highest version due to a typo.

Closes #23936.

PiperOrigin-RevId: 684528776
Change-Id: Ic61c84ca2f3489e43fc71944824e7e2311543ab9

Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>

Work towards https://github.com/bazelbuild/bazel/issues/19301
Fixes https://github.com/bazelbuild/bazel/issues/23580

RELNOTES: `override_repo` and `inject_repo` can be used to override and
inject repos in module extensions.

Closes https://github.com/bazelbuild/bazel/pull/23534.

PiperOrigin-RevId: 678139661
Change-Id: Iea7caca949c00e701f056c1037e273fee9740e93

(cherry picked from commit
https://github.com/bazelbuild/bazel/commit/46341b1a59c7a1cc8ca0dc604ad53b6de7fee653)

Fixes #23724
Fixes #23799

Also includes:
* Disallow importing injected repos
(8472c9df

)

---------

Co-authored-by: Xùdōng Yáng <wyverald@gmail.com>

commits:
* d62e0a0f
* c3393dac



---------

Co-authored-by: Fredrik Medley <fredrik@meroton.com>

Closes #23800.

PiperOrigin-RevId: 684529045
Change-Id: I14dc53b6f2e39c7a05ee3a8b872eb220af45cef9

Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>

Also switch back to Zulu where possible.

Closes #23913.

PiperOrigin-RevId: 684397892
Change-Id: I1b563bd45f85bd8ec5cfbaf8550f0a59ea8f0b54

Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>

Fixes https://github.com/bazelbuild/bazel/issues/23885

Closes #23102.

PiperOrigin-RevId: 684433748
Change-Id: I12cdb9a04f930a52e57bbd8551c8f2559a15932a

Commit
https://github.com/bazelbuild/bazel/commit/c2d316b4d3f832d0c5677f0abc63c27d059873b8



Co-authored-by: Keith Smiley <keithbsmiley@gmail.com>

On windows, bazel will run the workspace_status_command, and receive
carriage return characters \r even if the workspace_status_command did
not include them.

Fixes https://github.com/bazelbuild/bazel/issues/13442



PiperOrigin-RevId: 684055158
Change-Id: Idd3bd9c954d64b0a2d674dd7d90cf61c00955917

Co-authored-by: Googler <tomrenn@google.com>

This cherry picks 62dc3b5b and
0b0d9084 which allows setting
install_name and soname on shared libraries. No defaults changed here.

Fixes https://github.com/bazelbuild/bazel/issues/23842



---------

Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>

This allows path mapping to apply to actions that reference execpaths in
custom compiler options via location expansion.

Work towards #6526

Closes #23630.

PiperOrigin-RevId: 680941133
Change-Id: Ia10e2df481dcfe4480cbf9dfb1e12ec3b07d8ab2

Commit
https://github.com/bazelbuild/bazel/commit/b4b35af91283709689ffca37c4d1eb4f5eee0c30



Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>

(contains the refactor in f311efc5 to
reduce merge conflicts)

Adds support for spaces and newlines in source and target paths of
runfiles symlinks to `build-runfiles` as well as to the Bash, C++, and
Java runfiles libraries (the Python runfiles library has moved out of
the repo).

If a symlink has spaces or newlines in its source path, it is prefixed
with a space in the manifest and spaces, newlines, and backslashes in
the source path are escaped with `\s`, `\n`, and `\b` respectively. This
scheme has been chosen as it has the following properties:
1. There is no change to the format of manifest lines for entries whose
source and target paths don't contain a space. This ensures
compatibility with existing runfiles libraries.
2. There is even no change to the format of manifest lines for entries
whose target path contains spaces but whose source path does not. These
manifests previously failed in `build-runfiles`, but were usable on
Windows and supported by the official runfiles libraries. This also
ensures that the initialization snippet for the Bash runfiles library
doesn't need to change, even when used on Unix with a space in the
output base path.
3. The scheme is fully reversible and only depends on the source path,
which gives runfiles libraries a choice between reversing the escaping
when parsing the manifest (C++, Java) or applying the escaping when
searching the manifest (Bash).

Fixes https://github.com/bazelbuild/bazel/issues/4327

RELNOTES: Bazel now supports all characters in the rlocation and target
paths of runfiles and can be run from workspaces with a space in their
full path.

Closes https://github.com/bazelbuild/bazel/pull/23331.

PiperOrigin-RevId: 683362776
Change-Id: I1eb79217dcd53cef0089d62a7ba477b1d8f52c21

(cherry picked from commits
https://github.com/bazelbuild/bazel/commit/7407cef3837b4fe14e48e1a925f9b886c0cc945d
and f311efc5

)

Closes #23715

---------

Co-authored-by: Googler <jhorvitz@google.com>

The inability to pass C or C++ specific compiler flags to targets that
contain a mix of those sources is a common sticking point for new users.
These mirror the global `--conlyopt` and `--cxxopt` flags but at the
target level.

Fixes https://github.com/bazelbuild/bazel/issues/22041

RELNOTES: Add conlyopts and cxxopts attributes to cc rules

Closes #23840

PiperOrigin-RevId: 682144094
Change-Id: I0fe8b728c493652d875ce6a6dd2a9989c36b1f24

(cherry picked from commit 5854788d)

Before:
```
Caused by: java.util.NoSuchElementException: Resource foo is not tracked in this resource set.
    at com.google.devtools.build.lib.actions.ResourceManager.assertExtraResourcesTracked(ResourceManager.java:499)
    at com.google.devtools.build.lib.actions.ResourceManager.areResourcesAvailable(ResourceManager.java:540)
```
After:
```
ERROR: src/test/java/com/google/devtools/build/lib/actions/BUILD:102:10: Testing //src/test/java/com/google/devtools/build/lib/actions:ActionsTests failed: Resource foo is not being tracked by the resource manager. Available resources are: cpu, memory
```

Fixes #19572

Closes #23541.

PiperOrigin-RevId: 682282327
Change-Id: Ifdff5f85de9e45ac119c2a2cfd161c054a722546 
(cherry picked from commit e5ab94bf

)

Closes #23868

Co-authored-by: Alessandro Patti <ale812@yahoo.it>

Closes #23873.

PiperOrigin-RevId: 682416574
Change-Id: I531cbdadac035bb14585eafe5be093823bca2214

(cherry picked from commit cab7d45d)

Closes #23874

- Adding `--vendor_dir` to ignored package prefixes as if it's added in
the `.bazelignore` file.
- This allows users to do `bazel build //...` after vendoring external
deps in the source root without manually adding the vendor dir in
`.bazelignore`.

Fixes https://github.com/bazelbuild/bazel/issues/23521

Closes #23771.

PiperOrigin-RevId: 680994986
Change-Id: I9c8b76ca20b9060232dfe05460a8fc857c92e93f

Backporting
https://github.com/bazelbuild/bazel/commit/d42301b0714ab80aa376715995bc73849a451638

Fixes: https://github.com/bazelbuild/bazel/issues/23905

Commits:

https://github.com/bazelbuild/bazel/commit/dbb9670fb2719323c3e9b5df8ab045d187cf8c63

https://github.com/bazelbuild/bazel/commit/84c15a00d4a756fb82af5079b4e71f5cf933fe94

https://github.com/bazelbuild/bazel/commit/f9ed0b03269ee5364f01e1d177129e4597ba0a48

https://github.com/bazelbuild/bazel/commit/cc3ba22c3e9256dc2d9f419e25c9b653d7f81577

https://github.com/bazelbuild/bazel/commit/7e1393937c56ca25ad678851ec0de93c913eae7d

https://github.com/bazelbuild/bazel/commit/0f6d0d839381e9ccee5fd8857c449d6d76ba8714

https://github.com/bazelbuild/bazel/commit/38239d9d71eefb577c3966d17a4fbaae3eedf4fb

https://github.com/bazelbuild/bazel/commit/3cb5beaa1550896e0df54d00b66ea215b1e47048

https://github.com/bazelbuild/bazel/commit/3bc5dea1f0e9105489c641c72f322b9e17548b94

https://github.com/bazelbuild/bazel/commit/7518bbb4a67021ec8efcc64e74ebaa72074311d9

https://github.com/bazelbuild/bazel/commit/963e7a230aa31c06e3c4d695e9eb5f9947c8fd6e

https://github.com/bazelbuild/bazel/commit/ae0274497028964751310f4fd15117953bf30806

https://github.com/bazelbuild/bazel/commit/8d3bd0e0f95f2abeb9b6d9fc8b32ab4af717fa0f


(partial)

---------

Co-authored-by: Googler <shahan@google.com>
Co-authored-by: Tim Peut <timpeut@google.com>

When the flag is flipped, `ctx.path` no longer watches paths resolved
from `Label` parameters and other methods on `ctx` no longer watch such
paths even with `watch = "no"`.

Closes #23750.

PiperOrigin-RevId: 681978073
Change-Id: I9bef5c735db54c971beb806aa1f1a0eb287e3ff2

(cherry picked from commit 50196979)

Closes #23768

Fixes #23754

Closes #23755.

PiperOrigin-RevId: 679472028
Change-Id: I0ea922ee6edf28c5643c6f2b524371f1d5405c9c

Commit
https://github.com/bazelbuild/bazel/commit/765d5e0a64926517d686ff567d280914df08e7dc



Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>

The cherry-pick of the compact execlog runfiles changes assumed that
runfiles only appear in the top-level tool nested set, but this isn't
true for genrules. Instead, as in Bazel 8, it can be assumed that all
middleman are also contained in inputs, which makes it possible to
remove the extra middleman parameter and pass all runfiles tree
information down to transitive log calls.

Fixes #23884

Previously the execution logs were always written to relative paths.
This caused an issue if you put this flag in your `.bazelrc` and
expected the log to be produced in a relative directory. You can now use
`%workspace%` to handle writing to the root of your workspace.

Fixes https://github.com/bazelbuild/bazel/issues/22267

Closes #23813.

PiperOrigin-RevId: 682196916
Change-Id: I5f6fe3c72cfc3fe9a891e0d44440cb49bbc787d8

Commit
https://github.com/bazelbuild/bazel/commit/9aaeb9fe2c1edaca38f91c53a5620a2df2220302



Co-authored-by: Keith Smiley <keithbsmiley@gmail.com>

The format is auto-detected from the first few bytes of the input file.

PiperOrigin-RevId: 680915789
Change-Id: I6f1b4a2334912f25a8c41761a970e8f75265cc13

By cherry-picking the following changes:

* 33aca3fe
* 85b100b9
* 08cd046e
* ca802d6b
* 16900673
* 6096b5e4
* 041faf5e
* 46d55027
* d48e3915
* c43cf67b
* db4a4008
* 6922734a
* 544e2350
* b09cd655
* c72af54f
* 5997fdeb
* caa2c413

* Recommend the compact format over the binary and JSON formats.
* Note that `//src/tools/execlog:parser` can be used with any format.
* Note that `//src/tools/execlog:converter` can be used to convert
between formats.

PiperOrigin-RevId: 680941049
Change-Id: I81caf27a4ff6aef0ea97667df5ccbba1c3f10d58