Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/bazelbuild/bazel.git. Pull mirroring updated .
  1. Dec 19, 2024
  2. Dec 18, 2024
    • Googler's avatar
      Throw toolchain resolution error (as EvalError) instead of... · 764fa691
      Googler authored
      Throw toolchain resolution error (as EvalError) instead of IllegalStateException if create_compile_action() is called for an action that isn't configured for the toolchain.
      
      PiperOrigin-RevId: 705135234
      Change-Id: Iffaf819e9b59cc4925aa7bd14ce5c3f529664b1b
      764fa691
  3. Dec 07, 2024
  4. Dec 06, 2024
  5. Dec 05, 2024
    • Googler's avatar
      Skips looking up packages for RemoteConfiguredTargetValue. · 863ba672
      Googler authored
      RemoteConfiguredTargetValue includes an implementation of TargetData so it
      doesn't need to be looked up from the Package.
      
      PiperOrigin-RevId: 703085029
      Change-Id: I1f976a8c7b5e8c05f421281d8da9f810f0ece85c
      863ba672
    • Googler's avatar
      Add capability for RegisteredExecutionPlatformsFunction to reject execution platforms. · c63631f2
      Googler authored
      This adds the capability and debugging output, but doesn't actually check anything, that will be in the next change.
      
      Work towards selectively enabling execution platforms: #22567.
      
      PiperOrigin-RevId: 703081888
      Change-Id: Ibc92de582a4791af3f389645603cd66e38b710cf
      c63631f2
    • Googler's avatar
      Fix `EmptyRuleConfiguredTargetFactory` for native rules that are not instances of `EmptyRule` · a1d1902e
      Googler authored
      PiperOrigin-RevId: 703081614
      Change-Id: I16791ec75960fa884c0de3d0a29dd25beaab03ee
      a1d1902e
    • Googler's avatar
      Introduce new Starlark.positionalOnlyCall() function for calls with only positional params. · fdfdbd8a
      Googler authored
      Use it in the many suitable places where Starlark.call() is used so far.
      Next steps will be to introduce something corresponding in StarlarkCallable and implement a more efficient implementation thereof in StarlarkFunction and possibly BuiltinFunction.
      Further steps could be to allow optimized access paths from Eval.evalCall() to StarlarkFunction and, again possibly, to BuiltinFunction, that directly populate the locals array or the argument vector for the native call.
      
      PiperOrigin-RevId: 703075286
      Change-Id: I8fbda39645884a32831958b1fa6b9a1603b9567f
      fdfdbd8a
    • Fabian Meumertzheim's avatar
      Include file-level baseline coverage in combined report · 512b31d9
      Fabian Meumertzheim authored
      The coverage report produced with `--combined_report` now contains file-level baseline coverage information.
      
      Line-level as well as branch information requires language specific actions and is subject to a proposal for a Starlark API for baseline coverage.
      
      Work towards #5716
      
      Closes #24563.
      
      PiperOrigin-RevId: 703017111
      Change-Id: I40db58bc08949b84abc37db237fca0853430795c
      512b31d9
    • Googler's avatar
      Delete `--incompatible_disallow_resource_jars` · 6b6bb34c
      Googler authored
      The flag has been a no-op for a long while.
      
      Fixes https://github.com/bazelbuild/bazel/issues/13221
      
      PiperOrigin-RevId: 703008100
      Change-Id: I75f69edb1339e1c276eafb36539f0c14d7f290b2
      6b6bb34c
    • Googler's avatar
      Internal cleanup. · 57be366a
      Googler authored
      PiperOrigin-RevId: 703005422
      Change-Id: Ia14657f73bdfe473af80741566253f4a91884b2d
      57be366a
    • Googler's avatar
      Handle changed files outside of active directories for remote analysis caching. · 266dab6b
      Googler authored
      This is a _coarse grained and conservative_ approach to disallow clients from using remote analysis caching when there are changed files outside of the active directories. This is because such files __may__ invalidate a deserialized frontier, but is unable to due to the pruned Skyframe graph, and ultimately cause [stable inconsistent builds](https://bazel.build/run/build#build-consistency)
      
      This is implemented with the `--experimental_frontier_violation_check` flag and only triggers with `--experimental_remote_analysis_cache_mode=download`.
      
      The flag has 3 strictness levels:
      
      1) `strict`: **preferable if reverting the local changes is manageable**. Stop the build immediately and report which filesystem changes are affecting the build. Progress can only be made when the violating change is reverted, or with the `warn` option.
      2) `warn`: **preferable if reverting the local changes is undesirable**. Gracefully fallback to fully local evaluation by disabling analysis cache downloads, while warning the user which files are affecting the build. If there exists at least one remotely fetched analysis value in the Skyframe graph already, first invalidate all existing analysis and execution phase values, then continue the build without remote analysis caching.
      3) `disabled_for_testing`: do nothing. This is a test specific escape hatch.
      
      PiperOrigin-RevId: 702986396
      Change-Id: Ia031e57810bac8fae817d88640c44a4d1c47f307
      266dab6b
    • Bazel Release System's avatar
      Release 9.0.0-pre.20241125.3 (2024-12-04) · 3615f64a
      Bazel Release System authored
      Baseline: 7b20da28
      
      Cherry picks:
      
         + e27ab916:
           Automated rollback of commit
           3fdec931.
         + d699813b:
           Release 9.0.0-pre.20241125.3 (2024-12-04)
         + 0ee3d20d:
           Release 9.0.0-pre.20241125.3 (2024-12-04)
         + 08b47315:
           Release 9.0.0-pre.20241125.3 (2024-12-04)
         + 6c25f899:
           Release 9.0.0-pre.20241125.3 (2024-12-04)
      
      This release contains contributions from many people at Google, as well as .
      3615f64a
    • Bazel Release System's avatar
      Release 9.0.0-pre.20241125.3 (2024-12-04) · 23244dfc
      Bazel Release System authored
      Baseline: 7b20da28
      
      Cherry picks:
      
         + e27ab916:
           Automated rollback of commit
           3fdec931.
         + d699813b:
           Release 9.0.0-pre.20241125.3 (2024-12-04)
         + 0ee3d20d:
           Release 9.0.0-pre.20241125.3 (2024-12-04)
      
      This release contains contributions from many people at Google, as well as .
      23244dfc
    • Bazel Release System's avatar
      Release 9.0.0-pre.20241125.3 (2024-12-04) · f7d718fc
      Bazel Release System authored
      Baseline: 7b20da28
      
      Cherry picks:
      
         + e27ab916:
           Automated rollback of commit
           3fdec931.
      
      Important changes:
      
        - `archive_override` now accepts all attributes usable with
          `http_archive`; similar for `git_override` and `git_repository`.
        - Fixed an issue where `genquery` in external repos would evaluate
          labels as if they were in the main repo.
        - Re-enable symbolic macro attribute inheritance.
      
      This release contains contributions from many people at Google, as well as Fabian Meumertzheim, Jordan Mele, Simon Thornington, Ulrik Falklof, Xdng Yng, Xudong Yang.
      f7d718fc
    • Googler's avatar
      Support `PROJECT.scl` for projects with disjoint package paths. · 41557184
      Googler authored
      Example:
      ```
      foo project:
       - foo/...
       - tests/foo/...
       - third_party/foo/...
      ```
      
      A `PROJECT.scl` can *either* define canonical project data *OR*.exclusively declare:
      
      ```
      project = {
        "actual": "//foo:PROJECT.scl",
      }
      ```
      
      `$ bazel build //foo //bar` works if both `//foo` and `//bar` resolve to `PROJECT.scl`s that reference the same canonical `PROJECT.scl`.
      
      That means we can still only request targets from the same project in a single build.
      
      ## Also:
      
      Moved `getProjectFile` from `BuildTool` to `Project`. The original idea was that `Project` found matching `PROJECT.scl` files and `BuildTool` determined if the results could be properly built (i.e. all targets match to the same file).
      
      In practice I don't think those need to be separate logical concerns, so I just merged it all into `Project`.
      
      PiperOrigin-RevId: 702817985
      Change-Id: If0bf8865e9813b44db2d22e5ac77e539ad674458
      41557184
    • Googler's avatar
      Fixes a bug in implementation of Tarjan's SCC algorithm. · 3108031f
      Googler authored
      Tarjan's algorithm uses the traversal index, not the stack depth.
      
      PiperOrigin-RevId: 702737429
      Change-Id: I394897aa07512202ddbcf3f222bfe25abda87070
      3108031f
  6. Dec 04, 2024