This project is mirrored from https://github.com/bazelbuild/bazel.git.
Pull mirroring updated .
- Oct 19, 2023
-
-
salma-samy authored
This option can be used alongside any fetch operation to compel the fetching process. PiperOrigin-RevId: 574810048 Change-Id: I3df8fc18ac701cf0ca7a0ce68f1565fb064d59b5
-
salma-samy authored
PiperOrigin-RevId: 574440757 Change-Id: Ib37f1024709a5d604913088efdbfbd71d869d308
-
bazel.build machine account authored
The release includes native binaries such as `singlejar` and `ijar`, which benefit from being built with `-c opt`. Closes #19844. Commit https://github.com/bazelbuild/bazel/commit/92cf162b88f1b39b3b48d4ebee8e94cf10714953 PiperOrigin-RevId: 574373827 Change-Id: Iaf50289198a9cfa05f8389dc6b3ffefece6e9d16 Co-authored-by:
Fabian Meumertzheim <fabian@meumertzhe.im> Co-authored-by:
Ian (Hee) Cha <heec@google.com>
-
Ian (Hee) Cha authored
This allows a `java_binary` to be compiled for a platform with no registered C++ toolchain targets. Along the way removes unused parameters and outdated comments related to C++ toolchain resolution and usage in Java rules. Closes #19793. Commit https://github.com/bazelbuild/bazel/commit/9136223655214048a5be5a22fd90558b35fc2ca2 PiperOrigin-RevId: 574505206 Change-Id: I41e8249fb23d2005c4746e2647e02711cd27790d Co-authored-by:
Fabian Meumertzheim <fabian@meumertzhe.im>
-
bazel.build machine account authored
[7.0.0] ByteStreamBuildEventArtifactUploader: Treat test directory outputs like other directory outputs. (#19862) Fixes https://github.com/bazelbuild/bazel/issues/19847. Closes #19851. Commit https://github.com/bazelbuild/bazel/commit/5708f165f078893c5bca6054108485a59af663fb PiperOrigin-RevId: 574399055 Change-Id: I2d4cca1c70636b6f8f025a98ed5f0f19ae29bf47 Co-authored-by:
Benjamin Peterson <benjamin@engflow.com>
-
- Oct 18, 2023
-
-
bazel.build machine account authored
Working towards https://github.com/bazelbuild/continuous-integration/issues/1757. Closes #19866. Commit https://github.com/bazelbuild/bazel/commit/553c2bc904865fa94a9e077ac34d7d7147fa928d PiperOrigin-RevId: 574451509 Change-Id: I00bc491365a69558038293ad2035c5133da2059a Co-authored-by:
Chi Wang <chiwang@google.com>
-
Yun Peng authored
Cherry-picking two commits: --------- Stop removing add_opens and add_exports configurations See https://github.com/bazelbuild/bazel/issues/19850 PiperOrigin-RevId: 574291996 Change-Id: I4c2448876c8bc7cdc6dc3cc391556771b561610d --------- Drop testing on ubuntu 1804 (JDK 11) and add testing on ubuntu 2204 (JDK 17) According to https://wiki.ubuntu.com/Releases, ubuntu 1804 did reach end of standard support in June 2023. Tests failure with JDK 17 resolved in: https://github.com/bazelbuild/bazel/issues/19850 Related https://github.com/bazelbuild/continuous-integration/issues/1757 PiperOrigin-RevId: 574407319 Change-Id: I97bb500a401c1f6fd4a37e4a52fee622f9d22225 --------- Co-authored-by:
Googler <cushon@google.com>
-
bazel.build machine account authored
When an `sh_binary` is run directly from `bazel-bin`, its path won't be contained in the manifest and will not match a `bazel-out` regex. Instead, make the path absolute and then match after the `bazel-bin` to extract the binaries repository name. Also improve the error message when `runfiles_current_repository` can find neither the runfiles manifest nor the runfiles directory. Work towards fixing https://github.com/bazelbuild/bazel/pull/19796#discussion_r1358234830 Closes #19810. Commit https://github.com/bazelbuild/bazel/commit/58ce11244e475debf330abf282b5187172e28c36 PiperOrigin-RevId: 574208158 Change-Id: I45d6b503e8f34e13177d57ca64c202640306cfb8 Co-authored-by:
Fabian Meumertzheim <fabian@meumertzhe.im>
-
bazel.build machine account authored
If the allowlist is already present its value is respected (The package paths and label name are fixed/checked. Only repository name can be changed). Automatically add allowlist with tools repository as defined by rule definition environment. This fixes the incompatibility introduced in: https://github.com/bazelbuild/bazel/issues/19493 (because whilelist is ignored and default allowlist is added) Commit https://github.com/bazelbuild/bazel/commit/bb7fb2d32f055f2a70a5ab394cf5aef29bc74b2e PiperOrigin-RevId: 574226941 Change-Id: If90f78a610d7bd3c107dcd94a39902c7c939aa7b Co-authored-by:
Googler <ilist@google.com>
-
Ian (Hee) Cha authored
-
- Oct 17, 2023
-
-
Googler authored
When preparing an action for rewinding, evict it from the action cache to ensure that it is executed. PiperOrigin-RevId: 574158458 Change-Id: I82075f9a1a79cdd601ac6e0d2b3c17969dae81ca
-
John Cater authored
Fixes #16285. RELNOTES: Enable Platforms and Toolchains for Android. Android projects will need to stop passing the legacy flag `--fat_apk_cpu`, and instead use `--android_platforms` using platforms defined with the `@platforms//os:android` constraint. The https://github.com/bazelbuild/rules_android repository defines four standard Android platforms for projects that use those rules, `@rules_android//:armeabi-v7a`, `@rules_android//:arm64-v8a`, `@rules_android//:x86`, `@rules_android//:x86_64`. Blog post describing these changes to follow. Closes #19726. PiperOrigin-RevId: 574153852 Change-Id: Ief1e1be95fa03dd038a912dd318628ffdd562eaa
-
Googler authored
This follows the design document, allowing only extending aspects list and the default value. It would be less complex to implement `attr.override(aspects = ...)` and it could potentially solve problem of mixing new and overridden attributes. PiperOrigin-RevId: 574139579 Change-Id: I3261aacd9929a5d25039ba36301d20e8cefcd0bf
-
Googler authored
Set computed default to deps only when we need to propagate graph_node aspect. This change makes it possible to collapse cc_binary and cc_test into a single rule. PiperOrigin-RevId: 574139119 Change-Id: I58f54c87487387cf63658cde96f61a03a5e49876
-
Googler authored
This was already the case in another place of the same file, but not all. Failing to do so causes Bazel missing the action cache for CppCompileAction with sibling layout. Fixes #17819. PiperOrigin-RevId: 574134623 Change-Id: I602fc988ea6d066c394b2638c3084e5add08353d
-
Fabian Meumertzheim authored
Ensure that `BazelLockFileModule` only updates `MODULE.bazel.lock` if the content of the file needs to change. Every such update changes the file's metadata, which results in Skyframe invalidation of, in particular, all configurations. This broke `bazel config`, which uses `MemoizingEvaluator#getDoneValues()` to directly observe Skyframe state. Since this type of invalidation can also be caused by users and deviates from the usual "incremental correctness" guarantees provided by Bazel, let `config` show a descriptive error when no configurations are found. Fixes #19823 Closes #19842. PiperOrigin-RevId: 574133346 Change-Id: I5886c91fc6b7b938a7dee59ea75aa7b8afb5b161
-
Googler authored
Fixes https://github.com/bazelbuild/bazel/issues/19822 PiperOrigin-RevId: 574130268 Change-Id: Id4813b8a61edb2a25d223f0bb5727cf31b7ccc11
-
Googler authored
This was an oversight in https://github.com/bazelbuild/bazel/commit/5100d8716f4b9ce25db40c131a94f346055ca9cb. We're also not handling source directories correctly, but given their frowned-upon status, let's ignore it for now. I have a larger CL to make it impossible to misuse the LocalFile constructor (by passing in the Artifact and deriving the type from it), but it snowballed into a fairly large refactor, so I'd rather do it after Bazel 7 is cut. Fixes #19151. PiperOrigin-RevId: 574128307 Change-Id: Ib07150c6b900b1b99e683c8ce7b6cafe6da1500e
-
Googler authored
Rename ActionMetadataHandler to ActionOutputMetadataStore and ActionInputMetadataStore to ActionInputMetadataProvider. There are still bits and pieces that refer to "MetadataHandler" in some form in our test cases, but that's not a mechanical rename and it's fiddly so I'd rather do it separately (if ever) RELNOTES: None. PiperOrigin-RevId: 574113235 Change-Id: I86877e53866ad74ade24e419bfc10328c13f9a35
-
Googler authored
Partial roll forward of https://github.com/bazelbuild/bazel/commit/5ac62a2a5bfc04387d904f6ff1e74c6290bda9fd. Keep build_info api in cc_common, once android rules are released delete it. *** Original change description *** BEGIN_PUBLIC Switch Cpp `BuildInfo` system to new API. END_PUBLIC PiperOrigin-RevId: 574112862 Change-Id: I7cdc2a93499f3681bec9b5b03d0e11f84099cfa0
-
Googler authored
This type is currently only used at Google. Work towards enforcing the invariant that the OUTPUT, OUTPUT_FILE, OUTPUT_DIRECTORY and OUTPUT_SYMLINK types are used iff the output has an associated Artifact. PiperOrigin-RevId: 574112783 Change-Id: I8257f021784b604bd10cb202f6f0d4ccd8e161b1
-
John Cater authored
They are referred to within the repository, but since they are not defined the references fail and cause query failures. Closes #19835. PiperOrigin-RevId: 574109198 Change-Id: I892745101ffc63e3b59eae656996016a213bd121
-
Googler authored
Since the plan is to enable automatic-exec-groups globally (and is anyways enabled for all the rules that will use subrules to begin with), instead of introducing more parallel code paths, I think it makes sense to restrict toolchain usage in subrules to requiring automatic-exec-groups. PiperOrigin-RevId: 574096795 Change-Id: I331d46666be8f9e085051d43c387e78b5fa56d64
-
Googler authored
Hopefully resolve timeout failure of this test recently, for example https://buildkite.com/bazel/bazel-bazel/builds/25260 RELNOTES:None PiperOrigin-RevId: 574068852 Change-Id: Icfc6c3b1070634c379caa0ae333a769a1f2d1f55
-
Tim Peut authored
If the select() resolves to an empty list we will not include the proguard map in the dexing provider, so need to conditionally pull it from the optimization info provider. PiperOrigin-RevId: 574041946 Change-Id: Iff49d382abea4674e79938698b022079537fd633
-
Googler authored
Also adds a repeated `Any` field for strategies to report strategy-specific execution details. First commit addressing issue #19471. PiperOrigin-RevId: 573896902 Change-Id: I3d58cdfb503d552999c6261fc7fbd04c7d1de835
-
Googler authored
The final javacopts passed to `JavaBuilder`/`javac` is computed (in `java_common.compile`) by concatenating the following sets of options (in order): 1. The `javacopts` attribute on `java_toolchain` 2. The options provided with `--javacopt` on the commandline 3. The matching `compatible_javacopts` attribute on `java_toolchain` 4. The matching options from `java_toolchain.package_config` 5. The `javacopts` attribute on the `java_*` rule We already de-tokenize each of these sets into a single space-separated string before adding them to a `depset` (not doing so would mean `['-source', '8', '-target', '8', '-Xmx1G']` would result in getting back `['-source', '8', '-target', '-Xmx1G']` from the depset). In most cases, this de-tokenization is enough to ensure we get back the same set of options as we would if we stored them as a list. However, in the rare case that any of the above sets is *exactly* identical to another, it gets de-duped upon flattening. Since the right-most option should win, this change makes it so, that after de-duping, the right-most occurrence is preserved. A depset always performs left-to-right traversal, so all we need to do is add the above 5 sets of options in reverse order, and then reverse once more after flattening. PiperOrigin-RevId: 573895869 Change-Id: Id4758597e6d93fe5c71856a742915cafc1287a68
-
John Cater authored
We need this until #19829 is fixed. This should unblock #18262. Closes #19830. PiperOrigin-RevId: 573892609 Change-Id: I944901a2be6c5a0cb9279dc86edc0741f3129769
-
Googler authored
- keep only one function to get split prerequisites that returns `ConfiguredTargetAndData` and modify users to get `ConfiguredTarget` from it. - remove `getPrerequisiteMap()` PiperOrigin-RevId: 573886458 Change-Id: Ic4dbf5add0ccebd39e4c00492c4fd51d283d8f09
-
John Cater authored
Also add a note about how to update the lockfile. Closes #19796. PiperOrigin-RevId: 573850818 Change-Id: Iee09ccad949b692359f1280ee42cf6752e9bd5ac
-
Googler authored
Move this check to also cover native aspects evaluation, otherwise it evaluates the visibility of the tools of the underlying target rule against the target itself. PiperOrigin-RevId: 573850253 Change-Id: I69beb6542128338fe859d2978d29018731fc1258
-
Googler authored
Supporting this combination of features wouldn't be too hard - as far as I know, we'd just have to set up the `GraphInconsistencyReceiver` properly. However, we don't intend to run these features together yet, so might as well prohibit it until we need it. PiperOrigin-RevId: 573849045 Change-Id: I8bc91b9c5fa57b89b605fbe175755e945feb9e81
-
Googler authored
RELNOTES: None PiperOrigin-RevId: 573840190 Change-Id: I0b6055c73ba396609bf3403067848d13edf96120
-
Googler authored
Bazel tests status: - Bzlmod disabled: - AnalysisTestCase: to be migrated - ConfigurationTestCase: to be migrated - ConfigCommandTest: to be migrated, probably blocked by a bug - Bzlmod enabled: - BuildViewTestCase: migrated at https://github.com/bazelbuild/bazel/commit/d51144c811bc4360aad812deae557e7c7fc32fc2 - Java integration tests migrated at https://github.com/bazelbuild/bazel/commit/8d0471137361405d4903a9c24122b3cf327111b2 - Shell integration tests migrated at https://github.com/bazelbuild/bazel/commit/175a18dc9f58ba40e287336e06a26617a0becd0a (Bzlmod disabled in some tests) - Python integration tests migrated at https://github.com/bazelbuild/bazel/commit/50c8375982085d9cf80650a62ac7065ba5f46259 (Bzlmod disabled in some tests) - BuildIntegrationTestCase: migrated in this change - Other Java unit tests migrated in this change Issues identified: - cc_shared_library doesn't work well with Bzlmod: https://github.com/bazelbuild/bazel/issues/19822 - `bazel config` doesn't work well with Bzlmod: https://github.com/bazelbuild/bazel/issues/19823 Fixes https://github.com/bazelbuild/bazel/issues/18958 Tracking migration of remaining test cases in https://github.com/bazelbuild/bazel/issues/19824 RELNOTES[INC]: Bzlmod is enabled by default, please consider migrating your external dependencies from WORKSPACE to MODULE.bazel. Find more details at https://github.com/bazelbuild/bazel/issues/18958 PiperOrigin-RevId: 573827480 Change-Id: I097b4bd7caafc996b034284ee688b8f3d2bca1f7
-
- Oct 16, 2023
-
-
Ted Xie authored
PiperOrigin-RevId: 573823647 Change-Id: Ia0b5f521c5d329f33fd6fa780d79b87340c0d019
-
Fabian Meumertzheim authored
`PathMapper`s rewrite paths in command lines to make them more cache friendly, which requires executor support to stage files at the rewritten paths. This commit wires up the `PathMapper` used by a given `Spawn` in `RemoteExecutionService`, which ensures that paths of inputs and outputs are correctly mapped before being sent off to the remote executor and mapped back to the correct local paths when downloading the results. An end-to-end test will be added in #18155, but requires #19718, #19719, and #19721. Work towards #6526 Closes #19721. PiperOrigin-RevId: 573806130 Change-Id: Ibbd4ff641eb301d78f5ec54813e65788d786fcea
-
Googler authored
The former was very simple and had no uses other than through the latter so it was not a very useful abstraction. RELNOTES: None. PiperOrigin-RevId: 573800427 Change-Id: I33ff7fdc7044107f0c087384e1e1e2294059e107
-
Googler authored
Importantly, `java_plugin` was missing the attribute. PiperOrigin-RevId: 573799700 Change-Id: I31620dadbdf4c76777edd43b138f7b7c491b4670
-
Googler authored
RELNOTES: None. PiperOrigin-RevId: 573777234 Change-Id: I33bb1e44c959caa6e035a9be3ce218ffcaf05363
-
Googler authored
Thus, ActionMetadataHandler is not really an appropriate name anymore, but let's do the mechanical rename in a followup change (or else merge with OutputStore, I haven't quite decided yet) RELNOTES: None. PiperOrigin-RevId: 573775333 Change-Id: If27cc2699fa976b9d2979aff6f63a1e51c1d5a04
-