This project is mirrored from https://github.com/bazelbuild/bazel.git.
Pull mirroring updated .
- Oct 08, 2024
-
-
Fabian Meumertzheim authored
Adds support for spaces and newlines in source and target paths of runfiles symlinks to `build-runfiles` as well as to the Bash, C++, and Java runfiles libraries (the Python runfiles library has moved out of the repo). If a symlink has spaces or newlines in its source path, it is prefixed with a space in the manifest and spaces, newlines, and backslashes in the source path are escaped with `\s`, `\n`, and `\b` respectively. This scheme has been chosen as it has the following properties: 1. There is no change to the format of manifest lines for entries whose source and target paths don't contain a space. This ensures compatibility with existing runfiles libraries. 2. There is even no change to the format of manifest lines for entries whose target path contains spaces but whose source path does not. These manifests previously failed in `build-runfiles`, but were usable on Windows and supported by the official runfiles libraries. This also ensures that the initialization snippet for the Bash runfiles library doesn't need to change, even when used on Unix with a space in the output base path. 3. The scheme is fully reversible and only depends on the source path, which gives runfiles libraries a choice between reversing the escaping when parsing the manifest (C++, Java) or applying the escaping when searching the manifest (Bash). Fixes #4327 RELNOTES: Bazel now supports all characters in the rlocation and target paths of runfiles and can be run from workspaces with a space in their full path. Closes #23331. PiperOrigin-RevId: 683362776 Change-Id: I1eb79217dcd53cef0089d62a7ba477b1d8f52c21
-
Googler authored
Still used by apple_support Fix postsubmit breakage caused by https://github.com/bazelbuild/bazel/commit/1c4e78a9ceab9794140324d64833c628e382a3da: https://buildkite.com/bazel/bazel-bazel/builds/29644 PiperOrigin-RevId: 683346932 Change-Id: I6ff020a578920cb502527d0a9dc79f5c53cf2a93
-
Xavier Bonaventura authored
This PR is to flip the default value of `incompatible_disallow_empty_glob`. This flag is tracked in https://github.com/bazelbuild/bazel/issues/8195 and it is available since Bazel 0.29 from August 2019. Once this is merged, users still can allow empty globs without being explicit setting `--incompatible_disallow_empty_glob=false`. The motivation of the flip is https://github.com/bazel-contrib/SIG-rules-authors/issues/37 and the fact of not keeping an incompatible flag for 4 years without flipping it. What needs to be done before flipping this: - [x] Merge https://github.com/protocolbuffers/upb/pull/584 - [x] Update upb to a version that has the change in https://github.com/protocolbuffers/upb/pull/584 - [x] Merge https://github.com/protocolbuffers/upb/pull/745 - [x] Bring the changes from https://github.com/protocolbuffers/upb/pull/745 to the 21.x branch - [x] Bring the changes from https://github.com/protocolbuffers/upb/commit/e5f26018368b11aab672e8e8bb76513f3620c579 to the 21.x branch (https://github.com/protocolbuffers/upb/pull/781) - [x] Update upb to the latest commit of the 21.x branch (https://github.com/bazelbuild/bazel/pull/16343) - [x] Merge https://github.com/bazelbuild/bazel/pull/15374 - [x] Merge https://github.com/bazelbuild/bazel/pull/15339 - [x] Merge https://github.com/bazelbuild/bazel/pull/15330 - [x] Merge https://github.com/bazelbuild/bazel/pull/16431 - [x] Merge https://github.com/bazelbuild/bazel/pull/16468 - [x] Get green checks for this PR - [ ] Fix failures in downstream projects: https://buildkite.com/bazel/bazelisk-plus-incompatible-flags - [ ] Fix empty globs from IntellIJ Plugin (https://github.com/bazelbuild/intellij) - [ ] Issue: https://github.com/bazelbuild/intellij/issues/4040 - [ ] Android Studio Plugin - [ ] Android Studio Plugin Google - [ ] CLion Plugin - [ ] CLion Plugin Google - [ ] IntelliJ Plugin - [ ] IntelliJ Plugin Aspect - [ ] IntelliJ Plugin Aspect Google - [ ] IntelliJ Plugin Google - [ ] IntelliJ UE Plugin - [ ] IntelliJ UE Plugin Google - Opened PRs - [x] https://github.com/bazelbuild/intellij/pull/4025 - [x] https://github.com/bazelbuild/intellij/pull/4038 - [x] Fix empty globs from Bazel Bench (https://github.com/bazelbuild/bazel-bench) - [ ] https://github.com/bazelbuild/bazel-bench/pull/174 - [x] https://github.com/bazelbuild/bazel-bench/pull/149 - [x] Fix empty globs from Buildfarm (https://github.com/bazelbuild/bazel-buildfarm) - [x] Fix empty globs from Cargo - [x] ~~Fix empty globs from Cartographer (https://github.com/cartographer-project/cartographer)~~ (No longer maintained) - Issue: https://github.com/cartographer-project/cartographer/issues/1908 - PR to enforce it https://github.com/cartographer-project/cartographer/pull/1944 - [x] Fix empty globs from Cloud Robotics Core (https://github.com/googlecloudrobotics/core/) - [x] PR to prevent regresions https://github.com/googlecloudrobotics/core/pull/279 - [ ] Fix empty globs from Envoy - [x] Fix empty globs from FlatBuffers - [x] Fix empty globs from Flogger - [ ] Fix empty globs from Gerrit (https://gerrit.googlesource.com/gerrit.git) - Issue: https://issues.gerritcodereview.com/issues/40011754 - [x] Fix empty globs from :bazel:Protobuf - [x] Fix empty globs from rules_android_ndk - [ ] Fix empty globs from rules_dotnet - [x] Fix empty globs from :bazel:rules_foreign_cc https://github.com/bazelbuild/rules_foreign_cc/issues/974 - [x] Fix empty globs from rules_go - [x] Fix empty globs from rules_haskell https://github.com/tweag/rules_haskell/issues/1827 - [x] Fix empty globs from :bazel:rules_jvm_external - [x] Fix empty globs from rules_kotlin - [x] Fix empty globs from rules_nodejs - [x] Fix empty globs from :bazel:rules_python - [ ] Fix empty globs from rules_rust - [x] Fix empty globs from rules_swift - [x] Fix empty globs from rules_webtesting - [x] Fix empty globs from TensorFlow https://github.com/tensorflow/tensorflow/issues/58155 - [x] https://github.com/tensorflow/tensorflow/pull/58008 - [x] https://github.com/tensorflow/tensorflow/pull/58154 - [x] Fix empty globs from upb RELNOTES[INC]: The flag `--incompatible_disallow_empty_glob` now defaults to true. Closes #15327. PiperOrigin-RevId: 683316885 Change-Id: Id34ffd32a9e979fada9207e475b826a508100ba5
-
Googler authored
When --enforce_project_configs is enabled for a valid --scl_config, do not allow any other flags to be set in the user blazerc (~/.blazerc or --blazerc) or command line. PiperOrigin-RevId: 683295471 Change-Id: Ia707c2934ea34546fed3230acef62b504b24c8a2
-
Yun Peng authored
Fixes https://github.com/bazelbuild/bazel/issues/23809 Closes #23891. PiperOrigin-RevId: 683287734 Change-Id: I461eb49b58918cc174765af936f69de25406d8a2
-
hvd authored
Closes #23892. PiperOrigin-RevId: 683279958 Change-Id: I5c144e509ce1639c4f702f275ad1c0ac79c486cc
-
Googler authored
Downstream build: https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/4164 Downstream build shows that rules_android isn't quite yet ready, but I think it's better to enable the flag for Bazel 8 now, than to do an incompatible change later. PiperOrigin-RevId: 683271234 Change-Id: I4b1a8c5fe087f8dbf0742440d6af3c436bbf26d2
-
Keith Smiley authored
Fixes https://github.com/bazelbuild/bazel/issues/12716 Closes #23858. PiperOrigin-RevId: 683271198 Change-Id: I14d8c85e56e8a1069d4fe925d4eb78db8d8ff757
-
Fabian Meumertzheim authored
Verifies that runfiles middlemen artifacts in non-top-level nested sets are handled. Also makes the tests more realistic by ensuring that tools are always a subset of inputs. Related to #23884 Closes #23890. PiperOrigin-RevId: 683259163 Change-Id: Ic71377c069970038f20c0bd27bb7f719f3daef70
-
Maria authored
Closes #23625. PiperOrigin-RevId: 683255344 Change-Id: I7c6216660a638ff0e7737e3bd81afa16c1e3e6f1
-
Benjamin Peterson authored
You can figure out the target from the modified file usually, but why not include the label in the message, too? Closes #23854. PiperOrigin-RevId: 683252983 Change-Id: Ie40cadff52633208a90c6ff65534ed72d6711592
-
Googler authored
PiperOrigin-RevId: 683225064 Change-Id: I6f13f209c3aa5d7aa059447ee68982d616524bc4
-
Googler authored
Instead of constructing a `FilesetManifest`, callers use a `Visitor` that is invoked for every symlink in the fileset. This allows for an optimization: when the fileset has no relative symlinks (or we are ignoring relative symlinks), we can do a single-pass visitation without building up maps. Additionally, callers are responsible for concatenating the fileset-relative and execroot-relative paths to their roots. This reduces garbage from concatenating paths, since some callers don't need them. PiperOrigin-RevId: 683222046 Change-Id: I80f04306e7a617d3c3e630c56d96b2c968eb1d42
- Oct 07, 2024
-
-
Googler authored
PiperOrigin-RevId: 683179562 Change-Id: I7e0885e33b65dc5e24be705a676108c2aa3c8e9a
-
Googler authored
Kythe use @com_google_protobuf in their BUILD file while Bazel has renamed it to @protobuf. PiperOrigin-RevId: 683172653 Change-Id: I5122a31ff23175e8bd1ecfbe8d098cb5d3c4122f
-
Googler authored
It's needed for rules_java. PiperOrigin-RevId: 683146784 Change-Id: If48fd9b18b19c692a4f4b1a503a4118aa4f6dd20
-
Googler authored
PiperOrigin-RevId: 683140764 Change-Id: I7b62d23ff0e2acd888fbcee4ea43eec09b4d8ae3
-
Googler authored
PiperOrigin-RevId: 683140163 Change-Id: Ia0091cc690eb7cb1a68fc1f215834ede81af3fbf
-
Googler authored
PiperOrigin-RevId: 683139443 Change-Id: Ia58f22be486325a48233da7053a9cdc8cbc3289b
-
Googler authored
PiperOrigin-RevId: 683125706 Change-Id: I500bba9cd96a495720f2311e8de864b1e1f36b97
-
Googler authored
Dowstream tests: https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/4182 There are no apparent new failures related to this change in the downstream tests. But there's a lot of failures... PiperOrigin-RevId: 683121926 Change-Id: Ia0a0dda1ce31d660029eb4b9d07988ced62ec4af
-
CaerusKaru authored
Aspect Build supports remote cache and remote execution for self-hosting customers. Closes #22948. PiperOrigin-RevId: 683105675 Change-Id: I13377e36ea37358afafdc7b5cbbc9a7814fbe873
-
Googler authored
Fix Bazel build with Bazel@HEAD: https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/4181#019265b3-8ad1-45e3-b9a6-b32812ef6bfd PiperOrigin-RevId: 683102846 Change-Id: I62d9a103f4a349af57b8655695eb89c01aa54766
-
Googler authored
PiperOrigin-RevId: 683086079 Change-Id: I72baa602804202797410d67443ebf47a656e1a22
-
Googler authored
This is a blocker for removal of proto rules. Because of this dependency, not everything is loaded from rules repositories and java_tools's cc_proto_library in particular falls back to native rule. See: https://buildkite.com/bazel/google-bazel-presubmit/builds/84956 After the change we need java_tools and rules_java release. PiperOrigin-RevId: 683066764 Change-Id: Ic978dbb3058d60510f04021a278b6896f26bb754
-
Googler authored
PiperOrigin-RevId: 682998564 Change-Id: I20316c27050c97a0040953b0fd5b163adf30851f
-
Googler authored
PiperOrigin-RevId: 682997914 Change-Id: I30f5f9e752d1c91e16c838639790e90f3559b0f5
-
Googler authored
PiperOrigin-RevId: 682933226 Change-Id: If53f0bf4fd9ea5723602c0d4b5a2057909b4ac6d
-
Googler authored
Rollforward of https://github.com/bazelbuild/bazel/commit/af004d179abd31136978b9bbc37f13073f263fad: Remove Python native rule classes and py_runtime PiperOrigin-RevId: 682927198 Change-Id: If1b8e67dc72becdd703a8cfd911d543cc4095879
-
- Oct 06, 2024
-
-
Googler authored
- keeps the native stub definitions for now - cleanup of the rules & updating to rules_java v8.0.0 will be in a followup PiperOrigin-RevId: 682810444 Change-Id: I9dee6631697309af157655f0814532506e94cb2e
-
- Oct 05, 2024
-
-
Googler authored
Mechanical change that just adds `load()`s everywhere PiperOrigin-RevId: 682671088 Change-Id: I190d559accae12d71f5c510abc02d5d306a41b7b
-
Googler authored
Experimental flags that don't propagate to the exec configuration can create very surprising failure cases for both Bazel users and devs. Unless there is a valid reason to not propagate them, they should be. This is now enforced by a test and existing flags have been cleaned up where possible. The test strategy is the same as for `incompatible_` flags. Closes #23326. PiperOrigin-RevId: 682447129 Change-Id: I18d6f70301388afbab34884a813de8ac86dae3b7
-
Googler authored
PiperOrigin-RevId: 682441531 Change-Id: Ib4df7a8ca3068143392428963836fd48dee5d841
-
Googler authored
PiperOrigin-RevId: 682440906 Change-Id: I2fcf6454394f52d149d737eab9c66a740909d2de
-
Fabian Meumertzheim authored
Closes #23873. PiperOrigin-RevId: 682416574 Change-Id: I531cbdadac035bb14585eafe5be093823bca2214
-
Fabian Meumertzheim authored
Fixes #23861 RELNOTES[inc]: `repository_ctx.path()` and `module_ctx.path()` no longer watch arguments of type `Label`. Use the `watch()` method or the `watch` parameter on other methods on these context objects instead. See https://github.com/bazelbuild/bazel/issues/23861 for details. Closes #23872. PiperOrigin-RevId: 682413794 Change-Id: I22c9dd06b5c0f6c78302a28b52ca1f3e9a23507a
-
Googler authored
Now that WORKSPACE.bzlmod is completely empty. PiperOrigin-RevId: 682409800 Change-Id: I4412c6fc7d68524bf287afc31d5116d8b23607f0
-
Googler authored
PiperOrigin-RevId: 682384779 Change-Id: I69f006fae4f4335dc94ccd1a76c6bb1d49c2c3d3
-
Googler authored
*** Reason for rollback *** Breaks many targets in the depot that use the native python rules. *** Original change description *** Remove Python native rule classes and py_runtime PiperOrigin-RevId: 682373910 Change-Id: Ib874b62ff5f3fbf0899a6990d970b04b87dd9d93
-