feat: add signal option to dialog.showMessageBox (#26102)
* mac: add dialog.closeMessageBox API * win: Implement dialog.closeMessageBox * mac: Return cancelId with closeMessageBox * gtk: Implement dialog.closeMessageBox * win: Fix 32bit build * win: Reduce the scope of lock * fix: Build error after rebase * feat: Use AbortSignal to close message box * chore: silently handle duplicate ID * win: Add more notes about the threads * chore: apply reviews * fix: base::NoDestructor should be warpped in function * chore: fix style on windows
Showing
- docs/api/dialog.md 7 additions, 0 deletionsdocs/api/dialog.md
- lib/browser/api/dialog.ts 17 additions, 0 deletionslib/browser/api/dialog.ts
- shell/browser/api/electron_api_dialog.cc 1 addition, 0 deletionsshell/browser/api/electron_api_dialog.cc
- shell/browser/ui/message_box.h 4 additions, 3 deletionsshell/browser/ui/message_box.h
- shell/browser/ui/message_box_gtk.cc 31 additions, 2 deletionsshell/browser/ui/message_box_gtk.cc
- shell/browser/ui/message_box_mac.mm 34 additions, 0 deletionsshell/browser/ui/message_box_mac.mm
- shell/browser/ui/message_box_win.cc 122 additions, 16 deletionsshell/browser/ui/message_box_win.cc
- shell/common/gin_converters/message_box_converter.cc 3 additions, 2 deletionsshell/common/gin_converters/message_box_converter.cc
- spec-main/api-dialog-spec.ts 57 additions, 1 deletionspec-main/api-dialog-spec.ts
Please register or sign in to comment