Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
E
electron
Manage
Activity
Members
Labels
Plan
Issues
0
Issue boards
Milestones
Wiki
Requirements
Code
Merge requests
0
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Package Registry
Container Registry
Operate
Environments
Terraform modules
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
ExcellentOSS
electron
Commits
d3967171
Unverified
Commit
d3967171
authored
11 months ago
by
trop[bot]
Committed by
GitHub
11 months ago
Browse files
Options
Downloads
Patches
Plain Diff
refactor: simplify KeyWeakMap impl
Co-authored-by:
Charles Kerr
<
charles@charleskerr.com
>
parent
44e57c6c
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
shell/common/key_weak_map.h
+20
-28
20 additions, 28 deletions
shell/common/key_weak_map.h
with
20 additions
and
28 deletions
shell/common/key_weak_map.h
+
20
−
28
View file @
d3967171
...
@@ -6,9 +6,9 @@
...
@@ -6,9 +6,9 @@
#define ELECTRON_SHELL_COMMON_KEY_WEAK_MAP_H_
#define ELECTRON_SHELL_COMMON_KEY_WEAK_MAP_H_
#include
<unordered_map>
#include
<unordered_map>
#include
<utility>
#include
<vector>
#include
<vector>
#include
"base/containers/to_vector.h"
#include
"base/memory/raw_ptr.h"
#include
"base/memory/raw_ptr.h"
#include
"v8/include/v8.h"
#include
"v8/include/v8.h"
...
@@ -18,10 +18,10 @@ namespace electron {
...
@@ -18,10 +18,10 @@ namespace electron {
template
<
typename
K
>
template
<
typename
K
>
class
KeyWeakMap
{
class
KeyWeakMap
{
public:
public:
KeyWeakMap
()
{}
KeyWeakMap
()
=
default
;
~
KeyWeakMap
()
{
~
KeyWeakMap
()
{
for
(
auto
&
p
:
map_
)
for
(
auto
&
p
:
map_
)
p
.
second
.
second
.
ClearWeak
();
p
.
second
.
value
.
ClearWeak
();
}
}
// disable copy
// disable copy
...
@@ -29,55 +29,47 @@ class KeyWeakMap {
...
@@ -29,55 +29,47 @@ class KeyWeakMap {
KeyWeakMap
&
operator
=
(
const
KeyWeakMap
&
)
=
delete
;
KeyWeakMap
&
operator
=
(
const
KeyWeakMap
&
)
=
delete
;
// Sets the object to WeakMap with the given |key|.
// Sets the object to WeakMap with the given |key|.
void
Set
(
v8
::
Isolate
*
isolate
,
const
K
&
key
,
v8
::
Local
<
v8
::
Object
>
object
)
{
void
Set
(
v8
::
Isolate
*
isolate
,
const
K
&
key
,
v8
::
Local
<
v8
::
Object
>
value
)
{
KeyObject
key_object
=
{
key
,
this
};
auto
&
mapped
=
map_
[
key
]
=
auto
&
p
=
map_
[
key
]
=
Mapped
{
this
,
key
,
v8
::
Global
<
v8
::
Object
>
(
isolate
,
value
)};
std
::
make_pair
(
key_object
,
v8
::
Global
<
v8
::
Object
>
(
isolate
,
object
));
mapped
.
value
.
SetWeak
(
&
mapped
,
OnObjectGC
,
v8
::
WeakCallbackType
::
kParameter
);
p
.
second
.
SetWeak
(
&
(
p
.
first
),
OnObjectGC
,
v8
::
WeakCallbackType
::
kParameter
);
}
}
// Gets the object from WeakMap by its |key|.
// Gets the object from WeakMap by its |key|.
v8
::
MaybeLocal
<
v8
::
Object
>
Get
(
v8
::
Isolate
*
isolate
,
const
K
&
key
)
{
v8
::
MaybeLocal
<
v8
::
Object
>
Get
(
v8
::
Isolate
*
isolate
,
const
K
&
key
)
{
if
(
auto
iter
=
map_
.
find
(
key
);
iter
!=
map_
.
end
())
if
(
auto
iter
=
map_
.
find
(
key
);
iter
!=
map_
.
end
())
return
v8
::
Local
<
v8
::
Object
>::
New
(
isolate
,
iter
->
second
.
second
);
return
v8
::
Local
<
v8
::
Object
>::
New
(
isolate
,
iter
->
second
.
value
);
return
{};
return
{};
}
}
// Returns all objects.
// Returns all objects.
std
::
vector
<
v8
::
Local
<
v8
::
Object
>>
Values
(
v8
::
Isolate
*
isolate
)
const
{
std
::
vector
<
v8
::
Local
<
v8
::
Object
>>
Values
(
v8
::
Isolate
*
isolate
)
const
{
std
::
vector
<
v8
::
Local
<
v8
::
Object
>>
values
;
return
base
::
ToVector
(
map_
,
[
isolate
](
const
auto
&
iter
)
{
values
.
reserve
(
map_
.
size
());
return
v8
::
Local
<
v8
::
Object
>::
New
(
isolate
,
iter
.
second
.
value
);
for
(
const
auto
&
it
:
map_
)
});
values
.
emplace_back
(
v8
::
Local
<
v8
::
Object
>::
New
(
isolate
,
it
.
second
.
second
));
return
values
;
}
}
// Remove object with |key| in the WeakMap.
// Remove object with |key| in the WeakMap.
void
Remove
(
const
K
&
key
)
{
void
Remove
(
const
K
&
key
)
{
auto
iter
=
map_
.
find
(
key
);
if
(
auto
item
=
map_
.
extract
(
key
))
if
(
iter
==
map_
.
end
())
item
.
mapped
().
value
.
ClearWeak
();
return
;
iter
->
second
.
second
.
ClearWeak
();
map_
.
erase
(
iter
);
}
}
private
:
private
:
// Records the key and self, used by SetWeak.
// Records the key and self, used by SetWeak.
struct
KeyObject
{
struct
Mapped
{
K
key
;
raw_ptr
<
KeyWeakMap
>
self
;
raw_ptr
<
KeyWeakMap
>
self
;
K
key
;
v8
::
Global
<
v8
::
Object
>
value
;
};
};
static
void
OnObjectGC
(
static
void
OnObjectGC
(
const
v8
::
WeakCallbackInfo
<
Mapped
>&
data
)
{
const
v8
::
WeakCallbackInfo
<
typename
KeyWeakMap
<
K
>::
KeyObject
>&
data
)
{
auto
*
mapped
=
data
.
GetParameter
();
KeyWeakMap
<
K
>::
KeyObject
*
key_object
=
data
.
GetParameter
();
mapped
->
self
->
Remove
(
mapped
->
key
);
key_object
->
self
->
Remove
(
key_object
->
key
);
}
}
// Map of stored objects.
// Map of stored objects.
std
::
unordered_map
<
K
,
std
::
pair
<
KeyObject
,
v8
::
Global
<
v8
::
Object
>>
>
map_
;
std
::
unordered_map
<
K
,
Mapped
>
map_
;
};
};
}
// namespace electron
}
// namespace electron
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment