Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
E
electron
Manage
Activity
Members
Labels
Plan
Issues
0
Issue boards
Milestones
Wiki
Requirements
Code
Merge requests
0
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Package Registry
Container Registry
Operate
Environments
Terraform modules
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
ExcellentOSS
electron
Commits
f0836747
Unverified
Commit
f0836747
authored
10 months ago
by
trop[bot]
Committed by
GitHub
10 months ago
Browse files
Options
Downloads
Patches
Plain Diff
build: split darwin/mas macOS publish jobs
Co-authored-by:
Samuel Attard
<
samuel.r.attard@gmail.com
>
parent
cece3555
Branches
trop/30-x-y-bp-build-split-darwin-mas-macos-publish-jobs-1726612374702
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
.github/workflows/macos-publish.yml
+34
-2
34 additions, 2 deletions
.github/workflows/macos-publish.yml
.github/workflows/pipeline-segment-electron-build.yml
+7
-2
7 additions, 2 deletions
.github/workflows/pipeline-segment-electron-build.yml
with
41 additions
and
4 deletions
.github/workflows/macos-publish.yml
+
34
−
2
View file @
f0836747
...
...
@@ -40,7 +40,7 @@ jobs:
with
:
generate-sas-token
:
'
true'
publish-x64
:
publish-x64
-darwin
:
uses
:
./.github/workflows/pipeline-segment-electron-build.yml
needs
:
checkout-macos
with
:
...
...
@@ -48,13 +48,44 @@ jobs:
build-runs-on
:
macos-14-xlarge
target-platform
:
macos
target-arch
:
x64
target-variant
:
darwin
is-release
:
true
gn-build-type
:
release
generate-symbols
:
true
upload-to-storage
:
${{ inputs.upload-to-storage }}
secrets
:
inherit
publish-arm64
:
publish-x64-mas
:
uses
:
./.github/workflows/pipeline-segment-electron-build.yml
needs
:
checkout-macos
with
:
environment
:
production-release
build-runs-on
:
macos-14-xlarge
target-platform
:
macos
target-arch
:
x64
target-variant
:
mas
is-release
:
true
gn-build-type
:
release
generate-symbols
:
true
upload-to-storage
:
${{ inputs.upload-to-storage }}
secrets
:
inherit
publish-arm64-darwin
:
uses
:
./.github/workflows/pipeline-segment-electron-build.yml
needs
:
checkout-macos
with
:
environment
:
production-release
build-runs-on
:
macos-14-xlarge
target-platform
:
macos
target-arch
:
arm64
target-variant
:
darwin
is-release
:
true
gn-build-type
:
release
generate-symbols
:
true
upload-to-storage
:
${{ inputs.upload-to-storage }}
secrets
:
inherit
publish-arm64-mas
:
uses
:
./.github/workflows/pipeline-segment-electron-build.yml
needs
:
checkout-macos
with
:
...
...
@@ -62,6 +93,7 @@ jobs:
build-runs-on
:
macos-14-xlarge
target-platform
:
macos
target-arch
:
arm64
target-variant
:
mas
is-release
:
true
gn-build-type
:
release
generate-symbols
:
true
...
...
This diff is collapsed.
Click to expand it.
.github/workflows/pipeline-segment-electron-build.yml
+
7
−
2
View file @
f0836747
...
...
@@ -15,6 +15,10 @@ on:
type
:
string
description
:
'
Arch
to
build
for,
can
be
x64,
arm64
or
arm'
required
:
true
target-variant
:
type
:
string
description
:
'
Variant
to
build
for,
no
effect
on
non-macOS
target
platforms.
Can
be
darwin,
mas
or
all.'
default
:
all
build-runs-on
:
type
:
string
description
:
'
What
host
to
run
the
build'
...
...
@@ -188,6 +192,7 @@ jobs:
if
:
${{ inputs.target-platform == 'macos' }}
uses
:
./src/electron/.github/actions/free-space-macos
-
name
:
Build Electron
if
:
${{ inputs.target-platform != 'macos' || (inputs.target-variant == 'all' || inputs.target-variant == 'darwin') }}
uses
:
./src/electron/.github/actions/build-electron
with
:
target-arch
:
${{ inputs.target-arch }}
...
...
@@ -199,13 +204,13 @@ jobs:
upload-to-storage
:
'
${{
inputs.upload-to-storage
}}'
is-asan
:
'
${{
inputs.is-asan
}}'
-
name
:
Set GN_EXTRA_ARGS for MAS Build
if
:
${{ inputs.target-platform == 'macos' }}
if
:
${{ inputs.target-platform == 'macos'
&& (inputs.target-variant == 'all' || inputs.target-variant == 'mas')
}}
run
:
|
echo "MAS_BUILD=true" >> $GITHUB_ENV
GN_EXTRA_ARGS='is_mas_build=true'
echo "GN_EXTRA_ARGS=$GN_EXTRA_ARGS" >> $GITHUB_ENV
-
name
:
Build Electron (MAS)
if
:
${{ inputs.target-platform == 'macos' }}
if
:
${{ inputs.target-platform == 'macos'
&& (inputs.target-variant == 'all' || inputs.target-variant == 'mas')
}}
uses
:
./src/electron/.github/actions/build-electron
with
:
target-arch
:
${{ inputs.target-arch }}
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment