Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
E
electron
Manage
Activity
Members
Labels
Plan
Issues
0
Issue boards
Milestones
Wiki
Requirements
Code
Merge requests
0
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Package Registry
Container Registry
Operate
Environments
Terraform modules
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
ExcellentOSS
electron
Commits
f53397ad
Unverified
Commit
f53397ad
authored
6 months ago
by
VerteDinde
Browse files
Options
Downloads
Patches
Plain Diff
build: re-enable thin LTO Mac
parent
a15e42e9
Branches
re-enable-thin-lto-node-22
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
patches/chromium/.patches
+0
-1
0 additions, 1 deletion
patches/chromium/.patches
patches/chromium/build_disable_thin_lto_mac.patch
+0
-25
0 additions, 25 deletions
patches/chromium/build_disable_thin_lto_mac.patch
with
0 additions
and
26 deletions
patches/chromium/.patches
+
0
−
1
View file @
f53397ad
...
...
@@ -134,4 +134,3 @@ feat_allow_usage_of_sccontentsharingpicker_on_supported_platforms.patch
chore_partial_revert_of.patch
fix_software_compositing_infinite_loop.patch
refactor_unfilter_unresponsive_events.patch
build_disable_thin_lto_mac.patch
This diff is collapsed.
Click to expand it.
patches/chromium/build_disable_thin_lto_mac.patch
deleted
100644 → 0
+
0
−
25
View file @
a15e42e9
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
From: VerteDinde <vertedinde@electronjs.org>
Date: Tue, 12 Nov 2024 21:16:15 -0800
Subject: build: disable thin_lto on mac
This patch disables thin lto on mac only. After Node 22 was merged into
main, release builds began failing due to missing symbols, which seem to
be being stripped out by thin lto.
This patch can (and should) be removed when we can prevent those symbols
from being stripped in the release build.
diff --git a/build/config/compiler/compiler.gni b/build/config/compiler/compiler.gni
index ac5ce5e5d80facc0bbafe51ced9aba53a8fb0c04..6c457c4e63c4024490b47aaf29dfbbab83bf6f5e 100644
--- a/build/config/compiler/compiler.gni
+++ b/build/config/compiler/compiler.gni
@@ -86,7 +86,7 @@
declare_args() {
# have the same LLVM revisions as us, making bitcode useless to them.
use_thin_lto =
is_cfi || (is_clang && is_official_build && chrome_pgo_phase != 1 &&
- (is_linux || is_win || is_mac ||
+ (is_linux || is_win ||
(is_ios && use_lld && !is_cronet_build) ||
(is_android && target_os != "chromeos") ||
(is_chromeos && is_chromeos_device)))
This diff is collapsed.
Click to expand it.
Preview
0%
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment