This project is mirrored from https://github.com/electron/electron.git.
Pull mirroring failed .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer or owner.
Last successful update .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer or owner.
Last successful update .
- Jan 26, 2021
-
-
Electron Bot authored
-
Electron Bot authored
Co-authored-by:
Shelley Vohr <shelley.vohr@gmail.com>
-
Milan Burda authored
-
Milan Burda authored
-
- Jan 25, 2021
-
-
Electron Bot authored
-
Milan Burda authored
-
Milan Burda authored
-
Milan Burda authored
-
Zhang Zhi authored
-
Charles Kerr authored
* fix: do not throw if NativeImage conversion fails. Throwing is an unannounced semver/major breaking change, so revert that behavior but keep the rest of the #26546 refactor. * test: add invalid icon test * refactor: be explicit about when to throw or warn.
-
Shelley Vohr authored
-
- Jan 23, 2021
-
-
Cheng Zhao authored
-
Milan Burda authored
-
- Jan 22, 2021
-
-
Electron Bot authored
-
John Kleinschmidt authored
* ci: enable arm64 macOS tests
-
Michaela Laurencin authored
-
Electron Bot authored
-
Shelley Vohr authored
-
- Jan 21, 2021
-
-
Electron Bot authored
This reverts commit 09b6db46.
-
Electron Bot authored
-
Electron Bot authored
This reverts commit 299bc9ad.
-
Electron Bot authored
-
John Kleinschmidt authored
This reverts commit 6d6a7859.
-
Electron Bot authored
-
renmu123 authored
* docs: change semver to SemVer * docs: add a Period * docs: udpate a broken relative link * docs: update the links * docs: update the links
-
John Kleinschmidt authored
-
Milan Burda authored
-
Biru Mohanathas authored
The call stack for one of our top crashes looks like this: ``` node::Abort (node_errors.cc:241) node::Assert (node_errors.cc:256) node::MakeCallback (callback.cc:226) gin_helper::internal::CallMethodWithArgs (event_emitter_caller.cc:23) gin_helper::EmitEvent<T> (event_emitter_caller.h:51) gin_helper::EventEmitterMixin<T>::Emit<T> (event_emitter_mixin.h:81) electron::api::DownloadItem::OnDownloadUpdated (electron_api_download_item.cc:115) download::DownloadItemImpl::UpdateObservers (download_item_impl.cc:482) content::DownloadManagerImpl::Shutdown (download_manager_impl.cc:508) content::BrowserContext::~BrowserContext (browser_context.cc:476) ``` Full stack here: https://sentry.io/share/issue/9b030a0601b547188181b543c16ecda2/ During browser shutdown, the `DownloadManager` was being cleaned up *after* the Node environment had already been destroyed. This caused the `DownloadItem::OnDownloadUpdated` callback to crash when trying to emit the JS `done` event. To prevent this, we now manually shut down the `DownloadManager` earlier. This is also mentioned in the comment on `DownloadManager::Shutdown`: ``` // Shutdown the download manager. Content calls this when BrowserContext is // being destructed. If the embedder needs this to be called earlier, it can // call it. In that case, the delegate's Shutdown() method will only be called // once. ```
-
Chris Hartgerink authored
Corrects minor typo
-
John Kleinschmidt authored
This reverts commit e4fc47f5.
-
- Jan 20, 2021
-
-
Electron Bot authored
-
Robo authored
-
Shelley Vohr authored
-
- Jan 19, 2021
-
-
Electron Bot authored
-
Electron Bot authored
This reverts commit 9a336a6a.
-
Electron Bot authored
-
Cheng Zhao authored
-
David Sanders authored
* fix: improve redirect behavior in protocol module * Add test for redirection Co-authored-by:
Cheng Zhao <zcbenz@gmail.com>
-
Samuel Maddock authored
* fix: prevent crash when destroyed widget receives keyboard event Activating a key to close a window will cause a silent crash. Handling the keyboard event will lead to a nullptr dereferenced in Chromium code if the window widget has already been destroyed. * test: ensure BrowserWindow doesn't crash from keyboard events during close
-
riccardopiola authored
* fix duplicate symbols in component build * fix: duplicate symbols for mojom interfaces in component build
-