This project is mirrored from https://github.com/electron/electron.git.
Pull mirroring failed .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer or owner.
Last successful update .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer or owner.
Last successful update .
- Jan 25, 2024
-
-
trop[bot] authored
`delegated_frame_host_` holds a pointer to `delegated_frame_host_client_`. Since `delegated_frame_host_client_` was being destroyed first, that pointer was dangling in the OSRWHV destructor. Also, make these two unique_ptr fields `const` since they point to the same objects for the lifespan of the OSRWHV. Co-authored-by:
trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by:
Charles Kerr <charles@charleskerr.com>
-
trop[bot] authored
Co-authored-by:
trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by:
Max Schmitt <max@schmitt.mx>
-
trop[bot] authored
reset spawnedProcess instance in case of error Co-authored-by:
trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by:
Maikel Ortega Hernandez <maikeloh@gmail.com>
-
trop[bot] authored
* fix: draggable regions not working Co-authored-by:
Shelley Vohr <shelley.vohr@gmail.com> * fix: only support app regions for main frame Co-authored-by:
deepak1556 <hop2deep@gmail.com> --------- Co-authored-by:
trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by:
Shelley Vohr <shelley.vohr@gmail.com> Co-authored-by:
deepak1556 <hop2deep@gmail.com>
-
trop[bot] authored
Co-authored-by:
trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by:
Cheng Zhao <zcbenz@gmail.com>
-
trop[bot] authored
* refactor: do not use banned std::to_string() in ServiceWorkerContext::GetAllRunningWorkerInfo() Co-authored-by:
Charles Kerr <charles@charleskerr.com> * refactor: do not use banned std::to_string() in REPORT_AND_RETURN_IF_FAILED() Co-authored-by:
Charles Kerr <charles@charleskerr.com> * refactor: do not use banned std::to_string() in JSChunkedDataPipeGetter::OnWriteChunkComplete() Co-authored-by:
Charles Kerr <charles@charleskerr.com> * refactor: do not use banned std::to_string() in SetCrashKey() Co-authored-by:
Charles Kerr <charles@charleskerr.com> * chore: remove unused #include Co-authored-by:
Charles Kerr <charles@charleskerr.com> * fixup! refactor: do not use banned std::to_string() in REPORT_AND_RETURN_IF_FAILED() Co-authored-by:
Charles Kerr <charles@charleskerr.com> --------- Co-authored-by:
trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by:
Charles Kerr <charles@charleskerr.com>
-
Shelley Vohr authored
-
- Jan 24, 2024
-
-
Milan Burda authored
chore: replace absl::optional<T> with std::optional<T> (#40928)
-
trop[bot] authored
* fix: ElectronBrowserContext::PartitionKey comparisons Use c++20 default comparisons to simplify + fix PartitionKey sorting: - The equality operator is broken. `PartitionKey{"foo", false}` is both equal, to and less than, `PartitionKey{"foo", true}` - For some keys, the same session can be retrieved via both `fromPath()` and `fromPartition()`. This use case was discussed and removed from the original PR after code review said "always returning different sessions feels lower maintenance." The current behavior is a bug that comes from the comparison operators not checking the keys' types. Xref: https://github.com/electron/electron/pull/36728/commits/3f1aea9af91e17b2605eb8a5837bbb81888d76da#r1099745359 Xref: https://chromium.googlesource.com/chromium/src/+/main/styleguide/c++/c++-features.md#Default-comparisons-allowed Co-authored-by:
Charles Kerr <charles@charleskerr.com> * fixup! fix: ElectronBrowserContext::PartitionKey comparisons Co-authored-by:
Charles Kerr <charles@charleskerr.com> --------- Co-authored-by:
trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by:
Charles Kerr <charles@charleskerr.com>
-
- Jan 23, 2024
-
-
trop[bot] authored
* docs: fixed typos Co-authored-by:
Villy-P <valeriuspetrini@gmail.com> * Update docs/tutorial/performance.md Co-authored-by:
Keeley Hammond <vertedinde@electronjs.org> Co-authored-by:
Valerius Petrini <112593680+Villy-P@users.noreply.github.com> * Update performance.md Co-authored-by:
Valerius Petrini <112593680+Villy-P@users.noreply.github.com> --------- Co-authored-by:
trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by:
Villy-P <valeriuspetrini@gmail.com> Co-authored-by:
Valerius Petrini <112593680+Villy-P@users.noreply.github.com>
-
Keeley Hammond authored
Revert "feat: replace BrowserView with WebContentsView (#40759)" This reverts commit bd304f7c.
-
- Jan 19, 2024
-
-
trop[bot] authored
* chore: cleanup tests creating crashpad handler in the test runner process Co-authored-by:
deepak1556 <hop2deep@gmail.com> * ci: logging Co-authored-by:
deepak1556 <hop2deep@gmail.com> * ci: enable logging Co-authored-by:
deepak1556 <hop2deep@gmail.com> * ci: more logging Co-authored-by:
deepak1556 <hop2deep@gmail.com> * ci: run all tests Co-authored-by:
deepak1556 <hop2deep@gmail.com> * ci: more logging Co-authored-by:
deepak1556 <hop2deep@gmail.com> * ci: increase timeout Co-authored-by:
deepak1556 <hop2deep@gmail.com> * Revert "ci: increase timeout" This reverts commit 870f7445 . Co-authored-by:
deepak1556 <hop2deep@gmail.com> * Revert "ci: more logging" This reverts commit 46837f8b . Co-authored-by:
deepak1556 <hop2deep@gmail.com> * Revert "ci: run all tests" This reverts commit 6a7889ce . Co-authored-by:
deepak1556 <hop2deep@gmail.com> * Revert "ci: more logging" This reverts commit 351473ab . Co-authored-by:
deepak1556 <hop2deep@gmail.com> * Revert "ci: enable logging" This reverts commit 194109ed . Co-authored-by:
deepak1556 <hop2deep@gmail.com> * Revert "ci: logging" This reverts commit 9a3396fc . Co-authored-by:
deepak1556 <hop2deep@gmail.com> * chore: disable flaky ia32 tests Co-authored-by:
deepak1556 <hop2deep@gmail.com> * chore: fixup .patches after trop --------- Co-authored-by:
trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by:
deepak1556 <hop2deep@gmail.com> Co-authored-by:
John Kleinschmidt <jkleinsc@electronjs.org>
-
trop[bot] authored
* fix: crash when dialog.showMessageBoxSync missing buttons Co-authored-by:
Shelley Vohr <shelley.vohr@gmail.com> * chore: feedback from review Co-authored-by:
Shelley Vohr <shelley.vohr@gmail.com> --------- Co-authored-by:
trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by:
Shelley Vohr <shelley.vohr@gmail.com>
-
trop[bot] authored
* chore: fixup assertNotWindows Co-authored-by:
John Kleinschmidt <jkleinsc@electronjs.org> * remove logging Co-authored-by:
John Kleinschmidt <jkleinsc@electronjs.org> --------- Co-authored-by:
trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by:
John Kleinschmidt <jkleinsc@electronjs.org>
-
trop[bot] authored
* refactor: do not use deprecated ToInternalValue() in ElectronExtensionLoader::FinishExtensionLoad() Co-authored-by:
Charles Kerr <charles@charleskerr.com> * refactor: do not use deprecated ToInternalValue() in NotificationPresenterWin::SaveIconToFilesystem() Co-authored-by:
Charles Kerr <charles@charleskerr.com> * chore: rename temp variable to now_usec for clarity Co-authored-by:
Charles Kerr <charles@charleskerr.com> --------- Co-authored-by:
trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by:
Charles Kerr <charles@charleskerr.com>
-
- Jan 18, 2024
-
-
trop[bot] authored
fix: use `HasStyleMask(NSWindowStyleMaskResizable)` instead of `IsResizable()` for enabling/disabling window maximize button (#41029) * fix: use `HasStyleMask(NSWindowStyleMaskResizable)` instead of `IsResizable()` for enabling/disabling window maximize button Co-authored-by:
Tamás Zahola <tzahola@gmail.com> * Format Co-authored-by:
Tamás Zahola <tzahola@gmail.com> --------- Co-authored-by:
trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by:
Tamás Zahola <tzahola@gmail.com>
-
trop[bot] authored
* fix: modal rounding on nonmodal windows Co-authored-by:
Shelley Vohr <shelley.vohr@gmail.com> * chore: feedback from review Co-authored-by:
Shelley Vohr <shelley.vohr@gmail.com> --------- Co-authored-by:
trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by:
Shelley Vohr <shelley.vohr@gmail.com>
-
- Jan 17, 2024
-
-
trop[bot] authored
* refactor: use NoDestructor for g_io_thread_application_locale Co-authored-by:
Charles Kerr <charles@charleskerr.com> * refactor: use NoDestructor for ExtensionActionAPI::GetFactoryInstance() Co-authored-by:
Charles Kerr <charles@charleskerr.com> * refactor: use NoDestructor for ElectronExtensionsClient::GetPermissionMessageProvider() Co-authored-by:
Charles Kerr <charles@charleskerr.com> * refactor: use NoDestructor for feat_add_support_for_overriding_the_base_spellchecker_download_url.patch Co-authored-by:
Charles Kerr <charles@charleskerr.com> * chore: remove unused #include Co-authored-by:
Charles Kerr <charles@charleskerr.com> * fixup! refactor: use NoDestructor for ElectronExtensionsClient::GetPermissionMessageProvider() make sure instance is static Co-authored-by:
Charles Kerr <charles@charleskerr.com> * chore: remove unused #include "base/lazy_instance.h" Co-authored-by:
Charles Kerr <charles@charleskerr.com> --------- Co-authored-by:
trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by:
Charles Kerr <charles@charleskerr.com>
-
trop[bot] authored
* refactor: replace deprecated Base64Encode() usage in IWC::NetworkResourceLoader::OnDataReceived() Co-authored-by:
Charles Kerr <charles@charleskerr.com> * refactor: replace deprecated Base64Encode() usage EncodeToken(const base::UnguessableToken& token) Co-authored-by:
Charles Kerr <charles@charleskerr.com> --------- Co-authored-by:
trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by:
Charles Kerr <charles@charleskerr.com>
-
- Jan 16, 2024
-
-
trop[bot] authored
Co-authored-by:
trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by:
Shelley Vohr <shelley.vohr@gmail.com>
-
- Jan 15, 2024
-
-
trop[bot] authored
Co-authored-by:
trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by:
Shelley Vohr <shelley.vohr@gmail.com>
-
- Jan 12, 2024
-
-
Charles Kerr authored
* chore: migrate from base::StringPiece to std::string_view in keyboard_util.cc * chore: migrate from base::StringPiece to std::string_view in error_thrower.cc * chore: migrate from base::StringPiece to std::string_view in electron_api_web_contents.cc * chore: migrate from base::StringPiece to std::string_view in gin_helper/dictionary.h * chore: migrate from base::StringPiece to std::string_view in electron_api_url_loader.cc * chore: phase out internal use of base:::StringPiece `base::StringPiece` is being phased out upstream. Its code has been removed upstream and it's just a typedef for `std::string_view`. They haven't removed the typedef yet, so this PR tries to get ahead of future breakage by migrating "internal" use (i.e. leaving alone the places where the `base::StringPiece` name is coming from an upstream method that we override). Xref: https://bugs.chromium.org/p/chromium/issues/detail?id=691162 Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4294483 Xref: https://docs.google.com/document/d/1d4RnD1uAE2t4iANR0nXy82ASIPGsPuw2mpO6v6T7JKs
-
Samuel Attard authored
* chore: cherry-pick 389ea9be7d68 from v8 * chore: update patches --------- Co-authored-by:
PatchUp <73610968+patchup[bot]@users.noreply.github.com>
-
trop[bot] authored
* fix: InAppPurchase pre-emptive deallocation Co-authored-by:
Shelley Vohr <shelley.vohr@gmail.com> * test: try re-enabling IAP tests Co-authored-by:
Shelley Vohr <shelley.vohr@gmail.com> --------- Co-authored-by:
trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by:
Shelley Vohr <shelley.vohr@gmail.com>
-
trop[bot] authored
* feat: replace BrowserView with WebContentsView Co-authored-by:
Jeremy Rose <jeremya@chromium.org> * Update appveyor.yml --------- Co-authored-by:
trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by:
Jeremy Rose <jeremya@chromium.org>
-
trop[bot] authored
Co-authored-by:
trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by:
Samuel Attard <samuel.r.attard@gmail.com>
-
- Jan 11, 2024
-
-
trop[bot] authored
* chore: bump chromium in DEPS to 122.0.6223.0 Co-authored-by:
electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> * 5129828: Removes special cases for selenium-atoms dependencies. https://chromium-review.googlesource.com/c/chromium/src/+/5129828 Co-authored-by:
Shelley Vohr <shelley.vohr@gmail.com> * chore: fixup patch indices Co-authored-by:
Shelley Vohr <shelley.vohr@gmail.com> * 5139789: Deduplicate BrowserContext's ResourceContext https://chromium-review.googlesource.com/c/chromium/src/+/5139789 Co-authored-by:
Shelley Vohr <shelley.vohr@gmail.com> * 5148579: Simplify SelectFileDialog::Listener https://chromium-review.googlesource.com/c/chromium/src/+/5148579 Co-authored-by:
Shelley Vohr <shelley.vohr@gmail.com> * 5134038: Code Health: Use string_view in base::i18n::BreakIterator::SetText https://chromium-review.googlesource.com/c/chromium/src/+/5134038 Co-authored-by:
Shelley Vohr <shelley.vohr@gmail.com> * 5137427: Code Health: Use string_view in SpellCheck::SpellCheckWord https://chromium-review.googlesource.com/c/chromium/src/+/5137427 Co-authored-by:
Shelley Vohr <shelley.vohr@gmail.com> * adds ranges::fold_left_with_iter and ranges::fold_left Notable things in this commit: * refactors `__indirect_binary_left_foldable`, making it slightly different (but equivalent) to _`indirect-binary-left-foldable`_, which improves readability (a [patch to the Working Paper][patch] was made) * omits `__cpo` namespace, since it is not required for implementing niebloids (a cleanup should happen in 2024) * puts tests ensuring invocable robustness and dangling correctness inside the correctness testing to ensure that the algorithms' results are still correct [patch]: https://github.com/cplusplus/draft/pull/6734 Co-authored-by:
Shelley Vohr <shelley.vohr@gmail.com> * chore: bump chromium in DEPS to 122.0.6224.0 Co-authored-by:
electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> * 5154766: [Refresh 2023] [GTK] Fix gap above toolbar with fractional scaling https://chromium-review.googlesource.com/c/chromium/src/+/5154766 Co-authored-by:
Shelley Vohr <shelley.vohr@gmail.com> * chore: fixup patch indices Co-authored-by:
Shelley Vohr <shelley.vohr@gmail.com> * 5094458: Remove extra CGColorSpace parameters from skia and ui helpers https://chromium-review.googlesource.com/c/chromium/src/+/5094458 Co-authored-by:
Shelley Vohr <shelley.vohr@gmail.com> * chore: bump chromium in DEPS to 122.0.6226.0 Co-authored-by:
electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> * chore: update patches Co-authored-by:
PatchUp <73610968+patchup[bot]@users.noreply.github.com> * chore: bump chromium in DEPS to 122.0.6227.0 Co-authored-by:
electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> * chore: update patches Co-authored-by:
PatchUp <73610968+patchup[bot]@users.noreply.github.com> * chore: bump chromium in DEPS to 122.0.6228.0 Co-authored-by:
electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> * chore: update patches Co-authored-by:
PatchUp <73610968+patchup[bot]@users.noreply.github.com> * chore: bump chromium in DEPS to 122.0.6230.0 Co-authored-by:
electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> * chore: bump chromium in DEPS to 122.0.6232.0 Co-authored-by:
electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> * chore: bump chromium in DEPS to 122.0.6234.0 Co-authored-by:
electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> * chore: bump chromium in DEPS to 122.0.6236.2 Co-authored-by:
electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> * chore: update patches Co-authored-by:
Samuel Attard <marshallofsound@electronjs.org> * fix: remove --disable-color-correct-renderering Per https://electronhq.slack.com/archives/CB6CG54DB/p1698444047862459 it is not used any more and was never documented. Co-authored-by:
Samuel Attard <marshallofsound@electronjs.org> * chore: add WEB_PRINTING to content permission converter Unused in non-cros so no need to document Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5136178 Co-authored-by:
Samuel Attard <marshallofsound@electronjs.org> * chore: Views is now vec<raw_ptr> instead of raw<T*> Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5140028 Co-authored-by:
Samuel Attard <marshallofsound@electronjs.org> * spec: add Iterator to global intrinsics Co-authored-by:
Samuel Attard <marshallofsound@electronjs.org> * chore: update patches --------- Co-authored-by:
trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by:
electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by:
Shelley Vohr <shelley.vohr@gmail.com> Co-authored-by:
PatchUp <73610968+patchup[bot]@users.noreply.github.com> Co-authored-by:
Samuel Attard <marshallofsound@electronjs.org>
-
trop[bot] authored
* chore: add patch to always set macos platform for x-build * build: add infra for reclient support * build: override reclient version * build: use RBE in CI * chore: hardcode reclient fix version * build: lower process count on macOS * build: use large macOS instance for testing-arm64 * Revert "build: use large macOS instance for testing-arm64" This reverts commit 6844adfd . * build: login in via helper not writing file * chore: update patches * build: use recelint from DEPS * build: fix windows reproxy cfg * build: use reclient in appveyor * build: update WOA job too * build: force another build * build: do not checkout reclient Co-authored-by:
trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by:
Samuel Attard <sam@electronjs.org>
-
trop[bot] authored
* refactor: do not use deprecated NoDestructor in javascript_environment.cc Co-authored-by:
Charles Kerr <charles@charleskerr.com> * refactor: do not use deprecated NoDestructor in window_list.cc Co-authored-by:
Charles Kerr <charles@charleskerr.com> --------- Co-authored-by:
trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by:
Charles Kerr <charles@charleskerr.com>
-
- Jan 10, 2024
-
-
trop[bot] authored
* build: use aks arm64 test runners Co-authored-by:
Samuel Attard <samuel.r.attard@gmail.com> * build: better image Co-authored-by:
Samuel Attard <samuel.r.attard@gmail.com> * build: even more stuff Co-authored-by:
Samuel Attard <samuel.r.attard@gmail.com> * build: arm par Co-authored-by:
Samuel Attard <samuel.r.attard@gmail.com> * build: use aks arm32 Co-authored-by:
Samuel Attard <samuel.r.attard@gmail.com> * build: arm32 par Co-authored-by:
Samuel Attard <samuel.r.attard@gmail.com> * build: get test timings from abs paths Co-authored-by:
Samuel Attard <samuel.r.attard@gmail.com> * build: avoid realpath, use echo Co-authored-by:
Samuel Attard <samuel.r.attard@gmail.com> * chore: fix contentTracing test * cry --------- Co-authored-by:
trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by:
Samuel Attard <samuel.r.attard@gmail.com> Co-authored-by:
Samuel Attard <marshallofsound@electronjs.org>
-
trop[bot] authored
* fix: crash using powerMonitor before ready event Co-authored-by:
Shelley Vohr <shelley.vohr@gmail.com> * refactor: continue using DBusBluezManagerWrapperLinux Co-authored-by:
Shelley Vohr <shelley.vohr@gmail.com> --------- Co-authored-by:
trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by:
Shelley Vohr <shelley.vohr@gmail.com>
-
- Jan 09, 2024
-
-
trop[bot] authored
This doesn't need to be injected. Looks like it was an accident in 60ca38fb for https://github.com/electron/electron/pull/38465 . Co-authored-by:
trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by:
Charles Kerr <charles@charleskerr.com>
-
trop[bot] authored
* fix: wide string concatenation Co-authored-by:
clavin <clavin@electronjs.org> * Use wstring_views to keep length in context Co-authored-by:
clavin <clavin@electronjs.org> * forgot a space, oopsies Co-authored-by:
clavin <clavin@electronjs.org> --------- Co-authored-by:
trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by:
clavin <clavin@electronjs.org>
-
trop[bot] authored
* chore: initial prototype of net api from utility process * chore: update url loader to work on both browser and utility processes * chore: add net files to utility process bundle * chore: re-add app ready check but only on main process * chore: replace browser thread dcheck's with sequence checker * refactor: move url loader from browser to common * refactor: move net-client-request.ts from browser to common * docs: add utility process to net api docs * refactor: move net module app ready check to browser only * refactor: switch import from main to common after moving to common * test: add basic net module test for utility process * refactor: switch browser pid with utility pid * refactor: move electron_api_net from browser to common * chore: add fetch to utility net module * chore: add isOnline and online to utility net module * refactor: move net spec helpers into helper file * refactor: break apart net module tests Adds two additional net module test files: `api-net-session-spec.ts` for tests that depend on a session being available (aka depend on running on the main process) and `api-net-custom-protocols-spec.ts` for custom protocol tests. This enables running `api-net-spec.ts` in the utility process. * test: add utility process mocha runner to run net module tests * docs: add utility process to net module classes * refactor: update imports in lib/utility to use electron/utility * chore: check browser context before using in main process Since the browser context supplied to the SimpleURLLoaderWrapper can now be null for use in the UtilityProcess, adding a null check for the main process before use to get a more sensible error if something goes wrong. * chore: remove test debugging * chore: remove unnecessary header include * docs: add utility process net module limitations * test: run net module tests in utility process individually * refactor: clean up prior utility process net tests * chore: add resolveHost to utility process net module * chore: replace resolve host dcheck with sequence checker * test: add net module tests for net.resolveHost * docs: remove utility process limitation for resolveHost --------- Co-authored-by:
trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by:
Devraj Mehta <devm33@github.com>
-
trop[bot] authored
fix: macOS maximize button shouldn't be disabled just because the window is non-fullscreenable (#40897) * fix: macOS maximize button shouldn't be disabled just because the window is non-fullscreenable Co-authored-by:
Tamás Zahola <tzahola@gmail.com> * add test Co-authored-by:
Tamás Zahola <tzahola@gmail.com> * fix test by enabling maximize button if `resizable && (maximizable || fullscreenable)` instead of `(resizable && maximizable) && fullscreenable` Co-authored-by:
Tamás Zahola <tzahola@gmail.com> --------- Co-authored-by:
trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by:
Tamás Zahola <tzahola@gmail.com>
-
trop[bot] authored
refactor: use fixed-size arrays for the font cache Since we know at compile time which [family x script] combos we want to cache, we can hold the cache in fixed std::arrays instead of in nested std::unordered_maps. Co-authored-by:
trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by:
Charles Kerr <charles@charleskerr.com>
-
- Jan 08, 2024
-
-
trop[bot] authored
docs: add missing vibranch change Co-authored-by:
trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by:
Shelley Vohr <shelley.vohr@gmail.com>
-
- Jan 05, 2024
-
-
Charles Kerr authored
refactor: make NativeWindow getter methods const (#40804) * refactor: make NativeWindow getter methods const * fixup! refactor: make NativeWindow getter methods const make GetZOrderLevel() const * fixup! refactor: make NativeWindow getter methods const fix oops
-
trop[bot] authored
* chore: bump chromium in DEPS to 122.0.6180.0 Co-authored-by:
electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> * chore: update render_widget_host_view_base.patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5079532 minor manual changes to match upstream changes Co-authored-by:
Charles Kerr <charles@charleskerr.com> * chore: update printing.patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5094777 Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5054299 Update patch to upstream changes in print_view_manager_base.cc. CC @codebytere for
Co-authored-by:Charles Kerr <charles@charleskerr.com> * chore: update feat_add_onclose_to_messageport.patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5083156 no manual changes; patch applied with fuzz 1 Co-authored-by:
Charles Kerr <charles@charleskerr.com> * chore: update build_do_not_depend_on_packed_resource_integrity.patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5087072 minor manual changes to match upstream changes Co-authored-by:
Charles Kerr <charles@charleskerr.com> * chore: update port_autofill_colors_to_the_color_pipeline.patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4960481 no manual changes; patch applied with fuzz 2 Co-authored-by:
Charles Kerr <charles@charleskerr.com> * chore: update revert_api_dcheck-fail_when_we_reenter_v8_while_terminating.patch Xref: https://chromium-review.googlesource.com/c/v8/v8/+/5076902 Xref: https://chromium-review.googlesource.com/c/v8/v8/+/5096253 The `bailout_value` variable, which allowed us to fail gracefully in these macros, has been removed upstream. This raises the temperature on https://github.com/electron/electron/issues/40741 ... Since we don't have a bailout value, return a default-constructed instance of whatever the return type is of the function that invokes the macro. Co-authored-by:
Charles Kerr <charles@charleskerr.com> * Remove performActionOnRemotePage Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5068017 It appears it is not used by anything within Chromium or outside. Co-authored-by:
Charles Kerr <charles@charleskerr.com> * perf: in SubmenuButton ctor, move() the PressedCallback Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5066872 The copy construtor is more expensive and has been removed upstream Co-authored-by:
Charles Kerr <charles@charleskerr.com> * chore: update constructor call for ElectronExtensionsRendererClient::dispatcher_ Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5055146 Co-authored-by:
Charles Kerr <charles@charleskerr.com> * chore: handle CAPTURED_SURFACE_CONTROL in Converter<blink::PermissionType>::ToV8() Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5096614 Co-authored-by:
Charles Kerr <charles@charleskerr.com> * chore: e patches all Co-authored-by:
Charles Kerr <charles@charleskerr.com> * chore: bump chromium to 122.0.6181.0 Co-authored-by:
Charles Kerr <charles@charleskerr.com> * chore: e patches all Co-authored-by:
Charles Kerr <charles@charleskerr.com> * refactor: Add lookup for per-RenderFrame SpellCheckProvider Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5075094 Previously we could pass a routing ID into the spellcheck methods. This ID arg has been replaced with a SpellCheckHost& arg. We can get the SpellCheckHost from an accessor in SpellCheckProvider, which was already being created on a per-render-frame basis in RenderClientBase. This commit adds a RenderFrame-to-SpellCheckProvider accessor in RenderClientBase so that it can be used to get that needed SpellCheckHost. Co-authored-by:
Charles Kerr <charles@charleskerr.com> * chore: make lint happy Co-authored-by:
Charles Kerr <charles@charleskerr.com> * chore: restore the will_cause_resize arg to WebContents::ExitFullscreen Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5074445 Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5031312 upstream reverted this change Co-authored-by:
Charles Kerr <charles@charleskerr.com> * chore: bump chromium in DEPS to 122.0.6182.0 Co-authored-by:
electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> * chore: update patches Co-authored-by:
PatchUp <73610968+patchup[bot]@users.noreply.github.com> * chore: fix virtual function names that were renamed upstream Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5115241 Co-authored-by:
Charles Kerr <charles@charleskerr.com> * chore: handle new blink::PermissionType::SMART_CARD in PermissionType converter Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5049989 Co-authored-by:
Charles Kerr <charles@charleskerr.com> * chore: node script/gen-libc++-filenames.js Co-authored-by:
Charles Kerr <charles@charleskerr.com> * fixup! chore: update build_do_not_depend_on_packed_resource_integrity.patch Co-authored-by:
Charles Kerr <charles@charleskerr.com> * chore: remove revert_api_dcheck-fail_when_we_reenter_v8_while_terminating.patch The previous experiment of removing the DCHECK in 35093783 was a huge failure. We either need to either: A) use upstream as-is and fix the DCHECK failure, or B) revert https://chromium-review.googlesource.com/c/v8/v8/+/5076902 too C) find some other workaround This commit is the first half of option A, removing the patch to use upstream as-is. Co-authored-by:
Charles Kerr <charles@charleskerr.com> * chore: bump chromium in DEPS to 122.0.6184.0 Co-authored-by:
electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> * chore: bump chromium in DEPS to 122.0.6186.0 Co-authored-by:
electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> * chore; update mas_avoid_private_macos_api_usage.patch.patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5085619 minor manual changes to match upstream changes Co-authored-by:
Charles Kerr <charles@charleskerr.com> * chore: update build_do_not_depend_on_packed_resource_integrity.patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5120922 minor manual changes to match upstream changes Co-authored-by:
Charles Kerr <charles@charleskerr.com> * chore: update fix_move_autopipsettingshelper_behind_branding_buildflag.patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5041595 no manual changes; patch applied with fuzz 1 Co-authored-by:
Charles Kerr <charles@charleskerr.com> * chore: e patches all Co-authored-by:
Charles Kerr <charles@charleskerr.com> * chore: add refactor_update_node-platform_to_match_v8-platform_api_changes.patch Co-authored-by:
Charles Kerr <charles@charleskerr.com> * chore: bump chromium in DEPS to 122.0.6188.0 Co-authored-by:
electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> * chore: bump chromium in DEPS to 122.0.6190.0 Co-authored-by:
electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> * chore: bump chromium in DEPS to 122.0.6192.0 Co-authored-by:
electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> * chore: bump chromium in DEPS to 122.0.6194.0 Co-authored-by:
electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> * Remove an unnecessary DCHECK which causes Lacros to crash. https://chromium-review.googlesource.com/c/chromium/src/+/5124880 Co-authored-by:
deepak1556 <hop2deep@gmail.com> * Add shared regular profile function that includes ash https://chromium-review.googlesource.com/c/chromium/src/+/5100709 Co-authored-by:
deepak1556 <hop2deep@gmail.com> * Simplify the PrintManagerHost::ScriptedPrint() call https://chromium-review.googlesource.com/c/chromium/src/+/5019703 Co-authored-by:
deepak1556 <hop2deep@gmail.com> * Add tests https://chromium-review.googlesource.com/c/chromium/src/+/5024173 Co-authored-by:
deepak1556 <hop2deep@gmail.com> * chore: update patches Co-authored-by:
deepak1556 <hop2deep@gmail.com> * fixup! chore: add refactor_update_node-platform_to_match_v8-platform_api_changes.patch Co-authored-by:
deepak1556 <hop2deep@gmail.com> * chore: node script/gen-libc++-filenames.js Co-authored-by:
deepak1556 <hop2deep@gmail.com> * Remove //ui/ozone/buildflags.h https://chromium-review.googlesource.com/c/chromium/src/+/5119048 Co-authored-by:
deepak1556 <hop2deep@gmail.com> * fixup! Remove //ui/ozone/buildflags.h Co-authored-by:
deepak1556 <hop2deep@gmail.com> * fixup! Remove //ui/ozone/buildflags.h Co-authored-by:
deepak1556 <hop2deep@gmail.com> * chore: update patches Co-authored-by:
deepak1556 <hop2deep@gmail.com> * fixup! refactor: Add lookup for per-RenderFrame SpellCheckProvider Co-authored-by:
deepak1556 <hop2deep@gmail.com> * fixup! Remove //ui/ozone/buildflags.h Co-authored-by:
deepak1556 <hop2deep@gmail.com> * Add permission policy verification in PermissionControllerImpl https://chromium-review.googlesource.com/c/chromium/src/+/5059112 Co-authored-by:
deepak1556 <hop2deep@gmail.com> * fix: ensure spellcheck interface is registered for frame Co-authored-by:
deepak1556 <hop2deep@gmail.com> * Unify pending and scheduled exceptions https://chromium-review.googlesource.com/c/v8/v8/+/5050065 Co-authored-by:
deepak1556 <hop2deep@gmail.com> * fix: dchecks in node.js tests Co-authored-by:
deepak1556 <hop2deep@gmail.com> * fix: try adding termination check Co-authored-by:
Shelley Vohr <shelley.vohr@gmail.com> * chore: document breaking iframe change Co-authored-by:
Shelley Vohr <shelley.vohr@gmail.com> * chore: update patches after trop --------- Co-authored-by:
trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by:
electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by:
Charles Kerr <charles@charleskerr.com> Co-authored-by:
PatchUp <73610968+patchup[bot]@users.noreply.github.com> Co-authored-by:
deepak1556 <hop2deep@gmail.com> Co-authored-by:
Shelley Vohr <shelley.vohr@gmail.com> Co-authored-by:
John Kleinschmidt <jkleinsc@electronjs.org>
-
trop[bot] authored
* chore: add disclaimer to release timeline Co-authored-by:
Keeley Hammond <vertedinde@electronjs.org> * Update docs/tutorial/electron-timelines.md Co-authored-by:
David Sanders <dsanders11@ucsbalum.com> Co-authored-by:
Shelley Vohr <shelley.vohr@gmail.com> --------- Co-authored-by:
trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by:
Keeley Hammond <vertedinde@electronjs.org> Co-authored-by:
Shelley Vohr <shelley.vohr@gmail.com>
-