`computeDryLayout` access size bad (#164663)
Asserts if `RenderBox.size` is accessed in `computeDryLayout` Also changes `x is RenderObject` to `x != null` when x's static type is `RenderObject?`. ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Showing
- packages/flutter/lib/src/rendering/animated_size.dart 5 additions, 3 deletionspackages/flutter/lib/src/rendering/animated_size.dart
- packages/flutter/lib/src/rendering/box.dart 17 additions, 5 deletionspackages/flutter/lib/src/rendering/box.dart
- packages/flutter/lib/src/rendering/object.dart 17 additions, 21 deletionspackages/flutter/lib/src/rendering/object.dart
- packages/flutter/test/material/list_tile_test.dart 56 additions, 61 deletionspackages/flutter/test/material/list_tile_test.dart
- packages/flutter/test/rendering/box_test.dart 37 additions, 0 deletionspackages/flutter/test/rendering/box_test.dart
- packages/flutter/test/widgets/selectable_region_context_menu_test.dart 5 additions, 8 deletions...ter/test/widgets/selectable_region_context_menu_test.dart
- packages/flutter/test/widgets/selectable_region_test.dart 3 additions, 7 deletionspackages/flutter/test/widgets/selectable_region_test.dart
Please register or sign in to comment