Split up the conical gradient fragment shader (#164058)
fixes: https://github.com/flutter/flutter/issues/163580 testing: There are existing tests (AiksTest.CanRenderConicalGradient). The compilation failure of the nexus 5 cannot be reproduced locally so we can't assert this fixes the problem in a test. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Showing
- engine/src/flutter/ci/licenses_golden/licenses_flutter 20 additions, 4 deletionsengine/src/flutter/ci/licenses_golden/licenses_flutter
- engine/src/flutter/impeller/compiler/shader_lib/impeller/BUILD.gn 1 addition, 0 deletions...rc/flutter/impeller/compiler/shader_lib/impeller/BUILD.gn
- engine/src/flutter/impeller/compiler/shader_lib/impeller/conical_gradient_fill.glsl 9 additions, 15 deletions...r/compiler/shader_lib/impeller/conical_gradient_fill.glsl
- engine/src/flutter/impeller/compiler/shader_lib/impeller/conical_gradient_uniform_fill.glsl 8 additions, 13 deletions...er/shader_lib/impeller/conical_gradient_uniform_fill.glsl
- engine/src/flutter/impeller/compiler/shader_lib/impeller/gradient.glsl 103 additions, 99 deletions...utter/impeller/compiler/shader_lib/impeller/gradient.glsl
- engine/src/flutter/impeller/display_list/aiks_dl_gradient_unittests.cc 8 additions, 3 deletions...utter/impeller/display_list/aiks_dl_gradient_unittests.cc
- engine/src/flutter/impeller/entity/BUILD.gn 8 additions, 2 deletionsengine/src/flutter/impeller/entity/BUILD.gn
- engine/src/flutter/impeller/entity/contents/conical_gradient_contents.cc 36 additions, 11 deletions...ter/impeller/entity/contents/conical_gradient_contents.cc
- engine/src/flutter/impeller/entity/contents/content_context.cc 18 additions, 1 deletion...e/src/flutter/impeller/entity/contents/content_context.cc
- engine/src/flutter/impeller/entity/contents/content_context.h 98 additions, 16 deletions...ne/src/flutter/impeller/entity/contents/content_context.h
- engine/src/flutter/impeller/entity/shaders/gradients/conical_gradient_fill_conical.frag 22 additions, 0 deletions...tity/shaders/gradients/conical_gradient_fill_conical.frag
- engine/src/flutter/impeller/entity/shaders/gradients/conical_gradient_fill_radial.frag 22 additions, 0 deletions...ntity/shaders/gradients/conical_gradient_fill_radial.frag
- engine/src/flutter/impeller/entity/shaders/gradients/conical_gradient_fill_strip.frag 22 additions, 0 deletions...entity/shaders/gradients/conical_gradient_fill_strip.frag
- engine/src/flutter/impeller/entity/shaders/gradients/conical_gradient_fill_strip_radial.frag 20 additions, 0 deletions...shaders/gradients/conical_gradient_fill_strip_radial.frag
- engine/src/flutter/impeller/entity/shaders/gradients/conical_gradient_ssbo_fill.frag 3 additions, 1 deletion.../entity/shaders/gradients/conical_gradient_ssbo_fill.frag
- engine/src/flutter/impeller/entity/shaders/gradients/conical_gradient_uniform_fill_conical.frag 23 additions, 0 deletions...ders/gradients/conical_gradient_uniform_fill_conical.frag
- engine/src/flutter/impeller/entity/shaders/gradients/conical_gradient_uniform_fill_radial.frag 24 additions, 0 deletions...aders/gradients/conical_gradient_uniform_fill_radial.frag
- engine/src/flutter/impeller/entity/shaders/gradients/conical_gradient_uniform_fill_strip.frag 24 additions, 0 deletions...haders/gradients/conical_gradient_uniform_fill_strip.frag
- engine/src/flutter/impeller/entity/shaders/gradients/conical_gradient_uniform_fill_strip_radial.frag 21 additions, 0 deletions...gradients/conical_gradient_uniform_fill_strip_radial.frag
- engine/src/flutter/impeller/tools/malioc.json 1686 additions, 546 deletionsengine/src/flutter/impeller/tools/malioc.json
Please register or sign in to comment