This project is mirrored from https://github.com/flutter/flutter.git.
Pull mirroring updated .
- Jul 02, 2024
-
-
Andrew Kolos authored
Cleans up printTrace calls added while investigating https://github.com/flutter/flutter/issues/146879. Also makes[ this `catch` clause ](https://github.com/flutter/flutter/pull/151074/files#diff-214723283174eb75e740a102252215723aa56716226ea92d084ef8a5bea4e931L578-R581)more precise.
-
Nate Wilson authored
I really like how patterns can be used for variable assignment and avoiding duplicated logic. (related: #150942) ```dart // before final GestureRecognizer? recognizer = info.recognizer; if (recognizer is TapGestureRecognizer) { if (recognizer.onTap != null) { configuration.onTap = recognizer.onTap; configuration.isLink = true; } } else if (recognizer is DoubleTapGestureRecognizer) { if (recognizer.onDoubleTap != null) { configuration.onTap = recognizer.onDoubleTap; configuration.isLink = true; } } // after switch (info.recognizer) { case TapGestureRecognizer(:final VoidCallback? onTap): case DoubleTapGestureRecognizer(onDoubleTap: final VoidCallback? onTap): if (onTap != null) { configuration.onTap = onTap; configuration.isLink = true; } } ```
-
auto-submit[bot] authored
Reverts "Upgrade template Gradle, App AGP, Module AGP, and Kotlin versions, and tests (#150969)" (#151147) Reverts: flutter/flutter#150969 Initiated by: goderbauer Reason for reverting: Failing test in https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8743574743030691569/+/u/run_android_obfuscate_test/stdout Original PR Author: gmackall Reviewed By: {christopherfujino, reidbaker} This change reverts the following previous change: After the land of https://github.com/flutter/engine/pull/53592, there is some log spam: ``` e: /Users/mackall/.gradle/caches/transforms-3/c1e137371ec1afe9bc9bd7b05823752d/transformed/fragment-1.7.1/jars/classes.jar!/META-INF/fragment_release.kotlin_module: Module was compiled with an incompatible version of Kotlin. The binary version of its metadata is 1.8.0, expected version is 1.6.0. e: /Users/mackall/.gradle/caches/transforms-3/d86c7cb1c556fe1655fa56db671c649c/transformed/jetified-activity-1.8.1/jars/classes.jar!/META-INF/activity_release.kotlin_module: Module was compiled with an incompatible version of Kotlin. The binary version of its metadata is 1.8.0, expected version is 1.6.0. ... ``` I think this is harmless, but still annoying. Upgrading the AGP version fixes it. To be honest, I don't know why (I expected the Kotlin version would do it). But after https://github.com/flutter/flutter/pull/146307, our tests have been running on AGP/Gradle 8.1/8.3 for a while, so it makes sense to upgrade anyways. In a follow up PR: 1. Also upgrade the tests that were left behind in https://github.com/flutter/flutter/pull/146307, as I think removal of discontinued plugins paved the way here.
-
Gray Mackall authored
After the land of https://github.com/flutter/engine/pull/53592, there is some log spam: ``` e: /Users/mackall/.gradle/caches/transforms-3/c1e137371ec1afe9bc9bd7b05823752d/transformed/fragment-1.7.1/jars/classes.jar!/META-INF/fragment_release.kotlin_module: Module was compiled with an incompatible version of Kotlin. The binary version of its metadata is 1.8.0, expected version is 1.6.0. e: /Users/mackall/.gradle/caches/transforms-3/d86c7cb1c556fe1655fa56db671c649c/transformed/jetified-activity-1.8.1/jars/classes.jar!/META-INF/activity_release.kotlin_module: Module was compiled with an incompatible version of Kotlin. The binary version of its metadata is 1.8.0, expected version is 1.6.0. ... ``` I think this is harmless, but still annoying. Upgrading the AGP version fixes it. To be honest, I don't know why (I expected the Kotlin version would do it). But after https://github.com/flutter/flutter/pull/146307, our tests have been running on AGP/Gradle 8.1/8.3 for a while, so it makes sense to upgrade anyways. In a follow up PR: 1. Also upgrade the tests that were left behind in https://github.com/flutter/flutter/pull/146307, as I think removal of discontinued plugins paved the way here.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/b57a044ed10f...3456fee1a6b9 2024-07-01 skia-flutter-autoroll@skia.org Roll Skia from a67a67b7452b to a62bf018429c (2 revisions) (flutter/engine#53665) 2024-07-01 skia-flutter-autoroll@skia.org Roll Skia from 8af866a56bce to a67a67b7452b (1 revision) (flutter/engine#53664) 2024-07-01 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from DSPuQ9O6WejkIBUUh... to LkXpxHsQlkPT4mmJ7... (flutter/engine#53663) 2024-07-01 skia-flutter-autoroll@skia.org Roll Skia from e27104eaef37 to 8af866a56bce (4 revisions) (flutter/engine#53661) 2024-07-01 skia-flutter-autoroll@skia.org Roll Skia from 34be7c830184 to e27104eaef37 (1 revision) (flutter/engine#53659) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from DSPuQ9O6Wejk to LkXpxHsQlkPT If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
John McDole authored
Same as #150791 except with AARs (`flutter build module`)
-
Michael Goderbauer authored
docimports for references in doc comments on library statements now work! Part of https://github.com/flutter/flutter/issues/150800
-
Matthias Ngeo authored
This is a trivial fix for a typo in the docs.
-
flutter-pub-roller-bot authored
This PR was generated by `flutter update-packages --force-upgrade`.
-
Jason Simmons authored
This test suite had been failing when run with --test-randomize-ordering-seed=20240701
-
- Jul 01, 2024
-
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/0d93da7e2fe1...b57a044ed10f 2024-07-01 skia-flutter-autoroll@skia.org Roll Dart SDK from ab6a48438e07 to 338c6d4fd9c5 (1 revision) (flutter/engine#53658) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
- Jun 30, 2024
-
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/ad1343cfb99e...0d93da7e2fe1 2024-06-30 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from zU9wwHk8Oji6pArmw... to DSPuQ9O6WejkIBUUh... (flutter/engine#53657) 2024-06-29 skia-flutter-autoroll@skia.org Roll Dart SDK from e1e2b16d509b to ab6a48438e07 (1 revision) (flutter/engine#53655) 2024-06-29 skia-flutter-autoroll@skia.org Roll Skia from 2df28ce437cc to 34be7c830184 (1 revision) (flutter/engine#53654) 2024-06-29 skia-flutter-autoroll@skia.org Roll Skia from bc0e9542ce83 to 2df28ce437cc (1 revision) (flutter/engine#53652) 2024-06-29 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from H_P7EHb4zXXV-Eiik... to zU9wwHk8Oji6pArmw... (flutter/engine#53649) 2024-06-29 ditman@gmail.com [web] Fixes drag scrolling in embedded mode. (flutter/engine#53647) 2024-06-29 skia-flutter-autoroll@skia.org Roll Dart SDK from 160ace00da8a to e1e2b16d509b (1 revision) (flutter/engine#53646) 2024-06-28 skia-flutter-autoroll@skia.org Roll Skia from 1ad84eb8e94f to bc0e9542ce83 (1 revision) (flutter/engine#53644) 2024-06-28 skia-flutter-autoroll@skia.org Roll Dart SDK from 89b164e3adeb to 160ace00da8a (1 revision) (flutter/engine#53643) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from H_P7EHb4zXXV to DSPuQ9O6Wejk If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Jason Simmons authored
With today's random test order (--test-randomize-ordering-seed=20240629) this test is failing due to stack overflows when run on Windows.
-
- Jun 29, 2024
-
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/f828363d03ff...ad1343cfb99e 2024-06-28 yjbanov@google.com [web] switch from .didGain/LoseAccessibilityFocus to .focus (flutter/engine#53360) 2024-06-28 flar@google.com Reland [DisplayList] Add support for clipOval to leverage Impeller optimization (flutter/engine#53642) 2024-06-28 jonahwilliams@google.com [Impeller] experimental canvas bdf support. (flutter/engine#53597) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Valentin Vignal authored
Contributes to https://github.com/flutter/flutter/issues/130459 It adds a test for - `examples/api/test/material/segmented_button/segmented_button.0_test.dart`
-
flutter-pub-roller-bot authored
This PR was generated by `flutter update-packages --force-upgrade`.
-
flutter-pub-roller-bot authored
This PR was generated by `flutter update-packages --force-upgrade`.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/2f7e9ab27493...f828363d03ff 2024-06-28 skia-flutter-autoroll@skia.org Roll Skia from fc6f00bfacb5 to 1ad84eb8e94f (2 revisions) (flutter/engine#53641) 2024-06-28 skia-flutter-autoroll@skia.org Roll Skia from 3d5f5d546fb6 to fc6f00bfacb5 (1 revision) (flutter/engine#53637) 2024-06-28 skia-flutter-autoroll@skia.org Roll Dart SDK from 341dbaf977a3 to 89b164e3adeb (2 revisions) (flutter/engine#53636) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
dependabot[bot] authored
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.25.10 to 3.25.11. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/github/codeql-action/blob/main/CHANGELOG.md">github/codeql-action's changelog</a>.</em></p> <blockquote> <h1>CodeQL Action Changelog</h1> <p>See the <a href="https://github.com/github/codeql-action/releases">releases page</a> for the relevant changes to the CodeQL CLI and language packs.</p> <p>Note that the only difference between <code>v2</code> and <code>v3</code> of the CodeQL Action is the node version they support, with <code>v3</code> running on node 20 while we continue to release <code>v2</code> to support running on node 16. For example <code>3.22.11</code> was the first <code>v3</code> release and is functionally identical to <code>2.22.11</code>. This approach ensures an easy way to track exactly which features are included in different versions, indicated by the minor and patch version numbers.</p> <h2>[UNRELEASED]</h2> <p>No user facing changes.</p> <h2>3.25.11 - 28 Jun 2024</h2> <ul> <li>Avoid failing the workflow run if there is an error while uploading debug artifacts. <a href="https://redirect.github.com/github/codeql-action/pull/2349">#2349</a></li> <li>Update default CodeQL bundle version to 2.17.6. <a href="https://redirect.github.com/github/codeql-action/pull/2352">#2352</a></li> </ul> <h2>3.25.10 - 13 Jun 2024</h2> <ul> <li>Update default CodeQL bundle version to 2.17.5. <a href="https://redirect.github.com/github/codeql-action/pull/2327">#2327</a></li> </ul> <h2>3.25.9 - 12 Jun 2024</h2> <ul> <li>Avoid failing database creation if the database folder already exists and contains some unexpected files. Requires CodeQL 2.18.0 or higher. <a href="https://redirect.github.com/github/codeql-action/pull/2330">#2330</a></li> <li>The init Action will attempt to clean up the database cluster directory before creating a new database and at the end of the job. This will help to avoid issues where the database cluster directory is left in an inconsistent state. <a href="https://redirect.github.com/github/codeql-action/pull/2332">#2332</a></li> </ul> <h2>3.25.8 - 04 Jun 2024</h2> <ul> <li>Update default CodeQL bundle version to 2.17.4. <a href="https://redirect.github.com/github/codeql-action/pull/2321">#2321</a></li> </ul> <h2>3.25.7 - 31 May 2024</h2> <ul> <li>We are rolling out a feature in May/June 2024 that will reduce the Actions cache usage of the Action by keeping only the newest TRAP cache for each language. <a href="https://redirect.github.com/github/codeql-action/pull/2306">#2306</a></li> </ul> <h2>3.25.6 - 20 May 2024</h2> <ul> <li>Update default CodeQL bundle version to 2.17.3. <a href="https://redirect.github.com/github/codeql-action/pull/2295">#2295</a></li> </ul> <h2>3.25.5 - 13 May 2024</h2> <ul> <li>Add a compatibility matrix of supported CodeQL Action, CodeQL CLI, and GitHub Enterprise Server versions to the <a href="https://github.com/github/codeql-action/blob/main/README.md">https://github.com/github/codeql-action/blob/main/README.md</a>. <a href="https://redirect.github.com/github/codeql-action/pull/2273">#2273</a></li> <li>Avoid printing out a warning for a missing <code>on.push</code> trigger when the CodeQL Action is triggered via a <code>workflow_call</code> event. <a href="https://redirect.github.com/github/codeql-action/pull/2274">#2274</a></li> <li>The <code>tools: latest</code> input to the <code>init</code> Action has been renamed to <code>tools: linked</code>. This option specifies that the Action should use the tools shipped at the same time as the Action. The old name will continue to work for backwards compatibility, but we recommend that new workflows use the new name. <a href="https://redirect.github.com/github/codeql-action/pull/2281">#2281</a></li> </ul> <h2>3.25.4 - 08 May 2024</h2> <ul> <li>Update default CodeQL bundle version to 2.17.2. <a href="https://redirect.github.com/github/codeql-action/pull/2270">#2270</a></li> </ul> <h2>3.25.3 - 25 Apr 2024</h2> <ul> <li>Update default CodeQL bundle version to 2.17.1. <a href="https://redirect.github.com/github/codeql-action/pull/2247">#2247</a></li> <li>Workflows running on <code>macos-latest</code> using CodeQL CLI versions before v2.15.1 will need to either upgrade their CLI version to v2.15.1 or newer, or change the platform to an Intel MacOS runner, such as <code>macos-12</code>. ARM machines with SIP disabled, including the newest <code>macos-latest</code> image, are unsupported for CLI versions before 2.15.1. <a href="https://redirect.github.com/github/codeql-action/pull/2261">#2261</a></li> </ul> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/github/codeql-action/commit/b611370bb5703a7efb587f9d136a52ea24c5c38c"><code>b611370</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2357">#2357</a> from github/update-v3.25.11-de945755c</li> <li><a href="https://github.com/github/codeql-action/commit/3e6431f3accd84bb42779fc3c9d9f447caa3a6d3"><code>3e6431f</code></a> Update changelog for v3.25.11</li> <li><a href="https://github.com/github/codeql-action/commit/de945755c9edd3a4e5d160a71f1482ece6a3c271"><code>de94575</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2352">#2352</a> from github/update-bundle/codeql-bundle-v2.17.6</li> <li><a href="https://github.com/github/codeql-action/commit/a32d3058b827f5d2ba08dc2570887f14b164a794"><code>a32d305</code></a> Add changelog note</li> <li><a href="https://github.com/github/codeql-action/commit/9ccc99508a819cb9c340028d7711b129f96c8a2e"><code>9ccc995</code></a> Update default bundle to codeql-bundle-v2.17.6</li> <li><a href="https://github.com/github/codeql-action/commit/9b7c22c3b39078582fa6d0d8f3841e944ec54582"><code>9b7c22c</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2351">#2351</a> from github/dependabot/npm_and_yarn/npm-6791eaa26c</li> <li><a href="https://github.com/github/codeql-action/commit/9cf3243b0be3a9e0efff20a7fabd5a11246168e9"><code>9cf3243</code></a> Rebuild</li> <li><a href="https://github.com/github/codeql-action/commit/1895b29ac8e2046ddb708ac1eca53e6d5e143337"><code>1895b29</code></a> Update checked-in dependencies</li> <li><a href="https://github.com/github/codeql-action/commit/9dcfde966d641c9a59ee02a83f18329a2b2caace"><code>9dcfde9</code></a> Bump the npm group with 2 updates</li> <li><a href="https://github.com/github/codeql-action/commit/8723b5be41df185b62efd22191bb83fc24539ca0"><code>8723b5b</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2350">#2350</a> from github/angelapwen/add-exclude-pr-check-param</li> <li>Additional commits viewable in <a href="https://github.com/github/codeql-action/compare/23acc5c183826b7a8a97bce3cecc52db901f8251...b611370bb5703a7efb587f9d136a52ea24c5c38c">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
-
Andrew Kolos authored
[tool] when writing to openssl as a part of macOS/iOS code-signing, flush the stdin stream before closing it (#150120) Fixes https://github.com/flutter/flutter/issues/100584. Might help https://github.com/flutter/flutter/issues/137184.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/a78f5ce743ce...2f7e9ab27493 2024-06-28 skia-flutter-autoroll@skia.org Roll Skia from 7a09d38fa7f8 to 3d5f5d546fb6 (1 revision) (flutter/engine#53634) 2024-06-28 skia-flutter-autoroll@skia.org Roll Skia from 23a14cccc800 to 7a09d38fa7f8 (1 revision) (flutter/engine#53633) 2024-06-28 skia-flutter-autoroll@skia.org Roll Skia from cd77153f20a8 to 23a14cccc800 (1 revision) (flutter/engine#53631) 2024-06-28 flar@google.com Revert "[DisplayList] Add support for clipOval to leverage Impeller optimization" (flutter/engine#53629) 2024-06-28 skia-flutter-autoroll@skia.org Roll Dart SDK from 4005e5f1fb8e to 341dbaf977a3 (1 revision) (flutter/engine#53630) 2024-06-28 skia-flutter-autoroll@skia.org Roll Skia from 6650fcc6d054 to cd77153f20a8 (1 revision) (flutter/engine#53628) 2024-06-28 skia-flutter-autoroll@skia.org Roll Skia from 2204428a75ca to 6650fcc6d054 (2 revisions) (flutter/engine#53627) 2024-06-28 skia-flutter-autoroll@skia.org Roll Dart SDK from 0820b0766ac9 to 4005e5f1fb8e (1 revision) (flutter/engine#53626) 2024-06-28 skia-flutter-autoroll@skia.org Roll Skia from 1700e3962acd to 2204428a75ca (1 revision) (flutter/engine#53625) 2024-06-28 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from gBWzGuicxu76K82lg... to H_P7EHb4zXXV-Eiik... (flutter/engine#53624) 2024-06-28 flar@google.com [DisplayList] Add support for clipOval to leverage Impeller optimization (flutter/engine#53622) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from gBWzGuicxu76 to H_P7EHb4zXXV If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Tim Lehmann authored
Reopened after revert in #147658 Another test was added in the meantime to `draggable_test.dart` that didn't call `gesture.up()`. I added this call to the test and now all tests pass. --- # Original Description (#145647): We changed the coordinates used to position the `Draggable` feedback by transforming them into the `Overlay`s coordinate space. This has no influence on any untransformed `Overlay`, most Flutter apps should be not affected. This PR fixes the positioning of the feedback in transformed context (see #145639 for before video): https://github.com/flutter/flutter/assets/42270125/df34e198-0667-453d-a27a-a79b2e2825a1 - fixes #145639 ## Pre-launch Checklist - [X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [X] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [X] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [X] I signed the [CLA]. - [X] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat [Data Driven Fixes]: https://github.com/flutter/flutter/wiki/Data-driven-Fixes --------- Co-authored-by:
Jesper Bellenbaum <ayu4ger@gmail.com>
-
Michael Rittmeister authored
The Gradle Kotlin DSL also allows for type-safe application of the Flutter Gradle plugin, which is currently undetected by the CLI ```kotlin plugins { dev.flutter.`flutter-gradle-plugin` } ``` Please note that the added test case isn't ideal, since the example gradle isn't actually valid kotlin DSL, however the `kotlin host app language with Gradle Kotlin DSL` is identical Fixes #149859
-
Alejandro Santiago authored
The Pull Request changes the `dartSdkVersionBounds` value, which gets templated into the `pubspec.yaml` from the `flutter create`: https://github.com/flutter/flutter/blob/ffdeaa1995efc1fe7d759e13b92eba1ec57beea6/packages/flutter_tools/templates/app/pubspec.yaml.tmpl#L8 As from the Dart dependencies ["Best practices"](https://dart.dev/tools/pub/dependencies#use-caret-syntax) section of the documentation: > Use caret syntax Specify dependencies using the [caret syntax](https://dart.dev/tools/pub/dependencies#caret-syntax). This allows the pub tool to select newer versions of the package when they become available. Further, it places an upper bound on the allowed version. To learn more about the Caret syntax, refer to the [Caret syntax documentation](https://github.com/flutter/flutter/blob/ffdeaa1995efc1fe7d759e13b92eba1ec57beea6/packages/flutter_tools/templates/app/pubspec.yaml.tmpl#L8). **Additional context** - https://github.com/VGVentures/io_crossword/pull/592#event-13304953743 (cc: @kevmoo) - [Very Good Templates](https://github.com/VeryGoodOpenSource/very_good_templates) relies on the Caret syntax when templating the Dart SDK
-
- Jun 28, 2024
-
-
engine-flutter-autoroll authored
https://github.com/flutter/packages/compare/03f5f6d5660c...412ec4615aa4 2024-06-28 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.6 to 3.25.10 (flutter/packages#6924) 2024-06-27 ditman@gmail.com [video_player] Exposes VideoPlayerWebOptions. (flutter/packages#6990) 2024-06-27 ditman@gmail.com [ci] Add Wasm compilation to all_packages web app. (flutter/packages#6981) 2024-06-27 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Updates `README` with a usage section and fix some interface docs (flutter/packages#6988) 2024-06-27 stuartmorgan@google.com [tools] Fix vm test requirement (flutter/packages#6995) 2024-06-27 jacksongardner@google.com Update `web_benchmarks` package to properly support wasm. (flutter/packages#6970) 2024-06-27 stuartmorgan@google.com [pigeon] Implement equals for Java data classes (flutter/packages#6992) 2024-06-25 matanlurey@users.noreply.github.com Final refactor of `video_player_android` before `SurfaceProducer#setCallback`. (flutter/packages#6982) 2024-06-25 stuartmorgan@google.com [pigeon] Update testing and docs (flutter/packages#6984) 2024-06-25 parlough@gmail.com [various] Update flutter.dev links to more reliable destinations (flutter/packages#6963) 2024-06-25 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Adds initial Android implementation (flutter/packages#6733) 2024-06-25 engine-flutter-autoroll@skia.org Roll Flutter from 6c06abbb to e726eb40 (51 revisions) (flutter/packages#6987) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Danny Tuppeny authored
The debug adapter converts Flutter's structured errors into a text format to be sent to the debug client and shown in the console. When an error is not the first error since the last reload, it is shown as just a summary (since it may be caused by a prior error). In this mode, the filter was causing some important information (the erroring widget) to be omitted. This tweaks the logic to include child nodes of a `DiagnosticBlock` in this mode. Fixes https://github.com/Dart-Code/Dart-Code/issues/4743 ## Before:  ## After: 
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/94591ffb20df...a78f5ce743ce 2024-06-28 skia-flutter-autoroll@skia.org Roll Dart SDK from e7022f6eb6c9 to 0820b0766ac9 (1 revision) (flutter/engine#53623) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/ddd4814b9d40...94591ffb20df 2024-06-27 skia-flutter-autoroll@skia.org Roll Skia from cbd6e55139ca to 1700e3962acd (2 revisions) (flutter/engine#53619) 2024-06-27 skia-flutter-autoroll@skia.org Roll Dart SDK from b5f079c2936e to e7022f6eb6c9 (1 revision) (flutter/engine#53616) 2024-06-27 chinmaygarde@google.com Update DEPS to pull in 8c2d66fa4e6298894425f5bdd0591bc5b1154c53. (flutter/engine#53614) 2024-06-27 skia-flutter-autoroll@skia.org Roll Skia from c73e514838b4 to cbd6e55139ca (4 revisions) (flutter/engine#53615) 2024-06-27 johnoneil@users.noreply.github.com Fix #150515 Provide required headers for build with Clang-16 and GCC ⦠(flutter/engine#53479) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Gray Mackall authored
Manual engine roll up to https://github.com/flutter/engine/pull/53592. Manual roll because the change requires Gradle lockfiles to be re-generated.
-
Reid Baker authored
- **Fix gradle lint task configuration issue on release builds** Fixes #150955
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/b42c80460538...d1506c12808e 2024-06-27 skia-flutter-autoroll@skia.org Roll Skia from 09a46ebe4c01 to dee7339d0b53 (5 revisions) (flutter/engine#53612) 2024-06-27 skia-flutter-autoroll@skia.org Roll Dart SDK from 65fa56a24416 to b5f079c2936e (1 revision) (flutter/engine#53611) 2024-06-27 skia-flutter-autoroll@skia.org Roll Skia from a407ec8a29b9 to 09a46ebe4c01 (1 revision) (flutter/engine#53610) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Andrew Kolos authored
[tool] make the `systemTempDirectory` getter on `ErrorHandlingFileSystem` wrap the underlying filesystem's temp directory in a`ErrorHandlingDirectory` (#150876) Fixes https://github.com/flutter/flutter/issues/150730 If you can think of a more concise title, be my guest.
-
Jackson Gardner authored
If the user specifies the `--no-web-resources-cdn` or `--local-web-sdk`, we should use the local version of CanvasKit. `flutter.js` now has a flag that can be specified in the build configuration that tells it to load locally instead. Also, added a link to the relevant docs in the web template warnings. This addresses https://github.com/flutter/flutter/issues/148713 Also fixes https://github.com/flutter/flutter/issues/145559
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/a9194f0f01f4...b42c80460538 2024-06-27 skia-flutter-autoroll@skia.org Roll Dart SDK from 7d7fbb30e0ca to 65fa56a24416 (1 revision) (flutter/engine#53609) 2024-06-27 skia-flutter-autoroll@skia.org Roll Dart SDK from d825219c0ce1 to 7d7fbb30e0ca (1 revision) (flutter/engine#53608) 2024-06-27 skia-flutter-autoroll@skia.org Roll Skia from fb1458ac7bfd to a407ec8a29b9 (2 revisions) (flutter/engine#53607) 2024-06-27 skia-flutter-autoroll@skia.org Roll Skia from e2f68b30ea63 to fb1458ac7bfd (1 revision) (flutter/engine#53606) 2024-06-27 skia-flutter-autoroll@skia.org Roll Skia from 7b55cb1afe40 to e2f68b30ea63 (1 revision) (flutter/engine#53605) 2024-06-27 skia-flutter-autoroll@skia.org Roll Skia from 001694095f1b to 7b55cb1afe40 (1 revision) (flutter/engine#53603) 2024-06-27 skia-flutter-autoroll@skia.org Roll Dart SDK from 8dd486ebfab4 to d825219c0ce1 (1 revision) (flutter/engine#53602) 2024-06-27 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from n2dgSmMCaCO7ujvmr... to gBWzGuicxu76K82lg... (flutter/engine#53601) 2024-06-27 skia-flutter-autoroll@skia.org Roll Dart SDK from c01f907d34d8 to 8dd486ebfab4 (1 revision) (flutter/engine#53599) 2024-06-26 skia-flutter-autoroll@skia.org Roll Skia from 55ada83438cd to 001694095f1b (3 revisions) (flutter/engine#53598) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from n2dgSmMCaCO7 to gBWzGuicxu76 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
hangyu authored
issue: https://github.com/flutter/flutter/issues/117997 This is a partial reland of https://github.com/flutter/flutter/pull/149375 with updated g3fix cl/642457545 ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
-
Michael Goderbauer authored
-
- Jun 27, 2024
-
-
Yegor authored
Adds `onFocus` support to Cupertino and Material text field widgets (similar to https://github.com/flutter/flutter/pull/142942).
-
LouiseHsu authored
Fixes `flutter build ipa` failure: Command line name "app-store" is deprecated. Use "app-store-connect" (#150407) Fixes https://github.com/flutter/flutter/issues/149369
-
Ricardo Boss authored
This changes how the `IconThemeData` is passed to the child of `CupertinoButton`. Previously, it would derive the foreground color from the current theme and create a new `IconThemeData` object. This causes any `IconThemeData` to be overwritten. This change uses `IconTheme.of` to get the currently applied icon theme and only overwrites the properties provided by the `CupertinoButton` instead of the whole object. Fixes #149172.
-