Skip to content
Snippets Groups Projects
Select Git revision
0 result
Search by author
  • Any Author
  • ExcellentOSS ExcellentOSS ExcellentOSS
1 author
This project is mirrored from https://github.com/flutter/flutter.git. Pull mirroring updated .
  1. Feb 14, 2024
  3. Feb 07, 2024
    • flutteractionsbot's avatar
      [CP-beta]Test codesigning xcframeworks in artifacts (#143015) · 005b8e18
      flutteractionsbot authored 
      **This pull request is opened against a release branch.<br>
To request a cherry pick of a commit, please fill in the form below.** (Questions with an asterisk are required.)<br>

**To fill in the form, you can edit this PR description and type your answers after the 'My Answer' keywords. <br>
A flutter domain expert will evaluate this cherry pick request shortly after ALL questions are answered.**

* Issue Link: What is the link to the issue this cherry-pick is addressing?<br>

<pre>
  <b>My Answer:</b>
https://github.com/flutter/flutter/issues/140934

</pre>

* Changelog Description: Explain this cherry pick in one line that is accessible to most Flutter developers
        See https://github.com/flutter/flutter/wiki/Hotfix-Documentation-Best-Practices for examples (Bug fix, feature, docs update, ...)<br>

<pre>
  <b>My Answer:</b>
This cherry pick enables code signing test to run on release branches.

</pre>

* Impacted Users: Approximately who will hit this issue (ex. all Flutter devs, Windows developers, all end-customers, apps using X framework feature)?<br>

<pre>
  <b>My Answer:</b>
Release engineers who run code signing tests on releases.

</pre>

* impact_description: What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)<br>

<pre>
  <b>My Answer:</b>
Enabling codesigning Test would test the release artifact, and make sure both binaries and bundles are code signed.

</pre>

* Workaround: Is there a workaround for this issue?<br>

<pre>
  <b>My Answer:</b>
We can verify manually, but enabling an automated Code signing test would be better.

</pre>

* Risk: What is the risk level of this cherry-pick?<br>

<pre>
  <b>My Answer:</b>

</pre>

* Test Coverage: Are you confident that your fix is well-tested by automated tests?<br>

<pre>
  <b>My Answer:</b>

</pre>

* Validation Steps: What are the steps to validate that this fix works?<br>

<pre>
  <b>My Answer:</b>
code sign test should run on post submit of release branches and pass

</pre>
      005b8e18
  5. Feb 02, 2024
  7. Jan 31, 2024
  9. Jan 30, 2024
  11. Jan 26, 2024
  13. Jan 18, 2024
  15. Jan 12, 2024
  17. Jan 11, 2024
  19. Jan 08, 2024
  21. Jan 07, 2024
  23. Jan 06, 2024
  25. Jan 05, 2024