This project is mirrored from https://github.com/flutter/flutter.git.
Pull mirroring updated .
- Mar 10, 2024
-
-
Ian Hickson authored
This is part 4 of a broken down version of the #140101 refactor. This PR renames isAvailableForEnvironment to isForEnvironment and replaces a regular expression with a simple function. (The latter will change the behaviour for people with branch names like `mainly_refactors` or `chess_master_experiment` or whatever, but I'm pretty sure the old behaviour was not intended.) ---- This is a reland of https://github.com/flutter/flutter/pull/143176 which was speculatively reverted in https://github.com/flutter/flutter/pull/144855 but turned out not to be the cause of the tree redness.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/f77664330122...7c2a56a44b41 2024-03-10 skia-flutter-autoroll@skia.org Roll Skia from 8b92038ff67f to e6b884229d2d (1 revision) (flutter/engine#51316) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/51fefde43cb3...f77664330122 2024-03-09 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from lAV5jgp4796siOZgI... to gJ4Wr2FSpnGmoN3ke... (flutter/engine#51315) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from lAV5jgp4796s to gJ4Wr2FSpnGm If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/49f01510e4e2...51fefde43cb3 2024-03-09 skia-flutter-autoroll@skia.org Roll Skia from 983774f73a16 to 8b92038ff67f (1 revision) (flutter/engine#51313) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/958d7cd560d2...49f01510e4e2 2024-03-09 zanderso@users.noreply.github.com Roll buildroot to e9df434539745202fa5f9b729fe5f82e5de3f025 (flutter/engine#51306) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/fc06f5a99377...958d7cd560d2 2024-03-09 zanderso@users.noreply.github.com Explicitly list Android embedding dependency jars in GN (flutter/engine#51303) 2024-03-09 skia-flutter-autoroll@skia.org Roll Skia from 0da56a6c7446 to 983774f73a16 (1 revision) (flutter/engine#51311) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
- Mar 09, 2024
-
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/6f7fdc533490...fc06f5a99377 2024-03-09 skia-flutter-autoroll@skia.org Roll Dart SDK from 02e78997f308 to c3bd630e89bb (1 revision) (flutter/engine#51309) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/196132ffe2f8...6f7fdc533490 2024-03-09 skia-flutter-autoroll@skia.org Roll Skia from 8feb4b6a4aa6 to 0da56a6c7446 (1 revision) (flutter/engine#51308) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
yim authored
Fixes #143524
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/d4e3d964dc8a...196132ffe2f8 2024-03-09 skia-flutter-autoroll@skia.org Roll Dart SDK from b52b754d5d3e to 02e78997f308 (1 revision) (flutter/engine#51307) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/e79a72d362a7...d4e3d964dc8a 2024-03-09 skia-flutter-autoroll@skia.org Roll Skia from 3b0b79511469 to 8feb4b6a4aa6 (18 revisions) (flutter/engine#51305) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/c3b70321be79...e79a72d362a7 2024-03-09 skia-flutter-autoroll@skia.org Manual roll Dart SDK from 4c64fcc134bf to b52b754d5d3e (6 revisions) (flutter/engine#51304) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/79536627661a...c3b70321be79 2024-03-09 skia-flutter-autoroll@skia.org Roll Skia from a4fb847f47d9 to 3b0b79511469 (1 revision) (flutter/engine#51289) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/7541e902f1b4...79536627661a 2024-03-09 chinmaygarde@google.com [Impeller] Use the AHB prefix for utils that work with Android Hardware Buffers. (flutter/engine#51298) 2024-03-09 chinmaygarde@google.com [Impeller] Make DeviceHolder follow convention for backend specific utilities. (flutter/engine#51300) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/953927eae78b...7541e902f1b4 2024-03-08 30870216+gaaclarke@users.noreply.github.com [Impeller] implement mask blur for textures (flutter/engine#51183) 2024-03-08 zanderso@users.noreply.github.com Don't rely on dart binary on PATH in run_test.py (flutter/engine#51302) 2024-03-08 tugorez@users.noreply.github.com Mark the Flutter Views as focusable by setting a tabindex value. (flutter/engine#50876) 2024-03-08 chinmaygarde@google.com Update the instructions for updating licenses. (flutter/engine#51297) 2024-03-08 1961493+harryterkelsen@users.noreply.github.com Optimize overlays in CanvasKit (flutter/engine#47317) 2024-03-08 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 5Ra_AjCji-uR1GaX7... to lAV5jgp4796siOZgI... (flutter/engine#51296) 2024-03-08 chinmaygarde@google.com [Impeller] Add the KHR prefix to existing swapchain utilities. (flutter/engine#51295) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from 5Ra_AjCji-uR to lAV5jgp4796s If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Polina Cherkasova authored
-
Percival authored
I have found that some Apple-related links are no longer accessible, and they have been replaced
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/e099277ce061...953927eae78b 2024-03-08 zanderso@users.noreply.github.com Revert test if changes to golden tests (flutter/engine#51291) 2024-03-08 jmccandless@google.com iPad keyboard cut/copy/paste buttons (flutter/engine#50923) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
-
auto-submit[bot] authored
Reverts: flutter/flutter#143176 Initiated by: QuncCccccc Reason for reverting: made tree red. Original PR Author: Hixie Reviewed By: {Piinks} This change reverts the following previous change: This is part 4 of a broken down version of the #140101 refactor. This PR renames isAvailableForEnvironment to isForEnvironment and replaces a regular expression with a simple function. (The latter will change the behaviour for people with branch names like `mainly_refactors` or `chess_master_experiment` or whatever, but I'm pretty sure the old behaviour was not intended.) -
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/05fdf947f81b...e099277ce061 2024-03-08 dnfield@google.com Use `io.flutter.Build.API_LEVELS` rather than `android.os.Build.VERSION_CODES` (flutter/engine#51171) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Ian Hickson authored
This is part 4 of a broken down version of the #140101 refactor. This PR renames isAvailableForEnvironment to isForEnvironment and replaces a regular expression with a simple function. (The latter will change the behaviour for people with branch names like `mainly_refactors` or `chess_master_experiment` or whatever, but I'm pretty sure the old behaviour was not intended.)
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/bc4abcda6357...05fdf947f81b 2024-03-08 jonahwilliams@google.com [Impeller] More efficient usage of transient onscreen attachments. (flutter/engine#51206) 2024-03-08 68449066+zijiehe-google-com@users.noreply.github.com [Fuchsia] Providing FUCHSIA_SDK_PATH env var for fuchsia lsc (flutter/engine#51234) 2024-03-08 chris@bracken.jp Migrate vulkan_memory_allocator to flutter/third_party (flutter/engine#51275) 2024-03-08 jason-simmons@users.noreply.github.com Update CI scripts to use either src/flutter/third_party/dart or src/third_party/dart (flutter/engine#51276) 2024-03-08 kustermann@google.com Add fuchsia_gn_sdk GN variable pointing to //flutter/tools/fuchsia/gn-sdk (flutter/engine#51287) 2024-03-08 skia-flutter-autoroll@skia.org Roll Skia from 993a88a663c8 to a4fb847f47d9 (1 revision) (flutter/engine#51283) 2024-03-08 skia-flutter-autoroll@skia.org Roll Skia from 15f8d03a9594 to 993a88a663c8 (1 revision) (flutter/engine#51282) 2024-03-08 skia-flutter-autoroll@skia.org Roll Skia from 093994f8f078 to 15f8d03a9594 (1 revision) (flutter/engine#51280) 2024-03-08 skia-flutter-autoroll@skia.org Roll Skia from bf3f9c5f0edb to 093994f8f078 (1 revision) (flutter/engine#51278) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Mitchell Goodwin authored
Fixes #124850. Changes the fallback for the builder on Android. Before the error was from the platform being changed mid Cupertino transition to iOS. If a default builder wasn't set for iOS (which a developer developing only for Android might not), then it defaulted to the Zoom transition. Which changing the transition while on the fly caused issues.
-
Jackson Gardner authored
This fixes https://github.com/flutter/flutter/issues/143703 We need to make sure that when source maps are enabled for the dart2js target, it advertises the sourcemap file as one of its outputs so that the web release bundle can copy it over.
-
Flutter GitHub Bot authored
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY. { "name": "Linux_android new_gallery_opengles_impeller__transition_perf" } --> The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux_android%20new_gallery_opengles_impeller__transition_perf%22). This test can be marked as unflaky. -
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/bbb1ed00af49...bc4abcda6357 2024-03-08 bdero@google.com [Impeller] Add mask blur style support to the RRect blur fast path. (flutter/engine#51250) 2024-03-08 30870216+gaaclarke@users.noreply.github.com [Impeller] moved tests to aiks_blur_unittests, added warning (flutter/engine#51274) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
- Mar 08, 2024
-
-
engine-flutter-autoroll authored
https://github.com/flutter/packages/compare/6701c9e61804...0badb4356021 2024-03-07 katelovett@google.com [two_dimensional_scrollables] Fix another combo of pinned/unpinned merged TableViewCells (flutter/packages#6283) 2024-03-07 engine-flutter-autoroll@skia.org Roll Flutter from 8f84f3f3 to 471a8285 (27 revisions) (flutter/packages#6281) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Martin Kustermann authored
Remove `toString()` overrides in `dart:ui`/`package:flutter` in profile/release mode on wasm/vm targets (#144763) The flutter engine & framework can opt out of this optimization for individual classes / class hierarchies via: * `@pragma(flutter:keep-to-string)` * `@pragma(flutter:keep-to-string-in-subtypes)` Or by using the convenience constant `@keepToString` from `dart:ui`. => This aligns the build process more with g3 (which already does this) Closes https://github.com/flutter/flutter/issues/52759
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/80cd7981043f...bbb1ed00af49 2024-03-08 chris@bracken.jp Move ANGLE to flutter/third_party (flutter/engine#51270) 2024-03-07 skia-flutter-autoroll@skia.org Roll Skia from 4a65dfcc70a5 to bf3f9c5f0edb (4 revisions) (flutter/engine#51268) 2024-03-07 jason-simmons@users.noreply.github.com [Impeller] Fix a buffer overrun in ImpellerC reflector resource offsets (flutter/engine#51108) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Loïc de Porcaro authored
## Update `AlertDialog` Documentation for Material 3 Defaults This pull request updates the documentation for `AlertDialog` to accurately reflect the default text styles (`titleTextStyle` and `contentTextStyle`) when using Material 3. Previously, the documentation suggested default styles (`TextTheme.titleLarge` for titles and `TextTheme.titleMedium` for content) that do not align with Material 3 implementation, which uses `TextTheme.headlineSmall` and `TextTheme.bodyMedium` respectively. Fixes #144489
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/175069397a40...80cd7981043f 2024-03-07 chris@bracken.jp Roll buildroot to ef514ca5144ba0a4ce5e7075c325d24cd6da73a4 (flutter/engine#51265) 2024-03-07 skia-flutter-autoroll@skia.org Roll Dart SDK from 4bc97350dc47 to 4c64fcc134bf (1 revision) (flutter/engine#51266) 2024-03-07 bdero@google.com [Impeller] Record restore clips in the replay mechanism when StC is enabled. (flutter/engine#51259) 2024-03-07 skia-flutter-autoroll@skia.org Roll Skia from 6bfd57b8790f to 4a65dfcc70a5 (2 revisions) (flutter/engine#51263) 2024-03-07 zanderso@users.noreply.github.com [gn] Disable running some python scripts from GN (flutter/engine#51248) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Andrew Kolos authored
Partial implementation of https://github.com/flutter/flutter/issues/143348. The title says it all. Feel free to experiment with the feature using this project: https://github.com/andrewkolos/asset_transformers_test.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/ec4f9af3d53b...175069397a40 2024-03-07 chris@bracken.jp Migrate build_overrides from buildroot to engine (flutter/engine#51258) 2024-03-07 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from y67DIBX84h7pAekIp... to 5Ra_AjCji-uR1GaX7... (flutter/engine#51261) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from y67DIBX84h7p to 5Ra_AjCji-uR If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
August authored
Part of #137040 and #80374 The flag `throwOnPluginPubspecError` never actually was enabled during production in #79669, but only in some dart plugin tests. And in the tests the case of the error when enabling the flag was not explicitly tested. The only thing tested was, that it is not thrown when disabled. As explained [here](https://github.com/flutter/flutter/pull/142035#discussion_r1484237904) the only case, where this error could be thrown is, when a dart implementation and a native inline implementation are provided simultaneously. But throwing an exception there is a wrong behavior, as both can coexist in a plugin package, thus in the pubspec file. Disabling the flag means, that the error is not thrown and not shown to the user. This is the case in production (contrary to the dart plugin tests), which acts like these plugin cases of implementations are just skipped. And this is what actually should be done. In conclusion, I think the case of coexisting dart and native implementation in pubspec was just overlooked and therefore this error validation was introduced, which is not necessary or even valid. For more discussion, see: https://discord.com/channels/608014603317936148/608022056616853515/1200194937791205436 - This is tricky: I already added a test in #142035, which finally complies with the other tests, by removing the flag. So I think it falls in the category of "remove dead code". - Theoretically this is a breaking change, as removing / altering some tests. But the flag actually was never valid or used, so IDK. But this may not does fall in the category of "contributed tests".
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/305333c50191...ec4f9af3d53b 2024-03-07 skia-flutter-autoroll@skia.org Roll Skia from cf7fefd0bbfb to 6bfd57b8790f (24 revisions) (flutter/engine#51260) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/c2863530ce39...305333c50191 2024-03-07 skia-flutter-autoroll@skia.org Roll Skia from f17ec7494469 to cf7fefd0bbfb (1 revision) (flutter/engine#51227) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Faisal Ansari authored
Fixed -> DropdownMenu throws exception when it is in any scrollable list view and scrolls quickly #139871
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/9e8ccaa3842e...c2863530ce39 2024-03-07 skia-flutter-autoroll@skia.org Roll Dart SDK from bbf21a08a92d to 4bc97350dc47 (1 revision) (flutter/engine#51256) 2024-03-07 tugorez@users.noreply.github.com Prepend the accessibility placeholder (flutter/engine#51050) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/12828950890a...9e8ccaa3842e 2024-03-07 jesus_sguerrero@hotmail.com Skip impeller goldens on release (flutter/engine#51240) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
![auto-submit[bot]'s avatar](https://secure.gravatar.com/avatar/7b11150286008279e41ae47cdf1ca34cd65819555de0eba8efa968c8e1838e1a?s=80&d=identicon "auto-submit[bot]")
