This project is mirrored from https://github.com/flutter/flutter.git.
Pull mirroring updated .
- Apr 12, 2025
-
-
Reid Baker authored
-
- Apr 11, 2025
-
-
flutteractionsbot authored
[CP-stable][ Hot Restart ] Fix possible hang due to unhandled exception in UI isolates on hot restart (#166064) This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request) Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request. ### Issue Link: https://github.com/flutter/flutter/issues/161466 ### Changelog Description: [flutter/161466](https://github.com/flutter/flutter/issues/161466): Fixed issue where hot restart could hang indefinitely if "Pause on Unhandled Exceptions" was enabled and a call to `Isolate.run` had not completed. ### Impact Description: Hot restart (and the Dart-Code extension) could end up in a bad state where hot restart never completes and interacting with the application via the Dart-Code extension doesn't work as expected. The application becomes unresponsive and must be fully restarted to continue development. `Isolate.run` is used to load license files in the background, meaning that users don't need to explicitly be spawning isolates to encounter this issue. ### Workaround: Is there a workaround for this issue? Explicitly disable "Pause on Unhandled Exceptions", which is typically enabled by default. ### Risk: What is the risk level of this cherry-pick? ### Test Coverage: Are you confident that your fix is well-tested by automated tests? ### Validation Steps: What are the steps to validate that this fix works? 1. Create a Flutter project with the following `main.dart`: ```dart import 'dart:async'; import 'dart:developer'; import 'dart:isolate'; import 'package:flutter/material.dart'; void main() { WidgetsFlutterBinding.ensureInitialized().platformDispatcher.onError = (Object error, StackTrace? stack) { return true; }; runApp( const Center( child: Text( 'Hello, world!', key: Key('title'), textDirection: TextDirection.ltr, ), ), ); Isolate.run(() { print('COMPUTING'); debugger(); }); } ``` 2. Run the application in debug mode and perform a hot restart once `COMPUTING` appears on `stdout`. Hot restart should complete successfully.
-
- Apr 10, 2025
-
-
John "codefu" McDole authored
Cherry picks #165818 `update_engine_version.{ps1|sh}` needs to operate on a foreign repository. When flutter is run in a git-hook, these environment variables will override our git calls location and corrupt the install. Cherry pick notes: The files are diverging a bit; but the guts of the change were clean (ps1|sh) and the tests just needed some care.
-
flutteractionsbot authored
This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request) Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request. ### Issue Link: What is the link to the issue this cherry-pick is addressing? https://github.com/flutter/flutter/issues/163627 ### Changelog Description: Explain this cherry pick in one line that is accessible to most Flutter developers. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples [flutter/163627](https://github.com/flutter/flutter/issues/163627): Fix issue where placeholder types in ARB localizations weren't used for type inference, causing a possible type mismatch with the placeholder field defined in the template. ### Impact Description: What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch) Developers are unable to successfully generate localization code without making changes across all of their ARB files. ### Workaround: Is there a workaround for this issue? Downgrade to 3.27 or explicitly define types for all impacted placeholders across all template and localization files. ### Risk: What is the risk level of this cherry-pick? ### Test Coverage: Are you confident that your fix is well-tested by automated tests? ### Validation Steps: What are the steps to validate that this fix works? See https://github.com/benthillerkus/i18n_repro
-
Victoria Ashworth authored
Impacted Users: Flutter Release team, no external users impacted Impact Description: Runs tests on Xcode 16 and iOS 18 Simulator Workaround: N/A Risk: Low Test Coverage: Yes Validation Steps: N/A
-
- Apr 09, 2025
-
-
gaaclarke authored
cherry-pick of https://github.com/flutter/flutter/pull/165098 ## Impacted Users Impeller users developing on the Android Emulator (or some old hardware) ## Impact Description Crash in the Flutter app ## Workaround (Is there a workaround for this issue?) Use a real android device. ## Risk (What is the risk level of this cherry-pick?) ## Test Coverage (Are you confident that your fix is well-tested by automated tests?) Yes, there is an integration test that captures most of the problem. ## Validation Steps (What are the steps to validate that this fix works?) https://github.com/flutter/flutter/issues/163421 has reproduction steps
-
Reid Baker authored
Similar to https://github.com/flutter/flutter/pull/166438 Fixes #66553 Cherry pick the following prs to hopefully fix pre/post submits against 3.29. * https://github.com/flutter/flutter/pull/165692 * https://github.com/flutter/flutter/pull/165675 * https://github.com/flutter/flutter/pull/165678 * https://github.com/flutter/flutter/pull/166559 * Does not include https://github.com/flutter/flutter/pull/165818
-
- Mar 28, 2025
-
-
gaaclarke authored
## Impacted Users Impeller, all platforms ## Impact Description Text that is scaled over 48x will render at the incorrect size and position ## Workaround Change the font size instead of using a scale, but this isn't always clear from the framework usage. ## Risk If it is wrong, text will be rendered incorrectly. ## Test Coverage A golden test was written but they aren't automatically executed on release branches. ## Validation Steps https://github.com/flutter/flutter/issues/165130 has reproduction code
-
Justin McCandless authored
The `Linux tool_integration_tests*` have been failing on this release branch, blocking cherry picks https://github.com/flutter/flutter/pull/165430 and https://github.com/flutter/flutter/pull/165428. This PR attempts to cherry pick fixes that will make the tests go green. This PR contains cherry-picks of three PRs: * https://github.com/flutter/flutter/pull/164935 * https://github.com/flutter/flutter/pull/165620 * https://github.com/flutter/flutter/pull/165661 Example of the failures I was seeing: https://github.com/flutter/flutter/pull/165428/checks?check_run_id=38997055797. ``` error: { code: 5 message: builder not found: "Linux tool_integration_tests_1_6" } ```
-
- Mar 14, 2025
-
-
Reid Baker authored
Only the engine version change.
-
Jonah Williams authored
Cherry pick of https://github.com/flutter/flutter/pull/164126
-
Jonah Williams authored
Changelog for https://github.com/flutter/flutter/pull/165075, the dart stable change and for https://github.com/flutter/flutter/pull/165080
-
- Mar 13, 2025
-
-
Jonah Williams authored
Cherry pick fix of https://github.com/flutter/flutter/issues/164606 .
-
gaaclarke authored
cherry-pick of https://github.com/flutter/flutter/pull/165008 ## Impacted Users Impeller users. ## Impact Description Text that is rotated 180 degrees exactly will render as if it is scaled by {-1, 1} instead of {-1, -1}. ## Workaround You can rotate text 180.001 degrees instead but the fidelity will be less. ## Risk If it's wrong it could break all text rendering. There are golden tests for it. ## Test Coverage Golden tests (which are not run on release branches) ## Validation Steps https://github.com/flutter/flutter/issues/164958 has reproduction code
-
Jonah Williams authored
[CP] Change fallback behavior for devices pre API 29 to Skia regardless of Impeller state. (#165090) CP of https://github.com/flutter/flutter/pull/165075 > There are currently a large amount of crashes coming from older devices that we don't have good test coverage for. For now, lets remove the fallback to ImpellerGLES on old devices and instead use SkiaGLES, which we know from experience works on these older devices.
-
Reid Baker authored
Update dart version
-
Jonah Williams authored
Fixes https://github.com/flutter/flutter/issues/161142
-
- Mar 12, 2025
-
-
Harry Terkelsen authored
### Issue Link: What is the link to the issue this cherry-pick is addressing? https://github.com/flutter/flutter/issues/159974 ### Changelog Description: Explain this cherry pick in one line that is accessible to most Flutter developers. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples Improve performance of CanvasKit by avoiding copying bitmaps when rendering ### Impact Description: What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch) Improves performance of all apps using CanvasKit. Fixes a bug relating to embedded Flutter apps on mobile. ### Workaround: Is there a workaround for this issue? No ### Risk: What is the risk level of this cherry-pick? ### Test Coverage: Are you confident that your fix is well-tested by automated tests? ### Validation Steps: What are the steps to validate that this fix works? Run the example app in the fixed issue on Chrome for Android and verify it works as expected.
-
Gray Mackall authored
[CP-stable] Add empty io.flutter.app.FlutterApplication to give deprecation notice, and un-break projects that have not migrated (#164730) This is just the engine portion of https://github.com/flutter/flutter/pull/164343. I.e., it does not contain the test change. Copied from the original cherry pick pr: This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request) Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request. ### Issue Link: What is the link to the issue this cherry-pick is addressing? https://github.com/flutter/flutter/issues/164024 ### Changelog Description: Explain this cherry pick in one line that is accessible to most Flutter developers. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples https://github.com/flutter/flutter/issues/164024: Add back an empty `io.flutter.app.FlutterApplication` for Android apps that reference that class post v2 embedder migration ### Impact Description: What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch) The class does not provide any additional funcitonality, but it class was removed without sufficient notice in the breaking changes section of the Flutter documentation. As such, consumers of this class were broken without sufficient time to migrate. ### Workaround: Is there a workaround for this issue? Flutter projects which need a custom `Application` can instead simply extend an `android.app.Application`. There is no reason to extend a `FlutterApplication`. ### Risk: What is the risk level of this cherry-pick? ### Test Coverage: Are you confident that your fix is well-tested by automated tests? ### Validation Steps: What are the steps to validate that this fix works? Either make a flutter app which depends on this class, or run the spell check integration tests: ``` # from the .../flutter/dev/devicelab directory ../../bin/cache/dart-sdk/bin/dart bin/test_runner.dart test -t spell_check_test ```
-
Jonah Williams authored
FIxes https://github.com/flutter/flutter/issues/164628
-
Bobek Bobekos authored
[CP][Stable] Fix race condition causing crash when interacting with an animating scrollable (#164708) …Fix race condition causing crash when interacting with an animating scrollable (#164392) Fix https://github.com/flutter/flutter/issues/163297 Fix https://github.com/flutter/flutter/issues/14452 Partial patch: https://github.com/flutter/flutter/pull/37267 https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md <!-- Thanks for filing a pull request! Reviewers are typically assigned within a week of filing a request. To learn more about code review, see our documentation on Tree Hygiene: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md --> *Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.* *List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.* *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
-
- Mar 11, 2025
-
-
Jonah Williams authored
Rather than conditionally disabling AHBs, just disable Vulkan on devices where AHB imports don't work. FIx from last time is in the last commit, I reversed the string check accidentally and disabled vulkan everywhere 🥺 https://github.com/flutter/flutter/issues/163473 https://github.com/flutter/flutter/issues/160854
-
- Mar 08, 2025
-
-
Harry Terkelsen authored
## Stable Cherry Pick Cherry-picks https://github.com/flutter/flutter/pull/162198 to stable to fix issue with double-downloading CanvasKit. Fixes https://github.com/flutter/flutter/issues/163250 Impacted Users: All Flutter Web users Impact Description: `canvaskit.wasm` (a roughly 5 MB download) is double-downloaded. While some browsers may retrieve the second request from the cache, not all do. Workaround: None Risk: Low (a small change to the BUILD flags for CanvasKit that prevents `canvaskit.wasm` from being downloaded twice) Test Coverage: We don't have a test that checks how many requests there are for `canvaskit.wasm` Validation Steps: Build and run any Flutter Web app and check the network requests to see that `canvaskit.wasm` is only requested once.
-
- Mar 01, 2025
-
-
Justin McCandless authored
This PR updates the changelog for this cherry pick: https://github.com/flutter/flutter/pull/164050. If that cherry pick was successful, the presubmit test should not fail on this PR.
-
- Feb 28, 2025
-
-
Kevin Chisholm authored
Manually create the release-candidate-branch.version file on branch `flutter-3.29-candidate.0`.
-
flutteractionsbot authored
This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request) Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request. ### Issue Link: What is the link to the issue this cherry-pick is addressing? https://github.com/flutter/flutter/issues/164011 ### Changelog Description: Explain this cherry pick in one line that is accessible to most Flutter developers. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples Provide guided error message when app crashes due to JIT restriction on iPhones. ### Impact Description: What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch) iPhones using iOS newer version of iOS (such as the iOS 18.4 beta1) may get app crashes due to JIT restrictions. ### Workaround: Is there a workaround for this issue? No ### Risk: What is the risk level of this cherry-pick? ### Test Coverage: Are you confident that your fix is well-tested by automated tests? ### Validation Steps: What are the steps to validate that this fix works? Upgrade a device to iOS 18.4 beta1 and run `flutter run`.
-
flutteractionsbot authored
This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request) Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request. ### Issue Link: What is the link to the issue this cherry-pick is addressing? https://github.com/flutter/flutter/issues/150023 ### Changelog Description: Explain this cherry pick in one line that is accessible to most Flutter developers. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples Improve safaridriver launch process in Flutter's CI testing. ### Impact Description: What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch) Improve stability of Flutter's macOS web tests in CI. No impact to customers, only release team. ### Workaround: Is there a workaround for this issue? Rerun. ### Risk: What is the risk level of this cherry-pick? ### Test Coverage: Are you confident that your fix is well-tested by automated tests? ### Validation Steps: What are the steps to validate that this fix works? N/A
-
- Feb 27, 2025
-
-
flutteractionsbot authored
This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request) Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request. ### Issue Link: What is the link to the issue this cherry-pick is addressing? Part of https://github.com/flutter/flutter/issues/148887. ### Changelog Description: Explain this cherry pick in one line that is accessible to most Flutter developers. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples Configuration changes to run test on macOS 14 for Flutter's CI. ### Impact Description: What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch) Impacts what type of bot the test runs on for releases. ### Workaround: Is there a workaround for this issue? N/A ### Risk: What is the risk level of this cherry-pick? ### Test Coverage: Are you confident that your fix is well-tested by automated tests? ### Validation Steps: What are the steps to validate that this fix works? N/A
-
- Feb 26, 2025
-
-
flutteractionsbot authored
This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request) Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request. ### Issue Link: Cherry picked PR: https://github.com/flutter/flutter/pull/162450 Issue: https://github.com/flutter/flutter/issues/162098 < Replace with issue link here > ### Changelog Description: Explain this cherry pick in one line that is accessible to most Flutter developers. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples < Replace with changelog description here > ### Impact Description: What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch) Anyone using the `TabBar` widget. High impact. ### Workaround: Is there a workaround for this issue? None. ### Risk: What is the risk level of this cherry-pick? ### Test Coverage: Are you confident that your fix is well-tested by automated tests? ### Validation Steps: What are the steps to validate that this fix works? Run a `TabBar` with linear tab animation and tap third or fourth or use elastic animation observe tab indictor highlight.
-
Jason Simmons authored
[CP] Roll .ci.yaml changes into the LUCI configuration only when the master branch is updated (#164155) This is a cherry pick of an infrastructure fix. The "ci_yaml flutter roller" job updates the LUCI builder configuration to match the contents of ci.yaml. It should only run on the master branch because the older version of ci.yaml in a release branch may not contain newer builders that are needed by master branch PRs. See https://github.com/flutter/flutter/pull/163897
-
Jonah Williams authored
[CP][Impeller] ensure that OpenGL "flipped" textures do not leak via texture readback. (#163501) (#163667) Fixes https://github.com/flutter/flutter/issues/163315 Fixes https://github.com/flutter/flutter/issues/163521 Fixes https://github.com/flutter/flutter/issues/142641 OpenGL has an inverted coordinate system (bottom left is zero) compared to Metal/Vulkan (top left is zero). We handle this by rendering things upside down on OpenGL. Unfortunately this can leak out of the renderer via readback (toImage), so we need to make sure to undo the inversion. This is not performed for the "TextureCoordinateSystem::kUploadFromHost" state as that indicates the texture is already "right side up".
-
flutteractionsbot authored
This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request) Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request. ### Issue Link: What is the link to the issue this cherry-pick is addressing? https://github.com/flutter/flutter/issues/164128 ### Changelog Description: Explain this cherry pick in one line that is accessible to most Flutter developers. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples This cherry pick lands a fix to a test that is currently causing all presubmits to fail on the 3.29-candidate.0 stable release branch. The failure fixed in this test is dependent on the random ordering seed, which is why it didn't fail before. The current seed in which it fails is `--test-randomize-ordering-seed=20250221`. ### Impact Description: What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch) The only change is to reduce the flakiness of reorderable_list.test.dart. ### Workaround: Is there a workaround for this issue? Change the seed? ### Risk: What is the risk level of this cherry-pick? ### Test Coverage: Are you confident that your fix is well-tested by automated tests? ### Validation Steps: What are the steps to validate that this fix works? ``` flutter test /Users/jmccandless/Projects/flutter/packages/flutter/test/material/reorderable_list_test.dart --test-randomize-ordering-seed=20250221 ```
-
- Feb 21, 2025
-
-
John McDole authored
### Issue Link: #163308 #163691 and in some cases #162251 ### Changelog Description: Flutter tool respects tracked `engine.version` ### Impact Description: Non `master`, `stable`, and `beta` branches will respect tracked versions of `engine.version` and not download incorrect engine artifacts. ### Workaround: Deleting `engine/src/.gn` will trick the tools into thinking this is a non-monorepo. ### Risk: What is the risk level of this cherry-pick? ### Test Coverage: Are you confident that your fix is well-tested by automated tests? ### Validation Steps: 1. Switch to the branch / tag this is checked out to (i.e. `3.29.0`) 2. Examine `bin/internal/engine.version` 2. Run `flutter doctor` 3. See that it downloads the correct hash and `engine.version` hasn't been modified.
-
Jonah Williams authored
The common theme in: * https://github.com/flutter/flutter/issues/160854 * https://github.com/flutter/flutter/issues/160804 * https://github.com/flutter/flutter/issues/158091 Is that the Samsung exynos chipset has problems with AHB imports. Unfortunately some of the reported bugs are hard crashes/. While I couldn't reproduce the crash itself, it does indicate to me that attempting to feature detect if AHB imports work is probably too risky (and potentially slow, as we'd have to do a read back). While the Vulkan drivers otherwise work, the deivces in question are not able to reliably import AHBs which prevents platform views from working. This may not fix all issues as there could be different SoC models that also have problems. I considered removing 29 support as well, but there are a large number of APi 29 devices that work fine.
-
- Feb 20, 2025
-
-
flutteractionsbot authored
This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request) Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request. ### Issue Link: What is the link to the issue this cherry-pick is addressing? PR: https://github.com/flutter/flutter/pull/162880 Issue: https://github.com/flutter/flutter/issues/162839 ### Changelog Description: Explain this cherry pick in one line that is accessible to most Flutter developers. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples Fixes buttons with icons ignore `foregroundColor`. ### Impact Description: What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch) It impacts how buttons with icons render color when using `foregroundColor`. ### Workaround: Is there a workaround for this issue? Provide additional property such as `iconColor` along with `foregroundColor` to match colors for button label and icon. ### Risk: What is the risk level of this cherry-pick? ### Test Coverage: Are you confident that your fix is well-tested by automated tests? ### Validation Steps: What are the steps to validate that this fix works? Testing and samples.
-
gaaclarke authored
This is a cherry-pick for all the changes that went into fixing https://github.com/flutter/flutter/issues/149652 It looks like a lot but most of it is testing and refactoring. ## PRs included - https://github.com/flutter/flutter/pull/161625 - https://github.com/flutter/flutter/pull/162351 - https://github.com/flutter/flutter/pull/162415 - https://github.com/flutter/flutter/pull/162555 - https://github.com/flutter/flutter/pull/162824 ## Impacted Users All users of Impeller. ## Impact Description Animating text with translations and scales can cause: - jitter between glyphs - jitter between glyphs and the baseline - artifacts when rendering glyphs at non integer scales ## Workaround Use skia. ## Risk Since this edits how text is rendered, the risk is pretty high. The actual changes are small and there are unit tests for them. Golden test coverage for cherry-picks is not complete and text rendering golden coverage for android is problematic. ## Test Coverage Yes. ## Validation Steps The reproduction code in https://github.com/flutter/flutter/issues/149652 is good.
-
Victor Sanni authored
Original PR: https://github.com/flutter/flutter/pull/159120 The next stable branch has `CupertinoSliverNavigationBar.search`, but it is currently [unusable](https://github.com/flutter/flutter/pull/159120#discussion_r1945591377). The linked PR adds the search functionality and makes it usable.
-