Fix onDismiss in Modal
Summary: # Disclaimer: I might be missing something as the solution I implemented here seems like something that was considered by original author. If this solution isn't good, I have a plan B. # Problem: `onDismiss` prop isn't being called once the modal is dismissed, this diff fixes it. Also I've noticed that `onDismiss` is meant to only work on iOS, why is that? By landing this diff, it'll be called on Android as well so we need to change the docs (https://facebook.github.io/react-native/docs/modal.html#ondismiss). ## Video that shows the problem Following code is in playground.js P70222409 which just increments number everytime onDismiss is called {F166303269} Reviewed By: shergin Differential Revision: D16109536 fbshipit-source-id: 3fba56f5671912387b217f03b613dffd89614c9d
Showing
- Libraries/Modal/Modal.js 2 additions, 22 deletionsLibraries/Modal/Modal.js
- Libraries/Modal/RCTModalHostViewNativeComponent.js 0 additions, 8 deletionsLibraries/Modal/RCTModalHostViewNativeComponent.js
- React/Views/RCTModalHostViewManager.m 2 additions, 8 deletionsReact/Views/RCTModalHostViewManager.m
- React/Views/RCTModalManager.h 0 additions, 17 deletionsReact/Views/RCTModalManager.h
- React/Views/RCTModalManager.m 0 additions, 42 deletionsReact/Views/RCTModalManager.m
Please register or sign in to comment