This project is mirrored from https://github.com/facebook/react-native.git.
Pull mirroring updated .
- Dec 13, 2018
-
-
Lorenzo Sciandra authored
-
Sunny Luo authored
Summary: Fixes https://github.com/facebook/react-native/issues/22521 The current approach has an issue with white spaces when compiling in Xcode 10.1  Change back to relative path fixes this issue Pull Request resolved: https://github.com/facebook/react-native/pull/22598 Differential Revision: D13421446 Pulled By: hramos fbshipit-source-id: 688157b2e951399059cb6c95e2a6ce8d176e9b9c
-
Taylor123 authored
Summary: Experienced a `TouchableOpacity` releasing the `PanResponder` without invoking `onPress` due to a missing a direction key in the `hitSlop` prop; The missing key caused the corresponding pressExpand to become NaN which causes `isTouchWithinActive` to become falsey, when it should be truthy. If defaulting to 0 is undesired behavior, I'm happy to take a different approach. Pull Request resolved: https://github.com/facebook/react-native/pull/22281 Differential Revision: D13374335 Pulled By: cpojer fbshipit-source-id: f9d28e51b9d9c45aed42bea2df3d844a799fa827
-
Lea Bärtschi authored
Summary: Fixes #16304 The standard format for origin HTTP headers does not allow a trailing slash. In order to not get warnings when connecting a websocket, I removed the trailing slash when generating the default origin HTTP header for the websocket connect request. Release Notes: ---------- [Android] [Fixed] - Fixed default origin header for websocket connections to match the standard format (https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Origin) in WebSocketModule Pull Request resolved: https://github.com/facebook/react-native/pull/22290 Differential Revision: D13374345 Pulled By: cpojer fbshipit-source-id: 1173241f2b6912fd6df5e196053a950bb42ff01b
-
Zack Sheppard authored
Summary: Fixes #22530 As described in the issue, the previous behavior for the `RCTFatal` macro was to truncate the `reason` on the resulting `NSException` to 75 characters. This would ensure the reason would fit on a single line, but resulted in issues debugging errors that occurred in the wild, as many crash logging tools (like Sentry) discard the `name` value of the exception and use the `reason` as their primary identifier. At 75 characters, useful information like the location of the error would usually be truncated. - [x] This extends the truncation threshold to 175 characters, which should be short enough to prevent full-screen-takeover length errors, but long enough to provide useful context to the error. - [x] This adds a `userInfo` value to the resulting `NSException`. It copies over the `userInfo` from the `NSError` passed to the macro, and adds an "untruncated message" value that contains the untruncated version of the `NSException`'s reason. [iOS] [Changed] - RCTFatalExceptions now include more information in their reason and a userInfo. <!-- CATEGORY may be: - [General] - [iOS] - [Android] TYPE may be: - [Added] for new features. - [Changed] for changes in existing functionality. - [Deprecated] for soon-to-be removed features. - [Removed] for now removed features. - [Fixed] for any bug fixes. - [Security] in case of vulnerabilities. For more detail, see https://keepachangelog.com/en/1.0.0/#how MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes. EXAMPLES: [General] [Added] - Add snapToOffsets prop to ScrollView component [General] [Fixed] - Fix various issues in snapToInterval on ScrollView component [iOS] [Fixed] - Fix crash in RCTImagePicker --> Pull Request resolved: https://github.com/facebook/react-native/pull/22532 Differential Revision: D13373469 Pulled By: cpojer fbshipit-source-id: ac140d14ce76e1664869437c2c178bdd65ab6e0e
-
Radovan Šmitala authored
Summary: Default HelloWorld template for iOS doesn't make production main.jsbundle. This is little bit confusing in compare with Android building app when everything works one first run. Make it seamless, reduce confuse. Based on docs https://facebook.github.io/react-native/docs/running-on-device#3-configure-app-to-use-static-bundle Fixes #22335 Fixes #18562 Pull Request resolved: https://github.com/facebook/react-native/pull/22531 Differential Revision: D13372773 Pulled By: cpojer fbshipit-source-id: 888c675b7d11b1a323445e092ec9ff83924c42f4
-
David Vacca authored
Summary: This diff ensures that Events delivered from the C++ side are actually processed. This is done forcing the execution of AsyncEventBeat.beat() in these cases Reviewed By: shergin Differential Revision: D13313955 fbshipit-source-id: b2785647913a640c2d557f4fa08d447845a540e9
-
ifsnow authored
Summary: There is a problem that the `mediaPlaybackRequiresUserAction` property does not work in WKWebView(`useWebKit`) under iOS 10. I fully know you are currently working to migrate the core's WebView to the standalone `react-native-webview` project. This has already been submitted to PR in `react-native-webview` and will be merged soon. I hope this fix applies to `react-native` before your migration is done. Pull Request resolved: https://github.com/facebook/react-native/pull/22208 Differential Revision: D13334868 Pulled By: cpojer fbshipit-source-id: f2a811a477054155ed5fe62ab31e4d63f70e7848
-
Ian Park authored
Summary: `instance.hasOwnProperty` has potential danger because of some object could be eliminate own prototype chain. Update code be more reliable. This PR is solution of #22308 issue. (Fixes #22308) Pull Request resolved: https://github.com/facebook/react-native/pull/22348 Differential Revision: D13334882 Pulled By: cpojer fbshipit-source-id: 9b9310a972e933af1962666d7b0c683ff43cc5b2
-
hyochan authored
Summary: Fix ListEmptyComponent is rendered upside down when using inverted flag. Fixes #21196 Pull Request resolved: https://github.com/facebook/react-native/pull/21496 Differential Revision: D13334437 Pulled By: hramos fbshipit-source-id: b34a9a0a153862d3d5dbe410ab0a6c66a8cfcffd
-
Baldy Lukasz authored
Summary: Related to: #21853 Fixes #21853 Pull Request resolved: https://github.com/facebook/react-native/pull/21858 Differential Revision: D13322060 Pulled By: hramos fbshipit-source-id: 00a8de018fce6507aa131a11ba3e95d57044e683
-
Igor Mandrigin authored
Summary: iOS-specific. For languages with complex input (such as Japanese or Chinese), a user has to type multiple characters that are then merged into a single one. If `-[UITextView setAttributedString:]` is used while the user is still typing, it resets the input and characters are not being treated as typed together. This PR avoids calling this method if possible, replacing it by just copying the attributes if the string has not been changed. That preserves the state and user can continue to type Korean or Chinese characters. Fixes #19339 <!-- Required: Write your motivation here. If this PR fixes an issue, type "Fixes #issueNumber" to automatically close the issue when the PR is merged. --> <!-- Required: Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos! --> Essentially, the steps to reproduce are described in [the issue](https://github.com/facebook/react-native/issues/19339): 1. Type some Korean characters in TextInput, such as "하늘" (buttons `ㅎ`,`ㅏ`,`ㄴ`,`ㅡ`,`ㄹ`). 2. Then move the cursor to the beginning of the text, type "파란" (buttons `ㅍ`,`ㅏ`,`ㄹ`,`ㅏ`,`ㄴ`) this time. **Behaviour before this fix (broken)** Actual text: `ㅍㅏㄹㅏㄴ하늘`. Expected text: `파란하늘`. Characters aren't combined properly.  **Behaviour after this fix (correct)** Actual text: `파란하늘`. Expected text: `파란하늘`. Characters are combined, the same behaviour is in vanilla iOS `UITextView`.  <!-- Does this PR require a documentation change? Create a PR at https://github.com/facebook/react-native-website and add a link to it here. --> <!-- Required. Help reviewers and the release process by writing your own release notes. See below for an example. --> [IOS] [BUGFIX] [TextView] - Fix Korean/Chinese/Japanese input for multiline TextView on iOS. <!-- **INTERNAL and MINOR tagged notes will not be included in the next version's final release notes.** CATEGORY [----------] TYPE [ CLI ] [-------------] LOCATION [ DOCS ] [ BREAKING ] [-------------] [ GENERAL ] [ BUGFIX ] [ {Component} ] [ INTERNAL ] [ ENHANCEMENT ] [ {Filename} ] [ IOS ] [ FEATURE ] [ {Directory} ] |-----------| [ ANDROID ] [ MINOR ] [ {Framework} ] - | {Message} | [----------] [-------------] [-------------] |-----------| EXAMPLES: [IOS] [BREAKING] [FlatList] - Change a thing that breaks other things [ANDROID] [BUGFIX] [TextInput] - Did a thing to TextInput [CLI] [FEATURE] [local-cli/info/info.js] - CLI easier to do things with [DOCS] [BUGFIX] [GettingStarted.md] - Accidentally a thing/word [GENERAL] [ENHANCEMENT] [Yoga] - Added new yoga thing/position [INTERNAL] [FEATURE] [./scripts] - Added thing to script that nobody will see --> Pull Request resolved: https://github.com/facebook/react-native/pull/19809 Differential Revision: D13326614 Pulled By: shergin fbshipit-source-id: 6a5cab3f7290f0f623a6f4c29353a573eb321b0b
-
Ivan Filenko authored
Summary: Update `ws` package from 1.1.0 to 1.1.5 due to vulnerability issues. Here is `npm audit` report: ``` === npm audit security report === ┌──────────────────────────────────────────────────────────────────────────────┐ │ Manual Review │ │ Some vulnerabilities require your attention to resolve │ │ │ │ Visit https://go.npm.me/audit-guide for additional guidance │ └──────────────────────────────────────────────────────────────────────────────┘ ┌───────────────┬──────────────────────────────────────────────────────────────┐ │ High │ Denial of Service │ ├───────────────┼──────────────────────────────────────────────────────────────┤ │ Package │ ws │ ├───────────────┼──────────────────────────────────────────────────────────────┤ │ Patched in │ >= 1.1.5 <2.0.0 || >=3.3.1 │ ├───────────────┼──────────────────────────────────────────────────────────────┤ │ Dependency of │ c635d8a886cde7688a0123f573cc5b1f0430780052ba848c8fa1dc8a4c3… │ ├───────────────┼──────────────────────────────────────────────────────────────┤ │ Path │ c635d8a886cde7688a0123f573cc5b1f0430780052ba848c8fa1dc8a4c3… │ │ │ > react-devtools-core > ws │ ├───────────────┼──────────────────────────────────────────────────────────────┤ │ More info │ https://nodesecurity.io/advisories/550 │ └───────────────┴──────────────────────────────────────────────────────────────┘ ``` Pull Request resolved: https://github.com/facebook/react-native/pull/21769 Reviewed By: hramos Differential Revision: D10379892 Pulled By: cpojer fbshipit-source-id: 9d03f8231a90c5f55eb95ccac029aedd45a49a2d -
Tim Yung authored
Summary: @public This sync includes the following changes: - **[6bf5e8598](https://github.com/facebook/react/commit/6bf5e8598)**: Fix scheduler setTimeout() re-entrancy check (#14384) //<Brian Vaughn>// - **[7a48c900b](https://github.com/facebook/react/commit/7a48c900b)**: Prevent a v8 deopt when profiling (#14383) //<Brian Vaughn>// - **[f00c2755b](https://github.com/facebook/react/commit/f00c2755b)**: Removed unnecessary externals from Jest bundles (#14372) //<Brian Vaughn>// - **[52bea95cf](https://github.com/facebook/react/commit/52bea95cf)**: Fixed scheduler setTimeout fallback (#14358) //<Brian Vaughn>// - **[1d25aa578](https://github.com/facebook/react/commit/1d25aa578)**: [Fizz] New Server Rendering Infra (#14144) //<Sebastian Markbåge>// - **[f1bf28160](https://github.com/facebook/react/commit/f1bf28160)**: Fix bug in cloneHook (#14364) //<Imre Osswald>// - **[16e120438](https://github.com/facebook/react/commit/16e120438)**: [Fire] Add initial build infrastructure (#14359) //<Dan Abramov>// - **[d14ba87b1](https://github.com/facebook/react/commit/d14ba87b1)**: Validate propTypes for lazy() and memo() and warn about invalid patterns (#14298) //<Dan Abramov>// - **[4f964f09c](https://github.com/facebook/react/commit/4f964f09c)**: Adding isMemo check to react-is package (#14313) //<Jinto Jose>// - **[c2a2d8a53](https://github.com/facebook/react/commit/c2a2d8a53)**: Remove useMutationEffect (#14336) //<Sophie Alpert>// - **[48f1e5b3c](https://github.com/facebook/react/commit/48f1e5b3c)**: Add a null type test for memo (#14325) //<chun shang>// - **[f93f3402f](https://github.com/facebook/react/commit/f93f3402f)**: Make useEffect(async) warning more verbose (#14327) //<Dan Abramov>// - **[ee3ef3a07](https://github.com/facebook/react/commit/ee3ef3a07)**: Fix regression: Errors not emitted in streams (#14314) //<Pelle Wessman>// - **[33f6f5e53](https://github.com/facebook/react/commit/33f6f5e53)**: Remove usage of `fbjs/lib/invariant` in ReactNativeViewConfigRegistry. (#14330) //<Christoph Nakazawa>// - **[686f1060a](https://github.com/facebook/react/commit/686f1060a)**: Publish a local release (canary or stable) to NPM (#14260) //<Brian Vaughn>// - **[7475120ce](https://github.com/facebook/react/commit/7475120ce)**: Prevent deopts from modifying exports object in stable builds (#14309) //<Dan Abramov>// - **[0c7189d92](https://github.com/facebook/react/commit/0c7189d92)**: Fix resolution of outer props with React.memo() (#14312) //<Dan Abramov>// - **[14be29b2b](https://github.com/facebook/react/commit/14be29b2b)**: Add more test coverage for nested memo() (#14311) //<Dan Abramov>// - **[dc0dd4bbf](https://github.com/facebook/react/commit/dc0dd4bbf)**: Use |0 to coerce to number (#14297) //<Dan Abramov>// - **[dd8205cef](https://github.com/facebook/react/commit/dd8205cef)**: List ignored types instead of included types in the stack (#14308) //<Dan Abramov>// - **[a9fdf8a32](https://github.com/facebook/react/commit/a9fdf8a32)**: Warn about reassigning this.props (#14277) //<Dan Abramov>// - **[327cf0ee3](https://github.com/facebook/react/commit/327cf0ee3)**: Fix support for mixing react-dom/server@16.6 and react@<16.6 (#14291) //<Dan Abramov>// - **[c954efa70](https://github.com/facebook/react/commit/c954efa70)**: Remove `import * as` pattern from the codebase (#14282) //<Sebastian Markbåge>// - **[ccb14e270](https://github.com/facebook/react/commit/ccb14e270)**: Fix SSR useCallback in render phase (#14279) //<Dan Abramov>// - **[0e9cb3f5d](https://github.com/facebook/react/commit/0e9cb3f5d)**: Clear fields on unmount of fiber to avoid memory leak (#14276) //<Dominic Gannaway>// - **[592676503](https://github.com/facebook/react/commit/592676503)**: Revert "Clear memoizedState on unmount of fiber to avoid memory leak (#14218)" (#14275) //<Dominic Gannaway>// - **[9b2fb24f9](https://github.com/facebook/react/commit/9b2fb24f9)**: Clear memoizedState on unmount of fiber to avoid memory leak (#14218) //<Dominic Gannaway>// - **[a22fabc2a](https://github.com/facebook/react/commit/a22fabc2a)**: Reduce scheduler serialization overhead (#14249) //<Jason Miller>// - **[21d5f7d32](https://github.com/facebook/react/commit/21d5f7d32)**: Wrap shorthand CSS property collision warning in feature flag (#14245) //<Andrew Clark>// - **[8feeed10d](https://github.com/facebook/react/commit/8feeed10d)**: [scheduler] Remove window.postMessage fallback //<Andrew Clark>// - **[5bce0ef10](https://github.com/facebook/react/commit/5bce0ef10)**: [scheduler] Post to MessageChannel instead of window (#14234) //<Andrew Clark>// - **[f55795c8e](https://github.com/facebook/react/commit/f55795c8e)**: Add regression test for #14188 (#14197) //<Dan Abramov>// - **[b98adb648](https://github.com/facebook/react/commit/b98adb648)**: Simplify CSS shorthand property warning (#14183) //<Sophie Alpert>// - **[f8bfd5868](https://github.com/facebook/react/commit/f8bfd5868)**: fix typo //<Sebastian Markbage>// - **[961eb65b4](https://github.com/facebook/react/commit/961eb65b4)**: Use unique thread ID for each partial render to access Context (#14182) //<Sebastian Markbåge>// - **[1a6ab1e9b](https://github.com/facebook/react/commit/1a6ab1e9b)**: SimpleMemoComponent should warn if a ref is given (#14178) //<Sophie Alpert>// - **[8ae867e6b](https://github.com/facebook/react/commit/8ae867e6b)**: Warn about conflicting style values during updates (#14181) //<Sophie Alpert>// - **[d5e1bf07d](https://github.com/facebook/react/commit/d5e1bf07d)**: Renamed outdated schedule/tracing referecnes (#14177) //<Brian Vaughn>// - **[2dd4ba11e](https://github.com/facebook/react/commit/2dd4ba11e)**: ESlint -> ESLint //<Andrew Clark>// - **[9cc631a53](https://github.com/facebook/react/commit/9cc631a53)**: Don't run danger on bad build (#14143) //<Sophie Alpert>// - **[1034e26fe](https://github.com/facebook/react/commit/1034e26fe)**: Fix typos (#14124) //<Heaven>// - **[5618da49d](https://github.com/facebook/react/commit/5618da49d)**: Fix comment typo (#14156) //<Bartosz Gordon>// - **[9fb919945](https://github.com/facebook/react/commit/9fb919945)**: Add global to ESLint plugin bundle config //<Andrew Clark>// - **[c174f8592](https://github.com/facebook/react/commit/c174f8592)**: Add fb build of ESLint plugin (#14165) //<Andrew Clark>// - **[02e4848e3](https://github.com/facebook/react/commit/02e4848e3)**: Improved suspense support in ReactDOMServer (#14161) //<Alex Taylor>// - **[4b163fee1](https://github.com/facebook/react/commit/4b163fee1)**: Remove errant return assignment (#14164) //<Andrew Clark>// - **[e58ecda9a](https://github.com/facebook/react/commit/e58ecda9a)**: Suspense fuzz tester (#14147) //<Andrew Clark>// - **[7fd1661f8](https://github.com/facebook/react/commit/7fd1661f8)**: Don't warn if an unmounted component is pinged (#14158) //<Andrew Clark>// - **[f9e9913f0](https://github.com/facebook/react/commit/f9e9913f0)**: [Synchronous Suspense] Don't delete children of suspended component (#14157) //<Andrew Clark>// - **[7c560131b](https://github.com/facebook/react/commit/7c560131b)**: Adding logger pri (#14155) //<Nathan Schloss>// - **[3d8bda70e](https://github.com/facebook/react/commit/3d8bda70e)**: Refactor ESLint configuration to enable better IDE integration (#13914) //<Minh Nguyen>// - **[051272f20](https://github.com/facebook/react/commit/051272f20)**: Use Entry in `yarn build ...` Instead of Label (#14148) //<Sebastian Markbåge>// Release Notes: [GENERAL] [FEATURE] [React] - React sync for revisions 3ff2c7c...6bf5e85 Reviewed By: bvaughn Differential Revision: D13288288 fbshipit-source-id: 89a4837a9198c53fc79306933f589ef25d8bb4b6
-
Salil Apte authored
Summary: Currently, if you load an animated gif using the standard `Image` component, it will not correctly respect the loop count property found in the Netscape App Extension block of the file. The issues are as follows: 1) If the App Extension isn't present, the animated gif loops indefinitely when it should not loop at all. 2) If the App Extension is present, the animated gif loops one less time than it should. The other issue is that once the looping completes, the image doesn't pause at the last frame but instead, loops back to the beginning of the animation e.g. frame 1. The fix does a few things: 1) If there is _no_ App Extension present, the image doesn't loop at all 2) If there _is_ an App Extension present, it loops the correct amount of times. For instance, if the loop count is 1, it means the gif should loop _once_ after it finishes playing, for a total of _two_ total loops. 3) Once the number of loops completes (assuming loop count isn't set to 0 which means infinite), the animation pauses on the last frame. Pull Request resolved: https://github.com/facebook/react-native/pull/21999 Differential Revision: D13287005 Pulled By: hramos fbshipit-source-id: f7210ad40e0e76c9ec454953b8a067569d3feaaa
-
David Vacca authored
Summary: This diff fixes a NPE happening in StatusBarModule when the style passed by parameter is null. Even if JS shoulnd't send a null value, this method should not crash with an NPE. I'm not changing behavior, only avoiding NPE when status is null Reviewed By: RSNara Differential Revision: D13287057 fbshipit-source-id: cc5ac4e97083d63f2bf65c03bac0dc9bce976423
-
Valentin Shergin authored
Calling -[UIScrollView setContentOffset] with NaN values can cause a crash. That's not clear why exactly the computation returns NaN sometime, but the implemented sanitizing should help to detect this problem during development (and this also prevents the app from crashing). See attached task for more details. Reviewed By: fkgozali Differential Revision: D13242729 fbshipit-source-id: 747bf1b42e02597e9f1300eee24547563ab29b27
-
Tim Yung authored
Summary: On Android, `Switch` does not currently read its role as a "button". This fixes that and makes it consistent with iOS. Reviewed By: sahrens Differential Revision: D13136253 fbshipit-source-id: 0de5d54772d204168138cb2af7815cc458f72682
-
Nicolas Gallagher authored
Summary: Set the default text radius to 0 so that text shadows aren't applied to every text node Reviewed By: mdvacca Differential Revision: D13027589 fbshipit-source-id: 4f7386059ac1654b8f77dddf9eb1b772f6049e23
-
Michael Blanchard authored
Summary: Similar to #21950, this adds displayName to `ActivityIndicator`, so it displays the correct component name in snapshots instead of `Component`. Fixes #21937 (a little bit more than it was already fixed). Pull Request resolved: https://github.com/facebook/react-native/pull/22417 Differential Revision: D13205376 Pulled By: TheSavior fbshipit-source-id: 21e71d4980d159a1f33d32d83346b48257ec21d4
-
- Nov 27, 2018
-
-
Lorenzo Sciandra authored
-
Lorenzo Sciandra authored
This reverts commit 356ac5d0.
-
Lorenzo Sciandra authored
-
Adam Comella authored
Summary: If text is truncated and an inline view appears after the truncation point, the user should not see the inline view. Instead, we have a bug such that the inline view is always visible at the end of the visible text. This commit fixes this by marking the inline view as hidden if it appears after the truncation point. This appears to be a regression. React Native used to have logic similar to what this commit is adding: https://github.com/facebook/react-native/blob/1e2a924ba60001c6f0587c7561536f00b2922cbf/Libraries/Text/RCTShadowText.m#L186-L192 **Before fix** Inline view (blue square) is visible even though it appears after the truncation point:  The full text being rendered was: ``` <Text numberOfLines={1}> Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna <View style={{width: 50, height: 50, backgroundColor: 'steelblue'}} /> </Text> ``` **After fix** Inline view is properly truncated:  **Test Plan** Tested that the inline view is hidden if it appears after the truncation point when `numberOfLines` is 1 and 2. Similarly, verified that the inline view is visible if it appears before the truncation point. **Release Notes** [IOS] [BUGFIX] [Text] - Fix case where inline view is visible even though it should have been truncated Adam Comella Microsoft Corp. Pull Request resolved: https://github.com/facebook/react-native/pull/21456 Differential Revision: D10182991 Pulled By: shergin fbshipit-source-id: a5bddddb1bb8672b61d4feaa04013a92c8224155
-
gazoudoudou authored
Summary: I noticed that the _onBlur method was not exactly similar to the _onFocus one in the TextInput component. After digging, I found that the blurTextInput method in the TextInputState.js file was call twice in a raw instead of once when the textinput component should blur. By removing this line, I fix this unecessary multiple call. Pull Request resolved: https://github.com/facebook/react-native/pull/22156 Reviewed By: TheSavior Differential Revision: D13105396 Pulled By: RSNara fbshipit-source-id: 8e83461d8b288d8ee4047bc4a33c4480e193c349
-
empyrical authored
Summary: This pull request silences build warnings like this in open-source: ``` {snip}/ReactCommon/cxxreact/CxxNativeModule.cpp:134:85: warning: lambda capture 'callId' is not used [-Wunused-lambda-capture] messageQueueThread_->runOnQueue([method, params=std::move(params), first, second, callId] () { ``` These are variables used by "fbsystrace", which is not open-sourced. An unused statement has been added to the affected files in the `#else` for the `#ifdef WITH_FBSYSTRACE` conditionals Pull Request resolved: https://github.com/facebook/react-native/pull/22240 Differential Revision: D13031358 Pulled By: shergin fbshipit-source-id: 8ccfc226b65e32abda6abb573f77a6589bd19dcd -
Dulmandakh authored
Summary: resizeMode applies to Image.defaultSource, because depending on screen resolution sometimes we see padding around defaultSource image while source loading. Now we can control scale of both source and defaultSource. Changelog: ---------- [Android] [Fixed] - Image.resizeMode will apply to defaultSource, enhanced user experience. Previously, resizeMode didn't applied to defaultSource, therefore depending on screen resolution sometimes we see padding around defaultSource image while source loading. Pull Request resolved: https://github.com/facebook/react-native/pull/22216 Differential Revision: D13088220 Pulled By: mdvacca fbshipit-source-id: 92c66cf6228f3b7666b9ef2404d034f0005b5234
-
Brian Vaughn authored
-
Igor Mandrigin authored
Summary: This is a safe workaround to an issue in Android P: https://issuetracker.google.com/issues/112385925 It is based on a fact that even though `fling` receive a wrong sign in `velocityY`, `mOnScrollDispatchHelper.getYFlingVelocity()` still returns a fling direction. Fixes #19434 Pull Request resolved: https://github.com/facebook/react-native/pull/21117 Differential Revision: D13082740 Pulled By: hramos fbshipit-source-id: 1b28586d2c7bdcae4a111d3cead4a0455cebb99a
-
Eric Butler authored
Summary: Fixes #11666 (Which was incorrectly closed) Pull Request resolved: https://github.com/facebook/react-native/pull/22164 Differential Revision: D13057001 Pulled By: hramos fbshipit-source-id: bcd53e893bc7c114f866e54938166b74b8ae0299
-
Andrew Chen (Eng) authored
Summary: There are cases where we're trying to drop a view that is not associated with a ViewManager. This is likely caused by race conditions that can occur if we're dropping a view from JS (when it's no longer used) but at the same time dropping it from native (when layout animation ends, when the rootview gets unmounted). In either of those cases, it should be safe to ignore the drop operation because the view was likely dropped already. Reviewed By: mdvacca Differential Revision: D13036643 fbshipit-source-id: 260ffb56d32a0d670ad08f449b8df165b2533195
-
Brent Vatne authored
Summary: This regression was caused by 199c918d - property values are initialized to true rather than a string that matches the property name now. Pull Request resolved: https://github.com/facebook/react-native/pull/22262 Differential Revision: D13048839 Pulled By: hramos fbshipit-source-id: 09471334c37f3930aae7e35066943f33f8e617e5
-
Ranjan Shrestha authored
Summary: When the remote server closes the websocket, the app doesn't get a 'close' event in Android, There is no issue on iOS. Pull Request resolved: https://github.com/facebook/react-native/pull/22248 Differential Revision: D13047556 Pulled By: hramos fbshipit-source-id: c5c56ea8418cfdf734fb51f863b3066856de6512
-
Mehdi Mulani authored
Summary: @public We're seeing a crash on line 191 when we do `CFRelease(self->_firstTimeReachability);`. My thinking is that there's a race condition between the deallocation coming from calling `getCurrentConnectivity` twice in a row and the callback coming back. Reviewed By: PeteTheHeat Differential Revision: D12982772 fbshipit-source-id: d3d882a074b67a5e547e7f480f561fcaf8d79ec4
-
David Vacca authored
Summary: This diff fixes an IllegalArgumentException when dismissing ReactModalHostView. I wasn't able to reproduce this error because this is likely created by a race condition. Reviewed By: axe-fb Differential Revision: D12916787 fbshipit-source-id: b071ffc4c251f2a613bb1270de005def56818376
-
MateusAndrade authored
Summary: Changing the the this.props.visible if to be ` if (!!this.props.visible === false)` . So passing undefined, or other values wont set the modal to be visible. Granting that anything that is not true, will set the modal to null on the render. I make this this PR, because on the company that im working, we used a lot of RN. At the moment, we arent using anything like flow or TS. But to grant that the modals will only show if they are set visible to true i have changed the if made. _Pull requests that expand test coverage are more likely to get reviewed. Add a test case whenever possible!_ Pull Request resolved: https://github.com/facebook/react-native/pull/22072 Differential Revision: D12918086 Pulled By: TheSavior fbshipit-source-id: 8f9c63ac6fd56d83949bb8428ad7c5b7bf805c49
-
Chris Williams authored
Summary: Adding the new `textContentType` options from iOS 12. `newPassword` helps the OS know to put a password field into the keychain, and `oneTimeCode` hints that the field will take input from an SMS one time code. Pull Request resolved: https://github.com/facebook/react-native/pull/21079 Differential Revision: D9813328 Pulled By: TheSavior fbshipit-source-id: d2c04b41121b32f185af38ea4c642924e261a043
-
Zack Gomez authored
Summary: D8842691 split AccessibilityTraits into multiple RN properties. However, the accessor code did not support REMOVING traits. This results in buttons that were disabled (AccessibilityTraits & NotEnabled === true) never being enabled. Fix the issue by making the split accessors properly mask in the bits, allowing you unset them without disturbing bits managed by the other accessor. NOTE: setting AccessibilityTraits and AccessibilityRole or AccessibilityStates will still result in bugs. Reviewed By: shergin Differential Revision: D9661970 fbshipit-source-id: 77d70dd0754f2eaf8cbf895bfc13757c697a76d8
-
Keaton Greve authored
Summary: Fixes #20553. Re-applies the change as described in https://github.com/facebook/react-native/pull/16533, which was closed for being stale. Thanks to emusgrave for the original PR/change. Pull Request resolved: https://github.com/facebook/react-native/pull/20554 Differential Revision: D9414933 Pulled By: hramos fbshipit-source-id: 8ebca57e32b905c4ecfd661524ca415f51162545
-
Lorenzo Sciandra authored
-
