This project is mirrored from https://github.com/facebook/react-native.git.
Pull mirroring updated .
- Feb 28, 2025
-
-
Nicola Corti authored
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/49742 Seems like publishing jobs are not happy with Gradle Config Caching. I'm disabling it for now till we find out what's the root cause. Changelog: [Internal] [Changed] - Reviewed By: cipolleschi Differential Revision: D70385662 fbshipit-source-id: 532c46ea1e578bab5f3e5d6814a7f7193e67a7ad
-
- Feb 20, 2025
-
-
Nicola Corti authored
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/49514 This attemps to enable Config Caching on CI. I'm curious to see how much time this is going to save. There might be some problems with nigthlies so I want to make sure this is running for some days before the branch cut. Changelog: [Internal] [Changed] - Reviewed By: NickGerleman Differential Revision: D69846848 fbshipit-source-id: 0d5c292e65a6107df62f6494a1aae9abd0e8b6cc
-
- Jan 14, 2025
-
-
Nicola Corti authored
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/48651 Original commit changeset: dace7c931ec3 Original Phabricator Diff: D67975049 Reviewed By: cipolleschi Differential Revision: D68114130 fbshipit-source-id: 9fb1707191037127b9ae985d2e3298a64e911590
-
- Jan 10, 2025
-
-
Nicola Corti authored
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/48572 Because of this extra step on build-android, we're seeing the version 1000.0.0-<SHA> on commits on the release branch. This prevents it. Changelog: [Internal] [Changed] - Do not reset rn-artifacts-version on release branch Reviewed By: cipolleschi Differential Revision: D67975049 fbshipit-source-id: dace7c931ec310538c11c4b9e544fdc2241a1d0c
-
- Dec 13, 2024
-
-
Nick Gerleman authored
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/48237 Noticed this when trying to diagnose what seemed like a stale caching issue. It effectively reverts D59917944. D59917944 added logic to only do yarn caching on main, but it has some correctness issues: 1. We cache `node_modules` instead of the yarn cache, which may contain e.g. build artifacts, or other scratch/cache files written (such as anything that writes to `node_modules/.cache`). We really want to be caching the yarn cache, which has pristine packages before install, which I think it will also need to perform the real install anyways. 2. We key the cache on root `package.json`, which is missing a lot of information (both provided by the other `package.json` in the repo, but mostly, the lockfile resolution). We only save cache when we're on `refs/heads/main` (so continuous builds against main), and supposedly, builds against base branch should be able to restore against those, but recent PR jobs I have seen, where `package.json` has not changed, all have `Cache not found for input keys: node-modules-068350889e87919c1c6c2c220c8d2d92db13f38820bf2efb315d1274b97bc367` Because of the potential correctness issues, and that the strategy for limiting to main seemingly is not allowing cache to be used in PR, this diff goes back to previous solution, which may store more artifacts (but working cache should also reduce cost by making jobs run faster). Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D67140004 fbshipit-source-id: f74074a498af56b1837fa23cf80795f76935b762
-
- Aug 07, 2024
-
-
Nicola Corti authored
Summary: This reverts commit 9d9a8d2d. ## Changelog: [INTERNAL] - This reverts commit 9d9a8d2d. Pull Request resolved: https://github.com/facebook/react-native/pull/45929 Test Plan: CI Reviewed By: blakef Differential Revision: D60901502 Pulled By: cortinico fbshipit-source-id: 2b7a7908a29f031c1f229907aa899a8a6960da4b
-
- Aug 06, 2024
-
-
Riccardo Cipolleschi authored
Summary: We had CI on main failing consistently the past couple of days. The problem is that the hermes pipeline is failing to create the iOS XCFramework with the error: > unable to create a Mach-O from the binary at '/Users/runner/work/react-native/react-native/packages/react-native/sdks/hermes/destroot/Library/Frameworks/catalyst/hermes.framework/hermes' The main cause is this upgrade of [upload-artifacts](https://github.com/actions/upload-artifact/issues/590) which breaks symlinks. The solution is to bump the caches and downgrade the `upload-artifact` actions. ## Changelog: [Internal] - Try to fix CI for Hermes Pull Request resolved: https://github.com/facebook/react-native/pull/45908 Test Plan: GHA must be green Reviewed By: cortinico Differential Revision: D60828616 Pulled By: cipolleschi fbshipit-source-id: 6976b86dd67e2fd9d806ebaa62f47e39dc44b30d
-
- Jul 27, 2024
-
-
Riccardo Cipolleschi authored
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/45706 ## Context Running manual tests when preparing a release, it's time consuming. We have to do the cherry picks, wait for CI to finish, and then manually test 8 configurations. Maestro is a tool that allow us to run E2E tests automatically, and we can wire it to CI. ## Change To avoid flakyness and costs, let's run E2E tests only on main and on stable branches Changelog: [Internal] - Exploration to integrate maestro Reviewed By: blakef Differential Revision: D60283204 fbshipit-source-id: 806cb8905cb269f18785158dcc5777ef10e0ef44
-
Riccardo Cipolleschi authored
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/45709 ## Context Running manual tests when preparing a release, it's time consuming. We have to do the cherry picks, wait for CI to finish, and then manually test 8 configurations. Maestro is a tool that allow us to run E2E tests automatically, and we can wire it to CI. ## Change Connect RNTester Android to Maestro action Changelog: [Internal] - Exploration to integrate maestro Reviewed By: blakef Differential Revision: D60282769 fbshipit-source-id: 2a20f1cb249fc5c43b0579c3309efd60369a1da6
-
- Jul 26, 2024
-
-
Nicola Corti authored
Summary: Update ccache key to use github.ref ## Changelog: [INTERNAL] - Update ccache key to use github.ref Pull Request resolved: https://github.com/facebook/react-native/pull/45698 Test Plan: CI Reviewed By: blakef Differential Revision: D60277122 Pulled By: cortinico fbshipit-source-id: 10437e56a398e817fb030d505fbdb6cf7c23031a
-
- Jul 25, 2024
-
-
Nicola Corti authored
Summary: The correct path for ccache storage dir is actually `/github/home/.cache/ccache` ## Changelog: [INTERNAL] - Update ccache path Pull Request resolved: https://github.com/facebook/react-native/pull/45674 Test Plan: CI Reviewed By: cipolleschi Differential Revision: D60236560 Pulled By: cortinico fbshipit-source-id: bbce9081e6647e660c3f80d61d791268de5b75d1
-
Nicola Corti authored
Summary: This adds `ccache` on the Android build to speedup the building process. ## Changelog: [INTERNAL] - Adding ccache for Android builds Pull Request resolved: https://github.com/facebook/react-native/pull/45662 Test Plan: CI Reviewed By: cipolleschi Differential Revision: D60229625 Pulled By: cortinico fbshipit-source-id: bc7e416f4ed1b4932159feb672947669bfb498d7
-
Nicola Corti authored
Summary: `git config --global --add safe.directory` is no longer necessary because is done inside the Docker container. ## Changelog: [INTERNAL] - Remove unnecessary git config --global --add safe.directory Pull Request resolved: https://github.com/facebook/react-native/pull/45663 Test Plan: CI Reviewed By: blakef Differential Revision: D60229662 Pulled By: cortinico fbshipit-source-id: aa817ff27adaab3e3105ab22af74a871b377295b
-
- Jul 20, 2024
-
-
Blake Friedman authored
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/45544 ## This diff now does 5 things: 1. removes the old way we used `actions/setup-node` to manage the cache itself. 2. it creates a new `update-node-modules-cache` workflow, which is the only job that will update the node modules cache 3. it create a `yarn-install-with-cache` action that should be used install of directly calling `yarn install --non-interactive`. This will load a cache against a hash of `package.json`. 4. updated the cache reaper to aggressively remove everything but the latest `npm-{{ hash('package.json') }}`. 5. removed a `cache-setup`, which couldn't be used (we're using artefacts now). ## Why are we doing this: The various `node-cache-` keys for platforms and on various branches accounts for a very large proportion of the cache (10-20%). We don't frequently change these dependencies, and even when we do running `yarn install` after loading the cache will resolve any issues. Limiting the cache to `main` and aggressively pruning older cache entries will clean up a lot of "small win" caching. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D59917944 fbshipit-source-id: 4be6f1959e8fde642a4f208f7d19aceba2c3262f
-
- Jul 17, 2024
-
-
Nicola Corti authored
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/45474 Our actions inputs are now a mixture of different casing. I'm moving everything to be kebab-case Changelog: [Internal] [Changed] - Composite actions inputs should be kebab-case Reviewed By: cipolleschi Differential Revision: D59809181 fbshipit-source-id: af6d541c2b4f5fa162dcde412fb8808bae1ef2d3
-
Nicola Corti authored
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/45468 This should greatly reduce the time spent on build_npm_package because we're moving all the publishing logic to build_android. I need to do a bit more testing with nightlies to make sure that everything is published correctly. Changelog: [Internal] [Changed] - Make build_android publish to the stating repositories Reviewed By: cipolleschi Differential Revision: D59804015 fbshipit-source-id: be3f0b6e16f5fdbf760ec7a5e16c8e258e06dd28
-
Nicola Corti authored
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/45475 Instead of zipping all the RNTester's APK together, let's upload them per buildVariant so it's easier to retrieve them later. Changelog: [Internal] [Changed] - Split the rntester APK artifacts in 4 Reviewed By: cipolleschi Differential Revision: D59809721 fbshipit-source-id: 2d375475d5cee71c212f4d1f3a4a9edf3442358f
-
Nicola Corti authored
Summary: We don't need to specify a minor/patch for actions/upload-artifact. We also have all sorts of different versions scattered around the codebase. This aligns them to the latest sable in the 4.x series. Changelog: [Internal] [Changed] - actions/upload-artifact to v4.x Reviewed By: cipolleschi Differential Revision: D59811525 fbshipit-source-id: 7264db097bcb2ff34b3ace467996e8308c0f2034
-
- Jul 16, 2024
-
-
Riccardo Cipolleschi authored
Summary: This change factors out build-android job so we can reuse it ## Changelog: [Internal] - Factor out the build-android job for code reuse Pull Request resolved: https://github.com/facebook/react-native/pull/45455 Test Plan: GHA are green Reviewed By: blakef Differential Revision: D59802116 Pulled By: cipolleschi fbshipit-source-id: 12ece8004da3bfd1f275b4af8e9822d4b0ccc0f0
-