Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/facebook/react-native.git. Pull mirroring updated .
  1. Oct 16, 2024
  2. Sep 08, 2024
    • Riccardo Cipolleschi's avatar
      Zip slices to preserve symlinks (#46387) · d424c244
      Riccardo Cipolleschi authored
      Summary:
      When creating Hermes in CI, we build it for MacOS and Mac Catalyst as well.
      The slices for these platforms requires symlinks to work properly.
      The upload artifacts action on github, when applied to folders, follows the symlinks and copies the destination folder. The result is that Hermes for macOS and Catalyst does not work as expected.
      
      This should fix https://github.com/facebook/react-native/issues/46213.
      
      ## Changelog:
      [Internal] - Build Hermes in CI properly
      
      Pull Request resolved: https://github.com/facebook/react-native/pull/46387
      
      Test Plan: Tested already in 0.75
      
      Reviewed By: robhogan
      
      Differential Revision: D62355050
      
      Pulled By: cipolleschi
      
      fbshipit-source-id: 7abb85c8a2a88f13e06a49c6cb0caccbdad4551a
      d424c244
  3. Aug 06, 2024
    • Riccardo Cipolleschi's avatar
      Try to restore caches for Hermes (#45908) · 24e7f7d2
      Riccardo Cipolleschi authored
      Summary:
      We had CI on main failing consistently the past couple of days.
      The problem is that the hermes pipeline is failing to create the iOS XCFramework with the error:
      > unable to create a Mach-O from the binary at '/Users/runner/work/react-native/react-native/packages/react-native/sdks/hermes/destroot/Library/Frameworks/catalyst/hermes.framework/hermes'
      
      The main cause is this upgrade of [upload-artifacts](https://github.com/actions/upload-artifact/issues/590) which breaks symlinks.
      
      The solution is to bump the caches and downgrade the `upload-artifact` actions.
      ## Changelog:
      [Internal] - Try to fix CI for Hermes
      
      Pull Request resolved: https://github.com/facebook/react-native/pull/45908
      
      Test Plan: GHA must be green
      
      Reviewed By: cortinico
      
      Differential Revision: D60828616
      
      Pulled By: cipolleschi
      
      fbshipit-source-id: 6976b86dd67e2fd9d806ebaa62f47e39dc44b30d
      24e7f7d2
  4. Jul 19, 2024
    • Nicola Corti's avatar
      Align github/* action versions on major (#45542) · 818dd92a
      Nicola Corti authored
      Summary:
      Pull Request resolved: https://github.com/facebook/react-native/pull/45542
      
      As we do have several version numbers for external actions all across the codebase,
      here I'm aligning all of them to just use the majors.
      
      I'm doing it only for GitHub first party actions as we trust them,
      so minor/patch changes can safely be pulled in without code changes.
      
      Changelog:
      [Internal] [Changed] - Align github/* action versions on major
      
      Reviewed By: cipolleschi, blakef
      
      Differential Revision: D59959978
      
      fbshipit-source-id: bb07ce0dfd74d9502a2ac0ea90a2b32f55d6d655
      818dd92a
  5. Jul 17, 2024
    • Nicola Corti's avatar
      Composite actions inputs should be kebab-case (#45474) · c1b4133a
      Nicola Corti authored
      Summary:
      Pull Request resolved: https://github.com/facebook/react-native/pull/45474
      
      Our actions inputs are now a mixture of different casing.
      I'm moving everything to be kebab-case
      
      Changelog:
      [Internal] [Changed] -  Composite actions inputs should be kebab-case
      
      Reviewed By: cipolleschi
      
      Differential Revision: D59809181
      
      fbshipit-source-id: af6d541c2b4f5fa162dcde412fb8808bae1ef2d3
      c1b4133a
    • Nicola Corti's avatar
      actions/upload-artifact to v4.x · 16b9b55c
      Nicola Corti authored
      Summary:
      We don't need to specify a minor/patch for actions/upload-artifact.
      We also have all sorts of different versions scattered around the codebase.
      This aligns them to the latest sable in the 4.x series.
      
      Changelog:
      [Internal] [Changed] - actions/upload-artifact to v4.x
      
      Reviewed By: cipolleschi
      
      Differential Revision: D59811525
      
      fbshipit-source-id: 7264db097bcb2ff34b3ace467996e8308c0f2034
      16b9b55c
  6. Jul 10, 2024