Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/facebook/react-native.git. Pull mirroring updated .
  1. Aug 01, 2016
  2. Jul 21, 2016
  3. Jul 20, 2016
    • Emil Sjolander's avatar
      Make isTextNode a prop instead of a function · c7ff46bf
      Emil Sjolander authored
      Reviewed By: javache
      
      Differential Revision: D3586184
      
      fbshipit-source-id: 8b269c11c5d47efb6b788be68336845399292168
      c7ff46bf
    • Emil Sjolander's avatar
      Revamp API · 1af9270e
      Emil Sjolander authored
      Reviewed By: majak
      
      Differential Revision: D3579423
      
      fbshipit-source-id: 040ecab2f20216aa136ccb8a9e7e15ffa882b313
      1af9270e
    • Don Yu's avatar
      Add support for layout gravity to ToastAndroid · 12ec213c
      Don Yu authored
      Summary: Add support for top, bottom, and center layout gravity to ToastAndroid
      
      Reviewed By: AaaChiuuu
      
      Differential Revision: D3590224
      
      fbshipit-source-id: 84dbbcfbe4133f291d62723c5c261acd7b32b46e
      12ec213c
    • Emil Sjolander's avatar
      Use library style import for CSSMacros · 768caf5e
      Emil Sjolander authored
      Reviewed By: javache
      
      Differential Revision: D3576815
      
      fbshipit-source-id: 8d8cf34f701529b272f564088fb1b28708ec27a9
      768caf5e
    • Charles Dick's avatar
      AdsManager now uses new react native QPL identifiers · b25005a8
      Charles Dick authored
      Reviewed By: fkgozali
      
      Differential Revision: D3543775
      
      fbshipit-source-id: b7a6f811c579d35913ad5e480e1a5bc486a6172d
      b25005a8
    • Adam Comella's avatar
      Android: Fix handling of line height with inline images · c4ffc7d7
      Adam Comella authored
      Summary:
      This PR was split from a commit originally in #8619. /cc dmmiller
      
      When an inline image was larger than the specified line height,
      the image would be clipped. This changes the behavior so
      that the line height is changed to make room for the inline
      image. This is consistent with the behavior of RN for iOS.
      
      Here's how the change works.
      
      ReactTextView now receives its line height from the layout thread
      rather than directly from JavaScript.
      
      The reason is that the layout thread may pick a different line height.
      In the case that the tallest inline image is larger than the line
      height supplied by JavaScript, we want to use that image's height as
      the line height rather than the supplied line height.
      
      Also fixed a bug where the image, which is supposed to be baseline
      aligned, would be positioned at the wrong y location. To fix this,
      we use `y` (the baseline) in the `draw` method rather than trying
      to calculate the baseline from `bottom`. For more information
      see https://code.google.com/p/andro
      Closes https://github.com/facebook/react-native/pull/8907
      
      Differential Revision: D3592781
      
      Pulled By: dmmiller
      
      fbshipit-source-id: cba6cd86eb4e3abef6a0d7a81f802bdb0958492e
      c4ffc7d7
    • Andrew Jack's avatar
      Update OkHttp to 3.4.0 and Okio to 1.9.0 · c47f7457
      Andrew Jack authored
      Summary:
      - 3.3.1 wasn't compatible with Robolectric 3.0, however 3.4.0 [fixes](https://github.com/square/okhttp/issues/2533#issuecomment-230198063) this issue.
      - Few other fixes to OkHttp mentioned in the [CHANGELOG.md](https://github.com/square/okhttp/blob/master/CHANGELOG.md)
      
      > Fixes: #7743
      >
      - Android apps can recover from a `REFUSED_STREAM` in HTTP/2.
      - A few other fixes mentioned in the [CHANGELOG.md](https://github.com/square/okhttp/blob/master/CHANGELOG.md)
      
      - CircleCi
      - Test with `/Examples` 
      Closes https://github.com/facebook/react-native/pull/8672
      
      Reviewed By: alsutton
      
      Differential Revision: D3541293
      
      Pulled By: bestander
      
      fbshipit-source-id: 76429861b4f4df15cb9c18ab0f177daee3e1459d
      c47f7457
    • Emil Sjolander's avatar
      CamelCase · 1aa7ad0a
      Emil Sjolander authored
      Reviewed By: majak
      
      Differential Revision: D3576069
      
      fbshipit-source-id: cecda2cdb67f2f66ac92e336068d58731ccdb101
      1aa7ad0a
    • Jon Vassbø's avatar
      Support geolocation in android webview · b7bf24bc
      Jon Vassbø authored
      Summary:
      Makes sure request for geolocation use in the webview is handled.
      This solves issue #7609
      
      Currently use of geolocation in webview fails silently, as the permission request is never received by the native app.
      
      **Test plan (required)**
      
      1. Create new project with webview
      2. Add javascript for geolocation:
      ```javascript
      navigator.geolocation.getCurrentPosition(function (position) {
        console.log('success', position)
      }, function (error) {
        console.log('could not determine position', error)
      })
      ```
      3. Run code and assert geolocation permission is requested, resulting in success (or error) callback being called
      Closes https://github.com/facebook/react-native/pull/8305
      
      Differential Revision: D3592887
      
      fbshipit-source-id: 84fe2383fba8873431c5e89d154c0a4fd58ffb70
      b7bf24bc
    • Dan Caspi's avatar
      Better folly::dynamic ==> JSValue conversion · 654e4bed
      Dan Caspi authored
      Reviewed By: lexs
      
      Differential Revision: D3347854
      
      fbshipit-source-id: 95b81152d1b0d5fe41e01991c44f5d1110be7ddb
      654e4bed
    • Adam Comella's avatar
      Android: Refactor HierarchyOptimizer in preparation of inline view support · e1b3bbdb
      Adam Comella authored
      Summary:
      This PR was split from commits originally in #8619. /cc dmmiller
      
      These refactorings to the HierarchyOptimizer are in preparation for implementing support for inline views in #8619.
      
      **Refactoring 1: Collapse add*LayoutOnlyNodeToLayoutOnlyNode**
      
      addLayoutOnlyNodeToLayoutOnlyNode and addNonLayoutOnlyNodeToLayoutOnlyNode
      had nearly identical implementations. They both walk thru the ancestors
      looking for a nonlayout-only node and adjusting the passed in index at each
      step. This introduces a new function, walkUpUntilNonLayoutOnly, which
      takes care of that responsibility. This simplifies addNodeToNode
      because it can now consider the type of the parent and the type of
      the child independently.
      
      **Refactoring 2: Extract addGrandchildren**
      
      Pull out addLayoutOnlyNode's logic into a helper called
      addGrandchildren. We will need to call this method in
      another place later.
      
      **Test plan (required)**
      
      This change was tested with UIExplorer and a small test app and it's being used in my team's app.
      Closes https://github.com/facebook/react-native/pull/8908
      
      Differential Revision: D3592783
      
      Pulled By: dmmiller
      
      fbshipit-source-id: a513e8d381e71112ce6348bbee7d4a7c62c33619
      e1b3bbdb
    • Emil Sjolander's avatar
      Add [RCTShadowView isCSSLeaf] for skipping css tree of children · 0587c850
      Emil Sjolander authored
      Summary: RCTShadowText currently overrides a couple methods from RCTShadowView to reset the count of the cssNode children to 0. This diff instead moves that logic into RCTShadowView behind a configurable flag making it easier to reason about.
      
      Reviewed By: javache
      
      Differential Revision: D3586434
      
      fbshipit-source-id: 4389a8119dc49e3fc4357174c87c0c69287ae385
      0587c850
    • Emil Sjolander's avatar
      Remove fillCSSNode method · 10257756
      Emil Sjolander authored
      Summary: fillCSSNode was only ever used in RCTShadowView to set the child count which is already performed in insert/remove subview calls and in RCTShadowText is was used to set the measure function which can be done in the initializer instead.
      
      Reviewed By: majak, javache
      
      Differential Revision: D3586418
      
      fbshipit-source-id: de2155daf0f1702c8977bf23183a3b6a650d016b
      10257756
    • Konstantin Raev's avatar
      Enabled Vertical ScrollView instrumentation test in SandCastle · 702c14bd
      Konstantin Raev authored
      Reviewed By: emilsjolander
      
      Differential Revision: D3588423
      
      fbshipit-source-id: ad2486b3da5fe7972e4ea9409a729d2ba2483782
      702c14bd
    • Mengjue Wang's avatar
      Fix Popover problem for RTL 1/n · a527ef20
      Mengjue Wang authored
      Summary: Change modal.js to support RTL
      
      Reviewed By: javache
      
      Differential Revision: D3580776
      
      fbshipit-source-id: e9ef3f340f52e38fd905dce6d14a74d3bd7b7982
      a527ef20
  4. Jul 19, 2016