This project is mirrored from https://github.com/facebook/react-native.git.
Pull mirroring updated .
- Aug 01, 2016
-
-
Mike Grabowski authored
-
Mike Grabowski authored
Summary: This is an initial step of rewriting the CLI interface to use `rnpm` one (commander, plugins etc.). It's scope is to move all existing commands to use rnpm CLI interface, so that we get plugins, flags and our existing ecosystem working out of the box. <s>This is still WIP and some of the commands are left commented out.</s> For the `config` of `rnpm` (functions get info about project and dependency), <s>I am thinking we can merge them with</s> we decided to merge it with [`default.config.js`](https://github.com/grabbou/react-native/blob/e57683e420210749a5a6b802b4e70adb69675786/local-cli/default.config.js#L33), so they are available on the `new Config()` [instance](https://github.com/grabbou/react-native/blob/e57683e420210749a5a6b802b4e70adb69675786/local-cli/cliEntry.js#L59) (which means we don't have to change anything and current plugins, like runIOS and runAndroid can just start using it [w/o depending on any extra argument](https://github.com/grabbou/react-native/blob/e57683e420210749a5a6b802b4e Closes https://github.com/facebook/react-native/pull/7899 Differential Revision: D3613193 Pulled By: bestander fbshipit-source-id: 09a072f3b21e5239dfcd8da88a205bd28dc5d037
-
Marc Shilling authored
Summary: Addresses #8661 Closes https://github.com/facebook/react-native/pull/9071 Differential Revision: D3641285 Pulled By: foghina fbshipit-source-id: dede86743efddc33b6ead053e805770fc213685c
-
Nathan Azaria authored
Summary: There is a conflict between RCTImageLoader and RCTAssetsLibraryRequestHandler on handling images, which was caused by making RCTPhotoLibraryImageLoader able to handle assets library requests as well. This gives more priority to RCTImageLoader instead. Fixes #9031. Reviewed By: mmmulani Differential Revision: D3627451 fbshipit-source-id: 7ffd2c66f43ce1479c9a117768fb2d29f9d0dc08
-
Sokovikov authored
Summary: lineBreakMode only in rc so I think we can replace property without any deprecation warnings. satya164 Closes https://github.com/facebook/react-native/pull/9008 Differential Revision: D3614901 fbshipit-source-id: 724227c0a89192825a24850b930b80884571a51f
-
James Ide authored
Summary: RN imports CSSLayout files like so: `#import <CSSLayout/CSSLayout.h>`, so we need to tell CocoaPods to preserve the directory structure for CSSLayout files. This is done with the header_mappings_dir, but we want it to apply just to CSSLayout's files, hence the subspec. Closes https://github.com/facebook/react-native/pull/9015 Differential Revision: D3621727 fbshipit-source-id: fb3603a0820ca3d6502813204ff215cf160b1955
-
- Jul 21, 2016
-
-
Mike Grabowski authored
-
Fadil Sutomo authored
Summary: Not sure if I misunderstand the previous JSX convention. But I found that in JSX string props, double-quote is preferred instead. https://github.com/facebook/react-native/blob/master/.eslintrc#L182  Closes https://github.com/facebook/react-native/pull/8933 Differential Revision: D3597084 fbshipit-source-id: 606a2123f1a1ff1fe2234b636b68b3273ebf6ebb
-
Mengjue Wang authored
Summary: expose context for I18nManagerModule and I18nUtil Reviewed By: dmmiller Differential Revision: D3575706 fbshipit-source-id: d432d3762df13f9a1b33a32eff306f88e49fe852
-
Emil Sjolander authored
Reviewed By: javache Differential Revision: D3588205 fbshipit-source-id: 27f701a9a85cc0e86bb1d233a6bc74b529a8d4d4
-
Mengjue Wang authored
Summary: Add module dependence into RN Reviewed By: dmmiller Differential Revision: D3575689 fbshipit-source-id: bc8cd221ffa4fcdbdab97051c0f8dedd387d6ee1
-
Mengjue Wang authored
Summary: Create I18nUtil and I18nManagerModule for OSS. Reviewed By: dmmiller Differential Revision: D3575674 fbshipit-source-id: aad96be167f3e7b0692a9cc2c7f8a558e7aa722a
-
- Jul 20, 2016
-
-
Emil Sjolander authored
Reviewed By: javache Differential Revision: D3586184 fbshipit-source-id: 8b269c11c5d47efb6b788be68336845399292168
-
Emil Sjolander authored
Reviewed By: majak Differential Revision: D3579423 fbshipit-source-id: 040ecab2f20216aa136ccb8a9e7e15ffa882b313
-
Don Yu authored
Summary: Add support for top, bottom, and center layout gravity to ToastAndroid Reviewed By: AaaChiuuu Differential Revision: D3590224 fbshipit-source-id: 84dbbcfbe4133f291d62723c5c261acd7b32b46e
-
Emil Sjolander authored
Reviewed By: javache Differential Revision: D3576815 fbshipit-source-id: 8d8cf34f701529b272f564088fb1b28708ec27a9
-
Charles Dick authored
Reviewed By: fkgozali Differential Revision: D3543775 fbshipit-source-id: b7a6f811c579d35913ad5e480e1a5bc486a6172d
-
Adam Comella authored
Summary: This PR was split from a commit originally in #8619. /cc dmmiller When an inline image was larger than the specified line height, the image would be clipped. This changes the behavior so that the line height is changed to make room for the inline image. This is consistent with the behavior of RN for iOS. Here's how the change works. ReactTextView now receives its line height from the layout thread rather than directly from JavaScript. The reason is that the layout thread may pick a different line height. In the case that the tallest inline image is larger than the line height supplied by JavaScript, we want to use that image's height as the line height rather than the supplied line height. Also fixed a bug where the image, which is supposed to be baseline aligned, would be positioned at the wrong y location. To fix this, we use `y` (the baseline) in the `draw` method rather than trying to calculate the baseline from `bottom`. For more information see https://code.google.com/p/andro Closes https://github.com/facebook/react-native/pull/8907 Differential Revision: D3592781 Pulled By: dmmiller fbshipit-source-id: cba6cd86eb4e3abef6a0d7a81f802bdb0958492e
-
Andrew Jack authored
Summary: - 3.3.1 wasn't compatible with Robolectric 3.0, however 3.4.0 [fixes](https://github.com/square/okhttp/issues/2533#issuecomment-230198063) this issue. - Few other fixes to OkHttp mentioned in the [CHANGELOG.md](https://github.com/square/okhttp/blob/master/CHANGELOG.md) > Fixes: #7743 > - Android apps can recover from a `REFUSED_STREAM` in HTTP/2. - A few other fixes mentioned in the [CHANGELOG.md](https://github.com/square/okhttp/blob/master/CHANGELOG.md) - CircleCi - Test with `/Examples`
✅ Closes https://github.com/facebook/react-native/pull/8672 Reviewed By: alsutton Differential Revision: D3541293 Pulled By: bestander fbshipit-source-id: 76429861b4f4df15cb9c18ab0f177daee3e1459d -
Emil Sjolander authored
Reviewed By: majak Differential Revision: D3576069 fbshipit-source-id: cecda2cdb67f2f66ac92e336068d58731ccdb101
-
Jon Vassbø authored
Summary: Makes sure request for geolocation use in the webview is handled. This solves issue #7609 Currently use of geolocation in webview fails silently, as the permission request is never received by the native app. **Test plan (required)** 1. Create new project with webview 2. Add javascript for geolocation: ```javascript navigator.geolocation.getCurrentPosition(function (position) { console.log('success', position) }, function (error) { console.log('could not determine position', error) }) ``` 3. Run code and assert geolocation permission is requested, resulting in success (or error) callback being called Closes https://github.com/facebook/react-native/pull/8305 Differential Revision: D3592887 fbshipit-source-id: 84fe2383fba8873431c5e89d154c0a4fd58ffb70
-
Dan Caspi authored
Reviewed By: lexs Differential Revision: D3347854 fbshipit-source-id: 95b81152d1b0d5fe41e01991c44f5d1110be7ddb
-
Adam Comella authored
Summary: This PR was split from commits originally in #8619. /cc dmmiller These refactorings to the HierarchyOptimizer are in preparation for implementing support for inline views in #8619. **Refactoring 1: Collapse add*LayoutOnlyNodeToLayoutOnlyNode** addLayoutOnlyNodeToLayoutOnlyNode and addNonLayoutOnlyNodeToLayoutOnlyNode had nearly identical implementations. They both walk thru the ancestors looking for a nonlayout-only node and adjusting the passed in index at each step. This introduces a new function, walkUpUntilNonLayoutOnly, which takes care of that responsibility. This simplifies addNodeToNode because it can now consider the type of the parent and the type of the child independently. **Refactoring 2: Extract addGrandchildren** Pull out addLayoutOnlyNode's logic into a helper called addGrandchildren. We will need to call this method in another place later. **Test plan (required)** This change was tested with UIExplorer and a small test app and it's being used in my team's app. Closes https://github.com/facebook/react-native/pull/8908 Differential Revision: D3592783 Pulled By: dmmiller fbshipit-source-id: a513e8d381e71112ce6348bbee7d4a7c62c33619
-
Emil Sjolander authored
Summary: RCTShadowText currently overrides a couple methods from RCTShadowView to reset the count of the cssNode children to 0. This diff instead moves that logic into RCTShadowView behind a configurable flag making it easier to reason about. Reviewed By: javache Differential Revision: D3586434 fbshipit-source-id: 4389a8119dc49e3fc4357174c87c0c69287ae385
-
Emil Sjolander authored
Summary: fillCSSNode was only ever used in RCTShadowView to set the child count which is already performed in insert/remove subview calls and in RCTShadowText is was used to set the measure function which can be done in the initializer instead. Reviewed By: majak, javache Differential Revision: D3586418 fbshipit-source-id: de2155daf0f1702c8977bf23183a3b6a650d016b
-
Konstantin Raev authored
Reviewed By: emilsjolander Differential Revision: D3588423 fbshipit-source-id: ad2486b3da5fe7972e4ea9409a729d2ba2483782
-
Mengjue Wang authored
Summary: Change modal.js to support RTL Reviewed By: javache Differential Revision: D3580776 fbshipit-source-id: e9ef3f340f52e38fd905dce6d14a74d3bd7b7982
-
- Jul 19, 2016
-
-
Adalbert Gorecki authored
Summary: Just a small update to fix the error message in `Alert.js`. In my app, I'm using https://github.com/zo0r/react-native-push-notification to show local notifications. When the notification is tapped, I'm trying to show an alert with the notification text, but this results in an error (which is not the problem I'm addressing here). Unfortunately the wrong parameter was passed to the `console.warn`, so you couldn't see what the error message was. Before: <img width="416" alt="bildschirmfoto 2016-07-18 um 10 50 35" src="https://cloud.githubusercontent.com/assets/666322/16910168/7b45c7ac-4cd7-11e6-8d3e-3861d2fc648c.png"> <img width="416" alt="bildschirmfoto 2016-07-18 um 10 50 43" src="https://cloud.githubusercontent.com/assets/666322/16910173/854fc0ea-4cd7-11e6-956f-93ee68a09bd6.png"> After fix: <img width="416" alt="bildschirmfoto 2016-07-18 um 10 50 35" src="https://cloud.githubusercontent.com/assets/666322/16910168/7b45c7ac-4cd7-11e6-8d3e-3861d2fc648c.png"> <img width="416" alt="bildschirmfoto 2016 Closes https://github.com/facebook/react-native/pull/8861 Differential Revision: D3586453 fbshipit-source-id: bf81e42bd4450ef15a301e7367e94355379c442e
-
Pieter De Baets authored
Summary: Add some additional perf markers, and remove the usage of RCTProfileBlock as it completely breaks debugging / stepping in those blocks. Reviewed By: majak Differential Revision: D3579900 fbshipit-source-id: 8846dfc39b2448daa3669d5e1e8efb9096f183c5
-
Jhen authored
Summary: The `setupDevtools` for Android looks coming on [v0.30](https://github.com/facebook/react-native/commit/22fbb6d46d4b91bfe08b83aaba46ad92a32bf984), currently we need to run `adb reverse tcp:8097 tcp:8097`, I think get host IP (`10.0.2.2`, Genymotion: `10.0.3.2`) for Android will be better. (it can be found in `AndroidConstants` native module) Closes https://github.com/facebook/react-native/pull/8811 Differential Revision: D3586177 Pulled By: javache fbshipit-source-id: 3bfe04391b0fea608e4d3deab03dd376fab8727c
-
themorecolor@gmail.com authored
Summary: Closes https://github.com/facebook/react-native/pull/8886 Differential Revision: D3586269 fbshipit-source-id: d6dc0a3618f3c1c4516ce428dd525b3f8aa09d3c
-
Bart den Hollander authored
Summary: Installing react-native gives a warning because of outdated version of yeoman-generator. The warning is ```npm WARN deprecated minimatch@2.0.10: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue```. This MR will update the yeoman-generator version to 0.21.0 to resolve this warning. Closes https://github.com/facebook/react-native/pull/8859 Reviewed By: matryoshcow Differential Revision: D3580087 Pulled By: bestander fbshipit-source-id: 4daddd804679ab8e95e59cf0d0005f87d2f48e1c
-
aleclarsoniv authored
Summary: Addresses this comment: https://github.com/facebook/react-native/issues/2296#issuecomment-232446493 This pull request adds the `center` value to `ImageResizeMode`. When set, it will center the image within its frame. If the image is larger than its frame, the image is downscaled while maintaining its aspect ratio. That is how the Android implementation works, too. Sorry, don't have time to write tests.
😢 Any reviewers should make sure `RCTTargetRect` returns the correct value when: - the image is smaller than its frame (ie: no downscaling needed) - the image is larger than its frame (should be downscaled to avoid clipping) Closes https://github.com/facebook/react-native/pull/8792 Differential Revision: D3586134 Pulled By: javache fbshipit-source-id: 78fb8e5928284003437dac2c9ad264fa584f73ec -
Tobias Ritzau authored
Reviewed By: javache Differential Revision: D3569816 fbshipit-source-id: ab03f3f3ad10b3921d428628c87e4091c07ceafe
-
Rakan Nimer authored
Summary: **Motivation** : Debugging RN with Stetho is very helpful but not very well documented. **Result Screenshot**  Closes https://github.com/facebook/react-native/pull/8883 Differential Revision: D3586063 fbshipit-source-id: e55ebee0d1e1eedb109bec307c313942bc70b646
-
sasaki takeru authored
Summary: UIExplorerApp.ios.js is moved into js directory. Closes https://github.com/facebook/react-native/pull/8884 Differential Revision: D3586032 Pulled By: nathanajah fbshipit-source-id: 93793681e33a0922e3d8503da3f1c0d01fd4fa93
-
Brent Vatne authored
Summary: I thought it would be useful to help clear out references to no longer used styles and also catch typos on style names to have flow error when we try to access a style that isn't defined. Example: ```javascript export default class AuthenticationScreen extends React.Component { render() { // This throws an error because `continer` is misspelled return ( <View style={styles.continer} /> ) } } const styles = StyleSheet.create({ container: { flex: 1, }, } ``` ```javascript export default class AuthenticationScreen extends React.Component { render() { // This throws an error because no fancyContainer style is defined return ( <View style={[styles.container, styles.fancyContainer]} /> ) } } const styles = StyleSheet.create({ container: { flex: 1, }, } ``` All credit goes to jeffmo in this tweet: https://twitter.com/lbljeffmo/status/755179096271888385 Also included in the PR is some cleanup on styles that Closes https://github.com/facebook/react-native/pull/8876 Differential Revision: D3584983 Pulled By: yungsters fbshipit-source-id: 0ee0e12ff3d976c137d932688e323c26690e0a52
-
Yibin Chen authored
Reviewed By: AaaChiuuu Differential Revision: D3558831 fbshipit-source-id: b3909de774922fae903f3e8718fbfcd9b1ece2f8
-
Olivier Notteghem authored
Reviewed By: dmmiller Differential Revision: D3553287 fbshipit-source-id: ea33bb7d929cbc0229bfe8537c3a4fc58fe9691e
-
Mehdi Mulani authored
Reviewed By: javache Differential Revision: D3579609 fbshipit-source-id: c108bbe135a0a9a98045ebc8068a103c892a1d0f
-