Skip to content
Snippets Groups Projects
Select Git revision
0 result
Search by author
  • Any Author
0 authors
This project is mirrored from https://github.com/facebook/react-native.git. Pull mirroring updated .
  1. Nov 23, 2016
  3. Nov 21, 2016
  5. Nov 09, 2016
  7. Nov 08, 2016
    • Antoine Rousseau's avatar
      Android WebSocket: include cookies in request · be4afdde
      Antoine Rousseau authored 
      Summary:
This PR updates #6851 from srikanthkh, fixing coding conventions and javadoc, and adding a test plan.

Added testing functions into the WebSocketExample page of the UIExplorer, including a tiny http server to set a cookie on demand. Instructions included in the UIExplorer app.
Closes https://github.com/facebook/react-native/pull/9114

Differential Revision: D4140534

Pulled By: lacker

fbshipit-source-id: e020ad0c6d1d3ea09c0c3564c1795b4e1bc4517d
      be4afdde
    • Geordie's avatar
      Only retain the previousViews that need to be validated · a4bb4d25
      Geordie authored 
      Summary:
Fixes #4740, where views would unnecessarily be retained after performing `navigator.pop()` - this was particularly problematic for big lists and memory-intensive custom views.

This fix causes no functional change: `_previousViews` are only used in the loop starting at line 564 to ensure that the JavaScript and Native navigation stacks are equivalent at all times. As we do in this fix, that loop limits itself to only the views expected to be on the React navigation stack. So overall this change makes the code logically 'more correct'.

Tested by checking that `_previousViews.count` is always equivalent to `previousReactCount` in the loop (which means we could remove the complex `MIN(... MIN(previousReactCount, _previousViews.count)` in the loop too, but I wanted to keep the diff as small as possible for now).
Closes https://github.com/facebook/react-native/pull/10789

Differential Revision: D4140502

Pulled By: ericvicenti

fbshipit-source-id: 4491ad3c16642914c3081295cf95c4cf36be9f94
      a4bb4d25
  9. Nov 07, 2016
    • Andy Street's avatar
      Make CSSNode#measure final, cache more correct methodid · 0089cd76
      Andy Street authored 
      Summary:
In the JNI portion of CSSLayout, there's a subtle bug where we were caching the jmethodid of the 'measure' of the first object that had measure called on it. However, if that class had overriden measure, then the jmethodid would be specific to that subclass's implementation and would not work for other classes. Conversely, if a regular CSSNode had been called first, then the super method would be called on the subclass instead of the proper overriden method.

Since there's not really a reason to overriden measure anyway (since you can just provide a different measure function), it's safest to just mark it final and explicitly cache the appropriate methodid

Reviewed By: emilsjolander

Differential Revision: D4132428

fbshipit-source-id: 6fb51597d80f1c03681e6611153b52b73b392245
      0089cd76
    • Andy Street's avatar
      Lazy create children list when first child is added · a320b0ab
      Andy Street authored 
      Summary: We don't need to allocate a list for every node since leaf nodes don't have children.

Reviewed By: emilsjolander

Differential Revision: D4130818

fbshipit-source-id: 80d3e98fce9d2daa0676fd1cbed0e81edcf7adb3
      a320b0ab
    • Andy Street's avatar
      Assert that node can have measure function <==> node is a leaf node · 96a581f6
      Andy Street authored 
      Summary: Instead of silently ignorning non-leaf nodes with measure functions, we should assert that we don't create those kinds of trees.

Reviewed By: emilsjolander

Differential Revision: D4130770

fbshipit-source-id: a3ef10a2e63bbc12b5aa07977e4b84c8d59e3ffe
      96a581f6
    • Andres Suarez's avatar
      Remove prepack bundle functionality · ba8bbcbe
      Andres Suarez authored 
      Reviewed By: davidaurelio

Differential Revision: D4138495

fbshipit-source-id: 52793fc1a8ef8b2fc461156607c360f34c4cb362
      ba8bbcbe
    • Andres Suarez's avatar
      Move graphql from deps to devDeps · d2bdc24e
      Andres Suarez authored 
      Reviewed By: cpojer

Differential Revision: D4139626

fbshipit-source-id: 52e5c19cf3b472c0b62a0ae18fb7bb21f0d88841
      d2bdc24e
    • Héctor Ramos's avatar
      Consolidate Running on Device (Android|iOS) Guides into one · 72369ee4
      Héctor Ramos authored 
      Summary:
The RunningOnDeviceAndroid doc had some Linux-specific instructions that are not relevant to macOS/Windows users.
Closes https://github.com/facebook/react-native/pull/10726

Differential Revision: D4139089

Pulled By: JoelMarcey

fbshipit-source-id: cc57c1d7e3c9dec94e123c3597ac78b3efb15dd0
      72369ee4
    • Kevin Gozali's avatar
      modernize AppContainer and add rootTag in the child context · fb7fe2d4
      Kevin Gozali authored 
      Summary:
This does 2 things:
- modernize the component to use ES6 + flow
- assign `rootTag` to the child context

Each view in RN has its own `reactTag`. The reactTag for a root view is called `rootTag`. When there are multiple react root views active within the app (e.g. in a hybrid environment), rootTag is the only reliable "label" to differentiate them. This is especially useful when we want to limit an event/activity on a particular root view, instead of affecting all active root views. This allows components to do:

```
class Foo extends React.Component {
  static contextTypes = {
    rootTag: React.PropTypes.number,
  };

  componentDidMount() {
    // Get the root tag of this component, which is static for all components under the same root view
    console.log(this.context.rootTag);
  }
}
```

In a pure JS RN app environment, there will always be exactly 1 root view, so `rootTag` may usually be ignored.

Reviewed By: yungsters

Differential Revision: D4130376

fbshipit-source-id: 559b67615f487bad754b5832ad4a02bcef05be2a
      fb7fe2d4
    • Chuck Dishmon's avatar
      Update HandlingTextInput.md · 6c04b359
      Chuck Dishmon authored 
      Summary:
Thanks for submitting a pull request! Please provide enough information so that others can review your pull request:

> **Unless you are a React Native release maintainer and cherry-picking an *existing* commit into a current release, ensure your pull request is targeting the `master` React Native branch.**

Explain the **motivation** for making this change. What existing problem does the pull request solve?

Prefer **small pull requests**. These are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it.

**Test plan (required)**

Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI.

Make sure tests pass on both Travis and Circle CI.

**Code formatting**

Look around. Match the style of the rest of the codebase. See also the simple [style guide](https://github.com/facebook/react-native/blob/master/CONTRIBUTING.md#style-guide).

For more info, see
Closes https://github.com/facebook/react-native/pull/10763

Differential Revision: D4139069

Pulled By: JoelMarcey

fbshipit-source-id: ecc36f4e0ff4a44c95d63a256e0cdf67a4d386b3
      6c04b359
  11. Nov 06, 2016
  13. Nov 05, 2016
  15. Nov 04, 2016