This project is mirrored from https://github.com/facebook/react-native.git.
Pull mirroring updated .
- Dec 02, 2016
-
-
Mike Grabowski authored
-
Yann Pringault authored
Summary: This PR fixes #11096. I don't know enough the ReactAndroid's source code so I don't know if this is correct but I hope it is. In a recent commit (https://github.com/facebook/react-native/commit/d4b8ae7a8a3de314b5813e0bfcdf5fb265129d43), the `dispatchUpdates` method now returns a boolean to dispatch or not the `onLayout` event. This works well but if the content is unchanged, the line `nativeViewHierarchyOptimizer.handleUpdateLayout(this);` is never called. I don't know if it was intended but it was this which introduces my issue. I called this again even if the content didn't change. This was the behaviour before 0.38 so I guess I didn't break anything. **Test plan (required)** I tested my pretty big app with this fix and every screen is ok. Closes https://github.com/facebook/react-native/pull/11222 Differential Revision: D4252101 Pulled By: astreet fbshipit-source-id: 551559234631ac37245a854d81ba568f0ddb02dd
-
- Nov 23, 2016
-
-
Mike Grabowski authored
-
Mike Grabowski authored
Summary: We now keep track of breaking changes - include required steps to sync them up with the release so they are relevant. Differential Revision: D4225698 fbshipit-source-id: 35780330e95f2e51b3df192a709cd3e7431e52ab
-
Alex Kotliarskyi authored
Reviewed By: yungsters Differential Revision: D4179964 fbshipit-source-id: e56ee7814e23a3afc6223527f1afefe51a9e0aec
-
Alex Kotliarskyi authored
Reviewed By: fkgozali Differential Revision: D4196297 fbshipit-source-id: 5c32646dfe858f34c185a917e7d081a60777f242
-
Martin Konicek authored
Summary: Follow on in https://github.com/facebook/react-native/pull/10864. **Motivation** ncuillery Is has a lot of experience with upgrading RN projects (see his [talk](http://www.slideshare.net/ncuillery/introducing-the-new-reactnative-upgrade)) and is rewriting 'react-native upgrade' to use git. He tells me that we actually want git to merge changes in the .pbxproj file. In his words: "Making the project.pbxproj invisible for "git diff" means that react-native-git-upgrade will never be able to upgrade the project.pbxproj." Note the git docs explicitly recommend not to use git to merge .pbxproj files: https://git-scm.com/book/en/v2/Customizing-Git-Git-Attributes#Binary-Files ncuillery do we have an alternative? Some ideas: 1. Use a 3rd-party tool in 'react-native upgrade' to merge the .pbxproj file? 2. We could always re-generate and overwrite the .pbxproj file (never merge) and then run 'react-native link' to update native 3rd-party dependencies in the Xcode project? 3. Last resort: stay away Closes https://github.com/facebook/react-native/pull/11047 Differential Revision: D4220521 fbshipit-source-id: 823c735856b519be114aa4349ca1392910f00445
-
Nicolas Charpentier authored
Summary: Add icebox command to comment, label and close an issue from one command instead of ping facebook bot serveral times. The goal is to reduce ping pollution, see the [current implementation](https://github.com/facebook/react-native/issues/6752#issuecomment-260830484). Will be used by the Iceboxer script for people who only have access to the facebook-github-bot. cc mkonicek Closes https://github.com/facebook/react-native/pull/10963 Differential Revision: D4222330 Pulled By: mkonicek fbshipit-source-id: 69ecf282a7004dfc23884e906bec582c58a749a8
-
Vojtech Novak authored
Summary: the linked [repo](https://github.com/ncuillery/rn-diff) can help significantly ease the upgrade process. Closes https://github.com/facebook/react-native/pull/10953 Differential Revision: D4222341 Pulled By: mkonicek fbshipit-source-id: 5ff4952ecc38f816c404bb56af4d744cf84aef7d
-
Martin Konicek authored
Summary: As said in #10944, there's not yet some good infos on how to profile the javascript. I'm adding a mention to two ways of doing it (`react-addons-perf` and chrome profiler), feel free to correct me on this. I almost added an example for `react-addons-perf` but I'm not sure what's the correct way to use. Here's the way I use it: ```javascript import Perf from 'react-addons-perf'; .... componentDidMount() { console.log('start perf tracking'); Perf.start(); setTimeout(() => { console.log('stop perf tracking'); Perf.stop(); Perf.printExclusive(); }, 10000); } ... ``` Closes https://github.com/facebook/react-native/pull/10974 Differential Revision: D4221630 Pulled By: mkonicek fbshipit-source-id: 918f837b9c7169c3dd835e653c78159b801fb946
-
Adam Comella authored
Summary: Corresponding Android PR: https://github.com/facebook/react-native/pull/11001 This adds an onScroll event to TextInput which is useful when a multiline TextInput has so much content that it is scrollable. **Test plan (required)** Verified the event works properly in a test app. Also, my team uses this event in our app. Adam Comella Microsoft Corp. Closes https://github.com/facebook/react-native/pull/11002 Differential Revision: D4203565 Pulled By: ericvicenti fbshipit-source-id: 7cb5e10325c3b03c6b395cce0f1bacb0528db40a
-
Wojciech Ogrodowczyk authored
Summary: Just fixes a typo in an error message when running a simulator that XCode doesn't recognise. Closes https://github.com/facebook/react-native/pull/11060 Differential Revision: D4220364 Pulled By: mkonicek fbshipit-source-id: da7b9a529ad8cd77c6e144f4bbf3ea594a9efee4
-
Abhijit Nukalapati authored
Summary: - Updating code snippets in the android integration docs which use methods that no longer exist in the [ReactInstanceManager](https://github.com/facebook/react-native/blob/master/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManager.java) class Closes https://github.com/facebook/react-native/pull/11070 Differential Revision: D4220830 Pulled By: JoelMarcey fbshipit-source-id: 0dfc49accc27feb42ac31fb50c887736e652ec1b
-
Adam Comella authored
Summary: TextInput rounds padding down with `floor` when measuring. However, it rounds padding up with `ceil` when rendering. This change makes things consistent by moving TextInput's rendering code to use `floor` as well. It looks like this is the intended behavior because commit bdff10b4 moved measuring from `ceil` to `floor`. It looks like TextInput's rendering code was just overlooked in that commit. **Test plan (required)** Verified TextInput padding works in a test app. Also, my team uses this change in our app. Adam Comella Microsoft Corp. Closes https://github.com/facebook/react-native/pull/11003 Differential Revision: D4220855 Pulled By: mkonicek fbshipit-source-id: 95349867ef89c021a8441b383a09052ca0dd569c
-
Andres Suarez authored
Summary: * babel 6.19.0 (https://github.com/babel/babel/releases/tag/v6.19.0) * babylon 6.14.1 (https://github.com/babel/babylon/releases/tag/v6.14.0) * Now supports optional names for function types and object type indexers. Reviewed By: bestander Differential Revision: D4219045 fbshipit-source-id: d694c079e3176f426949f7859b6d2dfaab60a707
-
Patrik Toma authored
Summary: Improve code formatting Closes https://github.com/facebook/react-native/pull/11019 Differential Revision: D4220686 Pulled By: mkonicek fbshipit-source-id: 019c02ee98e632b7f48567a22ca8cabeddadd584
-
Pieter De Baets authored
Reviewed By: davidaurelio Differential Revision: D4220267 fbshipit-source-id: 37a6ff51609aaa129683d57f853f59758ff55012
-
king6cong authored
Summary: Closes https://github.com/facebook/react-native/pull/11067 Differential Revision: D4220269 Pulled By: mkonicek fbshipit-source-id: 7fa70d5f15211215396375711be1583a8877ef5e
-
- Nov 22, 2016
-
-
Daniel Dimitrov authored
Summary: When running in strict mode we run into the following error: “Cannot assign to read only property 'product' of object '#<WorkerNavigator>’” Moreover navigator.product = ‘ReactNative’; didn’t actually change the product value. Without strict mode this was silently ignored. By using our defineProperty function we are able to run in strict mode and now navigator.product is really ReactNative. See https://github.com/facebook/react-native/issues/10881 for more information --------------- Long story short - if we run in strict mode, the current code throws an error : `Cannot assign to read only property 'product' of object '#<WorkerNavigator>' initializeCore.js` (the current version of initializeCore.js doesn't have 'use strict'; on top, but if you are unfortunate enough to have a babel module that ads this for you, you are guaranteed to run into this. Moreover our contributing guidelines say that we should have 'use strict'; https://github.com/facebook/react-native/blob/master/CONTRIB Closes https://github.com/facebook/react-native/pull/11057 Differential Revision: D4219958 Pulled By: javache fbshipit-source-id: 35568b2ce4b87fff1aa8248f067d49e5f9f9e9a2
-
Pieter De Baets authored
Reviewed By: bnham Differential Revision: D4197374 fbshipit-source-id: 107a129cff35dddfe06104b607441ad412f83d90
-
Pieter De Baets authored
Reviewed By: bnham Differential Revision: D4197369 fbshipit-source-id: 53869fe1b56010c8a5330025d06ef557369e4957
-
Lukas Woehrl authored
Summary: Added an experimental feature to allow to use only rounded values. See #184. It's not a perfect solution and definitely can be further improved. I'm looking forward to your ideas. Closes https://github.com/facebook/css-layout/pull/256 Reviewed By: splhack Differential Revision: D4214168 Pulled By: emilsjolander fbshipit-source-id: 6293352d479b7b4dad258eb3f9e0afaa11cf7236
-
jrodiger authored
Summary: Line 367 said **throughly** when it should say **thoroughly** Closes https://github.com/facebook/react-native/pull/11054 Differential Revision: D4218630 fbshipit-source-id: b2bb58106879a01bdf9694fd8b1b2fda57295755
-
Michał Gregorczyk authored
Reviewed By: bnham Differential Revision: D4213580 fbshipit-source-id: 3830c15b0097030a4e4611aac814b12e1d6ae696
-
Michał Gregorczyk authored
Reviewed By: bnham Differential Revision: D4213497 fbshipit-source-id: 47e0e7d72891e1070c350a60fb7d3597e99d49a1
-
David Aurelio authored
Summary: Adds flow types for output functionality for easier maintenance and interop with new code Reviewed By: matryoshcow Differential Revision: D4211863 fbshipit-source-id: 591407d3a6d49536054ae94ba31125c18a1e1fa1
-
Martin Konicek authored
Summary: Followup for CLI rewrite (https://github.com/facebook/react-native/commit/a477aec10d29b4651944cb4292daf06dfa953ea3). See the comment in the code for details. **Test plan (required)** - Published to Sinopia locally ([docs](https://github.com/facebook/react-native/tree/master/react-native-cli)) - Ran 'react-native init MyApp', the correct files were created (no more .npmignore, but have .gitignore): $ cd MyApp $ ls -a . .flowconfig __tests__ ios .. .gitattributes android node_modules .babelrc .gitignore index.android.js package.json .buckconfig .watchmanconfig index.ios.js yarn.lock - Changed .flowconfig, ran 'react-native upgrade'. Saw a prompt "Do you want to overwrite .flowconfig", tried answering first 'n' and then 'y'. When answering 'y' the file was overwritten by the version from the template as expected. Closes https://github.com/facebook/react-native/pull/11051 Differential Revision: D4214831 Pulled By: ericvicenti fbshipit-source-id: 7c6aae4f97c7d45e7241bf017ed2f6527d5d29fe
-
Emil Sjolander authored
Reviewed By: gkassabli Differential Revision: D4213339 fbshipit-source-id: 5ca35ca307594f3419fd0dee81321d3c2e06710f
-
Emil Sjolander authored
Reviewed By: gkassabli Differential Revision: D4213313 fbshipit-source-id: 2061a809202f7f948bff1b3ee8dc4c230692a223
-
Emil Sjolander authored
Reviewed By: gkassabli Differential Revision: D4213302 fbshipit-source-id: df4bc43848325e99ad338a2fa6d5c9404315b0e6
-
Ovidiu Viorel Iepure authored
Summary: Fix more lint warnings in local-cli Reviewed By: davidaurelio Differential Revision: D4213265 fbshipit-source-id: a7f251f2af1e1de67a2b51908713e7a18faf6f18
-
Ovidiu Viorel Iepure authored
Summary: Switch to native promises in the local cli Reviewed By: davidaurelio Differential Revision: D4213142 fbshipit-source-id: aff99f8bb3dc237cecc852cdb09dee9b49b05753
-
Emil Sjolander authored
Reviewed By: gkassabli Differential Revision: D4211458 fbshipit-source-id: f8d0d318369c7b529ee29e61a52b17d0cf3b396d
-
Andy Street authored
Summary: flex: 1 is no longer correct Reviewed By: emilsjolander Differential Revision: D4182840 fbshipit-source-id: 912119c09d887d545a28d2855c5583f1d8d7c93e
-
Ovidiu Viorel Iepure authored
Summary: Remove Gradle testing from CI suite Reviewed By: bestander, astreet Differential Revision: D4213478 fbshipit-source-id: 2397aced9540ed9f478e55fdf0097cedc9af4805
-
Andy Street authored
Summary: Depends on D4189532 Drops the CSSNodePool when memory gets low. Reviewed By: emilsjolander Differential Revision: D4190264 fbshipit-source-id: 94cd36d877372e0d6ebdd989661af74bde41486d
-
Andy Street authored
Summary: Adds a pool to recycle CSSNodes within UIManager. A follow-up diff will hook this up to a memory pressure listener to drop the pool on memory pressure. Reviewed By: emilsjolander Differential Revision: D4189532 fbshipit-source-id: 46583546f71a8c59853e1dd124de31657b3c617b
-
Pieter De Baets authored
Summary: Correct header import paths, update podspec so we point at the copy in ReactCommon (and can eventually remove the copy under React) Reviewed By: astreet Differential Revision: D4204501 fbshipit-source-id: e979a010092f025b2cdc289e1e5f22fc7b65a8d1
-
- Nov 21, 2016
-
-
Pieter De Baets authored
Reviewed By: mhorowitz Differential Revision: D4159911 fbshipit-source-id: db913704641daf055060f5fe4561479daf76cd5a
-
Andy Street authored
Summary: Moves from CSSNodeDEPRECATED to CSSNode. This has shown to be a huge performance win for layout time within FB. This is BREAKING because CSSNode contains bug fixes that were not migrated to CSSNodeDEPRECATED which may change the way your layout appears. The most common of these by far involves `flex: 1`. Previously, developers had to put `flex: 1` in many places it didn't belong in order to work around a bug in css-layout. Now `flex: 1` is treated properly and, unfortunately, this means that your layout may no longer look correct. Specifically, you may see that your layout looks collapsed, or children don't render. The fix is to simply remove `flex: 1` from those containers. Reviewed By: emilsjolander Differential Revision: D3992787 fbshipit-source-id: 7a3a2a34a8941c0524e6ba3c5379e434d3e03247
-