This project is mirrored from https://github.com/facebook/react-native.git.
Pull mirroring updated .
- Feb 07, 2017
-
-
Leland Richardson authored
-
Ben Schwab authored
This follows the same approach as b59f99b7e7f69b138860d12959eec9b46cd790a3 but fixes a bug in ReactViewGroup#refreshTranslucentBackgroundDrawable where a view that has a borderRadius, but no nativeBackground would not be rendered due to a missing condition case.
-
Andy Chen authored
Picked from here: https://github.com/facebook/react-native/commit/26be005b0a8349afc7f00d8eb0bfe92be85021af
-
Leland Richardson authored
-
Jimmy Zhuang authored
-
Leland Richardson authored
-
- Feb 06, 2017
-
-
James Ide authored
In my RN checkout, I use "upstream" as my remote instead of "origin" -> this lets me run `scripts/bump-oss-version.js --remote upstream 0.41.1` for example. Also made the script executable so we don't need to put `node` in front of it, and updated the Releases.md doc. Test Plan: Did a dry run, saw that without the `--remote` flag the default remote is still `origin` and that specifying the flag let me override the origin.
-
James Ide authored
-
Eric Vicenti authored
Summary: The iOS and Android native folders of a React Native app can be difficult to maintain. This introduces a new workflow for creating and maintaining the native code of your app. Now it will be possible to: 1. Remove the native iOS or Android folders 2. Create an `app.json` for your app, with at least a `name` and `displayName` 3. Run `react-native eject`, and the native code for your app will be generated Then, as usual, you can run `react-native run-ios` and `react-native run-android`, to build and launch your app For apps that don't have any native code, it will be possible to ignore the `ios` and `android` folders from version control. Eject step tested in RN app by deleting native folders. mkonicek, what is the best way to test `react-native init`? As follow-up items, we can enable the following: - Configuring app icon and launch screen from the `app.json` - Automatically run `react-native link` for native libraries - A Closes https://github.com/facebook/react-native/pull/12162 Differential Revision: D4509138 Pulled By: ericvicenti fbshipit-source-id: 0ee213e68f0a3d44bfce337e3ec43e5024bacc66
- Feb 04, 2017
-
-
Martin Konicek authored
-
Mike Grabowski authored
Summary: Ignores `bundle.js` that is a webpack bundle and got most likely accidentally released. Already cherry-picked to 0.42 Fixes #12183 Closes https://github.com/facebook/react-native/pull/12185 Differential Revision: D4507535 Pulled By: mkonicek fbshipit-source-id: 2ab404534b345cf531f408b654c34a30abd01458
-
- Feb 03, 2017
-
-
Mike Grabowski authored
-
Emil Sjolander authored
-
rh389 authored
Summary: Fixes https://github.com/facebook/react-native/issues/11861 - the release config is currently broken for projects created by `react-native init` in `master`, 0.40 and 0.39. I'm still investigating when and how this got broken but this seems to be a clean fix. I've added `-ObjC` as well to match the main target but I'm not sure yet whether that's necessary. To test: ``` react-native init fooproject --version react-native@rh389/react-native#missinglinkerflags ``` Open in XCode, Edit scheme (⌘<), Change `Build Configuration` to `Release`, build. Update: The `-lc++` flag became necessary when https://github.com/facebook/react-native/commit/33deaad196834e77a507cad7b13039161258c059 landed because of the libstdc++ dependencies of `RCTLog`. Still not sure about `-ObjC`. javache ? Closes https://github.com/facebook/react-native/pull/11889 Differential Revision: D4421685 Pulled By: javache fbshipit-source-id: 954edaef773f8cef7b7ad671fa4d1f2bfc2f20f2
-
Tomas Roos authored
Summary: Currently the master Podspec is broken because tvOS files are being included, to avoid this compile error the file is being excluded. https://github.com/facebook/react-native/commit/c92ad5f6ae74c1d398c7cd93d5c4c50da0ca0430 Thats the commit which introduced the breakage anything later that that will fail. Aka RN 0.41 will fail because of this. **Test plan (required)** Tested on new project against master // cc ide Closes https://github.com/facebook/react-native/pull/11667 Differential Revision: D4375453 Pulled By: ericvicenti fbshipit-source-id: 035cdb8ef36054b40d1aaf59551cdc2e16f0cb19
-
- Jan 31, 2017
-
-
Martin Konicek authored
-
Martin Konicek authored
Summary: This is a followup for https://github.com/facebook/react-native/pull/12088 and implements the scrolling to end on Android natively rather than sending a large scroll offset from JS. This turned out to be an OK amount of code, and some reduction in the amount of JavaScript. The only part I'm not particularly happy about is: ``` // ScrollView always has one child - the scrollable area int bottom = scrollView.getChildAt(0).getHeight() + scrollView.getPaddingBottom(); ``` According to multiple sources (e.g. [this SO answer](http://stackoverflow.com/questions/3609297/android-total-height-of-scrollview)) it is the way to get the total size of the scrollable area, similar to`scrollView.contentSize` on iOS but more ugly and relying on the fact the ScrollView always has a single child (hopefully this won't change in future versions of Android). An alternative is: ``` View lastChild = scrollLayout.getChildAt(scrollLayout.getChildCount() - 1); int bottom = lastChild.getBottom() + scrollLayout.getPadd Closes https://github.com/facebook/react-native/pull/12101 Differential Revision: D4481523 Pulled By: mkonicek fbshipit-source-id: 8c7967a0b9e06890c1e1ea70ad573c6eceb03daf
-
Martin Konicek authored
Summary: **Motivation** A basic task of making a React Native ScrollView or ListView scroll to the bottom is currently very hard to accomplish: - https://github.com/facebook/react-native/issues/8003 - https://github.com/facebook/react-native/issues/913 - http://stackoverflow.com/questions/29829375/how-to-scroll-to-bottom-in-react-native-listview **NOTE:** If you're building something like a chat app where you want a ListView to keep scrolling to the bottom at all times, it's easiest to use the [react-native-invertible-scrollview](https://github.com/exponent/react-native-invertible-scroll-view) component rather calling `scrollToEnd` manually when layout changes. The invertible-scrollview uses a clever trick to invert the direction of the ScrollView. This pull request adds a `scrollToEnd` method which scrolls to the bottom if the ScrollView is vertical, to the right if the ScrollView is horizontal. The implementation is based on this SO answer: http://stackoverflow.com/questions/952412/uiscrollview-scrol Closes https://github.com/facebook/react-native/pull/12088 Differential Revision: D4474974 Pulled By: mkonicek fbshipit-source-id: 6ecf8b3435f47dd3a31e2fd5be6859062711c233
-
- Jan 04, 2017
-
-
Mike Grabowski authored
-
Drew Volz authored
Summary: Change "sucessfully" to "successfully" Closes https://github.com/facebook/react-native/pull/11715 Differential Revision: D4380482 Pulled By: JoelMarcey fbshipit-source-id: 2448d60b750cca0983d308945ad6ed9b46c73a97
-
Satyajit Sahoo authored
Summary: We want to pull RN API docs into exponent. So moving them into a module will be useful since we don't want to keep a duplicate list. Run `npm start` in the `website` folder and see it still generates docs. cc brentvatne Closes https://github.com/facebook/react-native/pull/11712 Differential Revision: D4380320 fbshipit-source-id: 103e5deecdbe9aa1a4690496bf954b5cdd6be097
-
Spencer Ahrens authored
Summary: Puts hierarchy and other inspector data in a fixed height scrollview so it never takes up too much space and you can always scroll to see everything you want. Reviewed By: fkgozali Differential Revision: D4374819 fbshipit-source-id: 89356670c984c693db345ad66a97d4cb54a98aee
-
Eric Vicenti authored
Summary: Added permission code to handle the user permission accepted or denied cases which causes potential app crashing if not handled. Only a small piece of code added to the guide to resolve an issue I was facing with permission. The app that I was testing following the guide available, it was crashing showing permission denied error on the android monitor, and there was no step for how to resolve the issue. So I tried out a solution so thought would share it on the official Guide to help people who are stuck with the same issue. Closes https://github.com/facebook/react-native/pull/11687 Differential Revision: D4377882 Pulled By: ericvicenti fbshipit-source-id: a7db104c7c1b7e1fb2590c83118715840c17927b
-
Jean Lauliac authored
Reviewed By: cpojer Differential Revision: D4377362 fbshipit-source-id: decd5ff9b245c9dfd4bb9af6e41717ee860fc1ba
-
David Aurelio authored
Reviewed By: bestander Differential Revision: D4377311 fbshipit-source-id: 4d9e70b08de94be839d0562fcd4d320feaffc4d6
-
Dave Lee authored
Summary: Strangely comparing a pointer with zero will only be a clang warning when compiling with `-Wpedantic`, so this incorrect comparison is silently allowed. **Test plan** Compiles with `-Wpedantic`. Closes https://github.com/facebook/react-native/pull/11709 Differential Revision: D4377512 Pulled By: ericvicenti fbshipit-source-id: 483cf1f41d3f539c452d542ad2155c4c4b41616d
-
Jean Lauliac authored
Reviewed By: cpojer Differential Revision: D4377137 fbshipit-source-id: 991619c0a42319a3bb4bf28dab4dd0fe1a474def
-
- Jan 03, 2017
-
-
Buchi Anora authored
Summary: updated this.state to reflect the different date type options in the DatePickerAndroid components. Closes https://github.com/facebook/react-native/pull/11600 Differential Revision: D4376621 Pulled By: ericvicenti fbshipit-source-id: 6802d346c200870e9b3de766c9e575c7d9f7e6df
-
Mark Oswald authored
Summary: As mkonicek suggested in [#9568](https://github.com/facebook/react-native/pull/9568#issuecomment-267600043) I did some cleanup **Test plan (required)** Only one functional change: > Run `react-native run-android --deviceId` Before it was beginning to build the app and then failing because of the missing device "true" :-) Now it's showing a message and stopping the build: ``` ❯ react-native run-android --deviceId Starting JS server... Parameter missing (device id) ``` Closes https://github.com/facebook/react-native/pull/11703 Differential Revision: D4376615 Pulled By: ericvicenti fbshipit-source-id: 3c6e0f12220ab22539c7bc3d390367e02c96728a
-
- Jan 02, 2017
-
-
Lukas Woehrl authored
Summary: Adds the feature to use percentage as a value unit. You can use the function ```YGPx(float)``` and ```YGPercent(float)``` for convenience. I did some benchmarks: ``` Without Percentage Feature - Release x86: Stack with flex: median: 0.000000 ms, stddev: 0.146683 ms Align stretch in undefined axis: median: 0.000000 ms, stddev: 0.136525 ms Nested flex: median: 0.000000 ms, stddev: 0.490101 ms Huge nested layout: median: 23.000000 ms, stddev: 0.928291 ms Stack with flex: median: 0.000000 ms, stddev: 0.170587 ms Align stretch in undefined axis: median: 0.000000 ms, stddev: 0.143384 ms Nested flex: median: 0.000000 ms, stddev: 0.477791 ms Huge nested layout: median: 22.000000 ms, stddev: 2.129779 ms With Percentage Feature - Release x86: Stack with flex: median: 0.000000 ms, stddev: 0.132951 ms Align stretch in undefined axis: median: 0.000000 ms, stddev: 0.136525 ms Nested flex: median: 0.000000 ms, stddev: 0.489570 ms Huge nested layout: median: 21.000000 ms, stddev: 1.390476 ms Closes https://github.com/facebook/yoga/pull/258 Reviewed By: dshahidehpour Differential Revision: D4361945 Pulled By: emilsjolander fbshipit-source-id: a8f5bc63ad352eb9410d792729e56664468cd76a
-
- Dec 31, 2016
-
-
dlowder-salesforce authored
Summary: **Motivation** New iOS project generation with react-native-cli should allow developers to build for Apple TV as well as iPhone/iPad. **Test plan** Added to `scripts/run-ci-e2e-tests.js` and `.travis.yml` to have the new tvOS target automatically built and tested in Travis CI. Closes https://github.com/facebook/react-native/pull/11591 Differential Revision: D4375593 Pulled By: mkonicek fbshipit-source-id: 4e241caa400a88e6b2f91416fa26b48ae01cb7b6
-
Konstantin Raev authored
Reviewed By: kentaromiura Differential Revision: D4375249 fbshipit-source-id: 7fa51d41ccbf1e017cfaceb5b6160361177f0b11
-
- Dec 30, 2016
-
-
James Ide authored
Summary: For consistency (and maybe correctness?) use an array instead of a string with spaces in it for the `exclude_paths` value in the Podspec. Closes https://github.com/facebook/react-native/pull/11664 Differential Revision: D4374863 fbshipit-source-id: b81773f418bd46d846bb935e038d240c98c0b71a
-
Michal Srb authored
Summary: Only tested on iOS. Closes https://github.com/facebook/react-native/pull/11621 Differential Revision: D4374415 Pulled By: mkonicek fbshipit-source-id: b686d0480b8db181dae46a94e9d1b88eab488074
-
Michal Srb authored
Summary: Closes https://github.com/facebook/react-native/pull/11620 Differential Revision: D4374419 Pulled By: mkonicek fbshipit-source-id: 035c2d4a65bc1b191b9b5563098632d10dd9734c
-
- Dec 29, 2016
-
-
Konstantin Raev authored
Summary: Circle CI has an older m2repository version by default Closes https://github.com/facebook/react-native/pull/11671 Differential Revision: D4372795 Pulled By: kentaromiura fbshipit-source-id: ac563fe3825a57087fbf806c913383e1ade8535f
-
Emil Sjolander authored
Differential Revision: D4366605 fbshipit-source-id: 0b94ee87a03a6ed918360dd9998930e780fc865d
-
Caleb Gomer authored
Summary: Update the Android RecyclerView, support v4, and annotation libraries to 23.4.0. Differential Revision: D4345649 fbshipit-source-id: 859c6555bc79358b1c8ffed0629cdf0e83408a00
-
Ahmed El-Helw authored
Summary: Before this patch, each Node would always generate a node region, representing the bounds of this particular Node. This set of Nodes was used when handling touch to figure out whether we should intercept touch (i.e. a flat Node is catching the draw), or let Android handle touch (i.e. a Node mounted to a View will handle the touch). This patch modifies the list of NodeRegions to exclude any Nodes that draw nothing at all. These Nodes, having no draw output, are effectively layout containers used to group items, so they shouldn't handle touch. Reviewed By: sriramramani Differential Revision: D4369484 fbshipit-source-id: 71b41611873580631f1639f368fa8d971995874f
-