This project is mirrored from https://github.com/facebook/react-native.git.
Pull mirroring updated .
- Oct 03, 2017
-
-
Mike Grabowski authored
-
- Sep 28, 2017
-
-
James Ide authored
-
Janic Duplessis authored
Summary: Basic implementation of the proposal in #15271 Note that this should not affect facebook internally since they are not using OSS releases. Points to consider: - How strict should the version match be, right now I just match exact versions. - Wasn't able to use haste for ReactNativeVersion because I was getting duplicate module provider caused by the template file in scripts/versiontemplates. I tried adding the scripts folder to modulePathIgnorePatterns in package.json but that didn't help. - Redscreen vs. warning, I think warning is useless because if the app crashes you won't have time to see the warning. - Should the check and native modules be __DEV__ only? **Test plan** Tested that it works when version match and that it redscreens when versions don't before getting other errors on Android and iOS. Closes https://github.com/facebook/react-native/pull/15518 Differential Revision: D5813551 Pulled By: hramos fbshipit-source-id: 901757e25724b0f22bf39de172b56309d0dd5a95
-
- Sep 19, 2017
-
-
James Ide authored
-
Tim Wang authored
Summary: React Native v0.48.0 shipped `WebSocketModule` support with `BlobModule` as dependency. But `BlobModule` is not mocked in jest which will cause render tests failed. Reference implantation: [BlobModule.java](https://github.com/facebook/react-native/blob/ed903099b42259958d8a6eb3af1a6460c1bc8b2c/ReactAndroid/src/main/java/com/facebook/react/modules/blob/BlobModule.java) Related PR: #11417 Related issue: #15810 Passed CI tests. Need render a component in jest with WebSocketModule as dependency. Closes https://github.com/facebook/react-native/pull/15843 Differential Revision: D5783263 Pulled By: shergin fbshipit-source-id: 2386692f4a644796da2fd66b3135da9f5911663e
-
- Sep 15, 2017
-
-
James Ide authored
-
Ben Roth authored
Summary: This avoids a crash when we try to load a PHAsset with nil image url. Specifically, the following condition evaluates to true when `imageURL` is nil: ```objc if ([imageURL.scheme caseInsensitiveCompare:@"assets-library"] == NSOrderedSame) { assetID = [imageURL absoluteString]; results = [PHAsset fetchAssetsWithALAssetURLs:@[imageURL] options:nil]; } ``` The crash will be "attempt to insert nil object from objects[0]" when we build the `@[imageURL]` array literal. We've seen this emerge as a very common crash among Expo users, so I wanted to at least provide a clear error message instead of terminating the app. Load an image from the photo library with a nil request url. Closes https://github.com/facebook/react-native/pull/15952 Differential Revision: D5835219 Pulled By: ericnakagawa fbshipit-source-id: 7be00a15e674a0905cf5c27c526ce9085d1b308f
-
Adam Miskiewicz authored
Summary: This PR refactors the symlink finding logic in local-cli in order to support nested symlinked modules as well as symlinked scoped NPM modules. Run tests, or try project with `npm link`'ed or `yarn link`'ed dependencies. Closes https://github.com/facebook/react-native/pull/15776 Reviewed By: cpojer Differential Revision: D5823008 Pulled By: jeanlauliac fbshipit-source-id: f2daeceef37bed2f8a136a0a5918730f9832884c
-
Andrew Jack authored
Summary: Apps targeting Android 8.0 (API level 26) cannot use `TYPE_SYSTEM_OVERLAY ` and `TYPE_SYSTEM_OVERLAY `. Targeting 26 will cause the app to crash when in `DEV_MODE`. https://developer.android.com/about/versions/oreo/android-8.0-changes.html#cwt This PR replaces uses of these overlay flags with the new `TYPE_APPLICATION_OVERLAY` when running on a device with Android 8.0 or later. When using `TYPE_APPLICATION_OVERLAY` it still requires the `SYSTEM_ALERT_WINDOW` permission, just like previous android versions. https://developer.android.com/reference/android/view/WindowManager.LayoutParams.html#TYPE_APPLICATION_OVERLAY https://github.com/AndrewJack/react-native-android-oreo tested here Closes https://github.com/facebook/react-native/pull/15601 Reviewed By: achen1 Differential Revision: D5801619 Pulled By: shergin fbshipit-source-id: 27d1b9bb64018e7f12f9c3d3d222f1fda468b124
-
- Sep 12, 2017
-
-
James Ide authored
-
Pieter De Baets authored
Reviewed By: fromcelticpark Differential Revision: D5536063 fbshipit-source-id: b0f19bebea839c7da84890c338ad4d38293bc99c
-
- Sep 08, 2017
-
-
Mike Grabowski authored
-
Héctor Ramos authored
Summary: Workaround for #15726. Closes https://github.com/facebook/react-native/pull/15817 Differential Revision: D5767831 Pulled By: hramos fbshipit-source-id: f0324ed4052007648ac23f9015069a97f005d19b
-
Héctor Ramos authored
Summary: Commenting these out until we can stop breaking the OSS builds. Closes https://github.com/facebook/react-native/pull/15859 Differential Revision: D5789816 Pulled By: hramos fbshipit-source-id: f3b2ecd0cbcb4dbe5e35697a925b2a8bd8397afe
-
James Ide authored
-
James Ide authored
Summary: We assign the value to an NSInteger so we should convert the NSString to an NSInteger instead of an int. Build the app in Xcode and run it. Closes https://github.com/facebook/react-native/pull/15806 Differential Revision: D5767118 Pulled By: shergin fbshipit-source-id: b310511f13f5f4026d595a219d69811801d313c2
-
Gilad Novik authored
Summary: Fixes "[NSTaggedPointerString unsignedIntValue]: unrecognized selector" error Closes https://github.com/facebook/react-native/pull/15755 Differential Revision: D5763628 Pulled By: shergin fbshipit-source-id: 6e1d1b1ae6bc63e07112b9dddcdf8e6f812a7f51
-
Neo authored
Summary: fix the regression I mentioned in https://github.com/facebook/react-native/pull/15162#issuecomment-319696706 as no one is working on this, I take the step, although I know nothing about Objective C I find the key point is that the keys in `NSDictionary` are not ordered as presented, it's a hash table, so no grantee on keys order, so I create a new array to do that, then it will check `ultralight` before `light` and `semibold` before `bold` Closes https://github.com/facebook/react-native/pull/15825 Differential Revision: D5782142 Pulled By: shergin fbshipit-source-id: 5346b0cb263e535c0b445e7a2912c452573248a5
-
Janic Duplessis authored
Summary: This code related to velocity would cause some scroll events to be skipped and caused some jitter for sticky headers. Not sure if there is a better fix but removing this does fix missing events and the velocity calculation still seems to be working. **Test plan** Tested that sticky headers now work properly on Android, tested that velocity calculation still seem to work. Closes https://github.com/facebook/react-native/pull/15761 Differential Revision: D5760820 Pulled By: sahrens fbshipit-source-id: 562b5f606bdc5452ca3d85efb5e0e3e7db224891
-
- Sep 06, 2017
-
-
Héctor Ramos authored
-
- Sep 01, 2017
-
-
Mike Grabowski authored
-
Alex Dvornikov authored
Reviewed By: javache Differential Revision: D5727367 fbshipit-source-id: ef6c03e57ee0c40da9411c77f0e8a733945afa07
-
Jean Lauliac authored
Reviewed By: cpojer Differential Revision: D5754623 fbshipit-source-id: b70bfa105e6752db5350b82433bd64e1ca45f33b
-
Michael Lee authored
Reviewed By: nlutsenko Differential Revision: D5739990 fbshipit-source-id: a1b862faab1dbcdb3bcc11f1bf662241cf7252e5
-
Kevin Gozali authored
Summary: The icon size in the test/example cannot be rounded correctly as 3x image, causing redbox like: ``` -[RNTesterSnapshotTests testTabBarExample] : failed: caught "NSInternalInconsistencyException", "RedBox error: Error setting property 'icon' of RCTTabBarItem with tag #14: Image source flux@3x.png size {33, 33} does not match loaded image size {33.333333333333336, 33.333333333333336}." ``` This simply resizes them from 100x100 to 99x99 Reviewed By: javache Differential Revision: D5747345 fbshipit-source-id: 084b4b028436b18dab324fef1fb0a4365072be75
-
Aaron Chiu authored
Reviewed By: achen1 Differential Revision: D5661567 fbshipit-source-id: 005323afbbb33ec5e36cbce7f395edc573dcc2ff
-
Jing Chen authored
Differential Revision: D5724764 fbshipit-source-id: a2f9c6917aea1d47854a1fd38a51b45c0b624ec2
-
Pavol Fulop authored
Summary: Thanks for submitting a PR! Please read these instructions carefully: - [x] Explain the **motivation** for making this change. - [ ] Provide a **test plan** demonstrating that the code is solid. - [ ] Match the **code formatting** of the rest of the codebase. - [ ] Target the `master` branch, NOT a "stable" branch. The existing documentation on this topic doesn't provide enough of detail on where to start a headlessJS task. Just docs change This PR extends HeadlessJS documentation to show an example on how to start HeadlessJsTaskService. Sample code in example reacts to connectivity change using custom broadcast receiver logic that bundles additional information and starts the aforementioned service. Closes https://github.com/facebook/react-native/pull/13957 Differential Revision: D5746809 Pulled By: hramos fbshipit-source-id: 3eeea7d4a71382acf4b6f7ad1b99d20e2745c558
-
Jean Lauliac authored
Reviewed By: cpojer Differential Revision: D5745702 fbshipit-source-id: 6dc88811525e1595f58b23b7d0ebd5cc9f309785
-
Radek Czemerys authored
Summary: I've made some contributions in the repo/other libraries and replied to a lot of issues/StackOverflow questions and want to help more
️ Closes https://github.com/facebook/react-native/pull/15723 Differential Revision: D5746712 Pulled By: hramos fbshipit-source-id: eac609b3cb1703b5c06a6368de8a0ea608d7e918 -
Syed Haani Hasan authored
Summary: <!-- Thank you for sending the PR! We appreciate you spending the time to work on these changes. Help us understand your motivation by explaining why you decided to make this change. You can learn more about contributing to React Native here: http://facebook.github.io/react-native/docs/contributing.html Happy contributing! --> I am a web developer, who recently started coding for mobile apps using react-native. I was trying to use the `inlineImageLeft` props of TextInput, but I found that it's docs weren't sufficient. So a PR for it. No code change. Updated the docs under website folder. Screenshot for the change below.  Closes https://github.com/facebook/react-native/pull/15708 Differential Revision: D5738795 Pulled By: hramos fbshipit-source-id: b8b6cbac5c50abd4d8a6ef8089dc9d92bc0b7f6f
-
- Aug 31, 2017
-
-
Adam Ernst authored
Reviewed By: javache Differential Revision: D5736692 fbshipit-source-id: e90dc38fa203ae65ac839f37940e96f23b35c330
-
Ben Nham authored
Reviewed By: alexeylang Differential Revision: D5694813 fbshipit-source-id: 2e2517e60a7547e261a7c15a3a9138dbb3cb9783
-
Ben Nham authored
Reviewed By: AaaChiuuu Differential Revision: D5694652 fbshipit-source-id: c7bfe4f222fd7b29baaec4102abe4f920ceaccc6
-
Wes Johnson authored
Summary: Wanted a "message-only" alert on iOS that doesn't lead to the message being large & bolded via the title field (current state). Before:  After:  It also aligns iOS with Android's current behaviour. The above screenhots were generated from the `RNTester` example added herein. Allowed for passing an empty string through to `UIAlertController.alertControllerWithTitle` so that the message could be rendered in its expected place on iOS (not as the title). * Ran RNTester & compared example alerts before & after (below default with titles, for example) * Ran end-to-end manual test suite (it's the only one I could get through without unrelated failures) Before  After  Closes https://github.com/facebook/react-native/pull/15685 Differential Revision: D5729420 Pulled By: hramos fbshipit-source-id: 4866b0b24473ae35e9ebae09f2cee13a49d7717e
-
Mike Grabowski authored
Summary: Third meeting notes. Closes https://github.com/facebook/react-native/pull/15674 Differential Revision: D5727572 Pulled By: hramos fbshipit-source-id: 595cad320a7e6e4145533321736646cd230ef3e0
-
Gabriel Oliveira authored
Summary: <!-- Thank you for sending the PR! We appreciate you spending the time to work on these changes. Help us understand your motivation by explaining why you decided to make this change. You can learn more about contributing to React Native here: http://facebook.github.io/react-native/docs/contributing.html Happy contributing! --> Changing all pages in doc to have title " - React Native", which will make the results easier to distinguish like suggested in issue #15659. I'm not shure how to write a test to this but if you open any page in doc you can see the page title has changed when the title is passed to Site component. Closes https://github.com/facebook/react-native/pull/15714 Differential Revision: D5739971 Pulled By: TheSavior fbshipit-source-id: ba9b5ea83fe5c502653972262eb993a24941a62e
-
Zachary Liu authored
Reviewed By: AaaChiuuu Differential Revision: D5737684 fbshipit-source-id: dc9312f595da23390cda14d5092c92d1e0319b83
-
Florian Schoellhammer authored
Reviewed By: achen1 Differential Revision: D5724107 fbshipit-source-id: 26548c0bc937b725d0cbe3c139ace09006f4fddb
-
Marc Horowitz authored
Reviewed By: javache Differential Revision: D5724406 fbshipit-source-id: 24974601d161fd23805d8e925b2b20a1cf11850d
-