Skip to content
Snippets Groups Projects
Select Git revision
20 results
Search by author
  • Any Author
0 authors
This project is mirrored from https://github.com/facebook/react-native.git. Pull mirroring updated .
  1. Sep 10, 2018
  3. Jul 04, 2018
  5. Jun 28, 2018
  7. Jun 23, 2018
  9. Jun 22, 2018
  11. Jun 19, 2018
  13. Jun 16, 2018
    • Hector Ramos's avatar
      [0.56.0-rc.2] Bump version numbers · d9d32407
      Hector Ramos authored
      v0.56.0-rc.2
      d9d32407
    • Hector Ramos's avatar
      Revert "[0.56.0-rc.2] Bump version numbers" · 053f580a
      Hector Ramos authored 
      This reverts commit d91c9d97.
      053f580a
    • Hector Ramos's avatar
      Fix config error in circle · 9ead7d61
      Hector Ramos authored
      9ead7d61
    • Hector Ramos's avatar
      [0.56.0-rc.2] Bump version numbers · d91c9d97
      Hector Ramos authored
      d91c9d97
    • Hector Ramos's avatar
      Only deploy releases on stable branches · 93b722f2
      Hector Ramos authored
      93b722f2
    • Hector Ramos's avatar
      Revert "[0.56.0-rc.2] Bump version numbers" · 9821241b
      Hector Ramos authored 
      This reverts commit 541c6e97.
      9821241b
    • Hector Ramos's avatar
      [0.56.0-rc.2] Bump version numbers · 541c6e97
      Hector Ramos authored
      541c6e97
    • Hector Ramos's avatar
      Revert "[0.56.0-rc.2] Bump version numbers" · cf71637a
      Hector Ramos authored 
      This reverts commit 55eef9b5.
      cf71637a
    • hamaron's avatar
      iOS: Fixed the bug where a Backspace event was emitted when entering... · 3fc653e1
      hamaron authored 
      iOS: Fixed the bug where a Backspace event was emitted when entering characters after clearing a text in TextInput by an empty string (#18627)

Summary:
The bug #18374 was caused by the loose condition to execute `stringByReplacingCharactersInRange` in the method `textInputShouldChangeTextInRange` . As a result, `findMismatch` wrongly returning `true` which ends up the Backspace event being fired in another `textInputShouldChangeTextInRange` call in `textInputDidChange`.

<!--
  Required: Write your motivation here.
  If this PR fixes an issue, type "Fixes #issueNumber" to automatically close the issue when the PR is merged.
-->

1. Pass all the tests by `yarn run test`
2. Run the following code and type any text. (This code is brought from #18374. Thank you michalpetrov!!) And then verify that 'Backspace' events are not emitted after clearing text
and entering any letters.

```javascript
type Props = {};
type State = {
  text: string,
  keys: string
};
export default class App extends Component<Props, State> {
  state = {text: '', keys: ''}
  render() {
    return (
      <View style={styles.container}>
        <TextInput style={styles.textInput} value={this.state.text} onChangeText={this.onChangeText} onKeyPress={this.onKeyPress}/>
        <Button title="Clear" onPress={this.onClear}/>
        <Text>Text: {this.state.text}</Text>
        <Text>Keys: {this.state.keys}</Text>
      </View>
    );
  }

  onChangeText = (text: string) => {
    this.setState({text})
  }

  onKeyPress = ({ nativeEvent }: Object) => {
    this.setState({keys: this.state.keys + nativeEvent.key + ', '})
  }

  onClear = () => {
    this.setState({text: '', keys: ''})
  }
}
```

<!--
  Does this PR require a documentation change?
  Create a PR at https://github.com/facebook/react-native-website and add a link to it here.
-->

<!--
  Required.
  Help reviewers and the release process by writing your own release notes. See below for an example.
-->

[IOS] [BUGFIX] [TextInput] - Fixed the bug where Backspace event was emitted when entering a character after clearing a text in TextInput by an empty string

<!--
  **INTERNAL and MINOR tagged notes will not be included in the next version's final release notes.**

    CATEGORY
  [----------]      TYPE
  [ CLI      ] [-------------]    LOCATION
  [ DOCS     ] [ BREAKING    ] [-------------]
  [ GENERAL  ] [ BUGFIX      ] [ {Component} ]
  [ INTERNAL ] [ ENHANCEMENT ] [ {Filename}  ]
  [ IOS      ] [ FEATURE     ] [ {Directory} ]   |-----------|
  [ ANDROID  ] [ MINOR       ] [ {Framework} ] - | {Message} |
  [----------] [-------------] [-------------]   |-----------|

 EXAMPLES:

 [IOS] [BREAKING] [FlatList] - Change a thing that breaks other things
 [ANDROID] [BUGFIX] [TextInput] - Did a thing to TextInput
 [CLI] [FEATURE] [local-cli/info/info.js] - CLI easier to do things with
 [DOCS] [BUGFIX] [GettingStarted.md] - Accidentally a thing/word
 [GENERAL] [ENHANCEMENT] [Yoga] - Added new yoga thing/position
 [INTERNAL] [FEATURE] [./scripts] - Added thing to script that nobody will see
-->
Closes https://github.com/facebook/react-native/pull/18627

Differential Revision: D8436331

Pulled By: hramos

fbshipit-source-id: ec75a6ca926061cbf7cb106db652f2b4a71c9a0c
      3fc653e1
  15. Jun 15, 2018