Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/facebook/react-native.git. Pull mirroring updated .
  1. Nov 23, 2018
  2. Nov 17, 2018
    • Panagiotis Vekris's avatar
      Flow v0.86.0 in xplat/js · 8fb228f3
      Panagiotis Vekris authored
      Summary:
      allow-large-files
      bypass-lint
      ignore-conflict-markers
      ignore-signed-source
      ignore-nocommit
      
      drop-conflicts
      
      Reviewed By: yungsters
      
      Differential Revision: D13081129
      
      fbshipit-source-id: fbb0ccaf3c0a2f224a56f6f6ac6c26811ebba583
      8fb228f3
  3. Nov 15, 2018
    • Stephy Ma's avatar
      Revert D12994045: Flow v0.86.0 in xplat/js [3/n] · 984eef8f
      Stephy Ma authored
      Differential Revision:
      D12994045
      
      Original commit changeset: 04552bf081ba
      
      fbshipit-source-id: 062b367b88a966a6efc895c99e9911f0ec0fe8ff
      984eef8f
    • Panagiotis Vekris's avatar
      Flow v0.86.0 in xplat/js [3/n] · 43ad3a64
      Panagiotis Vekris authored
      Summary:
      allow-large-files
      bypass-lint
      ignore-conflict-markers
      ignore-signed-source
      ignore-nocommit
      
      drop-conflicts
      
      Reviewed By: avikchaudhuri
      
      Differential Revision: D12994045
      
      fbshipit-source-id: 04552bf081ba742de58e80fba08f8280cb86b1c3
      43ad3a64
  4. Nov 02, 2018
    • Sam Goldman's avatar
      Deploy Flow v0.85 to xplat/js · adc8a33f
      Sam Goldman authored
      Reviewed By: fishythefish
      
      Differential Revision: D12898653
      
      fbshipit-source-id: 2ed11ce569600fe4c12528939a350dd827c9a29a
      adc8a33f
  5. Oct 26, 2018
  6. Oct 19, 2018
    • Eli White's avatar
      Blacklist react-native-implementation.js from haste · 44217d48
      Eli White authored
      Summary:
      We don't want people requiring from this file via haste. This file is the main for the react-native yarn workspace requireable via require('react-native').
      
      https://pxl.cl/jnWC
      
      Reviewed By: mostafaeweda, RSNara
      
      Differential Revision: D10444200
      
      fbshipit-source-id: 3832857e3df01def128525f32c9735e928802b59
      44217d48
  7. Oct 13, 2018
    • Marshall Roch's avatar
      @allow-large-files [flow] update to v0.83 · 7b150690
      Marshall Roch authored
      Reviewed By: fishythefish
      
      Differential Revision: D10362346
      
      fbshipit-source-id: 0f4cc9977cfaa947e3b23112dd1cf482642e2319
      7b150690
    • Marshall Roch's avatar
      fix FlowFixMe and FlowIssue suppression regexes · 870eaa54
      Marshall Roch authored
      Summary: was using `[foo|bar]` to match `foo` or `bar` instead of `\\(foo\\|bar\\)` (ocaml/emacs regexes are the worst). this meant that the "site" part of FlowFixMe and FlowIssue suppression comments were basically not working, so a suppression in one site suppressed the other incorrectly.
      
      Reviewed By: jbrown215
      
      Differential Revision: D10365477
      
      fbshipit-source-id: 1188c7378b5e6fd3090b27c1aa54480efdd09250
      870eaa54
  8. Oct 02, 2018
  9. Sep 19, 2018
    • Nat Mote's avatar
      Upgrade xplat/js to Flow v0.81 · b118f4ec
      Nat Mote authored
      Reviewed By: dsainati1, pakoito
      
      Differential Revision: D9920018
      
      fbshipit-source-id: 208fa08109d307dc09f0e0357f5caa6dfcfa5ddf
      b118f4ec
  10. Sep 05, 2018
    • Gabe Levi's avatar
      Deploy v0.80.0 to xplat/js · 66bd4992
      Gabe Levi authored
      Reviewed By: samwgoldman
      
      Differential Revision: D9646704
      
      fbshipit-source-id: d5a19f653785c81929337876936ba5069fc0abc3
      66bd4992
  11. Aug 19, 2018
    • Panagiotis Vekris's avatar
      v0.79.1 in xplat/js · d4870bab
      Panagiotis Vekris authored
      Summary: The controller you requested could not be found.
      
      Reviewed By: gabelevi
      
      Differential Revision: D9390604
      
      fbshipit-source-id: 68ba89ba197f74322e4c85c3bfc1f334fb740852
      d4870bab
  12. Aug 17, 2018
  13. Aug 14, 2018
    • Jordan Brown's avatar
      Add test to sync RN github flow configs · 97fd0966
      Jordan Brown authored
      Summary:
      Adds three more tests:
      
      * compare RN github ios and android flowconfigs
      * compare xplat/js ios flowconfig with RN github ios flowconfig
      * compare xplat/js android flowconfig with RN github android flowconfig
      
      Reviewed By: TheSavior
      
      Differential Revision: D9191176
      
      fbshipit-source-id: 34f3644ffc5a26d3bdfd94b6c05a138407aaedeb
      97fd0966
  14. Aug 10, 2018
    • Héctor Ramos's avatar
      Check Flow and run basic packager tests using open source RN config · b21575f5
      Héctor Ramos authored
      Summary:
      Most of the changes associated with this commit will not be visible on GitHub, as they concern files in the internal Facebook monorepo. The bulk of this change is the addition of a new test that runs on the internal test infrastructure. The actual script used by the test has various references to the internal test infra, but a copy is produced below with some changes that should allow it to run on open source should anyone be interested in testing this outside of Facebook.
      
      The test has the main goal of catching common sources of FB-to-GitHub breakages, such as the OSS Flow config falling out of date (we use a different flow config than what is synced out in .flowconfig, and hence internally we rename this file to .github.flowconfig). It also checks that the packager can run on a brand new project, among other things.
      
      ```
      
      set -e
      
      THIS_DIR=$(pwd)
      
      REACT_NATIVE_TEMP_DIR=$(mktemp -d /tmp/react-native-XXXXXXXX)
      REACT_NATIVE_APP_TEMP_DIR=$(mktemp -d /tmp/react-native-XXXXXXXX)
      
      OFFLINE_MIRROR=$(yarn config get yarn-offline-mirror)
      
      function describe {
        printf "\\n\\n>>>>> %s\\n\\n\\n" "$1"
      }
      
      function cleanup {
        set +e
        rm -rf "$REACT_NATIVE_TEMP_DIR"
        rm -rf "$REACT_NATIVE_APP_TEMP_DIR"
        rm "$OFFLINE_MIRROR/react-native-v1000.0.0.tgz"
        set -e
      }
      
      trap cleanup EXIT
      
      describe "Creating temporary react-native-github clone"
      cp -R "react-native" "$REACT_NATIVE_TEMP_DIR"
      pushd "$REACT_NATIVE_TEMP_DIR/react-native" >/dev/null
      
      echo yarn-offline-mirror="$OFFLINE_MIRROR" > .npmrc
      
      describe "Installing react-native node_modules from offline cache"
      yarn install --mutex network --offline --frozen-lockfile --ignore-engines --ignore-scripts 2>&1
      
      describe "Running a Flow check"
      mv .github.flowconfig .flowconfig
      ./node_modules/.bin/flow check
      
      describe "Running a basic packager test"
      touch .watchmanconfig
      node local-cli/cli.js bundle --platform android --dev true --entry-file ReactAndroid/src/androidTest/js/TestBundle.js --bundle-output ReactAndroid/src/androidTest/assets/AndroidTestBundle.js
      
      describe "Creating package for e2e test"
      yarn pack
      REACT_NATIVE_PACKAGE="$(pwd)/react-native-v1000.0.0.tgz"
      REACT_VERSION=$(node -p -e "require('./package.json').peerDependencies['react']")
      REACT_NATIVE_HASH=$(shasum "$REACT_NATIVE_PACKAGE" | awk '{print $1;}')
      REACT_NATIVE_DEPS=$(node -p -e "const deps=require('./package.json').dependencies; '    ' + Object.keys(deps).map(dep => dep + ' \"' + deps[dep] +'\"').join('\n    ')")
      
      popd >/dev/null
      
      describe "Installing temporary RN app"
      
      mkdir "$REACT_NATIVE_APP_TEMP_DIR/PackagerTest"
      pushd "$REACT_NATIVE_APP_TEMP_DIR/PackagerTest" >/dev/null
      
      cp "$REACT_NATIVE_PACKAGE" ./
      cp "$REACT_NATIVE_PACKAGE" "$OFFLINE_MIRROR"
      cp "$REACT_NATIVE_TEMP_DIR/react-native/.npmrc" ./
      cp "$REACT_NATIVE_TEMP_DIR/react-native/yarn.lock" ./
      
      cat <<LOCKFILE >> yarn.lock
      react-native@1000.0.0:
        version "1000.0.0"
        resolved react-native-v1000.0.0.tgz#$REACT_NATIVE_HASH
        dependencies:
      $REACT_NATIVE_DEPS
      LOCKFILE
      
      cat > package.json <<- EndOfFile
      {
        "name": "packager-test",
        "version": "0.0.1",
        "private": true,
        "scripts": {
          "start": "node node_modules/react-native/local-cli/cli.js start"
        },
        "dependencies": {
          "react": "$REACT_VERSION",
          "react-native": "1000.0.0"
        }
      }
      EndOfFile
      
      yarn install --mutex network --offline --frozen-lockfile --ignore-engines --ignore-scripts 2>&1
      sed -e s/"HelloWorld"/PackagerTest/g "react-native/local-cli/templates/HelloWorld/app.json" > app.json
      cp "react-native/local-cli/templates/HelloWorld/_buckconfig" .buckconfig
      cp "react-native/local-cli/templates/HelloWorld/_flowconfig" .flowconfig
      cp "react-native/local-cli/templates/HelloWorld/_watchmanconfig" .watchmanconfig
      cp "react-native/local-cli/templates/HelloWorld/App.js" App.js
      cp "react-native/local-cli/templates/HelloWorld/index.js" index.js
      
      describe "Running a Flow check on a new RN app"
      flow check
      
      describe "Verifying packager can produce JS bundle for a new RN app on both platforms"
      node ./node_modules/react-native/local-cli/cli.js bundle --platform ios --dev true --entry-file index.js --bundle-output ios-bundle.js
      test -e ios-bundle.js
      rm ios-bundle.js
      node ./node_modules/react-native/local-cli/cli.js bundle --platform android --dev true --entry-file index.js --bundle-output android-bundle.js
      test -e android-bundle.js
      rm android-bundle.js
      
      popd >/dev/null
      ```
      
      Reviewed By: arcanis
      
      Differential Revision: D9129463
      
      fbshipit-source-id: a91eeaa150ae6623ee67bd758bc8a98bb31e57b8
      b21575f5
  15. Aug 09, 2018
  16. Aug 08, 2018
    • Mayank Patke's avatar
      v0.78 in fbsource · ccf5dfbe
      Mayank Patke authored
      Summary: The controller you requested could not be found.
      
      Reviewed By: pakoito
      
      Differential Revision: D9174188
      
      fbshipit-source-id: 4ec9ef5b6f802964a83b6bc0bd29db7f47b37c21
      ccf5dfbe
  17. Aug 04, 2018
  18. Aug 03, 2018
    • Héctor Ramos's avatar
      Enable optional_chaining in open source Flow config · a9792ac4
      Héctor Ramos authored
      Summary:
      There's a couple of Flow errors in open source, following D9081343:
      
      ```
      yarn run v1.6.0
      $ flow check
      Error --------------------------------------------------------------------- Libraries/Components/Switch/Switch.js:139:31
      
      Experimental optional chaining (`?.`) usage. Optional chaining is an active early-stage feature proposal that may
      change. You may opt in to using it anyway by putting `esproposal.optional_chaining=enable` into the `[options]` section
      of your `.flowconfig`.
      
         139|     let _trackColorForFalse = trackColor?.false;
                                            ^^^^^^^^^^^^^^^^^
      
      Error --------------------------------------------------------------------- Libraries/Components/Switch/Switch.js:140:30
      
      Experimental optional chaining (`?.`) usage. Optional chaining is an active early-stage feature proposal that may
      change. You may opt in to using it anyway by putting `esproposal.optional_chaining=enable` into the `[options]` section
      of your `.flowconfig`.
      
         140|     let _trackColorForTrue = trackColor?.true;
                                           ^^^^^^^^^^^^^^^^
      ```
      
      See https://circleci.com/gh/facebook/react-native/48701
      
      We have a different Flow config for open source, .github.flowconfig, that needs to be updated to ensure Flow passes in oss.
      
      Reviewed By: TheSavior
      
      Differential Revision: D9141134
      
      fbshipit-source-id: 7b546ef4c9a91bdd66472242f38a6fc8bcf86364
      a9792ac4
  19. Jul 24, 2018
  20. Jul 09, 2018
    • Gabe Levi's avatar
      Flow v0.76.0 · eac34e30
      Gabe Levi authored
      Summary: No new errors in this version. Just removed a bunch of unused suppressions
      
      Reviewed By: TheSavior
      
      Differential Revision: D8754160
      
      fbshipit-source-id: 2f02240b6d65edecba5d9ed603c7703462547a7f
      eac34e30
  21. Jun 22, 2018
    • Sam Goldman's avatar
      Deploy Flow v0.75.0 to fbsource · 6264b693
      Sam Goldman authored
      Summary:
      bypass-lint
      allow-large-files
      
      Reviewed By: gabelevi
      
      Differential Revision: D8579147
      
      fbshipit-source-id: 12280dd4872551247ff9baafab3d766d3d7a544a
      6264b693
  22. Jun 20, 2018
    • Eli White's avatar
      Add @flow-strict support to .flowconfig · 9cfc2c01
      Eli White authored
      Summary:
      We enforce this config locally in fbsource, lets ensure our flow strict files are run the same way in the github repo.
      
      @public
      
      Reviewed By: sahrens
      
      Differential Revision: D8530133
      
      fbshipit-source-id: 18528992ad6490826431359d5d8c6acd6710a8ae
      9cfc2c01
  23. Jun 11, 2018
    • Maël Nison's avatar
      Upgrade to Flow v0.74.0 · 3bed272a
      Maël Nison authored
      Reviewed By: panagosg7
      
      Differential Revision: D8322344
      
      fbshipit-source-id: 1208528009785f7f797201777287af525d0a9ca1
      3bed272a
  24. Jun 10, 2018
    • Eli White's avatar
      Disallow requiring from invariant/warning (#19634) · 521fb6d0
      Eli White authored
      Summary:
      In this repo we have to require from fbjs/lib/invariant and issues occur when we require directly from invariant/warning. Flow doesn't complain about those requires right now because we have a transitive dependency on invariant and warning causing them to happen to be at the root of node_modules.
      
      This change blacklists requiring directly from invariant and warning using Flow. janicduplessis opened a pull request to do this with ESLint back in 2017: https://github.com/facebook/react-native/pull/13014
      Closes https://github.com/facebook/react-native/pull/19634
      
      Reviewed By: hramos
      
      Differential Revision: D8343060
      
      Pulled By: TheSavior
      
      fbshipit-source-id: 9cfc7915b2fb68a567355fc2f5edc4dfcd46f4af
      521fb6d0
  25. May 26, 2018
  26. May 12, 2018
    • Panagiotis Vekris's avatar
      v0.72.0 in xplat/js · 4767f9be
      Panagiotis Vekris authored
      Reviewed By: gabelevi
      
      Differential Revision: D7956747
      
      fbshipit-source-id: b1993de405c273b3cc1ed74f994e8e75bda0a985
      4767f9be
  27. Apr 28, 2018
    • Mayank Patke's avatar
      v0.71.0 in xplat/js · d0822c3b
      Mayank Patke authored
      Reviewed By: yungsters
      
      Differential Revision: D7787035
      
      fbshipit-source-id: 07defbbaa6fdc8f3016727fe6d6b1640efbf8ab6
      d0822c3b
  28. Apr 25, 2018
    • Rubén Norte's avatar
      Remove @providesModule from all modules · d5e9e55f
      Rubén Norte authored
      Summary:
      This PR removes the need for having the `providesModule` tags in all the modules in the repository.
      
      It configures Flow, Jest and Metro to get the module names from the filenames (`Libraries/Animated/src/nodes/AnimatedInterpolation.js` => `AnimatedInterpolation`)
      
      * Checked the Flow configuration by running flow on the project root (no errors):
      
      ```
      yarn flow
      ```
      
      * Checked the Jest configuration by running the tests with a clean cache:
      
      ```
      yarn jest --clearCache && yarn test
      ```
      
      * Checked the Metro configuration by starting the server with a clean cache and requesting some bundles:
      
      ```
      yarn run start --reset-cache
      curl 'localhost:8081/IntegrationTests/AccessibilityManagerTest.bundle?platform=android'
      curl 'localhost:8081/Libraries/Alert/Alert.bundle?platform=ios'
      ```
      
      [INTERNAL] [FEATURE] [All] - Removed providesModule from all modules and configured tools.
      Closes https://github.com/facebook/react-native/pull/18995
      
      Reviewed By: mjesun
      
      Differential Revision: D7729509
      
      Pulled By: rubennorte
      
      fbshipit-source-id: 892f760a05ce1fddb088ff0cd2e97e521fb8e825
      d5e9e55f
  29. Apr 17, 2018
  30. Mar 29, 2018
    • glevi@fb.com's avatar
      Upgrade to Flow v0.69.0 · f3ef2279
      glevi@fb.com authored
      Reviewed By: panagosg7
      
      Differential Revision: D7437630
      
      fbshipit-source-id: db9627afed89049c07a121296fbd52e2bfbf39bf
      f3ef2279
  31. Mar 20, 2018
    • Sam Goldman's avatar
      Upgrade to Flow v0.68.0 · 0d924dd6
      Sam Goldman authored
      Reviewed By: gabelevi
      
      Differential Revision: D7310349
      
      fbshipit-source-id: 70d29815dd7912704aec8a015c970be3fafeeba3
      0d924dd6
  32. Mar 10, 2018
    • Nat Mote's avatar
      Upgrade to Flow v0.67 · adabae2c
      Nat Mote authored
      Reviewed By: gabelevi
      
      Differential Revision: D7208080
      
      fbshipit-source-id: 81380aca39b7a74646a4a44af1e5571bc5629b77
      adabae2c
  33. Feb 17, 2018
  34. Feb 08, 2018
  35. Feb 07, 2018
  36. Jan 25, 2018
  37. Jan 09, 2018