Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/facebook/react-native.git. Pull mirroring updated .
  1. Aug 27, 2019
  2. Aug 26, 2019
    • grabbou's avatar
      [0.61.0-rc.0] Bump version numbers · bc28eee8
      grabbou authored
      bc28eee8
    • Mehdi Mulani's avatar
      Remove RCTUIImageViewAnimated WeakProxy gating · 104b0cc8
      Mehdi Mulani authored
      Summary:
      To help determine how severe this issue is, put the fix behind a MC.
      We will only pick the parent diff to the RC branch so that the fix immediately goes to master and we don't have to worry about fixing this any further.
      
      Reviewed By: fkgozali
      
      Differential Revision: D16940181
      
      fbshipit-source-id: 91eb08181f82f51aea6a20b3fd489a33bdc0e424
      104b0cc8
    • Mehdi Mulani's avatar
      Add RCTWeakProxy to properly deallocate RCTUIImageViewAnimated · 6d6b532f
      Mehdi Mulani authored
      Summary:
      @public
      CADisplayLink strongly holds onto its target, so you have to use a weak proxy object to pass the target into the CADisplayLink.
      
      Previously we passed a weak-self point (i.e. weakSelf) but this did not have the intended effect, since the pointer to self would still be passed to CADisplayLink, and thus it would hold onto the RCTUIImageViewAnimated strongly.
      
      So is weakSelf doing anything other than using self?
      It is but it's very minor and not useful. In the case that the object got de-allocated between assigning self to weakSelf and creating the CADisplayLink, then we would pass a nil target. This is actually impossible though because we are running an instance method, so self is implicitly retained! So semantically it is something different but in practice it is the same as passing self through.
      
      Notes:
      * This system was added originally in https://github.com/facebook/react-native/pull/24822
      * https://github.com/facebook/react-native/pull/25636 then "enabled" this system by deprecating existing approach
      
      Reviewed By: fkgozali
      
      Differential Revision: D16939869
      
      fbshipit-source-id: 7a0e947896f23aa30ad074d1dcb4d4db7543e00a
      6d6b532f
    • grabbou's avatar
      Revert "[0.61.0-rc.0] Bump version numbers" · 1dd11520
      grabbou authored
      This reverts commit 2575eb31.
      1dd11520
  3. Aug 22, 2019
  4. Aug 21, 2019
  5. Aug 16, 2019
    • Peter Argany's avatar
      Move RCTExceptionsManager to CoreModules and make it conform to spec · 6991e286
      Peter Argany authored
      Summary:
      `NativeExceptionsManager.js` contains the JS spec for this native module. This diff moves the objc code to CoreModules (since it's the only directory that supports TM at the moment) and makes it conform to the spec.
      
      NOTE: I will update podfiles after this diff is reviewed, before I land. Adding those generated changes makes it really hard to review.
      
      Reviewed By: RSNara
      
      Differential Revision: D16812212
      
      fbshipit-source-id: 38b6e9a20ce15e7e9995df34493b37ed7adb2911
      6991e286
    • Marc Horowitz's avatar
      Fix BUCK-related React Native CI failures · 111cb323
      Marc Horowitz authored
      Reviewed By: cpojer
      
      Differential Revision: D16812633
      
      fbshipit-source-id: 50de7603fbb514ff1c3bb6c5fa6afd579d8a20b8
      111cb323
    • Peter Argany's avatar
      Pass RuntimeExecutor into RCTSurfacePresenter · 0b3aeec5
      Peter Argany authored
      Summary: Instead of getting `RuntimeExecutor` from the bridge, pass it from above. Right now pass through `null`, but eventually this will work :)
      
      Reviewed By: RSNara
      
      Differential Revision: D16626288
      
      fbshipit-source-id: bce527f85c0a79cfe6cf240a3633bbbe357f75c4
      0b3aeec5
    • Peter Argany's avatar
      Pass RCTImageLoader into RCTSurfacePresenter [5/N] · a380f0f3
      Peter Argany authored
      Summary: Instead of grabbing `imageManager` from the bridge, pass it from above. Right now, still use bridge to pass from above, but this gives us flexibility to not use bridge in the future.
      
      Reviewed By: shergin
      
      Differential Revision: D16504270
      
      fbshipit-source-id: 7977a7957b659375f8348d26cd57b648e9d5959f
      a380f0f3
    • Peter Argany's avatar
      Convert RCTImageLoader to TurboModules [4/N] · 30c1196d
      Peter Argany authored
      Summary:
      This diff adds a JS spec for RCTImageLoader, and conforms to it in ObjC++. Since RCTImageLoader isn't called from JS, the js spec is empty. Since `/CoreModules/` is the only dir in OSS which supports TM, move the ObjC++ impl there.
      
      The change in `NativeExceptionsManager.js` fixes a weird bug I was hitting in codegen, where the codegen cpp file wouldn't compile due to unused variable.
      
      Reviewed By: JoshuaGross
      
      Differential Revision: D16495674
      
      fbshipit-source-id: 191897b87730a6b0b96022eedc6412551fae04a6
      30c1196d
    • Eli White's avatar
      Add support for spread with ReadOnlyArray · 6c3b01d0
      Eli White authored
      Summary: The new support for ReadOnlyArray needs to call this new function for spreads too.
      
      Reviewed By: JoshuaGross
      
      Differential Revision: D16823796
      
      fbshipit-source-id: 9de94b41cdead7ce5238c77a9e39b5daf760dfe2
      6c3b01d0
    • Joshua Gross's avatar
      Support Double in when generating props for .h files, in parsing component... · c8b9a3f8
      Joshua Gross authored
      Support Double in when generating props for .h files, in parsing component props, and for commands and events
      
      Summary: I realized my previous diff was incomplete. Adding parsing and generation code for Double for props, commands, and events.
      
      Reviewed By: rickhanlonii
      
      Differential Revision: D16823540
      
      fbshipit-source-id: fbed9897bb84b789c502cf4153e81060590152b8
      c8b9a3f8
  6. Aug 15, 2019
    • Michał Osadnik's avatar
      Split buck rules for component and modules · 269ea488
      Michał Osadnik authored
      Summary: Split buck rules for component and modules for our further convenience
      
      Reviewed By: rickhanlonii
      
      Differential Revision: D16803703
      
      fbshipit-source-id: c01fb97875b43be4020edd054cad538ec8ed6861
      269ea488
    • Michał Osadnik's avatar
      Add error message for paring unnamed params · 996ea88d
      Michał Osadnik authored
      Summary:
      We're currently not supporting this kind of params
      
      ```
      +sample(string):void
      ````
      
      and here's special exception for it.
      
      Reviewed By: RSNara
      
      Differential Revision: D16708583
      
      fbshipit-source-id: 809f9808b77108857c8363536b896089e9cb957f
      996ea88d
    • Rick Hanlon's avatar
      Add e2e tests for array object props · 958b7aa9
      Rick Hanlon authored
      Summary: Adds e2e tests for the array of object prop types in the codegen
      
      Reviewed By: rubennorte, motiz88
      
      Differential Revision: D16814301
      
      fbshipit-source-id: 613f32a888451c0c1b7359133b7bf88878e36916
      958b7aa9
    • Rick Hanlon's avatar
      Parse $ReadOnlyArray<$ReadOnly{}> props · 86eb4c7f
      Rick Hanlon authored
      Summary: Add flow type parsing for `$ReadOnlyArray<$ReadOnly<{}>>`
      
      Reviewed By: TheSavior
      
      Differential Revision: D16814261
      
      fbshipit-source-id: 9442916f5d31f6d27f560332aee311b3ad8f0864
      86eb4c7f
    • Rick Hanlon's avatar
      Generate array<object> props · 243ccc54
      Rick Hanlon authored
      Summary: Adds the cxx generators for arrays of object props
      
      Reviewed By: JoshuaGross, TheSavior
      
      Differential Revision: D16814136
      
      fbshipit-source-id: fa4600f60c063bfb460033f5fde43e26c04b5a3b
      243ccc54
    • Rick Hanlon's avatar
      Add array<object> props to schema · bc1c7b10
      Rick Hanlon authored
      Summary: Adds arrays of objects to the codegen schema
      
      Reviewed By: motiz88
      
      Differential Revision: D16814117
      
      fbshipit-source-id: 10b20446f7aac5dccc3d2cb148891a134d136d3f
      bc1c7b10
    • Rick Hanlon's avatar
      Add e2e test for object props · 70fc54a2
      Rick Hanlon authored
      Summary: Adds e2e tests for cxx and java object props
      
      Reviewed By: JoshuaGross
      
      Differential Revision: D16759242
      
      fbshipit-source-id: 2307dc4b3ba26222de510cf5876c582d35fc665c
      70fc54a2
    • Rick Hanlon's avatar
      Add Object props support for cxx · 56f9eb35
      Rick Hanlon authored
      Summary: Adds ability to codegen object props to cxx by generating the cxx structs and conversion functions |
      
      Reviewed By: JoshuaGross
      
      Differential Revision: D16759170
      
      fbshipit-source-id: 7437421e59f4be42fbcd4cddc2e0ed513ae71d08
      56f9eb35
    • Pascal Hartig's avatar
      Remove vendored proguard annotation (#26069) · 35fc0add
      Pascal Hartig authored
      Summary:
      There have been multiple complaints about combining RN with various
      other FB libraries, including Litho and Flipper, because of bundled dependencies
      that can't be deduplicated by Gradle.
      
      This is one of three current conflicts:
      
      1) Proguard annotations (this PR)
      2) Yoga
      3) fbjni
      
      While the Yoga group name doesn't make a massive amount of sense
      it was the easiest existing package to use and since we don't
      have a better namespace for this, we might as well use this.
      
      A similar change to Litho is landing right now.
      
      ## Changelog
      
      [Android] [Changed] - Use centralized package for DoNotStrip annotation
      Pull Request resolved: https://github.com/facebook/react-native/pull/26069
      
      Test Plan:
      ```
      yarn
      ./gradlew :RNTester:android:app:assembleDebug
      ```
      
      Reviewed By: cpojer
      
      Differential Revision: D16827430
      
      Pulled By: passy
      
      fbshipit-source-id: 87542b5422fee598d8e635651441f0ecd42eb9d7
      35fc0add
    • Oleksandr Melnykov's avatar
      Generate super call to BaseViewManagerDelegate if delegate has no props · a206e919
      Oleksandr Melnykov authored
      Summary: This diff adds a super call to `BaseViewManagerDelegate` if the current delegate doesn't have any props. We still want to set base view props, so we need `BaseViewManagerDelegate` to take care of this.
      
      Reviewed By: rickhanlonii
      
      Differential Revision: D16806648
      
      fbshipit-source-id: 61963f2211cc7b2e7f5822c48bb0a7f50d909221
      a206e919
    • Rodrigo Salazar's avatar
      add the jni initializer to the build for sampling profiler · 0cf1c6df
      Rodrigo Salazar authored
      Summary: The OnLoad.cpp file is needed since it actually registers the jni functions, it wasn't included in the build so it wasn't working correctly.
      
      Reviewed By: jbower-fb
      
      Differential Revision: D16826230
      
      fbshipit-source-id: 0243e456c4015879d17650737a6a27a58a3d0d9a
      0cf1c6df
    • empyrical's avatar
      Deprecate Text proptypes (#26055) · 0057cc9b
      empyrical authored
      Summary:
      This pull request moves `Text`'s prop types to the `DeprecatedPropTypes` folder.
      
      This was already partly in progress - there were redundant `TextPropTypes` and `DeprecatedTextPropTypes` files so I removed one, and made sure the version with the doc strings was the one used.
      
      ## Changelog
      
      [General] [Deprecated] - Move `Text` component's proptypes to DeprecatedPropTypes
      Pull Request resolved: https://github.com/facebook/react-native/pull/26055
      
      Test Plan: Flow checks pass for iOS and Android
      
      Differential Revision: D16801078
      
      Pulled By: TheSavior
      
      fbshipit-source-id: ef19300945d48d0a4a83d728ee32cdf7d1c0f0cc
      0057cc9b
    • Eli White's avatar
      Add failure tests for duplicate props with the same name · 51133235
      Eli White authored
      Summary: There are a couple of cases where props can conflict which would cause undefined behavior. We'll throw to protect against that. Now that we support type spread this is more possible without someone realizing.
      
      Reviewed By: JoshuaGross
      
      Differential Revision: D16813884
      
      fbshipit-source-id: 1a8fce365ab315198abdff0de6006cfe34e84fb9
      51133235
    • Eli White's avatar
      Support deeply nested spreads · ac6c747a
      Eli White authored
      Summary: Apparently I missed one more edge case. Thanks Josh for flagging!
      
      Reviewed By: JoshuaGross
      
      Differential Revision: D16813354
      
      fbshipit-source-id: 6b59bc7b18184e3aa437c3b038ffd22b0fc0ba6a
      ac6c747a
    • Eli White's avatar
      Support spreading locally defined types deeply · 9ae866c0
      Eli White authored
      Summary: We want to be able to spread props at any level, not just the top level
      
      Reviewed By: JoshuaGross
      
      Differential Revision: D16812884
      
      fbshipit-source-id: 2e710141f833a7cc7ea25a91a1523a5c43b4e02c
      9ae866c0
    • Eli White's avatar
      Support spreading locally defined types · 0a396748
      Eli White authored
      Summary: We want to be able to spread types that are defined in the same file.
      
      Reviewed By: JoshuaGross
      
      Differential Revision: D16812171
      
      fbshipit-source-id: 7cda9869ea25f0357b3f8a3b28443407b219f04b
      0a396748
    • Joshua Gross's avatar
      Add support for `Double` prop type · a02176e2
      Joshua Gross authored
      Summary: Support a prop-type `Double`, in addition to `Float`, for flow typing and codegen of components.
      
      Reviewed By: TheSavior
      
      Differential Revision: D16812812
      
      fbshipit-source-id: b5588b3218636283a4e9c5d17212dd0b92986eb9
      a02176e2
    • Ramanpreet Nara's avatar
      Migrate RCTImage NativeModules to CoreModules · bf78d796
      Ramanpreet Nara authored
      Summary:
      This diff moves RCTImageLoader, RCTImageEditingManager, and RCTImageStoreManager to CoreModules. This is necessary for us to convert all these NativeModules to TurboModules.
      
      **Note:** As a part of this diff, I had to break apart `RCTImageLoader.h`. All the protocols that were in `RCTImageLoader` are now in their own headers. Furthermore, `RCTImageLoader`'s methods are defined in `RCTImageLoaderProtocol`, so that we can call them from classes like `RCTImageViewManager` in `RCTImage`.
      
      Reviewed By: PeteTheHeat
      
      Differential Revision: D16805827
      
      fbshipit-source-id: 89f6728b0766c30b74e25f7af1be8e6b8a7e6397
      bf78d796
    • David Vacca's avatar
      Revert D16543433: [Fabric][JS] Use SoundManager in Pressability and Touchable · 441c00ab
      David Vacca authored
      Differential Revision:
      D16543433
      
      Original commit changeset: a2ba060bc480
      
      fbshipit-source-id: 0ba31019fb7a9e77577e495782a3b10029575d22
      441c00ab