This project is mirrored from https://github.com/facebook/react-native.git.
Pull mirroring updated .
- Oct 26, 2021
-
-
Luna Wei authored
-
Luna Wei authored
Summary: Changelog: [Internal] Add back Xcode_12_5_M1_post_install_workaround workaround Reviewed By: sota000 Differential Revision: D31902449 fbshipit-source-id: 5c9d962d0d1a55a9f14186bd7d6d8fe087101f0d
-
Tuomas Jaakola authored
Summary: Many have reported about the misguiding error `Fatal Exception: java.lang.UnsatisfiedLinkError: couldn't find DSO to load: libhermes.so` even though they don't use Hermes (for example issues https://github.com/facebook/react-native/issues/26075 #25923). **The current code does not handle errors correctly when loading JSC or Hermes in `ReactInstanceManagerBuilder`**. **ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManagerBuilder.java:** ```java try { return new HermesExecutorFactory(); } catch (UnsatisfiedLinkError hermesE) { // We never get here because "new HermesExecutorFactory()" does not throw an exception! hermesE.printStackTrace(); throw jscE; } ``` In Java, when an exception is thrown in static block, it will be RuntimeException and it can't be caught. For example the exception from `SoLoader.loadLibrary` can't be caught and it will crash the app. **ReactAndroid/src/main/java/com/facebook/hermes/reactexecutor/HermesExecutor.java:** ```java static { // Exception from this code block will be RuntimeException and it can't be caught! SoLoader.loadLibrary("hermes"); try { SoLoader.loadLibrary("hermes-executor-debug"); mode_ = "Debug"; } catch (UnsatisfiedLinkError e) { SoLoader.loadLibrary("hermes-executor-release"); mode_ = "Release"; } } ``` This PR fixes the code so that the original exception from failed JSC loading is not swallowed. It does not fix the original issue why JSC loading is failing with some devices, but it can be really helpful to know what the real error is. For example Firebase Crashlytics shows wrong stack trace with current code. I'm sure that this fix could have been written better. It feels wrong to import `JSCExecutor` and `HermesExecutor` in `ReactInstanceManagerBuilder.java`. However, the main point of this PR is to give the idea what is wrong with the current code. ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://github.com/facebook/react-native/wiki/Changelog --> [Android] [Fixed] - Fix error handling when loading JSC or Hermes Pull Request resolved: https://github.com/facebook/react-native/pull/30749 Test Plan: * from this PR, modify `ReactAndroid/src/main/java/com/facebook/react/jscexecutor/JSCExecutor.java` so that JSC loading will fail: ```java // original SoLoader.loadLibrary("jscexecutor"); // changed SoLoader.loadLibrary("jscexecutor-does-not-exist"); ``` * Run `rn-tester` app * Check from Logcat that the app crashed with correct exception and stacktrace. It should **not** be `java.lang.UnsatisfiedLinkError: couldn't find DSO to load: libhermes.so` Tested with Hermes ``` SoLoader.loadLibrary("hermes-executor-test"); ``` Got this one in logcat ``` 09-24 20:12:39.552 6412 6455 E AndroidRuntime: java.lang.UnsatisfiedLinkError: couldn't find DSO to load: libhermes-executor-test.so ``` Reviewed By: cortinico Differential Revision: D30346032 Pulled By: sota000 fbshipit-source-id: 09b032a9e471af233b7ac90b571c311952ab6342
-
- Oct 23, 2021
-
-
Luna Wei authored
-
Gustavo Sverzut Barbieri authored
Summary: Fix the `scripts/update-ruby.sh` so it always use the correct [bundle config](https://bundler.io/man/bundle-config.1.html#DESCRIPTION). In the current version it wasn't using the correct configuration inside the `template/` directory, resulting in incorrect platform for `template/Gemfile.lock`. While at that, update the gems to their latest version: - ethon 0.14.0 -> 0.15.0 - json 0.5.1 -> 0.6.0 - zeitwerk 2.4.2 -> 2.5.1 - bundler 2.2.28 -> 2.2.29 No changelog Pull Request resolved: https://github.com/facebook/react-native/pull/32456 Test Plan: Run `bump-oss-version.js` and see `template/Gemfile.lock` lists `ruby` as the `PLATFORM` (no diff in that line). - https://github.com/facebook/react-native/commit/e18cf90d71d0bef2e2a0caf30a89e53129152965#r58230816 Reviewed By: yungsters Differential Revision: D31841524 Pulled By: charlesbdudley fbshipit-source-id: 695c245fcb344c866afed45f747e04233e5c91e4
-
- Oct 19, 2021
-
-
Kevin Gozali authored
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/32418 This commit does 2 things: * Process and store stats for *-stable branches, in addition to main * Print out the new stats to stdout, so that CI jobs can display them for verification purpose This also means a new field `branch` is used for the Firestore data. Changelog: [Internal] Reviewed By: hramos Differential Revision: D31717251 fbshipit-source-id: 9dbfa8fb8f0243c013dcd822230400d26c09eaa4
-
- Oct 17, 2021
-
-
Luna Wei authored
-
- Oct 16, 2021
-
-
Kevin Gozali authored
Summary: The size information is currently not used for release branches. Further, the CI step failed because there is no PR associated with commits in RC branch. This commit fixed that error by skipping the entire work altogether. Sample error: https://app.circleci.com/pipelines/github/facebook/react-native/10161/workflows/3625732a-531f-435d-83b6-1dbc638e1bab/jobs/215405/parallel-runs/0/steps/0-125 In theory, we should be storing RC bundle sizes as well, but the current backing Firebase DB has not been configured with proper index: ``` Error [FirebaseError]: The query requires an index. ... ``` Changelog: [Internal] Reviewed By: lunaleaps Differential Revision: D31705912 fbshipit-source-id: 26757174f7937cb23d8e55066b833ae15ec011e3
-
Reviewed By: zertosh Differential Revision: D31681073 fbshipit-source-id: 1283e00c2ba1ecfa824b3c182ac35ae11cbe9bc2
-
- Oct 15, 2021
-
-
Pieter De Baets authored
Summary: Noticed we were sometimes receiving incorrect paths through the view hierarchy. This was largely harmless, as the hover events generated from this would still be correct. We just sometimes send more onExit/onEnter events than necessary. Changelog: [Internal] Reviewed By: rshest Differential Revision: D31434300 fbshipit-source-id: 3888270eaa16edf48f5d894a1e6daeca1ecfed1e
-
Nicola Corti authored
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/32403 As the title says, we should cleanup issues that are really stale (i.e. more than one year inactive). I ended up using actions/stale which is the first party solution for this. Changelog: [Internal] [Changed] - Add stale GitHub action Reviewed By: hramos Differential Revision: D31653083 fbshipit-source-id: 48538a571183f9ff28a23e7d1fdd01980581de35
-
Joshua Gross authored
Summary: These dynamic_casts aren't really giving us much (they have never fired once in dev! and don't run in prod anyway). They also prevent us from disabling RTTI. So, let's get rid of them. Changelog: [Internal] Reviewed By: philIip Differential Revision: D31634895 fbshipit-source-id: 4a9b259837127feb324f64fa3e9e23eb1cc481a6
-
Andrei Shikov authored
Summary: Using `WriteableNativeArray` directly in common code is breaking unit tests on CircleCI. Changelog: [Android][Internal] - Use mock of native array for sending touches Reviewed By: mdvacca Differential Revision: D31665842 fbshipit-source-id: 886418ff6a3f07046e8e17d4743060d80c26b288
-
Joshua Gross authored
Summary: Nearly all of these are identical and these compiler_flags are now centralized in rn_defs.bzl. This should have NO CHANGE on build configuration, the flags have just moved for now. Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D31631766 fbshipit-source-id: be40ebeb70ae52b7ded07ca08c4a29f10a0ed925
-
Joshua Gross authored
Summary: Centralize C++ compiler flags in rn_defs.bzl. There is really no reason for these Cxx libraries to specify their own compiler flags: nearly 100% of them are identical, and the copypasta makes it difficult to make repo-wide changes (like upgrading C++ versions, etc). This is now causing build failures until everything is migrated properly, and there are two flags (enable_rtti and enable_exceptions) that MUST have the same value and can be configured per-module, as needed. Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D31631767 fbshipit-source-id: 84f0441eb0ad09219e97d13babe0707d25f08472
-
Luna Wei authored
Summary: Changelog: [Internal] - Reorder nightly versioning to better support ordering Reviewed By: hramos Differential Revision: D31643453 fbshipit-source-id: 3f1b82085179b435d6920d9e5ae2350419154920
-
Marshall Roch authored
Summary: Changelog: [Internal] Reviewed By: vrama628 Differential Revision: D31640841 fbshipit-source-id: 783200913d06baca5b1d32d07b8ed5f4ecde7e1e
-
- Oct 14, 2021
-
-
Pieter De Baets authored
Summary: This seems like a remnant of an old refactor. This is passed in, we wrap it with a JMessageQueueThread and then never use it again. Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D31506280 fbshipit-source-id: aca01439dcddbe2b44ce80342fa8664f827919c9
-
Andrei Shikov authored
Summary: Updates touch events in Fabric to be dispatched through the same pipeline as the rest of events, instead of relying on custom dispatch behavior. Previous method of handling touches was reusing Paper behavior which required: 1. Transform event into a Paper-compatible form of WritableArray and dispatch it to `RCTEventEmitter.receiveTouches`. 2. Intercept `receiveTouches` for Fabric and redirect it to `FabricEventEmitter` 3. Perform transformations copied from Paper JS renderer in Java, transform it to the final form and dispatch this event as usual after. The new behavior uses emitter's `receiveEvent` method directly to dispatch events. Additionally, it should decrease allocations done when transforming events during step 3 above, as `WritableNativeMap`-based operations performed many re-allocations when reading/re-creating arrays. Changelog: [Android][Changed] - Added an experimental touch dispatch path Reviewed By: JoshuaGross Differential Revision: D31280052 fbshipit-source-id: 829c2646ac6b0ebff0f0106159e76d84324ac732
-
Andrei Shikov authored
Summary: Simplifies logic of touch dispatch by retrieving surface id and other require info from the event directly. Changelog: [Android][Internal] - Simplify logic of dispatching touches Reviewed By: cortinico Differential Revision: D31583314 fbshipit-source-id: c6b6e131a759c2ebe0cf4441c3aeb1a8b9f5781e
-
Reviewed By: zertosh Differential Revision: D31647300 fbshipit-source-id: b0374baa40ff01d3ef6174d348e1c7793cb7bcaf
-
Desmond Ng authored
Differential Revision: D31636434 (https://github.com/facebook/react-native/commit/2bced60851ec668d3bc9c75c99803891aab772e3) Original commit changeset: 4632cdc1bfd3 fbshipit-source-id: 7810fcba547d091e5014d6a3f70af7779e9a2aa1
-
Reviewed By: zertosh Differential Revision: D31636434 fbshipit-source-id: 4632cdc1bfd3eb398079fa3c7c3791783f30515f
-
Joel Arvidsson authored
Summary: https://github.com/facebook/react-native/issues/29099 introduced a regression where non-rounded borders on Android would render partly outside of the bounds of the view as I reported in https://github.com/facebook/react-native/issues/32393. This PR addresses that by rendering the borders completely inside the view like it works on iOS, previous version of RN and for rounded corners. ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://github.com/facebook/react-native/wiki/Changelog --> [Android] [Fixed] - Fix Android border positioning regression Pull Request resolved: https://github.com/facebook/react-native/pull/32398 Test Plan: Rendering the following code (as reported in the issue) in the RN Tester app: ```jsx <View style={{ aspectRatio: 1, backgroundColor: 'green', borderWidth: 8, borderColor: 'black', borderStyle: 'dashed', }} /> ``` |Before|After| |--|--| ||| Reviewed By: yungsters Differential Revision: D31623647 Pulled By: lunaleaps fbshipit-source-id: c38d172ae4a9dc48f800c63258223a59e2f621ed
-
Luna Wei authored
Summary: Changelog: [Internal] - Fix artifacts link in PR commitly comment Reviewed By: hramos Differential Revision: D31624488 fbshipit-source-id: cef7c79f1f8d290aa9541c3c955c9a68dc5fd643
-
Geraint White authored
Summary: Ref https://github.com/facebook/react-native/issues/25601#issuecomment-510856047. From https://github.com/facebook/react-native/pull/31040. The `hermesFlagsRelease` option only works with the release build type, but not with other build types. This PR allows hermes flags on a per variant basis to be specified using the `hermesFlagsForVariant` lambda. It also allows the hermes debugger cleanup to be run on a per variant basis using the `deleteDebugFilesForVariant` lambda. ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://github.com/facebook/react-native/wiki/Changelog --> [Android] [Fixed] - Fix hermesFlags not working with multiple variants Pull Request resolved: https://github.com/facebook/react-native/pull/32281 Test Plan: Set the following options in `android/app/build.gradle` and ensure warnings are hidden when running `./gradlew assembleRelease` and `./gradlew assembleLive`. ``` hermesFlagsForVariant: { def v -> v.name.toLowerCase().contains('release') || v.name.toLowerCase().contains('live') ? ['-w'] : [] }, deleteDebugFilesForVariant: { def v -> v.name.toLowerCase().contains('release') || v.name.toLowerCase().contains('live') }, ``` Reviewed By: cortinico Differential Revision: D31234241 Pulled By: ShikaSD fbshipit-source-id: 2cb3dd63adbcd023061076b5a3b262a87b470518
-
- Oct 13, 2021
-
-
Andrei Shikov authored
Summary: Propagate event category definition to every event that is using `dispatchModernV2` (gated in production), providing opportunity to override categories of some events if needed. No events are meaningfully affected by this change, as coalesced events (e.g. scroll) are always dispatched as continuous and touch events are handled separately. Changelog: [Internal] Expose event category in Event class Reviewed By: cortinico Differential Revision: D31276249 fbshipit-source-id: f9a756b3a5cf5897e17209f3d0aed6a1c16cbd2e
-
svbutko authored
Summary: Bump Kotlin version to 1.5.31 to include following changes: https://kotlinlang.org/docs/whatsnew15.html https://kotlinlang.org/docs/whatsnew1520.html https://kotlinlang.org/docs/whatsnew1530.html Primarily: - Native support for Apple silicon - Kotlin/JS IR backend reaches Beta - Improved Gradle plugin experience - Performance improvements ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://github.com/facebook/react-native/wiki/Changelog --> [Android] [Changed] - Bump Kotlin version to 1.5.31 [Android] [Changed] - Bump Gradle version to 7.2 Pull Request resolved: https://github.com/facebook/react-native/pull/32319 Reviewed By: yungsters Differential Revision: D31365479 Pulled By: cortinico fbshipit-source-id: 1ffaef1222a6ada8ebc746267b2a22561c3c770f
-
Nicola Corti authored
Summary: This Diff is restricting the scope of `mavenCentral` to do not include react-native packages. This will make us sure we don't pickup older versions of react-native. This specifically is a problem if you're building on a nightly as the version of RN nightly is `0.0.0.xxx` which is lower than then version on maven central. More on this here https://github.com/facebook/react-native/pull/32326#issuecomment-933368880 Changelog: [Internal] [Changed] - Restrict mavenCentral to exclude react-native older packages Reviewed By: ShikaSD Differential Revision: D31571803 fbshipit-source-id: d7ce7e82825cbebda2e4e534565d7ab15dba2624
-
David Vacca authored
Summary: https://reactnative.dev/docs/view.html doesn't work, this diff replaces the url for the new link [Changelog] [General][Fixed] - Updated documentation link in `View`. Reviewed By: yungsters Differential Revision: D31519836 fbshipit-source-id: c93feee4652caf4ef8390a047599149fc547db48
-
Xin Chen authored
Summary: This issue is found when investigating T101563978 with IOS platform. When animation is off, the x position measurement is off after `scrollToItem` is called. The android fix is checked in at D31492685 (https://github.com/facebook/react-native/commit/1a9e2d5d5589ce5cee92868ea5bccceb6e161eff). For IOS, the correct state data is updated only for animated cases, but not for instant scroll cases. This diff unified them. Changelog [IOS][Fixed] Fixed an edge case when scroll to item/index is called without animation, the offset position is not updated. This caused the measurement of the position to be wrong. Reviewed By: sammy-SC Differential Revision: D31564169 fbshipit-source-id: 89f47d8054afb03c2ace1d595163b160e5bb2036
-
Luna Wei authored
Summary: Changelog: [Internal] - Change accessibilityValue.text type to allow for Stringish type Reviewed By: yungsters Differential Revision: D31577860 fbshipit-source-id: af12505794037a68850a16ce139359e2f8a879e4
-
Lulu Wu authored
Summary: Added more logs to understand what's the root cause for https://fburl.com/logview/kgknonri ```java.lang.IllegalStateException: Message queue threads already initialized at X.5y2.A0I(:64) at com.facebook.venice.ReactInstance.<init>(:112) at X.PrB.EgB(:33) at X.2pN.run(:4) at X.2pA.execute(:32) at X.2p6.A00(:30) at X.2p6.A08(:2) at X.PrC.EgB(:26) at X.Pr7.run(:4) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641) at java.lang.Thread.run(Thread.java:919) ``` Changelog: [Android][Changed] - Add some logs Reviewed By: RSNara Differential Revision: D31584264 fbshipit-source-id: 11b8bb2c6c9af2266688e3dae95e09f0160de79a
-
- Oct 12, 2021
-
-
Andrei Shikov authored
Summary: This sync includes the following changes: - **[579c008a7](https://github.com/facebook/react/commit/579c008a7 )**: [Fizz/Flight] pipeToNodeWritable(..., writable).startWriting() -> renderToPipeableStream(...).pipe(writable) ([#22450](https://github.com/facebook/react/pull/22450)) //<Sebastian Markbåge>// - **[f2c381131](https://github.com/facebook/react/commit/f2c381131 )**: fix: useSyncExternalStoreExtra ([#22500](https://github.com/facebook/react/pull/22500)) //<Daishi Kato>// - **[0ecbbe142](https://github.com/facebook/react/commit/0ecbbe142 )**: Sync hydrate discrete events in capture phase and dont replay discrete events ([#22448](https://github.com/facebook/react/pull/22448)) //<salazarm>// - **[a724a3b57](https://github.com/facebook/react/commit/a724a3b57 )**: [RFC] Codemod invariant -> throw new Error ([#22435](https://github.com/facebook/react/pull/22435)) //<Andrew Clark>// - **[201af81b0](https://github.com/facebook/react/commit/201af81b0 )**: Release pooled cache reference in complete/unwind ([#22464](https://github.com/facebook/react/pull/22464)) //<Joseph Savona>// - **[033efe731](https://github.com/facebook/react/commit/033efe731 )**: Call get snapshot in useSyncExternalStore server shim ([#22453](https://github.com/facebook/react/pull/22453)) //<salazarm>// - **[7843b142a](https://github.com/facebook/react/commit/7843b142a )**: [Fizz/Flight] Pass in Destination lazily to startFlowing instead of in createRequest ([#22449](https://github.com/facebook/react/pull/22449)) //<Sebastian Markbåge>// - **[d9fb383d6](https://github.com/facebook/react/commit/d9fb383d6 )**: Extract queueing logic into shared functions ([#22452](https://github.com/facebook/react/pull/22452)) //<Andrew Clark>// - **[9175f4d15](https://github.com/facebook/react/commit/9175f4d15 )**: Scheduling Profiler: Show Suspense resource .displayName ([#22451](https://github.com/facebook/react/pull/22451)) //<Brian Vaughn>// - **[eba248c39](https://github.com/facebook/react/commit/eba248c39 )**: [Fizz/Flight] Remove reentrancy hack ([#22446](https://github.com/facebook/react/pull/22446)) //<Sebastian Markbåge>// - **[66388150e](https://github.com/facebook/react/commit/66388150e )**: Remove usereducer eager bailout ([#22445](https://github.com/facebook/react/pull/22445)) //<Joseph Savona>// - **[d3e086932](https://github.com/facebook/react/commit/d3e086932 )**: Make root.unmount() synchronous ([#22444](https://github.com/facebook/react/pull/22444)) //<Andrew Clark>// - **[2cc6d79c9](https://github.com/facebook/react/commit/2cc6d79c9 )**: Rename onReadyToStream to onCompleteShell ([#22443](https://github.com/facebook/react/pull/22443)) //<Sebastian Markbåge>// - **[c88fb49d3](https://github.com/facebook/react/commit/c88fb49d3 )**: Improve DEV errors if string coercion throws (Temporal.*, Symbol, etc.) ([#22064](https://github.com/facebook/react/pull/22064)) //<Justin Grant>// - **[05726d72c](https://github.com/facebook/react/commit/05726d72c )**: [Fix] Errors should not "unsuspend" a transition ([#22423](https://github.com/facebook/react/pull/22423)) //<Andrew Clark>// - **[3746eaf98](https://github.com/facebook/react/commit/3746eaf98 )**: Packages/React/src/ReactLazy ---> changing -1 to unintialized ([#22421](https://github.com/facebook/react/pull/22421)) //<BIKI DAS>// - **[04ccc01d9](https://github.com/facebook/react/commit/04ccc01d9 )**: Hydration errors should force a client render ([#22416](https://github.com/facebook/react/pull/22416)) //<Andrew Clark>// - **[029fdcebb](https://github.com/facebook/react/commit/029fdcebb )**: root.hydrate -> root.isDehydrated ([#22420](https://github.com/facebook/react/pull/22420)) //<Andrew Clark>// - **[af87f5a83](https://github.com/facebook/react/commit/af87f5a83 )**: Scheduling Profiler marks should include thrown Errors ([#22417](https://github.com/facebook/react/pull/22417)) //<Brian Vaughn>// - **[d47339ea3](https://github.com/facebook/react/commit/d47339ea3 )**: [Fizz] Remove assignID mechanism ([#22410](https://github.com/facebook/react/pull/22410)) //<Sebastian Markbåge>// - **[3a50d9557](https://github.com/facebook/react/commit/3a50d9557 )**: Never attach ping listeners in legacy Suspense ([#22407](https://github.com/facebook/react/pull/22407)) //<Andrew Clark>// - **[82c8fa90b](https://github.com/facebook/react/commit/82c8fa90b )**: Add back useMutableSource temporarily ([#22396](https://github.com/facebook/react/pull/22396)) //<Andrew Clark>// - **[5b57bc6e3](https://github.com/facebook/react/commit/5b57bc6e3 )**: [Draft] don't patch console during first render ([#22308](https://github.com/facebook/react/pull/22308)) //<Luna Ruan>// - **[cf07c3df1](https://github.com/facebook/react/commit/cf07c3df1 )**: Delete all but one `build2` reference ([#22391](https://github.com/facebook/react/pull/22391)) //<Andrew Clark>// - **[bb0d06935](https://github.com/facebook/react/commit/bb0d06935 )**: [build2 -> build] Local scripts //<Andrew Clark>// - **[0c81d347b](https://github.com/facebook/react/commit/0c81d347b )**: Write artifacts to `build` instead of `build2` //<Andrew Clark>// - **[4da03c9fb](https://github.com/facebook/react/commit/4da03c9fb )**: useSyncExternalStore React Native version ([#22367](https://github.com/facebook/react/pull/22367)) //<salazarm>// - **[48d475c9e](https://github.com/facebook/react/commit/48d475c9e )**: correct typos ([#22294](https://github.com/facebook/react/pull/22294)) //<Bowen>// - **[cb6c619c0](https://github.com/facebook/react/commit/cb6c619c0 )**: Remove Fiber fields that were used for hydrating useMutableSource ([#22368](https://github.com/facebook/react/pull/22368)) //<Sebastian Silbermann>// - **[64e70f82e](https://github.com/facebook/react/commit/64e70f82e )**: [Fizz] add avoidThisFallback support ([#22318](https://github.com/facebook/react/pull/22318)) //<salazarm>// - **[3ee7a004e](https://github.com/facebook/react/commit/3ee7a004e )**: devtools: Display actual ReactDOM API name in root type ([#22363](https://github.com/facebook/react/pull/22363)) //<Sebastian Silbermann>// - **[79b8fc667](https://github.com/facebook/react/commit/79b8fc667 )**: Implement getServerSnapshot in userspace shim ([#22359](https://github.com/facebook/react/pull/22359)) //<Andrew Clark>// - **[86b3e2461](https://github.com/facebook/react/commit/86b3e2461 )**: Implement useSyncExternalStore on server ([#22347](https://github.com/facebook/react/pull/22347)) //<Andrew Clark>// - **[8209de269](https://github.com/facebook/react/commit/8209de269 )**: Delete useMutableSource implementation ([#22292](https://github.com/facebook/react/pull/22292)) //<Andrew Clark>// Changelog: [General][Changed] - React Native sync for revisions e8feb11...afcb9cd jest_e2e[run_all_tests] Reviewed By: yungsters Differential Revision: D31541359 fbshipit-source-id: c35941bc303fdf55cb061e9996200dc868a6f2af
-
Aditya Wasan authored
Summary: This PR adds `ACCESS_MEDIA_LOCATION` permission to the PermissionsAndroid library. It fixes https://github.com/facebook/react-native/issues/31953. It's a `dangerous` permission added in API level 29. https://developer.android.com/reference/android/Manifest.permission#ACCESS_MEDIA_LOCATION ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://github.com/facebook/react-native/wiki/Changelog --> [Android] [Added] - Add ACCESS_MEDIA_LOCATION permission to PermisionsAndroid library. Pull Request resolved: https://github.com/facebook/react-native/pull/32282 Test Plan: ``` PermissionsAndroid.ACCESS_MEDIA_LOCATION === 'android.permission.ACCESS_MEDIA_LOCATION' ``` Reviewed By: yungsters Differential Revision: D31235523 Pulled By: cortinico fbshipit-source-id: 45fa86b1cdf8bc76453e9df6198c1f7ed923db7c
-
Luna Wei authored
Summary: Changelog: [Internal] - Install dependencies for posting as bot Reviewed By: hramos Differential Revision: D31552246 fbshipit-source-id: 83e4953730cbd8dc5f3475ced20fb6556f97a4c6
-
Oleksandr Melnykov authored
Summary: Changelog: [Internal] Reviewed By: yungsters Differential Revision: D31552508 fbshipit-source-id: 1821f97393e3b9c40bd484a0831eb8fbdfc4bb82
-
Kræn Hansen authored
Summary: This is a proposal to adjust the in-code documentation to clarify the semantics of the `enableHermes` variable. This fixes https://github.com/facebook/react-native-website/issues/2813. ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://github.com/facebook/react-native/wiki/Changelog --> [Android] [Fixed] - Clarified in-code documentation in the template's `android/app/build.gradle`. Pull Request resolved: https://github.com/facebook/react-native/pull/32382 Test Plan: This is just an update to documentation, no need for tests. Reviewed By: yungsters Differential Revision: D31550133 Pulled By: Huxpro fbshipit-source-id: d60e5d256e1ffaf8556710b75582f1ae1c0f1fd3
-
Andrei Shikov authored
Summary: The elevation barriers that limited view reordering were applied incorrectly, disabling elevation completely for some combinations of views. This change ensures the order of barriers is correct and only disables elevation reorder between the children and not on them. Changelog: [Internal] Reviewed By: p-sun Differential Revision: D31541961 fbshipit-source-id: 2fa4dc6906790053bd4445c841aeda0e2b3830e5
-
- Oct 10, 2021
-
-
Héctor Ramos authored
Summary: The test_docker_android job on Circle CI has a simple function: verify the base community RN Android image can be downloaded, and verify that we can use it to build a container with a compiled Android test app. Since the job is not strictly running a suite of tests, it can be moved to GitHub Actions. It will run on GitHub Actions as a Check on commits to main and pull requests. As building the test image requires the use of the base React Native Android image, we can skip downloading the base container and go straight to building the test image. Changelog: [Internal] Reviewed By: fkgozali Differential Revision: D31521978 fbshipit-source-id: ca8372a1464054e37f2da28a3ecfbc8f84db0408
-