[compiler][be] Stabilize compiler output: sort deps and decls by name (31f56963) · Commits · ExcellentOSS / react

Commit 31f56963 authored 7 months ago by

Mofei Zhang

[compiler][be] Stabilize compiler output: sort deps and decls by name

All dependencies and declarations of a reactive scope can be reordered to scope start/end. i.e. generated code does not depend on conditional short-circuiting logic as dependencies are inferred to have no side effects.

Sorting these by name helps us get higher signal compilation snapshot diffs when upgrading the compiler and testing PRs internally at Meta

parent d19ba8ec

Hide whitespace changes

Inline Side-by-side

Showing

compiler/packages/babel-plugin-react-compiler/src/ReactiveScopes/CodegenReactiveFunction.ts 34 additions, 2 deletions

...ct-compiler/src/ReactiveScopes/CodegenReactiveFunction.ts
compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/array-at-effect.expect.md 3 additions, 3 deletions

...src/__tests__/fixtures/compiler/array-at-effect.expect.md
compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/array-property-call.expect.md 5 additions, 5 deletions

...__tests__/fixtures/compiler/array-property-call.expect.md
compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/bug-invalid-phi-as-dependency.expect.md 3 additions, 3 deletions

...fixtures/compiler/bug-invalid-phi-as-dependency.expect.md
compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/capturing-fun-alias-captured-mutate-2-iife.expect.md 3 additions, 3 deletions

...iler/capturing-fun-alias-captured-mutate-2-iife.expect.md
compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/capturing-fun-alias-captured-mutate-2.expect.md 3 additions, 3 deletions

.../compiler/capturing-fun-alias-captured-mutate-2.expect.md
compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/capturing-fun-alias-captured-mutate-arr-2-iife.expect.md 3 additions, 3 deletions

.../capturing-fun-alias-captured-mutate-arr-2-iife.expect.md
compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/capturing-fun-alias-captured-mutate-arr-2.expect.md 3 additions, 3 deletions

...piler/capturing-fun-alias-captured-mutate-arr-2.expect.md
compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/capturing-func-alias-captured-mutate-arr-iife.expect.md 3 additions, 3 deletions

...r/capturing-func-alias-captured-mutate-arr-iife.expect.md
compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/capturing-func-alias-captured-mutate-arr.expect.md 3 additions, 3 deletions

...mpiler/capturing-func-alias-captured-mutate-arr.expect.md
compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/capturing-func-alias-captured-mutate-iife.expect.md 3 additions, 3 deletions

...piler/capturing-func-alias-captured-mutate-iife.expect.md
compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/capturing-func-alias-captured-mutate.expect.md 3 additions, 3 deletions

...s/compiler/capturing-func-alias-captured-mutate.expect.md
compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/capturing-function-member-expr-call.expect.md 3 additions, 3 deletions

...es/compiler/capturing-function-member-expr-call.expect.md
compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/component.expect.md 6 additions, 6 deletions

...piler/src/__tests__/fixtures/compiler/component.expect.md
compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/dependencies-outputs.expect.md 3 additions, 3 deletions

..._tests__/fixtures/compiler/dependencies-outputs.expect.md
compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/destructure-in-branch-ssa.expect.md 4 additions, 4 deletions

...s__/fixtures/compiler/destructure-in-branch-ssa.expect.md
compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/destructuring-same-property-identifier-names.expect.md 3 additions, 3 deletions

...er/destructuring-same-property-identifier-names.expect.md
compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/destructuring.expect.md 17 additions, 17 deletions

...r/src/__tests__/fixtures/compiler/destructuring.expect.md
compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/dont-merge-if-dep-is-inner-declaration-of-previous-scope.expect.md 5 additions, 5 deletions

...e-if-dep-is-inner-declaration-of-previous-scope.expect.md
compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/existing-variables-with-c-name.expect.md 3 additions, 3 deletions

...ixtures/compiler/existing-variables-with-c-name.expect.md

with 113 additions and 81 deletions

Please register or to comment